Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-13 Thread Karl O. Pinc
On 11/13/2009 07:05:37 AM, David Sommerseth wrote: > When a broad part of the users have tested this over time, used it in > production environment and bugs connected to this is fixed ... then > we > can consider to change the default behaviour, which normally would be > done in connection to a n

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-13 Thread Karl O. Pinc
On 11/13/2009 06:28:36 AM, Victor Wagner wrote: > It is possible to add ADDITIONAL configuration directive such as > --allow-unicode-in-names, which doesn't have such side-effect as > no-name-remapping > does now. > > But I think that this should be enabled by default. If someone cannot > handle

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-13 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/11/09 13:28, Victor Wagner wrote: > On 2009.11.12 at 19:25:16 +0100, David Sommerseth wrote: > >>> no-name-remapping has side effects, i.e. disables system method of >>> script execution. >> >> I'd have to disagree here. OpenVPN should not ch

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-13 Thread Victor Wagner
On 2009.11.12 at 19:25:16 +0100, David Sommerseth wrote: > > no-name-remapping has side effects, i.e. disables system method of > > script execution. > > I'd have to disagree here. OpenVPN should not change the default > behaviour at all, as that can break a lot of already implemented > instal

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-12 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (let's try to get this into the mailing list as well, sorry about that) On 12/11/09 18:59, Victor Wagner wrote: > On 2009.11.12 at 10:01:55 -0700, James Yonan wrote: > >> Victor Wagner wrote: >>> On 2009.10.24 at 13:39:56 -0600, James Yonan wrote: >>

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-12 Thread Victor Wagner
On 2009.11.12 at 10:01:55 -0700, James Yonan wrote: > Victor Wagner wrote: > > On 2009.10.24 at 13:39:56 -0600, James Yonan wrote: > > > >> Can you submit a patch (as an email attachment) with this fix? > > Attached > > > > This patch also contains X509_NAME_oneline replacement, which handles > >

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-11-12 Thread James Yonan
Victor Wagner wrote: > On 2009.10.24 at 13:39:56 -0600, James Yonan wrote: > >> Can you submit a patch (as an email attachment) with this fix? > Attached > > This patch also contains X509_NAME_oneline replacement, which handles > MSB characters. > > I've not checked if this patch applies cleanly t

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-10-26 Thread Victor Wagner
On 2009.10.24 at 13:39:56 -0600, James Yonan wrote: > > Can you submit a patch (as an email attachment) with this fix? Attached This patch also contains X509_NAME_oneline replacement, which handles MSB characters. I've not checked if this patch applies cleanly to unmodified source. I've just d

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-10-25 Thread Victor Wagner
On 2009.10.24 at 13:39:56 -0600, James Yonan wrote: > Victor Wagner wrote: > > I've found out that string_mod family of function do very bad job > > with certificates with cyrillic characters in the subject. > > > > As of OpenVPN 2.1_rc19 class CC_PRINT is determined by function > > isprint from

Re: [Openvpn-devel] Character classes in the tls-verify script

2009-10-24 Thread James Yonan
Victor Wagner wrote: I've found out that string_mod family of function do very bad job with certificates with cyrillic characters in the subject. As of OpenVPN 2.1_rc19 class CC_PRINT is determined by function isprint from ctype.h, which does wrong job if there was no setlocale call (and there i

[Openvpn-devel] Character classes in the tls-verify script

2009-10-23 Thread Victor Wagner
I've found out that string_mod family of function do very bad job with certificates with cyrillic characters in the subject. As of OpenVPN 2.1_rc19 class CC_PRINT is determined by function isprint from ctype.h, which does wrong job if there was no setlocale call (and there is no setlocale call in