On 24/10/14 15:20, Gert Doering wrote:
[...snip...]
> ... please don't do whitespace changes in places where no code changes
> (as it makes it harder to see where changes happened)
[...snip...]
> Here's an escaped tab-to-space conversion or so, but "just whitespace
> change" nonetheless.
[...snip.
Hi,
On Fri, Oct 24, 2014 at 02:23:48PM +0300, Lev Stipakov wrote:
> As discussed on IRC meeting, we replace session-id with peer-id.
>
> So, waiting for review and code-ACK :)
A few bits of review on the "non-critical" parts - so, most of it is style,
but nevertheless:
>/* Decrypt packe
Hello,
As discussed on IRC meeting, we replace session-id with peer-id.
So, waiting for review and code-ACK :)
-Lev
2014-10-23 17:07 GMT+03:00 Lev Stipakov :
> Hi Steffan,
>
> Patch attached.
>
> -Lev
>
> 2014-10-23 10:52 GMT+03:00 Steffan Karger :
>> Hi Lev,
>>
>> On 10/21/2014 09:33 AM, Lev S
Hi Steffan,
Patch attached.
-Lev
2014-10-23 10:52 GMT+03:00 Steffan Karger :
> Hi Lev,
>
> On 10/21/2014 09:33 AM, Lev Stipakov wrote:
>>
>> Thanks for your comments. I have fixed (1) and (2) - well, reusing
>> existing code in (2) has fixed also (1).
>
> Thanks! Do you have the patch somewhere
Hi Lev,
On 10/21/2014 09:33 AM, Lev Stipakov wrote:
>
> Thanks for your comments. I have fixed (1) and (2) - well, reusing
> existing code in (2) has fixed also (1).
Thanks! Do you have the patch somewhere for us to look at?
> Regarding (3) - I don't have much experience in crypto thing, so it
Hi Steffan,
Thanks for your comments. I have fixed (1) and (2) - well, reusing
existing code in (2) has fixed also (1).
Regarding (3) - I don't have much experience in crypto thing, so it
would be nice if someone suggests if we should use another alignment.
I'd be happy to join IRC meeting (nick
Hi Lev,
On 02-10-14 13:47, Lev Stipakov wrote:
> Apologize for the delay. Patch with review suggestions attached.
Thanks for providing the patch, and following up on comments on the
list. I've been deferring a reply to your first version, because I
wanted to take a thorough look at the code befor
Hello Arne, Heikki and everyone,
Apologize for the delay. Patch with review suggestions attached.
-Lev.
2014-08-12 11:26 GMT+03:00 Heikki Hannikainen :
> On Wed, 9 Jul 2014, Arne Schwabe wrote:
>
>> Am 29.06.14 18:13, schrieb Arne Schwabe:
>>>
>>> Am 27.03.14 09:57, schrieb Lev Stipakov:
On Wed, 9 Jul 2014, Arne Schwabe wrote:
Am 29.06.14 18:13, schrieb Arne Schwabe:
Am 27.03.14 09:57, schrieb Lev Stipakov:
Hi,
Same patch with added NULL check in push.c:308. Turns out that
peer_info might be NULL.
I looked at the patched, a few minor nitpicks:
One more little nitpick:
Am 29.06.14 18:13, schrieb Arne Schwabe:
> Am 27.03.14 09:57, schrieb Lev Stipakov:
>> Hi,
>>
>> Same patch with added NULL check in push.c:308. Turns out that
>> peer_info might be NULL.
>>
> I looked at the patched, a few minor nitpicks:
>
> - The test should be if the IV_PROTO is at least 2 and
Am 27.03.14 09:57, schrieb Lev Stipakov:
> Hi,
>
> Same patch with added NULL check in push.c:308. Turns out that
> peer_info might be NULL.
>
I looked at the patched, a few minor nitpicks:
- The test should be if the IV_PROTO is at least 2 and not if exactly 2
- use_session_id should be bool inst
Hi!
Great stuff, can't wait to use it!
André
On 27.03.2014 09:57, Lev Stipakov wrote:
> Hi,
>
> Same patch with added NULL check in push.c:308. Turns out that
> peer_info might be NULL.
>
> -Lev
>
> On Wed, Mar 26, 2014 at 10:52 AM, Lev Stipakov wrote:
>> Hello,
>>
>> Despite that implementatio
Hi,
Same patch with added NULL check in push.c:308. Turns out that
peer_info might be NULL.
-Lev
On Wed, Mar 26, 2014 at 10:52 AM, Lev Stipakov wrote:
> Hello,
>
> Despite that implementation of session-id has already been discussed,
> I would like to propose an alternative approach.
>
> I sugg
Hello,
Despite that implementation of session-id has already been discussed,
I would like to propose an alternative approach.
I suggest to use an array of multi_instance objects and session-id as
an item's index in that array. Why I think it is a good idea?
1) We could utilize less bytes for ses
14 matches
Mail list logo