Re: [Openvpn-devel] [PATCH] Automatically cache expected IPs for t_client.sh on the first run

2016-10-04 Thread Arne Schwabe
Am 03.10.16 um 12:51 schrieb sam...@openvpn.net: > From: Samuli Seppänen > > Previously one had to manually define correct values for the EXPECT_IFCONFIG* > variables based on what IPv4 and IPv6 addresses the test VPN server handed > out. > This was a tedious process

Re: [Openvpn-devel] [PATCH] make t_client robust against sudoers misconfiguration

2016-10-04 Thread Arne Schwabe
Am 02.10.16 um 15:19 schrieb Gert Doering: > Instead of testing (and priming) sudo with "true", prime with > "kill -0 $$" (just test signalling ourselves). If this fails, > we won't be able to kill the openvpn process we're going to > start later on -> thus, SKIP on failure. > > This helps with

Re: [Openvpn-devel] [PATCH applied] Automatically cache expected IPs for t_client.sh on the first run

2016-10-04 Thread Gert Doering
Your patch has been applied to the following branches commit df0b00c253e41cce9567be79dbd3faa14c60473b (master) commit beca355525fd250f660b5c400edd3ba83d25f171 (release/2.3) Author: Samuli Sepp�nen Date: Mon Oct 3 13:51:27 2016 +0300 Automatically cache expected IPs for t_client.sh on

Re: [Openvpn-devel] [PATCH applied] make t_client robust against sudoers misconfiguration

2016-10-04 Thread Gert Doering
Patch has been applied to the following branches commit 8ca29af7c6d4759ce019ec9d0cd3eae4511a6804 (master) commit 0bd4ef0a18c65bfbd4e5b08735d7bb67dd010b97 (release/2.3) Author: Gert Doering Date: Sun Oct 2 15:19:23 2016 +0200 make t_client robust against sudoers misconfiguration

[Openvpn-devel] [PATCH] add POSTINIT_CMD_suf to t_client.sh and sample config

2016-10-04 Thread Gert Doering
We have pre-init and cleanup commands, but some test cases might need or want to run a shell script after openvpn has initialized, but before executing any tests (ifconfig comparison and ping). Example: POSTINIT_CMD_4="sleep 5" on MacOS X for tap tests (IPv6 DAD) Signed-off-by: Gert Doering

Re: [Openvpn-devel] [PATCH] add POSTINIT_CMD_suf to t_client.sh and sample config

2016-10-04 Thread Arne Schwabe
Am 04.10.16 um 13:38 schrieb Gert Doering: > We have pre-init and cleanup commands, but some test cases might need > or want to run a shell script after openvpn has initialized, but before > executing any tests (ifconfig comparison and ping). > > Example: POSTINIT_CMD_4="sleep 5" on MacOS X for

Re: [Openvpn-devel] [PATCH applied] add POSTINIT_CMD_suf to t_client.sh and sample config

2016-10-04 Thread Gert Doering
Your patch has been applied to the following branches commit bae1ad7005fd9a1fadeed56370a9ac5422a33fee (master) commit 7891c8ce93b33749ee75ab579aa391bc5eab6e2f (release/2.3) Author: Gert Doering Date: Tue Oct 4 13:38:54 2016 +0200 add POSTINIT_CMD_suf to t_client.sh and sample config

Re: [Openvpn-devel] [PATCH master] Exclude peer-id from pulled options digest

2016-10-04 Thread Steffan Karger
Hi, On 24-09-16 17:54, Lev Stipakov wrote: > Peer-id might change on restart and this should not trigger reopening > tun. > > Trac #649 Feature-ACK. The same holds for ncp stuff though, so I think we should do the same for cipher, auth and keysize. Unless those change the tun-mtu, hmm... That

[Openvpn-devel] [PATCH v2 2.3] Exclude peer-id from pulled options digest

2016-10-04 Thread Lev Stipakov
v2: - Use md5_* methods - Move digest update to separate method Peer-id might change on restart and this should not trigger reopening tun. Trac #649 --- src/openvpn/push.c | 43 +-- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git

[Openvpn-devel] [PATCH v2] Exclude peer-id from pulled options digest

2016-10-04 Thread Lev Stipakov
v2: - Move digest update to separate method Peer-id might change on restart and this should not trigger reopening tun. Trac #649 --- src/openvpn/push.c | 45 ++--- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/src/openvpn/push.c