Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Gert Doering
Hi, On Sat, Jun 06, 2020 at 12:43:10PM +0200, Arne Schwabe wrote: > > Naive question - can we not just use a .so on Mac? Like, consistent, > > build .so, request .so from openssl.cnf? > > I thought I tested that and it didn't work but I tested it again and > that also works. Then let's just do

[Openvpn-devel] [PATCH applied] Re: allow usage of --server-ipv6 even when no --server is specified

2020-06-06 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code and tested on the t_server setup. Sufficiently trivial change :-) - but also all the other code parts that assume "if you do --server-ipv6, you must have done --server as well!!" have been adjusted in previous patches (ipv6-only ifconfig, ipv6-only pools).

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Gert Doering
Hi, On Sat, Jun 06, 2020 at 12:48:36AM +0200, Arne Schwabe wrote: > > So if this works, with the eval above and full path substitution in the > > openssl.cnf.in I think I might have a solution. > > Unfortunately not. Still creates the .so file. If everything fails we > might just do a if mac

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Arne Schwabe
Am 06.06.20 um 10:41 schrieb Gert Doering: > Hi, > > On Sat, Jun 06, 2020 at 12:48:36AM +0200, Arne Schwabe wrote: >>> So if this works, with the eval above and full path substitution in the >>> openssl.cnf.in I think I might have a solution. >> >> Unfortunately not. Still creates the .so file.

[Openvpn-devel] [PATCH applied] Re: pool: allow to configure an IPv6-only ifconfig-pool

2020-06-06 Thread Gert Doering
Acked-by: Gert Doering Reviewed again ("stare at code"). Most of the changes are really "straightforward", as soon as done :-) - make all the IPv4 stuff in the pool handling conditional, make IPv6 "stand on its own", plus fiddling with minimum sizes (if both protocols are "on", the more

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Arne Schwabe
Am 06.06.20 um 17:22 schrieb James Bottomley: > On Sat, 2020-06-06 at 13:28 +0200, Gert Doering wrote: >> Hi, >> >> On Sat, Jun 06, 2020 at 12:43:10PM +0200, Arne Schwabe wrote: Naive question - can we not just use a .so on Mac? Like, consistent, build .so, request .so from openssl.cnf?

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Gert Doering
Hi, On Sat, Jun 06, 2020 at 08:22:51AM -0700, James Bottomley wrote: > The only remaining problem is the lack of environment variable support > in MAC openssl which I'll fix by using the absolute path. If it works > I think below is the replacement patch. That patch seems to go the

[Openvpn-devel] [PATCH applied] Re: openssl: add engine method for loading the key

2020-06-06 Thread Gert Doering
Your patch has been applied to the master branch. commit 8155f8aa0a8d801dd0d84e0ec844b9ca4c225df7 Author: James Bottomley Date: Thu May 28 15:59:18 2020 -0700 openssl: add engine method for loading the key Signed-off-by: James Bottomley Acked-by: Arne Schwabe Message-Id:

Re: [Openvpn-devel] [PATCH v4 4/7] pool: add support for ifconfig-pool-persist with IPv6 only

2020-06-06 Thread Gert Doering
HI, On Sat, May 30, 2020 at 02:05:57AM +0200, Antonio Quartulli wrote: > From: Antonio Quartulli > > Without altering the pool logic, this patch enables using > a persistent IP pool also when the server is configured > with IPv6 only. > > Trac: #208 > Signed-off-by: Antonio Quartulli NAK, as

[Openvpn-devel] [PATCH applied] Re: crypto_openssl: add initialization to pick up local configuration

2020-06-06 Thread Gert Doering
Your patch has been applied to the master branch. commit a4071b20115c7d4e808df81169a986e65cec4efa Author: James Bottomley Date: Thu May 28 15:59:19 2020 -0700 crypto_openssl: add initialization to pick up local configuration Signed-off-by: James Bottomley Acked-by: Arne

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread James Bottomley
On Sat, 2020-06-06 at 13:28 +0200, Gert Doering wrote: > Hi, > > On Sat, Jun 06, 2020 at 12:43:10PM +0200, Arne Schwabe wrote: > > > Naive question - can we not just use a .so on Mac? Like, > > > consistent, build .so, request .so from openssl.cnf? > > > > I thought I tested that and it didn't

[Openvpn-devel] [PATCH v5] pool: add support for ifconfig-pool-persist with IPv6 only

2020-06-06 Thread Antonio Quartulli
From: Antonio Quartulli Without altering the pool logic, this patch enables using a persistent IP pool also when the server is configured with IPv6 only. Trac: #208 Signed-off-by: Antonio Quartulli --- Changes from v4: - prevent persist-pool parser from bailing out when only IPv4 addresses

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread James Bottomley
On Sat, 2020-06-06 at 20:16 +0200, Gert Doering wrote: > Hi, > > On Sat, Jun 06, 2020 at 08:22:51AM -0700, James Bottomley wrote: > > The only remaining problem is the lack of environment variable > > support > > in MAC openssl which I'll fix by using the absolute path. If it > > works > > I

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-06 Thread Gert Doering
Hi, On Sat, Jun 06, 2020 at 12:10:47PM -0700, James Bottomley wrote: > > > +eval shrext=$shrext_cmds > > > +AC_SUBST([shrext]) > > > > ... I hoped we can get rid of this again... > > In theory I can get around this using the libtool -shrext .so on the > command line. Someone would have to