Acked-by: Gert Doering
Antonio and I have stared at the code. It has stared back. And it
makes sense (AND it reduces quite a bit of code!) - *and* it passes all
client and server side tests I have, including async-auth pam.
I have fixed the whitespace mistake, and skipped the "const" hunk
*sigh* the commit ID in the previous mail was wrong, it was "before I
changed the commit message". Here's the correct one. Sorry.
commit 4f378ddb9932973965bb4931e85c991ddd86f7f0
Author: Arne Schwabe
Date: Thu Jul 9 12:15:59 2020 +0200
Move protocol option negotiation from push_prepare
Acked-by: Gert Doering
Your patch has been applied to the master branch.
I have stared at the code, Antonio has stared at the code, and
it makes sense. The test server says "but it breaks async auth",
so I've amended the commit message with a big fat NOTE that says
"this breaks async auth,
Hi all,
On 08-Jul-20 10:24, Gert Doering wrote:
On Tue, Jul 07, 2020 at 06:14:25PM +0200, Jan Just Keijser wrote:
This one works(!), so generally, Win10 accepts this DHCP option - but
it seems to want "all domains in one".
Can you send a v3?
not sure if all went well , but here's V3.
Hi,
On Fri, Jul 10, 2020 at 06:48:26PM +0200, Jan Just Keijser wrote:
> > It's just a comment, but if that is wrong, it's not helpful in trying to
> > understand the code.
> >
> just submitted patch v4 but forgot to fix that: richard is right 29
> decimal is 0x1D - or just 29, I guess - not
On 08/07/20 10:24, Gert Doering wrote:
Can I have a v4, please? :-)
V4:
>From fe0592df3235f3eb9bc9820586651ba8fc8bade0 Mon Sep 17 00:00:00 2001
From: Jan Just Keijser
Date: Fri, 10 Jul 2020 18:40:43 +0200
Subject: [PATCH] Added support for DHCP option 119 (dns search suffix list)
for
Acked-by: Gert Doering
Tested on client and server side (and server vs. 2.3/2.4/master clients)
and all works, including --ncp-disable clients. I'm fairly sure I have
not all corner cases covered (like, master client talking to a 2.3 server
with poor man's NCP), so more testing is needed in the
