On Fri, Dec 16, 2022 at 11:07:17AM +0200, Lev Stipakov wrote:
> From: Lev Stipakov
>
> Git magic to get branch name
>
> git rev-parse --symbolic-full-name HEAD
>
> doesn't work when we're on tag, which is the case when
> we build releases. In this case, use tag name as branch name
> with
Acked-by: Gert Doering
As agreed on the security@ list - this covers all possible leaks, and
is fully "normal OpenVPN style". I didn't test actual file creation
failures, but I *did* test regular server operation with plugins and
scripts, and that all still works fine.
As instructed, I've
Hi,
That was fast!
> Tested on Windows which is the only platform that currently
> supports stats from DCO in client mode.
Would be nice to have a comment (in code maybe?) that:
DCO resets stats on reconnect. Since client expects stats
to be preserved across reconnects, we need to save DCO
Acked-by: Gert Doering
Straightforward enough :-) - still, run through the test mill. I have
no ASAN environment around right now, so couldn't verify the actual
overflow "before" - but stare-at-code confirms the problem and the fix.
Your patch has been applied to the master, release/2.6,
From: Lev Stipakov
Git magic to get branch name
git rev-parse --symbolic-full-name HEAD
doesn't work when we're on tag, which is the case when
we build releases. In this case, use tag name as branch name
with another git magic:
git describe --tags
This fixes
Hi,
> From: Lev Stipakov
>
> Git magic to get branch name
>
> git rev-parse --symbolic-full-name HEAD
>
> doesn't work when we're on tag, which is the case when
> we build releases. In this case, use tag name as branch name
> with another git magic:
>
> git describe --tags
>
> This
On Mon, Dec 12, 2022 at 12:38:41PM +0100, Arne Schwabe wrote:
> Am 27.11.22 um 15:25 schrieb Frank Lichtenheld:
> > That makes it possible to remove several preprocessor
> > directives which is a good thing. The cost should be
> > negligible.
>
> Acked-By: Arne Schwabe
>
> In general the commit
On Wed, Dec 07, 2022 at 05:01:30PM -0500, Selva Nair wrote:
> Hi,
>
> Now that we have a shiny, newly updated, CHANGES.rst file for the GUI, it
> may be useful to link to it in future release announcements:
>
> https://github.com/OpenVPN/openvpn-gui/blob/master/CHANGES.rst
>
Done.
> Although
Acked-by: Gert Doering
stare-at-code confirms that this is a simple-enough fix.
One could argue for moving the fclose(fp) up before the tangled if/else/...
construct, but this one will do and is easy enough to review "it will
not change anything except in case of error".
Your patch has been
Acked-by: Gert Doering
Haven't tested anything :-) - but the documentation addition is useful.
Your patch has been applied to the master, release/2.6 and release/2.5 branch.
commit 4b6854881c36e16054878e0467ef87d925e20cae (master)
commit d327476c35a3fe366c1d9155ccf24172c59bb60d (release/2.6)
Acked-by: Gert Doering
This doesn't change anything code wise (where it changes the if/else,
it just gets rid of the second-to-last empty block, and by adding an
early exit gets rid of an indentation level), but improves clarity, so
very welcome. The diffs to bio_read() work better with "git
Acked-by: Gert Doering
Trivial enough.
Client-side tested to see if the compiler agrees :-) (it does, but in
release/2.5, *one* of these GCs is actually still used - 2.5 still has PF,
and PF log calls mroute_addr_print_ex(..., )... so the backport only
removes the other gc)
Your patch has been
Acked-by: Gert Doering
Have not tested beyond "we agreed on that, message looks good,
and it compiles".
Your patch has been applied to the master and release/2.6 branch.
commit e005b8d1fda1ad1e26fe0dbe7e09184a1f19b553 (master)
commit f4f92cc589b5fc473b83c9e9e109a414fa6102ca (release/2.6)
13 matches
Mail list logo
