Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-19 Thread Gert Doering
Hi, On Fri, Mar 19, 2021 at 12:16:28AM +0100, David Sommerseth wrote: > On 19/03/2021 00:00, Juliusz Sosinowicz wrote: > > For reference, the version of pkg-config shipped on my Ubuntu 14 vm is > > 0.26-1ubuntu4. It looks like the default packages are very outdated. > > Thanks for checking.

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Arne Schwabe
Am 18.03.2021 um 21:52 schrieb David Sommerseth: If this is due to an outdated pkg-config, I'm reluctant to give this patch an ACK.  Using properly up-to-date dependency stack should be a reasonable precondition to build OpenVPN.  If it is due to unavailable pkg-config, it's a different

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth
On 19/03/2021 00:00, Juliusz Sosinowicz wrote: For reference, the version of pkg-config shipped on my Ubuntu 14 vm is 0.26-1ubuntu4. It looks like the default packages are very outdated. Thanks for checking. You might want to reconsider if you want to support Ubuntu 14 these days; Ubuntu

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth
On 18/03/2021 21:52, David Sommerseth wrote: It would be great to figure out if pkg-config is available on those build hosts failing without this change.  If it is present, it needs to be checked which version it is. If this is due to an outdated pkg-config, I'm reluctant to give this patch

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz
For reference, the version of pkg-config shipped on my Ubuntu 14 vm is 0.26-1ubuntu4. It looks like the default packages are very outdated. Juliusz On 18/03/2021 21:52, David Sommerseth wrote: On 18/03/2021 19:12, Juliusz Sosinowicz wrote: PKG_CHECK_VAR is not available on older versions of

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth
On 18/03/2021 19:12, Juliusz Sosinowicz wrote: PKG_CHECK_VAR is not available on older versions of autoconf. This patch copies the definition generated by newer versions of autoconf to be used for compatibility with older versions. Tested with automake 1.14.1-2ubuntu1 and autoconf 2.69-6.

[Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz
PKG_CHECK_VAR is not available on older versions of autoconf. This patch copies the definition generated by newer versions of autoconf to be used for compatibility with older versions. Tested with automake 1.14.1-2ubuntu1 and autoconf 2.69-6. Signed-off-by: Juliusz Sosinowicz --- compat.m4 |

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth
On 18/03/2021 18:56, Gert Doering wrote: Hi, On Thu, Mar 18, 2021 at 06:25:13PM +0100, David Sommerseth wrote: I'm not seeing the rationale to why we need this; can you explain that? See my other mail: because the previous configure.ac patch (for WolfSSL support) breaks some platforms.

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Gert Doering
Hi, On Thu, Mar 18, 2021 at 06:25:13PM +0100, David Sommerseth wrote: > I'm not seeing the rationale to why we need this; can you explain that? See my other mail: because the previous configure.ac patch (for WolfSSL support) breaks some platforms. Seems "some m4 bits" are not universally there.

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth
On 18/03/2021 17:16, Juliusz Sosinowicz wrote: Signed-off-by: Juliusz Sosinowicz --- compat.m4 | 16 1 file changed, 16 insertions(+) diff --git a/compat.m4 b/compat.m4 index e54a7203..47650f6d 100644 --- a/compat.m4 +++ b/compat.m4 @@ -64,6 +64,22 @@ ifdef(

[Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz
Signed-off-by: Juliusz Sosinowicz --- compat.m4 | 16 1 file changed, 16 insertions(+) diff --git a/compat.m4 b/compat.m4 index e54a7203..47650f6d 100644 --- a/compat.m4 +++ b/compat.m4 @@ -64,6 +64,22 @@ ifdef( AC_DEFUN([AC_TYPE_UINT64_T], []) ] )