Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-19 Thread Gert Doering 
Hi,

On Fri, Mar 19, 2021 at 12:16:28AM +0100, David Sommerseth wrote:
> On 19/03/2021 00:00, Juliusz Sosinowicz wrote:
> > For reference, the version of pkg-config shipped on my Ubuntu 14 vm is 
> > 0.26-1ubuntu4. It looks like the default packages are very outdated.
> 
> Thanks for checking.  You might want to reconsider if you want to 
> support Ubuntu 14 these days; Ubuntu 16.04 LTS is the oldest one 
> supported by Canonical, and after end of April this year only 16.04.4 is 
> supported.
> 
> 

Ubuntu 16 and Ubuntu 18 (!) also have this old stuff and fail building,
so it seems "updating pkgconfig" is really not their prime priority.

I'll merge with the new commit message.

Thanks for the review.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
 Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany g...@greenie.muc.de


signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Arne Schwabe 


Am 18.03.2021 um 21:52 schrieb David Sommerseth:
If this is due to an outdated pkg-config, I'm reluctant to give this 
patch an ACK.  Using properly up-to-date dependency stack should be a 
reasonable precondition to build OpenVPN.  If it is due to unavailable 
pkg-config, it's a different story. 


We support RHEL7, which also has pkgconfig 0.27. So that is also a 
problem. And even if RHEL7 shipped a version that was recent enough, 
denying Ubuntu 16 support because an old dependency that can be fixed 
with this small change like would be quite a hyprocrasy as we supported 
old RHEL versions for a long time in OpenVPN often needing a lot larger 
compromises. In fact RHEL7/CentOS 7 is currently in my opinion only 
reason to still support OpenSSL 1.0.2, which has has reached end of life 
on 2019-12-31.



Arne




___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth 

On 19/03/2021 00:00, Juliusz Sosinowicz wrote:
For reference, the version of pkg-config shipped on my Ubuntu 14 vm is 
0.26-1ubuntu4. It looks like the default packages are very outdated.


Thanks for checking.  You might want to reconsider if you want to 
support Ubuntu 14 these days; Ubuntu 16.04 LTS is the oldest one 
supported by Canonical, and after end of April this year only 16.04.4 is 
supported.





--
kind regards,

David Sommerseth
OpenVPN Inc




On 18/03/2021 21:52, David Sommerseth wrote:

On 18/03/2021 19:12, Juliusz Sosinowicz wrote:

PKG_CHECK_VAR is not available on older versions of autoconf. This
patch copies the definition generated by newer versions of autoconf to
be used for compatibility with older versions. Tested with automake
1.14.1-2ubuntu1 and autoconf 2.69-6.

Signed-off-by: Juliusz Sosinowicz 


I ended up doing some more investigation here, to better understand 
where this could fail.


So it seems this is not related to automake/autoconf versions.  It is 
related to pkg-config version, which is the one providing 
/usr/share/aclocal/pkg.m4 which provides the PKG_CHECK_VAR() macro.


 



What surprises me is that this was added to pkg-config 0.28, which was 
released in 2013-01-24.  The latest release, 0.29.2 was released 
2017-03-20.


 




It would be great to figure out if pkg-config is available on those 
build hosts failing without this change.  If it is present, it needs 
to be checked which version it is.


If this is due to an outdated pkg-config, I'm reluctant to give this 
patch an ACK.  Using properly up-to-date dependency stack should be a 
reasonable precondition to build OpenVPN.  If it is due to unavailable 
pkg-config, it's a different story.


Regardless, the commit message is incorrect.  But that can probably be 
fixed at commit time.







OpenPGP_signature
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth 

On 18/03/2021 21:52, David Sommerseth wrote:
It would be great to figure out if pkg-config is available on those 
build hosts failing without this change.  If it is present, it needs to 
be checked which version it is.


If this is due to an outdated pkg-config, I'm reluctant to give this 
patch an ACK.  Using properly up-to-date dependency stack should be a 
reasonable precondition to build OpenVPN.  If it is due to unavailable 
pkg-config, it's a different story.


So I managed to test this more properly on RHEL-7 and CentOS-7.  This 
major release is forked off from a mixture of Fedora 19 and 20.  And 
pkgconfig got upgraded from 0.27 in F19 to 0.28 in F20; but this was not 
pulled into RHEL-7 (which CentOS-7 builds on).


This is also the latest pkgconfig version available on RHEL-7, which is 
the oldest enterprise Linux distro we support.  So my concern about not 
up-to-date dependency stack is no longer valid.  We need this change.


If Gert is fine with updating the commit message at commit time, I'm 
ready to give it my ACK now.


I propose this commit message:
--
build: Add support for pkg-config < 0.28

RHEL-7 ships pkgconfig-0.27-1 which is lacking the PKG_CHECK_VAR() m4 
macro.  This might be the situation on other OS distributions as well. 
Ship our own macro providing this support when not found on the build host.

--

Acked-By: David Sommerseth 


--
kind regards,

David Sommerseth
OpenVPN Inc




OpenPGP_signature
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz 
For reference, the version of pkg-config shipped on my Ubuntu 14 vm is 
0.26-1ubuntu4. It looks like the default packages are very outdated.


Juliusz

On 18/03/2021 21:52, David Sommerseth wrote:

On 18/03/2021 19:12, Juliusz Sosinowicz wrote:

PKG_CHECK_VAR is not available on older versions of autoconf. This
patch copies the definition generated by newer versions of autoconf to
be used for compatibility with older versions. Tested with automake
1.14.1-2ubuntu1 and autoconf 2.69-6.

Signed-off-by: Juliusz Sosinowicz 


I ended up doing some more investigation here, to better understand 
where this could fail.


So it seems this is not related to automake/autoconf versions.  It is 
related to pkg-config version, which is the one providing 
/usr/share/aclocal/pkg.m4 which provides the PKG_CHECK_VAR() macro.


 



What surprises me is that this was added to pkg-config 0.28, which was 
released in 2013-01-24.  The latest release, 0.29.2 was released 
2017-03-20.


 




It would be great to figure out if pkg-config is available on those 
build hosts failing without this change.  If it is present, it needs 
to be checked which version it is.


If this is due to an outdated pkg-config, I'm reluctant to give this 
patch an ACK.  Using properly up-to-date dependency stack should be a 
reasonable precondition to build OpenVPN.  If it is due to unavailable 
pkg-config, it's a different story.


Regardless, the commit message is incorrect.  But that can probably be 
fixed at commit time.






___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth 

On 18/03/2021 19:12, Juliusz Sosinowicz wrote:

PKG_CHECK_VAR is not available on older versions of autoconf. This
patch copies the definition generated by newer versions of autoconf to
be used for compatibility with older versions. Tested with automake
1.14.1-2ubuntu1 and autoconf 2.69-6.

Signed-off-by: Juliusz Sosinowicz 


I ended up doing some more investigation here, to better understand 
where this could fail.


So it seems this is not related to automake/autoconf versions.  It is 
related to pkg-config version, which is the one providing 
/usr/share/aclocal/pkg.m4 which provides the PKG_CHECK_VAR() macro.




What surprises me is that this was added to pkg-config 0.28, which was 
released in 2013-01-24.  The latest release, 0.29.2 was released 2017-03-20.





It would be great to figure out if pkg-config is available on those 
build hosts failing without this change.  If it is present, it needs to 
be checked which version it is.


If this is due to an outdated pkg-config, I'm reluctant to give this 
patch an ACK.  Using properly up-to-date dependency stack should be a 
reasonable precondition to build OpenVPN.  If it is due to unavailable 
pkg-config, it's a different story.


Regardless, the commit message is incorrect.  But that can probably be 
fixed at commit time.



--
kind regards,

David Sommerseth
OpenVPN Inc



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz 
PKG_CHECK_VAR is not available on older versions of autoconf. This patch copies 
the definition generated by newer versions of autoconf to be used for 
compatibility with older versions. Tested with automake 1.14.1-2ubuntu1 and 
autoconf 2.69-6.

Signed-off-by: Juliusz Sosinowicz 
---
 compat.m4 | 16 
 1 file changed, 16 insertions(+)

diff --git a/compat.m4 b/compat.m4
index e54a7203..47650f6d 100644
--- a/compat.m4
+++ b/compat.m4
@@ -64,6 +64,22 @@ ifdef(
AC_DEFUN([AC_TYPE_UINT64_T], [])
]
 )
+ifdef(
+   [PKG_CHECK_VAR],
+   ,
+   [
+   AC_DEFUN([PKG_CHECK_VAR],
+   [AC_REQUIRE([PKG_PROG_PKG_CONFIG])
+   AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
+
+   _PKG_CONFIG([$1], [variable="][$3]["], [$2])
+   AS_VAR_COPY([$1], [pkg_cv_][$1])
+
+   AS_VAR_IF([$1], [""], [$5], [$4])
+   ])
+   ]
+)
+
 if test -z "${docdir}"; then
docdir="\$(datadir)/doc/\$(PACKAGE_NAME)"
AC_SUBST([docdir])
-- 
2.25.1



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth 

On 18/03/2021 18:56, Gert Doering wrote:

Hi,

On Thu, Mar 18, 2021 at 06:25:13PM +0100, David Sommerseth wrote:

I'm not seeing the rationale to why we need this; can you explain that?


See my other mail: because the previous configure.ac patch (for WolfSSL
support) breaks some platforms.  Seems "some m4 bits" are not universally
there.


Right, I missed that context when looking at it ... but that context 
could still have been in the commit message, for the git history to 
explain why we needed it ;)



--
kind regards,

David Sommerseth
OpenVPN Inc




OpenPGP_signature
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Gert Doering 
Hi,

On Thu, Mar 18, 2021 at 06:25:13PM +0100, David Sommerseth wrote:
> I'm not seeing the rationale to why we need this; can you explain that?

See my other mail: because the previous configure.ac patch (for WolfSSL
support) breaks some platforms.  Seems "some m4 bits" are not universally
there.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
 Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany g...@greenie.muc.de


signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread David Sommerseth 

On 18/03/2021 17:16, Juliusz Sosinowicz wrote:

Signed-off-by: Juliusz Sosinowicz 
---
  compat.m4 | 16 
  1 file changed, 16 insertions(+)

diff --git a/compat.m4 b/compat.m4
index e54a7203..47650f6d 100644
--- a/compat.m4
+++ b/compat.m4
@@ -64,6 +64,22 @@ ifdef(
AC_DEFUN([AC_TYPE_UINT64_T], [])
]
  )
+ifdef(
+   [PKG_CHECK_VAR],
+   ,
+   [
+   AC_DEFUN([PKG_CHECK_VAR],
+   [AC_REQUIRE([PKG_PROG_PKG_CONFIG])
+   AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
+
+   _PKG_CONFIG([$1], [variable="][$3]["], [$2])
+   AS_VAR_COPY([$1], [pkg_cv_][$1])
+
+   AS_VAR_IF([$1], [""], [$5], [$4])
+   ])
+   ]
+)
+
  if test -z "${docdir}"; then
docdir="\$(datadir)/doc/\$(PACKAGE_NAME)"
AC_SUBST([docdir])



I'm not seeing the rationale to why we need this; can you explain that?

The TL;DR version of Chris Beams "How to write a git commit message" [1] is:

git subject--->>  _What_ this patch is about
git body message   --->>  _Why_  the change is needed
git diff   --->>  _How_  the change is solved

[1] 


--
kind regards,

David Sommerseth
OpenVPN Inc




OpenPGP_signature
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Add PKG_CHECK_VAR compatibility definition for old autoconf versions

2021-03-18 Thread Juliusz Sosinowicz 
Signed-off-by: Juliusz Sosinowicz 
---
 compat.m4 | 16 
 1 file changed, 16 insertions(+)

diff --git a/compat.m4 b/compat.m4
index e54a7203..47650f6d 100644
--- a/compat.m4
+++ b/compat.m4
@@ -64,6 +64,22 @@ ifdef(
AC_DEFUN([AC_TYPE_UINT64_T], [])
]
 )
+ifdef(
+   [PKG_CHECK_VAR],
+   ,
+   [
+   AC_DEFUN([PKG_CHECK_VAR],
+   [AC_REQUIRE([PKG_PROG_PKG_CONFIG])
+   AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
+
+   _PKG_CONFIG([$1], [variable="][$3]["], [$2])
+   AS_VAR_COPY([$1], [pkg_cv_][$1])
+
+   AS_VAR_IF([$1], [""], [$5], [$4])
+   ])
+   ]
+)
+
 if test -z "${docdir}"; then
docdir="\$(datadir)/doc/\$(PACKAGE_NAME)"
AC_SUBST([docdir])
-- 
2.25.1



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel