Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 26/09/16 16:45, Gert Doering wrote:
> Hi,
> 
> On Mon, Sep 26, 2016 at 01:26:24PM +0500,  ??
> wrote:
>> it would be easiest, but it is not required. as Steffan Karger
>> wrote "Could you please include such descriptions in future
>> patches?"
> 
> Well, a proper commit message *is* required.
> 
> So, instead of us having do your work (of providing a proper commit
> message), and then complaining that this is taking a bit longer
> (because it's extra work) - what about "re-sending the patch with a
> proper commit message" instead?
> 
> I have a bunch of work to do, and "make me do more work and then
> complain that I'm slow doing it" is a very trusted way to get moved
> all the way DOWN on my priority list.  Like, "I might think about
> this next May".

+1 ... Due to _exactly_ this reasoning, it was on my "If I have time
this week"-list.

Thanks Gert for taking care of it!


- -- 
kind regards,

David Sommerseth
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJX6XloAAoJEIbPlEyWcf3yPrwP/i8Yu4TVUZr0waGJ6Gx9g3Z9
qMUqKSfif73+3nnPbPsEd8N0+eRHjG7dgQ52+/Sahph73dIWiiLrepRAC3VJCc1r
7ZGsFYYkoYKMf2VlWHKgi8WkuaXt7xhofHLLh0GtmmOvaGU9zcqaIZpLEPpXpfYf
RULw8ozDE+rirQA2UCxht1Fqn+tf/36t0X1zCkFXplkglT7oxLr6aPHbuUUUl19v
9URwwxDGFyy4De0ZalH/cosAXRwzsyjEvG2QCFoGGsLEbiNMElpT9MImPkJFjjyc
ltPtZGMW3tjdAIRIyTtMhlXZvrUu0eig+2SjCmwWZMAwL0XfSguUsEk9c13opSuT
xTsAoE8c2rEXN/5UvwFIiRI9qgUwp83zQDVu6QEjlaH4/PG5iRz7kSisc2FGQtwS
nYN+183nW8MQVJFSaZ++VbnOnGhpH86NmgTc2BxRInDIBEjd4uQTQVXMH1UBWzmJ
7PFrEowT3vnRF6SDFaE2YzyCP2hp1DwD0la2NCeieXcaAq0+1lSmR4UpSlPeNkO+
QujuqtyoeC372P0CnLxbOZCdrvXhBcRWGs8O1PjBzHy5xeyApgbWNoqI7kkENvk9
+WRrVPq9cQngrfr1dCo4H3c6y1wRSjzhMU7VxJ5/82+u3qPXxBIvnu/tSl24dbpM
anEkoVh1m3iCyJt+aJp1
=bNDi
-END PGP SIGNATURE-

--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Gert Doering]

Hi,

On Mon, Sep 26, 2016 at 01:26:24PM +0500,  ?? wrote:
> it would be easiest, but it is not required.
> as Steffan Karger wrote "Could you please include such descriptions in
> future patches?"

Well, a proper commit message *is* required.

So, instead of us having do your work (of providing a proper commit message),
and then complaining that this is taking a bit longer (because it's extra
work) - what about "re-sending the patch with a proper commit message" 
instead?

I have a bunch of work to do, and "make me do more work and then complain
that I'm slow doing it" is a very trusted way to get moved all the way 
DOWN on my priority list.  Like, "I might think about this next May".

gert

-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Steffan Karger]

On 26-09-16 10:26, Илья Шипицин wrote:
> 
> 2016-09-26 12:37 GMT+05:00 Samuli Seppänen  >:
> All the pieces (ACK, fixed commit message) seem to be present. Maybe
> it would be easiest to fix the commit message just before the push:
> 
> 
> it would be easiest, but it is not required.
> as Steffan Karger wrote "Could you please include such descriptions in
> future patches?"
>
> ---
> 
> Enable "--disable-crypto" build configuration
> 
> 
> Previously, 'make test' failed for --disable-crypto builds.  Since
> that is not fixed, we should no longer accept --disable-crypto builds
> to fail 'make test' on travis.

The committer (David or Gert) can probably just include this text into
the commit message when applying the patch.  I think that's what Samuli
suggested.

Committer:  if you do so, could you please fix my typo from 'not fixed'
to 'now fixed'?  ;-)

Thanks,
-Steffan

--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Илья Шипицин]

2016-09-26 12:37 GMT+05:00 Samuli Seppänen :

> Il 24/09/2016 09:32, Илья Шипицин ha scritto:
>
>> can we merge it ?
>>
>> 2016-09-17 16:17 GMT+05:00 Steffan Karger > >:
>>
>> Hi,
>>
>> On 17 September 2016 at 12:54, Ilya Shipitsin > > wrote:
>> > ---
>> >  .travis.yml | 4 
>> >  1 file changed, 4 deletions(-)
>> >
>> > diff --git a/.travis.yml b/.travis.yml
>> > index 452c48e..369db97 100644
>> > --- a/.travis.yml
>> > +++ b/.travis.yml
>> > @@ -51,10 +51,6 @@ matrix:
>> >os: osx
>> >osx_image: xcode7.3
>> >compiler: clang
>> > -  allow_failures:
>> > -- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
>> > -  os: linux
>> > -  compiler: clang
>> >exclude:
>> >  - compiler: gcc
>> >
>> > --
>> > 2.5.5
>>
>> Thanks.  The patch is good, so ACK.
>>
>> But the commit messages should describe why this change is needed.  In
>> this case:
>>
>> Previously, 'make test' failed for --disable-crypto builds.  Since
>> that is not fixed, we should no longer accept --disable-crypto builds
>> to fail 'make test' on travis.
>>
>> Could you please include such descriptions in future patches?
>>
>> -Steffan
>>
>>
>>
>>
>> 
>> --
>>
>>
>>
>> ___
>> Openvpn-devel mailing list
>> Openvpn-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>>
>>
> All the pieces (ACK, fixed commit message) seem to be present. Maybe it
> would be easiest to fix the commit message just before the push:
>

it would be easiest, but it is not required.
as Steffan Karger wrote "Could you please include such descriptions in
future patches?"


>
> ---
>
> Enable "--disable-crypto" build configuration
>
>
> Previously, 'make test' failed for --disable-crypto builds.  Since
> that is not fixed, we should no longer accept --disable-crypto builds
> to fail 'make test' on travis.
>
> --
> Samuli Seppänen
> Community Manager
> OpenVPN Technologies, Inc
>
> irc freenode net: mattock
>
--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Samuli Seppänen]

Il 24/09/2016 09:32, Илья Шипицин ha scritto:
> can we merge it ?
>
> 2016-09-17 16:17 GMT+05:00 Steffan Karger  >:
>
> Hi,
>
> On 17 September 2016 at 12:54, Ilya Shipitsin  > wrote:
> > ---
> >  .travis.yml | 4 
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 452c48e..369db97 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -51,10 +51,6 @@ matrix:
> >os: osx
> >osx_image: xcode7.3
> >compiler: clang
> > -  allow_failures:
> > -- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
> > -  os: linux
> > -  compiler: clang
> >exclude:
> >  - compiler: gcc
> >
> > --
> > 2.5.5
>
> Thanks.  The patch is good, so ACK.
>
> But the commit messages should describe why this change is needed.  In
> this case:
>
> Previously, 'make test' failed for --disable-crypto builds.  Since
> that is not fixed, we should no longer accept --disable-crypto builds
> to fail 'make test' on travis.
>
> Could you please include such descriptions in future patches?
>
> -Steffan
>
>
>
>
> --
>
>
>
> ___
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>

All the pieces (ACK, fixed commit message) seem to be present. Maybe it 
would be easiest to fix the commit message just before the push:

---

Enable "--disable-crypto" build configuration

Previously, 'make test' failed for --disable-crypto builds.  Since
that is not fixed, we should no longer accept --disable-crypto builds
to fail 'make test' on travis.

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Илья Шипицин]

can we merge it ?

2016-09-17 16:17 GMT+05:00 Steffan Karger :

> Hi,
>
> On 17 September 2016 at 12:54, Ilya Shipitsin 
> wrote:
> > ---
> >  .travis.yml | 4 
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 452c48e..369db97 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -51,10 +51,6 @@ matrix:
> >os: osx
> >osx_image: xcode7.3
> >compiler: clang
> > -  allow_failures:
> > -- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
> > -  os: linux
> > -  compiler: clang
> >exclude:
> >  - compiler: gcc
> >
> > --
> > 2.5.5
>
> Thanks.  The patch is good, so ACK.
>
> But the commit messages should describe why this change is needed.  In
> this case:
>
> Previously, 'make test' failed for --disable-crypto builds.  Since
> that is not fixed, we should no longer accept --disable-crypto builds
> to fail 'make test' on travis.
>
> Could you please include such descriptions in future patches?
>
> -Steffan
>
--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Илья Шипицин]

2016-09-17 16:17 GMT+05:00 Steffan Karger :

> Hi,
>
> On 17 September 2016 at 12:54, Ilya Shipitsin 
> wrote:
> > ---
> >  .travis.yml | 4 
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 452c48e..369db97 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -51,10 +51,6 @@ matrix:
> >os: osx
> >osx_image: xcode7.3
> >compiler: clang
> > -  allow_failures:
> > -- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
> > -  os: linux
> > -  compiler: clang
> >exclude:
> >  - compiler: gcc
> >
> > --
> > 2.5.5
>
> Thanks.  The patch is good, so ACK.
>
> But the commit messages should describe why this change is needed.  In
> this case:
>
> Previously, 'make test' failed for --disable-crypto builds.  Since
> that is not fixed, we should no longer accept --disable-crypto builds
> to fail 'make test' on travis.
>
> Could you please include such descriptions in future patches?
>

ok, I'm going to play with travis-ci + valgrind soon.

or, some powershell for windows testing (it's on my list)



>
> -Steffan
>
--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Steffan Karger]

Hi,

On 17 September 2016 at 12:54, Ilya Shipitsin  wrote:
> ---
>  .travis.yml | 4 
>  1 file changed, 4 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 452c48e..369db97 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -51,10 +51,6 @@ matrix:
>os: osx
>osx_image: xcode7.3
>compiler: clang
> -  allow_failures:
> -- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
> -  os: linux
> -  compiler: clang
>exclude:
>  - compiler: gcc
>
> --
> 2.5.5

Thanks.  The patch is good, so ACK.

But the commit messages should describe why this change is needed.  In
this case:

Previously, 'make test' failed for --disable-crypto builds.  Since
that is not fixed, we should no longer accept --disable-crypto builds
to fail 'make test' on travis.

Could you please include such descriptions in future patches?

-Steffan

--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

[Ilya Shipitsin]

---
 .travis.yml | 4 
 1 file changed, 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 452c48e..369db97 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -51,10 +51,6 @@ matrix:
   os: osx
   osx_image: xcode7.3
   compiler: clang
-  allow_failures:
-- env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto"
-  os: linux
-  compiler: clang
   exclude:
 - compiler: gcc
 
-- 
2.5.5


--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel