Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password query the management interface (if available).

2020-04-05 Thread Gert Doering
Hi, On Sun, Apr 05, 2020 at 10:25:56AM +0200, Gert Doering wrote: > On Fri, Apr 03, 2020 at 09:17:44PM -0400, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > When only username is found in the file, redirect the auth-user-pass > > query to the management interface if

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password query the management interface (if available).

2020-04-05 Thread Gert Doering
HI, On Fri, Apr 03, 2020 at 09:17:44PM -0400, selva.n...@gmail.com wrote: > From: Selva Nair > > When only username is found in the file, redirect the auth-user-pass > query to the management interface if management-query-passwords is > enabled. Otherwise the user is prompted on console, if

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Jonathan K. Bullard
On Mon, Mar 30, 2020 at 12:30 PM Selva Nair wrote: > That is, if management-query-passwords is enabled and auth file is > missing password, query the management, not on console irrespective > of other options and OS. If that's acceptable, I'll submit a v2. That's fine with me (and Tunnelblick),

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Gert Doering
Hi, On Mon, Mar 30, 2020 at 12:29:44PM -0400, Selva Nair wrote: > Personally I would prefer to enable this code for all platforms although > its a minor regression. > > That is, if management-query-passwords is enabled and auth file is > missing password, query the management, not on console

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Selva Nair
Hi, On Mon, Mar 30, 2020 at 12:11 PM Jonathan K. Bullard wrote: > Hi, > > On Mon, Mar 30, 2020 at 11:12 AM Selva Nair wrote: > > Jonathan K. Bullard wrote: > > > > > > If the OS X command line user was using --management-query-passwords > > > (as Tunnelblick does), they wouldn't see the

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Jonathan K. Bullard
Hi, On Mon, Mar 30, 2020 at 11:12 AM Selva Nair wrote: > Jonathan K. Bullard wrote: > > > > If the OS X command line user was using --management-query-passwords > > (as Tunnelblick does), they wouldn't see the password prompt on > > /dev/tty, would they? > > In case of auth-file missing

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Selva Nair
Hi, On Mon, Mar 30, 2020 at 2:07 AM Gert Doering wrote: > > Hi, > > On Sun, Mar 29, 2020 at 07:58:15PM -0400, Selva Nair wrote: > > Yes, that's right. However, that logic wont be proper on OS-X, would it? > > Command line users who use --log can still see password > > prompt on /dev/tty. We'll

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-30 Thread Gert Doering
Hi, On Sun, Mar 29, 2020 at 07:58:15PM -0400, Selva Nair wrote: > Yes, that's right. However, that logic wont be proper on OS-X, would it? > Command line users who use --log can still see password > prompt on /dev/tty. We'll be breaking that behaviour. > > I considered checking for env vars like

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Jonathan K. Bullard
Hi, On Sun, Mar 29, 2020 at 7:58 PM Selva Nair wrote: > > Hi, > > On Sun, Mar 29, 2020 at 7:13 PM Jonathan K. Bullard > wrote: > > On a Mac using Tunnelblick (which uses the management interface with > > management-query-passwords enabled), if the auth-user-pass file > > contains only the

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Selva Nair
Hi, On Sun, Mar 29, 2020 at 7:13 PM Jonathan K. Bullard wrote: > > Hi, > > On Sun, Mar 29, 2020 at 4:34 PM wrote: > > > > From: Selva Nair > > > > If only username is found in the file, redirect the auth-user-pass > > query to the management on Windows if (i) management-query-passwords > > is

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Jonathan K. Bullard
Hi, On Sun, Mar 29, 2020 at 4:34 PM wrote: > > From: Selva Nair > > If only username is found in the file, redirect the auth-user-pass > query to the management on Windows if (i) management-query-passwords > is enabled and (ii) stdout is redirected to a log file. These > restrictions avoid