Re: [OpenWrt-Devel] [PATCH] net/openl2tp: fix ppp setup timeout in non-rpc (mini) version

2012-04-30 Thread Daniel Golle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I merged your branches into my openwrt, packages and luci repos and gave it a try over the past 24 hours running on a ath9k-based router. Results: very nice. This should go uptream. On 27/04/12 15:39, David Woodhouse wrote: On Fri, 2012-04-27 at

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread David Woodhouse
On Sun, 2012-04-22 at 14:48 -0700, Dave Täht wrote: + +-#define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))-words [3]) ++#define tcp_flag_word2(tp) ( ((union tcp_word_hdr *)(tp))-words [3]) ++#define tcp_flag_word(tp) ( __get_unaligned_cpu32union tcp_word_hdr *)(tp))-words

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Dave Taht
On Mon, Apr 30, 2012 at 3:49 AM, David Woodhouse dw...@infradead.org wrote: On Sun, 2012-04-22 at 14:48 -0700, Dave Täht wrote: Thank you very much for the code review! + +-#define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))-words [3]) ++#define tcp_flag_word2(tp) ( ((union

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread David Woodhouse
On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to however wired up this chip and shipped it in qty millions. Actually that message was already received, successor chipsets from this manufacturer did it up right. So the real problem is that the ar71xx doesn't allow you to DMA to

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Felix Fietkau
On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to however wired up this chip and shipped it in qty millions. Actually that message was already received, successor chipsets from this manufacturer did it up right. So the real problem

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Dave Taht
On Mon, Apr 30, 2012 at 7:49 AM, David Woodhouse dw...@infradead.org wrote: On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to however wired up this chip and shipped it in qty millions. Actually that message was already received, successor chipsets from this manufacturer did it up

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Dave Taht
On Mon, Apr 30, 2012 at 8:02 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to however wired up this chip and shipped it in qty millions. Actually that message was already received, successor

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Felix Fietkau
On 2012-04-30 5:08 PM, Dave Taht wrote: On Mon, Apr 30, 2012 at 8:02 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to however wired up this chip and shipped it in qty millions. Actually that

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Dave Taht
On Mon, Apr 30, 2012 at 10:26 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 5:08 PM, Dave Taht wrote: On Mon, Apr 30, 2012 at 8:02 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon, 2012-04-30 at 07:41 -0700, Dave Taht wrote: Tell it to

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Felix Fietkau
On 2012-04-30 8:11 PM, Dave Taht wrote: On Mon, Apr 30, 2012 at 10:26 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 5:08 PM, Dave Taht wrote: On Mon, Apr 30, 2012 at 8:02 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon, 2012-04-30 at

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread David Woodhouse
On Mon, 2012-04-30 at 11:11 -0700, Dave Taht wrote: On Mon, Apr 30, 2012 at 10:26 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 5:08 PM, Dave Taht wrote: On Mon, Apr 30, 2012 at 8:02 AM, Felix Fietkau n...@openwrt.org wrote: On 2012-04-30 4:49 PM, David Woodhouse wrote: On Mon,

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread David Woodhouse
On Mon, 2012-04-30 at 20:34 +0200, Felix Fietkau wrote: There could be a generic Kconfig variable which could be selected by CPU targets or ethernet drivers (with a dependency on !HAVE_EFFICIENT_UNALIGNED_ACCESS). That's cleaner than messing around with #define stuff manually. Don't just

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread Karl P
On 04/30/2012 06:48 PM, David Woodhouse wrote: On Mon, 2012-04-30 at 20:34 +0200, Felix Fietkau wrote: There could be a generic Kconfig variable which could be selected by CPU targets or ethernet drivers (with a dependency on !HAVE_EFFICIENT_UNALIGNED_ACCESS). That's cleaner than messing

Re: [OpenWrt-Devel] [PATCH 2/2] Comprehensive ipv4 and ipv6 unaligned access patch for ar71xx

2012-04-30 Thread David Woodhouse
On Mon, 2012-04-30 at 19:16 +, Karl P wrote: As a user, I _never_ want to have to go and turn on the switch that says, make my device work as fast as it can Is there any reason that I would _not_ want this? You may only have a printer, or something like that, attached to the crappy