This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
target/linux/apm821xx/image/mbl_gen_hdd_img.sh | 2 +-
target/linux/arc770/image/gen_axs10x_sdcard_img.sh | 2 +-
target/linux/archs38/image/gen_axs10x_sdcard_img.sh | 2 +-
target/l
This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
Fix accidental remove of subshell.
---
target/linux/octeon/base-files/lib/upgrade/platform.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/octeon/bas
This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
target/linux/lantiq/base-files/etc/hotplug.d/dsl/pppoa.sh | 2 +-
.../linux/lantiq/base-files/lib/functions/lantiq_dsl.sh | 8
2 files changed, 5 insertions(+), 5 deletions(-)
dif
This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
.../generic/base-files/etc/uci-defaults/09_hardware | 12 ++--
target/linux/orion/image/generic.mk | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --
This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
.../base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 6 +++---
target/linux/ipq806x/base-files/lib/upgrade/linksys.sh | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
d
This replaces deprecated backticks by more versatile $(...) syntax.
Signed-off-by: Adrian Schmutzler
---
target/linux/mvebu/base-files/lib/upgrade/linksys.sh | 2 +-
target/linux/mvebu/base-files/sbin/fan_ctrl.sh | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ta
This replaces deprecated backticks by more versatile $(...) syntax.
While at it, remove some useless cat commands and deprecated
egrep commands.
Signed-off-by: Adrian Schmutzler
---
target/linux/ramips/base-files/etc/board.d/02_network | 8
.../base-files/lib/preinit/07_set_preinit
On 7/24/19 11:05 AM, Rosen Penev wrote:
On Wed, Jul 24, 2019 at 10:48 AM Adrian Schmutzler
wrote:
Hi,
-Original Message-
From: Rosen Penev [mailto:ros...@gmail.com]
Sent: Mittwoch, 24. Juli 2019 18:54
To: Adrian Schmutzler
Cc: OpenWrt Development List
Subject: Re: [OpenWrt-Devel] [
On Wed, Jul 24, 2019 at 10:48 AM Adrian Schmutzler
wrote:
>
> Hi,
>
> > -Original Message-
> > From: Rosen Penev [mailto:ros...@gmail.com]
> > Sent: Mittwoch, 24. Juli 2019 18:54
> > To: Adrian Schmutzler
> > Cc: OpenWrt Development List
> > Subject: Re: [OpenWrt-Devel] [PATCH] mvebu: Re
Warnings fixed:
SC2004: $/${} is unnecessary on arithmetic variables.
SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Signed-off-by: Rosen Penev
---
v2: Fixed mistake with executing PIDCOUNT.
package/system/ubox/Makefile | 2 +-
package/system/ubox/files/log.init | 6 +++
On Wed, Jul 24, 2019 at 10:50 AM Petr Štetiar wrote:
>
> Rosen Penev [2019-07-24 10:32:31]:
>
> > SC2004: $/${} is unnecessary on arithmetic variables.
> > SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
>
> Can you please provide some details, why should we care about this shell
Hi,
I suppose this has no been runtime tested since `$(${PIDCOUNT} + 1)`
will attempt to execute `${PIDCOUNT}` as command in a subshell with '+'
and '1' passed as arguments to it:
root@OpenWrt:~# PIDCOUNT=1; PIDCOUNT="$(${PIDCOUNT} + 1)"; echo
"$PIDCOUNT"
-ash: 1: not found
I think the prope
Rosen Penev [2019-07-24 10:32:31]:
> SC2004: $/${} is unnecessary on arithmetic variables.
> SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Can you please provide some details, why should we care about this shellcheck
warnings ?
> - PIDCOUNT="$(( ${PIDCOUNT} + 1))"
> +
Hi,
> -Original Message-
> From: Rosen Penev [mailto:ros...@gmail.com]
> Sent: Mittwoch, 24. Juli 2019 18:54
> To: Adrian Schmutzler
> Cc: OpenWrt Development List
> Subject: Re: [OpenWrt-Devel] [PATCH] mvebu: Replace backticks by $(...)
>
> On Wed, Jul 24, 2019 at 6:34 AM Adrian Schmut
Warnings fixed:
SC2004: $/${} is unnecessary on arithmetic variables.
SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Signed-off-by: Rosen Penev
---
package/system/ubox/Makefile | 2 +-
package/system/ubox/files/log.init | 6 +++---
2 files changed, 4 insertions(+), 4 del
On Wed, Jul 24, 2019 at 6:34 AM Adrian Schmutzler
wrote:
>
> Signed-off-by: Adrian Schmutzler
> ---
> target/linux/mvebu/base-files/lib/upgrade/linksys.sh | 2 +-
> target/linux/mvebu/base-files/sbin/fan_ctrl.sh | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
Signed-off-by: Adrian Schmutzler
---
target/linux/ath79/base-files/etc/board.d/01_leds | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/ath79/base-files/etc/board.d/01_leds
b/target/linux/ath79/base-files/etc/board.d/01_leds
index d24a42d239..f3bf43a247 100755
Adrian Schmutzler [2019-07-24 15:40:35]:
You've forget to provide commit description/message in all your patches,
usually answer to "Why do you need this changes?" or "Why are you proposing
this changes?"
> Signed-off-by: Adrian Schmutzler
> ---
> target/linux/octeon/base-files/lib/upgrade/pla
Signed-off-by: Adrian Schmutzler
---
target/linux/apm821xx/image/mbl_gen_hdd_img.sh | 2 +-
target/linux/arc770/image/gen_axs10x_sdcard_img.sh | 2 +-
target/linux/archs38/image/gen_axs10x_sdcard_img.sh | 2 +-
target/linux/at91/image/gen_at91_sdcard_img.sh | 2 +-
target/linux/brc
Signed-off-by: Adrian Schmutzler
---
target/linux/octeon/base-files/lib/upgrade/platform.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/octeon/base-files/lib/upgrade/platform.sh
b/target/linux/octeon/base-files/lib/upgrade/platform.sh
index 0e4ca37629..5d
Signed-off-by: Adrian Schmutzler
---
target/linux/lantiq/base-files/etc/hotplug.d/dsl/pppoa.sh | 2 +-
.../linux/lantiq/base-files/lib/functions/lantiq_dsl.sh | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/linux/lantiq/base-files/etc/hotplug.d/dsl/pppoa.sh
Signed-off-by: Adrian Schmutzler
---
.../generic/base-files/etc/uci-defaults/09_hardware | 12 ++--
target/linux/orion/image/generic.mk | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/target/linux/orion/generic/base-files/etc/uci-defaults/09_hardw
Signed-off-by: Adrian Schmutzler
---
.../base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 6 +++---
target/linux/ipq806x/base-files/lib/upgrade/linksys.sh | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/target/linux/ipq806x/base-files/etc/hotplug.d/ieee80211/
Signed-off-by: Adrian Schmutzler
---
target/linux/mvebu/base-files/lib/upgrade/linksys.sh | 2 +-
target/linux/mvebu/base-files/sbin/fan_ctrl.sh | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/linux/mvebu/base-files/lib/upgrade/linksys.sh
b/target/linux/mv
While at it, remove some useless cat commands.
Signed-off-by: Adrian Schmutzler
---
target/linux/ramips/base-files/etc/board.d/02_network | 8
.../base-files/lib/preinit/07_set_preinit_iface_ramips| 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/linu
This commit adds support for the ZhuoTK JS7628 development board,
The device has the following specifications:
- SOC:MT7628AN/NN
- RAM:64/128/256 MB (DDR2)
- FLASH:8/16/32 MB (SPI NOR)
- Ethernet:3x 10/100 Mbps ethernet ports (MT7628 built-in switch)
- WIFI:1x 2T2R 2.4 GHz Wi-Fi
- LEDs:1x system s
26 matches
Mail list logo
