[PATCH uhttpd 3/3] main: free port string after strdup()

2020-12-31 Thread Hauke Mehrtens
This fixes a memory leak. Signed-off-by: Hauke Mehrtens --- main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/main.c b/main.c index 73e3d42..bca69cf 100644 --- a/main.c +++ b/main.c @@ -298,6 +298,7 @@ int main(int argc, char **argv) case 'p':

[PATCH uhttpd 2/3] listen: Copy only parts of ai_addr

2020-12-31 Thread Hauke Mehrtens
ai_addr has different sizes for IPv4 and IPv6. Only copy the parts which are actually used and not the full array, to not copy and uninitialized memory. This fixes a warning found with the address sanitizer. Signed-off-by: Hauke Mehrtens --- listen.c | 15 ++- 1 file changed, 10

[PATCH uhttpd 1/3] cmake: Use variables

2020-12-31 Thread Hauke Mehrtens
This makes it easier to build this outside of OpenWrt. Signed-off-by: Hauke Mehrtens --- CMakeLists.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7ae8ba4..61a3315 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -35,9

Re: Please revert 98b86296e6 as it breaks several ipq806x devices

2020-12-31 Thread Paweł Dembicki
czw., 31 gru 2020 o 16:51 Adrian Schmutzler napisał(a): > > Hi, > Hi all, > Pawel hasn't been in the recipients list, so I added him: > > @Pawel: If you haven't followed the thread via openwrt-devel anyway, you > should definitely have a look, particularly at the latest findings by Hannu >

Re: Persistent HTTP(S) connections in opkg

2020-12-31 Thread Hauke Mehrtens
On 12/31/20 8:40 PM, Hauke Mehrtens wrote: On 12/30/20 7:14 PM, Baptiste Jonglez wrote: Following the discussion in http://lists.openwrt.org/pipermail/openwrt-devel/2020-November/032297.html There are basically two options to implement persistent connections in opkg: 1) keep calling

Re: Persistent HTTP(S) connections in opkg

2020-12-31 Thread Paul Spooren
On Mi, Dez 30, 2020 at 19:14, Baptiste Jonglez wrote: Following the discussion in http://lists.openwrt.org/pipermail/openwrt-devel/2020-November/032297.html There are basically two options to implement persistent connections in opkg: 1) keep calling "wget", but pass the list of all

Re: [PATCH] kernel-build: fix STRIP_KERNEL_EXPORTS for 64-bit kernels

2020-12-31 Thread Hauke Mehrtens
On 12/31/20 8:38 PM, Rui Salvaterra wrote: Hi again, On Thu, 31 Dec 2020 at 19:30, Rui Salvaterra wrote: On Thu, 31 Dec 2020 at 19:07, Hauke Mehrtens wrote: Result with your change: hauke@hauke-t480:~/openwrt/openwrt$

Re: Persistent HTTP(S) connections in opkg

2020-12-31 Thread Hauke Mehrtens
On 12/30/20 7:14 PM, Baptiste Jonglez wrote: Following the discussion in http://lists.openwrt.org/pipermail/openwrt-devel/2020-November/032297.html There are basically two options to implement persistent connections in opkg: 1) keep calling "wget", but pass the list of all packages to

Re: [PATCH] kernel-build: fix STRIP_KERNEL_EXPORTS for 64-bit kernels

2020-12-31 Thread Rui Salvaterra
Hi again, On Thu, 31 Dec 2020 at 19:30, Rui Salvaterra wrote: > > On Thu, 31 Dec 2020 at 19:07, Hauke Mehrtens wrote: > > > > Result with your change: > > > > hauke@hauke-t480:~/openwrt/openwrt$ > >

Re: [PATCH] build/prereq: merge ifndef IB block together

2020-12-31 Thread Paul Spooren
On Mi, Dez 30, 2020 at 18:10, Paul Spooren wrote: On Mi, Dez 30, 2020 at 18:28, Baptiste Jonglez wrote: Hi, On 29-12-20, Paul Spooren wrote: Multiple prereq checks are only required within the build system but not for the ImageBuilder. These checks are excluded by using ifndef

Re: [PATCH] kernel-build: fix STRIP_KERNEL_EXPORTS for 64-bit kernels

2020-12-31 Thread Rui Salvaterra
Hi, Hauke, On Thu, 31 Dec 2020 at 19:07, Hauke Mehrtens wrote: > > Hi, > > On the ipq40xx target the results of both commands are different. The > original command removed the __ksymtab_ prefix, you do not remove it. > > Original result: > >

Re: [PATCH] usbutils: remove

2020-12-31 Thread Paul Spooren
On Do, Dez 31, 2020 at 11:47, Bjørn Mork wrote: Paul Spooren writes: On Mi, Dez 30, 2020 at 10:03, Bjørn Mork wrote: Rosen Penev writes: I have git send-email preset to send stuff to this email address. I usually don't CC anyone. I don't understand what "maintainer" means in

Re: [PATCH] kernel-build: fix STRIP_KERNEL_EXPORTS for 64-bit kernels

2020-12-31 Thread Hauke Mehrtens
On 12/30/20 9:04 PM, Rui Salvaterra wrote: While parsing the nm output, we need to account for the fact that 64-bit kernels have 64-bit wide addresses. While at it, replace the grep | sed combo with a single awk invocation and a stronger regex. Fixes: 2ef0acc5fcda557fa5aaad35d27cb8cf75be96d2

RE: Please revert 98b86296e6 as it breaks several ipq806x devices

2020-12-31 Thread Adrian Schmutzler
Hi, Pawel hasn't been in the recipients list, so I added him: @Pawel: If you haven't followed the thread via openwrt-devel anyway, you should definitely have a look, particularly at the latest findings by Hannu (below; thanks!).

Re: Please revert 98b86296e6 as it breaks several ipq806x devices

2020-12-31 Thread Hannu Nyman
Hannu Nyman kirjoitti 31.12.2020 klo 14.32: ... I did some further debugging, and noticed something. In short: Possibly the definition of CONFIG_CMDLINE_OVERRIDE has been placed into a slightly wrong place in arch/arm/Kconfig. I compared the kernel build log with the working code (without

Re: Please revert 98b86296e6 as it breaks several ipq806x devices

2020-12-31 Thread Hannu Nyman
Christian Lamparter kirjoitti 28.12.2020 klo 16.59: On 28/12/2020 15:27, Adrian Schmutzler wrote: -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Hannu Nyman Sent: Montag, 28. Dezember 2020 10:12 To: OpenWrt Development List Cc: Petr

Re: [PATCH] usbutils: remove

2020-12-31 Thread Bjørn Mork
Paul Spooren writes: > On Mi, Dez 30, 2020 at 10:03, Bjørn Mork wrote: >> Rosen Penev writes: >> >>> I have git send-email preset to send stuff to this email address. I >>> usually don't CC anyone. >> I don't understand what "maintainer" means in an OpenWrt context... > > My understanding is