Re: [PATCH] procd: Adding support to detect Pantavisor Container Platform

2021-03-20 Thread John Crispin
On 20.03.21 15:46, Gaurav Pathak wrote: as it runs a custom modified version of LXC I assume that if this is a custom downstream version then the change is not applicable for merge into upstream owrt. please explain what "custom version" means.     John

Re: [PATCH] procd: Adding support to detect Pantavisor Container Platform

2021-03-20 Thread Paul Spooren
On Sat, Mar 20, 2021 at 20:16, Gaurav Pathak wrote: Added a new file pv_platform.h having function is_pantavisor() to detect the pantavisor container platform, as it runs a custom modified version of LXC, so detecting LXC using is_container() is not returning expected result. pv_platform.

[PATCH v2 2/2] uhttpd: Execute uci commit and reload_config once

2021-03-20 Thread Hauke Mehrtens
Instead of doing uci commit and reload_config for each setting do it only once when one of these options was changed. This should make it a little faster when both conditions are taken. Signed-off-by: Hauke Mehrtens --- package/network/services/uhttpd/files/ubus.default | 10 ++ 1 file c

Re: [PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Hauke Mehrtens
On 3/20/21 2:05 PM, Jo-Philipp Wich wrote: Hi Hauke, thanks for looking into it! I have a couple of remarks... [...] [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && { uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock' uci commit uhttpd + re

[PATCH v2 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Hauke Mehrtens
Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over http and returns a Error 404. This caused problems when installing luci on the snapshots and acces

Re: [PATCH uhttpd] client: Always close connection with request body in case of error

2021-03-20 Thread Hauke Mehrtens
On 3/20/21 8:28 PM, Hauke Mehrtens wrote: When we run into an error like a 404 Not Found the request body is not read and will be parsed as part of the next request. The next Request will then fail because there is unexpected data in it. When we run into such a problem with a request body close r

[PATCH uhttpd] client: Always close connection with request body in case of error

2021-03-20 Thread Hauke Mehrtens
When we run into an error like a 404 Not Found the request body is not read and will be parsed as part of the next request. The next Request will then fail because there is unexpected data in it. When we run into such a problem with a request body close return an error and close the connection. Thi

Re: Massive package rebuild failure

2021-03-20 Thread Petr Štetiar
Marcel Telka [2021-03-20 14:09:21]: Hi, > There seems to be massive package rebuild failure resulting in almost > all packages missing from the 19.07 repo, for example: > > https://downloads.openwrt.org/releases/faillogs-19.07/mips_24kc/packages/ sorry for the troubles, it's caused by the rece

[PATCH] procd: Adding support to detect Pantavisor Container Platform

2021-03-20 Thread Gaurav Pathak
Added a new file pv_platform.h having function is_pantavisor() to detect the pantavisor container platform, as it runs a custom modified version of LXC, so detecting LXC using is_container() is not returning expected result. pv_platform.h is derived from container.h to check if procd is running in

Massive package rebuild failure

2021-03-20 Thread Marcel Telka
Hi, There seems to be massive package rebuild failure resulting in almost all packages missing from the 19.07 repo, for example: https://downloads.openwrt.org/releases/faillogs-19.07/mips_24kc/packages/ Could you please have look at it? Thanks. -- +---

Re: [PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Jo-Philipp Wich
Hi Hauke, thanks for looking into it! I have a couple of remarks... > [...] > [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && { > uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock' > uci commit uhttpd > + reload_config That might reload other, unrel

Re: [PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Hauke Mehrtens
On 3/20/21 1:32 PM, Hauke Mehrtens wrote: Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over http and returns a Error 404. This caused problems whe

[PATCH 2/2] uhttpd: Execute uci commit and reload_config once

2021-03-20 Thread Hauke Mehrtens
Instead of doing uci commit and reload_config for each setting do it only once when one of these options was changed. This should make it a little faster when both conditions are taken. Signed-off-by: Hauke Mehrtens --- package/network/services/uhttpd/files/ubus.default | 10 ++ 1 file c

[PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Hauke Mehrtens
Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over http and returns a Error 404. This caused problems when installing luci on the snapshots and acces

[PATCH 0/4] remove invalid/disabled/unnecessary UBI upgrade code

2021-03-20 Thread Bjørn Mork
The problem of partially erasing an UBI partition was solved with the addition of the EOF marker in 2013. Ref https://dev.archive.openwrt.org/changeset/38681.html https://dev.archive.openwrt.org/changeset/38682.html Bjørn Mork (4): mvebu: sysupgrade: drop unnecessary UBI to UBI logic kirk

[PATCH 3/4] ipq806x: sysupgrade: drop unnecessary UBI to UBI logic

2021-03-20 Thread Bjørn Mork
The purpose of this code seems to be to avoid issues caused by partially overwriting an existing UBI partition, where some of the erase counters would be reset but not the unmodified ones. This problem has been solved in a more generic way by the UBI EOF marker. This ensures that any old PEBs afte

[PATCH 2/4] kirkwood: sysupgrade: drop unnecessary UBI to UBI logic

2021-03-20 Thread Bjørn Mork
The purpose of this code seems to be to avoid issues caused by partially overwriting an existing UBI partition, where some of the erase counters would be reset but not the unmodified ones. This problem has been solved in a more generic way by the UBI EOF marker. This ensures that any old PEBs afte

[PATCH 1/4] mvebu: sysupgrade: drop unnecessary UBI to UBI logic

2021-03-20 Thread Bjørn Mork
The recent changes to the maximum kernel size for Mamba and Venom highlighted the fact that the old Mamba kernel size has been hardcoded in linksys_get_root_magic() even for devices with a different kernel/rootfs split. The purpose of this code seems to be to avoid issues caused by partially overw

[PATCH 4/4] ipq40xx: sysupgrade: drop disabled UBI to UBI logic

2021-03-20 Thread Bjørn Mork
The commented out code is not required, as the comment indicates. The purpose of this code seems to be to avoid issues caused by partially overwriting an existing UBI partition, where some of the erase counters would be reset but not the unmodified ones. This problem has been solved in a more gen