[OpenWrt-Devel] [PATCH ustream-ssl] ustream-openssl: clear error stack before SSL_read/SSL_write

2020-03-13 Thread Jo-Philipp Wich
id results. Signed-off-by: Jo-Philipp Wich --- ustream-openssl.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ustream-openssl.c b/ustream-openssl.c index 049aa40..f8e848d 100644 --- a/ustream-openssl.c +++ b/ustream-openssl.c @@ -266,6 +266,8 @@ __h

Re: [OpenWrt-Devel] Security implications for consideration [Was: Re: [openwrt/openwrt] rpcd: add respawn param]

2020-03-04 Thread Jo-Philipp Wich
Hi, > [...] feel free to revert it. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-03-03 Thread Jo-Philipp Wich
Hi Florian, > Deleting an interface section in LuCI is generic. So I don't know if we should > do this and make an exception for wireguard. proper removal of wg peer sections is in LuCI master and openwrt-19.07 now. ~ Jo signature.asc Description: OpenPGP digital signature

[OpenWrt-Devel] Next maintenance releases

2020-02-21 Thread Jo-Philipp Wich
Hi, I'd like to release 19.07.2 and 18.06.8 sometime between Sun 23rd and Tue 25th. If you have pending important fixes you like to see backported to the respective branches please do so ASAP or mention the commits in a reply to this mail. Regards, Jo

[OpenWrt-Devel] [PATCH uclient] uclient-fetch: support specifying advertised TLS ciphers

2020-02-15 Thread Jo-Philipp Wich
-by: Jo-Philipp Wich --- uclient-fetch.c | 12 1 file changed, 12 insertions(+) diff --git a/uclient-fetch.c b/uclient-fetch.c index 38c9c53..a06be5d 100644 --- a/uclient-fetch.c +++ b/uclient-fetch.c @@ -467,6 +467,7 @@ static int usage(const char *progname) "HTTPS op

[OpenWrt-Devel] [PATCH uhttpd] tls: support specifying accepted TLS ciphers

2020-02-15 Thread Jo-Philipp Wich
-Philipp Wich --- main.c | 12 +--- tls.c | 7 ++- tls.h | 4 ++-- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/main.c b/main.c index 6c29afe..26e74ec 100644 --- a/main.c +++ b/main.c @@ -139,6 +139,7 @@ static int usage(const char *name) "

[OpenWrt-Devel] [PATCH ustream-ssl] add support for specifying usable ciphers

2020-02-15 Thread Jo-Philipp Wich
://tls.mbed.org/api/ssl_8h.html#a9914cdf5533e813e1ea7ca52981aa006 Signed-off-by: Jo-Philipp Wich --- ustream-internal.h | 1 + ustream-mbedtls.c | 66 ++ ustream-mbedtls.h | 1 + ustream-openssl.c | 11 +++- ustream-ssl.c | 1 + ustream-ssl.h

Re: [OpenWrt-Devel] [PATCH] ath79: introduces KERNEL_LZMA variable for common build sequence

2020-02-03 Thread Jo-Philipp Wich
Hi, what is the actual benefit of this? The image building recipes are hard enough to understand as-is, is it really worth it to replace a plain "kernel-bin | append-dtb | lzma" command sequence with yet another variable indirection just to safe a few bytes in the Makefile? I could understand

[OpenWrt-Devel] Merged: buildbot: signall.sh store usign.key asusign.sec

2020-02-02 Thread Jo-Philipp Wich
Merged into buildbot.git, branch master at http://git.lede-project.org/?p=buildbot.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] RFI: OpenWRT Upgrade System; ENH,SEC suggestions

2020-02-01 Thread Jo-Philipp Wich
Hi Wes, > It's definitely an issue that the sha256 checksum check was broken. > But, can someone explain why a person who is MITM'ing ipk downloads > would change the package and not the checksum? the repository index files containing the SHA256 checksums are signed using usign, which is a

[OpenWrt-Devel] Security Advisory 2020-01-31-2 - libubox tagged binary data JSON serialization vulnerability (CVE-2020-7248)

2020-01-31 Thread Jo-Philipp Wich
rt 19.07.1, 18.06.7 and subsequent releases. Older versions of OpenWrt (e.g. OpenWrt 15.05 and LEDE 17.01) are end of life and not supported any more. Other users of libubox should update to the latest version ASAP. CREDITS The issues were discovered and fixed by Petr Štetiar and Jo-Philipp Wich.

[OpenWrt-Devel] Security Advisory 2020-01-31-1 - Opkg susceptible to MITM (CVE-2020-7982)

2020-01-31 Thread Jo-Philipp Wich
DESCRIPTION A bug in the package list parse logic of OpenWrt's opkg fork caused the package manager to ignore SHA-256 checksums embedded in the signed repository index, effectively bypassing integrity checking of downloaded .ipk artifacts. The bug has been introduced with commit

[OpenWrt-Devel] OpenWrt 19.07.1 service release

2020-01-31 Thread Jo-Philipp Wich
Hi, The OpenWrt Community is proud to announce the first service release of the stable OpenWrt 19.07 series. OpenWrt 19.07.1 incorporates important security updates for base packages, fixes for 5GHz performance issues and flow offloading memory leaks as well as new versions of the Linux kernel

[OpenWrt-Devel] OpenWrt 18.06.7 service release

2020-01-31 Thread Jo-Philipp Wich
Hi, The OpenWrt Community is proud to announce the seventh service release of the stable OpenWrt 18.06 series. OpenWrt 18.06.7 incorporates important security updates for base packages, new versions of the Linux kernel and fixes for various devices. Selected highlights of this service

[OpenWrt-Devel] Merged: fw3: robustify flow table detection.

2020-01-28 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.lede-project.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] fw3: robustify flow table detection.

2020-01-23 Thread Jo-Philipp Wich
Hi, > This doesn't seem right to me in case target > 12, > MIN(sizeof(line), strlen(target)) perhaps? a simple strcmp() without len will be the most appropriate since both line (produced by fgets()) and target (a constant string literal) will be \0 terminated. ~ Jo signature.asc Description:

Re: [OpenWrt-Devel] [PATCH v2 5/5] hostapd: wpa_supplicant: enable proper GCMP cipher support

2020-01-16 Thread Jo-Philipp Wich
Hi, > + case "$wpa_cipher" in > + GCMP) > + append network_data "pairwise=GCMP" "$N$T" > + append network_data "group=GCMP" "$N$T" > + ;; > + esac > + how is this supposed to work and look like in uci? I couldn't find any

Re: [OpenWrt-Devel] [PATCH v2] wireguard: skip peer config if public key of the peer is not defined

2020-01-16 Thread Jo-Philipp Wich
Hi, > + if [ -z "$public_key" ]; then > + echo "Skipping peer config $peer_config because public key is > not defined." > + return 0 > + fi I guess there will be other error conditions that could cause the wg setup to fail... is there any more robust way to check

Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-01-16 Thread Jo-Philipp Wich
Hi, I think this behavior is not really acceptable. Programs, init scripts, hotplug events etc. should not automatically modify (and commit) uci configurations, especially not such vital ones like the network config. The main problem I see is that you do not know what state the config is in at

[OpenWrt-Devel] Merged: cryptodev-linux: remove DEFAULT redefinition

2020-01-15 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] dev.archive.openwrt.org cert expired

2020-01-01 Thread Jo-Philipp Wich
Hi, thanks. The cert was auto-renewed but the nginx reload failed due to `service` not being in $PATH for cronjobs. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH 1/2] scripts/flashing: Switch from echo -en to printf

2020-01-01 Thread Jo-Philipp Wich
Hi. $ patch -p1 < 1216552.patch patching file scripts/flashing/flash.sh Hunk #1 FAILED at 51. 1 out of 1 hunk FAILED -- saving rejects to file scripts/flashing/flash.sh.rej ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH] scripts/gen_image_generic.sh: Replace -o with ||

2020-01-01 Thread Jo-Philipp Wich
Hi, > [...] > +if [ ! $# -eq 5 ] || [ ! $# -eq 6 ]; then why not simply "-ne" ? ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

[OpenWrt-Devel] Merged: scripts/gen-dependencies.sh: replacebackticks with $()

2020-01-01 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: scripts/gen-dependencies.sh: use /bin/sh

2020-01-01 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: libcxx: Build with the libsupc++ ABI

2020-01-01 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: libcxx: Add size optimizations

2020-01-01 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: openssl: update to version 1.0.2u

2020-01-01 Thread Jo-Philipp Wich
Merged into openwrt-18.06 at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] busybox: Include hdparm by default on nas type device

2020-01-01 Thread Jo-Philipp Wich
Hi Linus, can you move the condition before the sed program populating the initial config? That should restore the ability for users to deselect busybox hdparm (e.g. to replace it with something different). ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] Preserving configs over sysupgrade on ath79/tiny broken for some boards (on 19.07 and master), possible solutions

2019-12-30 Thread Jo-Philipp Wich
Hi, given that (binary release) support for 4MB devices will end with 19.07, I'd vote for reverting the 4K sector change in ath79 and stick with 64K ones as common denominator across the entire target. That will be the least invasive and most robust fix. Regards, Jo signature.asc Description:

Re: [OpenWrt-Devel] [PATCH] zones: enforce forward policy with zone_NAME_src_POLICY

2019-12-13 Thread Jo-Philipp Wich
Hi, per definition, zone forward policies were only ever meant to apply to traffic between interfaces within the same zone *not* to traffic anywhere else. Your patch would break that assumption as far as I can see. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] [RFC][PATCH] base-files: send informational UDP message each second waiting

2019-12-11 Thread Jo-Philipp Wich
Hi, > Question is, if it's worth the hassle for a feature which is targeted more > towards the expert users. from my pov - it is not worth overengineering this feature. The proposed patch is more than adequate. It increases the probability of the message getting delivered without additional code

Re: [OpenWrt-Devel] The meaning of Signed-off-by for netifd [Was: Re: [PATCH netifd] interface: warn if ip6hint is truncated]

2019-12-04 Thread Jo-Philipp Wich
Hi, > ok, so you claim my SoB means that *I* confirmed that my change is > compatible to the netifd's license. I didn't do that though. as it has been pointed out on this list, adding a S-o-b without consent should not be done, so I reverted the offending commit. Kind regards, Jo

Re: [OpenWrt-Devel] Kernel version for OpenWrt 20.X

2019-11-27 Thread Jo-Philipp Wich
Hi Hauke, I agree with aiming for a kernel 5.4 based release in April. If we decide to go this route, we should also set a fixed feature freeze date (maybe end of March?) on which we branch off and drop targets not ported by then. ~ Jo ___

Re: [OpenWrt-Devel] [PATCH] generic ar8xxx: increase VLAN table for AR83x7

2019-11-25 Thread Jo-Philipp Wich
Hi, does it make sense to keep the vlan/vid indirection if we increase the table size to 4096? A simple 1:1 mapping of the vid to the table index would be simpler and more robust from the configuration pov. ~ Jo ___ openwrt-devel mailing list

[OpenWrt-Devel] [PATCH 16/17] ramips: disable WR512-3GN 4MB variant by default

2019-11-16 Thread Jo-Philipp Wich
Disable the WR512-3GN 4MB image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [PATCH 17/17] ramips: disable ZyXel Keenetic by default

2019-11-16 Thread Jo-Philipp Wich
Disable the ZyXel Keenetic images by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 2 ++ 1 file changed, 2 insertions

[OpenWrt-Devel] [PATCH 14/17] ar71xx: disable TP-Link TL-WA855RE by default

2019-11-16 Thread Jo-Philipp Wich
Disable the TP-Link TL-WA855RE image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-tp-link.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 13/17] brcm47xx: disable Netgear WNR2000 v2 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the Netgear WNR2000 v2 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/brcm47xx/image/Makefile | 2 ++ 1 file changed, 2

[OpenWrt-Devel] [PATCH 11/17] ramips: disable TP-Link TL-WA750RE by default

2019-11-16 Thread Jo-Philipp Wich
Disable the TP-Link TL-WA750RE image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/30 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-tp-link.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 10/17] ar71xx: disable TP-Link TL-WA850RE by default

2019-11-16 Thread Jo-Philipp Wich
Disable the TP-Link TL-WA850RE image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/30 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-tp-link.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 09/17] ramips: disable TP-Link TL-WR840N v5 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the TP-Link TL-WR840N v5 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/29 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/mt76x8.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 15/17] ramips: disable A5-V11 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the A5-V11 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 1 + 1 file changed, 1 insertion(+) diff

[OpenWrt-Devel] [PATCH 12/17] brcm47xx: disable Linksys E1000 v1 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the Linksys E1000 v1 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72 Signed-off-by: Jo-Philipp Wich --- target/linux/brcm47xx/image/Makefile | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [PATCH 05/17] ar71xx: disable Netgear WNR2000v4 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the Netgear WNR2000v4 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/11 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-legacy-devices.mk | 1 + 1 file changed

[OpenWrt-Devel] [PATCH 03/17] ar71xx: disable TP-Link TL-WA850RE v2 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the TP-Link TL-WA850RE v2 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/9 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-tp-link.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 07/17] ramips: disable D-Link DIR-645 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the D-Link DIR-645 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/23 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt3883.mk | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [PATCH 06/17] ramips: disable D-Link DIR-300 B5/B6/B7 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the D-Link DIR-300 B5/B6/B7 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/18 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH 08/17] ramips: disable Sitecom WL-351 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the Sitecom WL-351 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/24 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [PATCH 04/17] ar71xx: disable On Networks N150R by default

2019-11-16 Thread Jo-Philipp Wich
Disable the On Networks N150R image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/10 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-legacy-devices.mk | 1 + 1 file changed

[OpenWrt-Devel] [PATCH 01/17] ramips: disable ASUS RT-N10+ B1 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the ASUS RT-N10+ B1 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/1 Signed-off-by: Jo-Philipp Wich --- target/linux/ramips/image/rt305x.mk | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [RFC PATCH 00/17] disable known broken device images for 19.07

2019-11-16 Thread Jo-Philipp Wich
here and only disable the ones explicitly reported. Jo-Philipp Wich (17): ramips: disable ASUS RT-N10+ B1 by default ar71xx: disable Netgear WNR612 v2 by default ar71xx: disable TP-Link TL-WA850RE v2 by default ar71xx: disable On Networks N150R by default ar71xx: disable Netgear WNR2000v4

[OpenWrt-Devel] [PATCH 02/17] ar71xx: disable Netgear WNR612 v2 by default

2019-11-16 Thread Jo-Philipp Wich
Disable the Netgear WNR612 v2 image by default as the device has insufficient flash space for release build images. Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/4 Signed-off-by: Jo-Philipp Wich --- target/linux/ar71xx/image/tiny-legacy-devices.mk | 1 + 1 file changed

[OpenWrt-Devel] OpenWrt 19.07.0 first release candidate

2019-11-08 Thread Jo-Philipp Wich
Hi, The OpenWrt community is proud to announce the first release candidate of the upcoming OpenWrt 19.07 stable version series. It incorporates over 3700 commits since branching the previous OpenWrt 18.06 release and has been under development for about one a half year. With this release the

Re: [OpenWrt-Devel] [19.07] cherry-pick ipqx0xx-generic profile

2019-11-03 Thread Jo-Philipp Wich
Hi Sven, done. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] uhttpd/luci/rpcd is broken?

2019-11-02 Thread Jo-Philipp Wich
Hi, thanks for checking. Can you please pm me your /tmp/dhcp.leases, /tmp/hosts/odhcpd and /etc/config/dhcp? Thanks! ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] uhttpd/luci/rpcd is broken?

2019-11-02 Thread Jo-Philipp Wich
Hi, please try to find out which procedure is crashing rpcd by testing the following commands: - ubus call luci-rpc getNetworkDevices - ubus call luci-rpc getWirelessDevices - ubus call luci-rpc getHostHints - ubus call luci-rpc getBoardJSON - ubus call luci-rpc getDSLStatus - ubus call luci-rpc

Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Jo-Philipp Wich
directory does not even _exist_ in the SDKs, > which are used on the build bots when building packages (see [1] and > [2]). [...] > Signed-off-by: Sebastian Kemper Acked-by: Jo-Philipp Wich I wanted to look into this for a long time but never had the motivation to actually do comprehensive

Re: [OpenWrt-Devel] [PATCH rpcd v2 0/6] memory issue fixes

2019-10-29 Thread Jo-Philipp Wich
Hi Yousong, thank you for the series. I applied it with slight whitespace changes after some valgrind testing on-target. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] rpcd: uci: fix segfault and double free on set method

2019-10-29 Thread Jo-Philipp Wich
Hi Daniel, Yousong, thanks for the reporting issue and the proposed patch. I'd prefer to go with a minimal variant which merely zeroes the flags to avoid touching too much code. Imho the current uci_set() behavior of freeing uci_ptr members without zeroing them is a bug that should be corrected

Re: [OpenWrt-Devel] How to trigger wifi reload from wifi.lua

2019-10-24 Thread Jo-Philipp Wich
Hi, > On the Luci GUI, the current behaviour of Save of changes to the > items in wifi.lua and wireless_modefreq.htm is to invoke a network > restart. I would like to to change this behavior to invoke wifi restart > directly from wifi.lua. This is not supported and will confuse the netifd

Re: [OpenWrt-Devel] How to add items to Luci wireless_modefreq template

2019-10-24 Thread Jo-Philipp Wich
Hi, you need to extend the netifd wireless handler to recognize your proprietary options. LuCI does not perform any wireless or network restarting by itself, it relies on netifd doing the reloading of changed values. If you introduce new options not yet known to netifd, it will do nothing when

Re: [OpenWrt-Devel] Hang on setting $PROMPT in master

2019-10-21 Thread Jo-Philipp Wich
Hi, might be related to this: http://lists.busybox.net/pipermail/busybox/2019-October/087535.html Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-18 Thread Jo-Philipp Wich
Hi, thanks Bjørn - this looks similar to a fix I had in mind. I'll give it some more thorough tries later. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-17 Thread Jo-Philipp Wich
Hi, further blockers: * opkg, under some circumstances fails to install local packages: root@mir3g:~# opkg install ./rpcd_2019-09-01-821045f6-3_x86_64.ipk Installing rpcd (2019-09-21-95f0973c-1) to root... Collected errors: * opkg_download_pkg: Package rpcd is not available from any

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-16 Thread Jo-Philipp Wich
Hi, > Silly question, does 18.6 have the same issue or is this a regression in > relation to 18.6? I believe it is a regression but I am not 100% sure yet. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-16 Thread Jo-Philipp Wich
Hi, > Does it impact OpenWrt ? or just some OpenWrt based distributions ? > (might influence who need to fix this ;) ) it impacts the usage of the kmod compatibility repositories - apparently they're completely ignored by opkg. This problem was reported in the forum by a user who was unable to

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-16 Thread Jo-Philipp Wich
Hi, another blocker: opkg fails to select the correct provider package in case multiple repositories provide the same kmod with different versions and only one of the provider satisfied version dependency constraints. Someone needs to debug and fix this. ~ Jo signature.asc Description:

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-11 Thread Jo-Philipp Wich
Hi Bjørn, > Or: Start discussing the release blockers here and now. Thanks. 1) Blocker: LuCI master needs to be backported to 19.07 Time estimate: 2-3 weeks 2) Blocker: All relevant sub-components for WPA-3 + GUI support, such as hostapd, iwinfo etc. need to be backported to 19.07

Re: [OpenWrt-Devel] [PATCH] libnl-tiny: move source code into separate Git repository

2019-10-07 Thread Jo-Philipp Wich
Hi, On 10/7/19 4:28 PM, Petr Štetiar wrote: > In order to make the source code usable and testable separately out of > buildroot. > > Signed-off-by: Petr Štetiar Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digit

Re: [OpenWrt-Devel] rpcd: file: add path based read/write/exec ACL checks

2019-09-22 Thread Jo-Philipp Wich
Hi, > What do I have to do to enable access again, without calling ubus > session grant like in the commit? Thank you! you need to add the following sections: "superuser": { ... "read": { "file": { "/": [ "stat", "read" ], "/*": [ "stat", "read" ]

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-09-04 Thread Jo-Philipp Wich
Hi, > Buildbot is already crunching the images and packages, and pretty much > all targets are green. So there are no obvious build related issues > preventing the release. I have also not noticed any franctic discussion > about specific major bugs blocking the release, so it looks pretty good >

[OpenWrt-Devel] Merged: bzip2: Fix CVE-2019-12900

2019-09-03 Thread Jo-Philipp Wich
Merged into openwrt-18.06. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: phase1: run prepare instead of diffconfig

2019-09-03 Thread Jo-Philipp Wich
Merged into buildbot.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: upslug2: Update to git repository

2019-09-03 Thread Jo-Philipp Wich
Merged into master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: firewall3: Fix some format string problems

2019-09-03 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: rpcd: Switch to nanosleep

2019-09-03 Thread Jo-Philipp Wich
Merged into project/rpcd.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: libblkid-tiny: addsblkid_probe_set_utf8label support

2019-09-03 Thread Jo-Philipp Wich
Merged into project/fstools.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: libblkid-tiny: useblkid_probe_set_utf8label for label set

2019-09-03 Thread Jo-Philipp Wich
Merged into project/fstools.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH procd] system: reject sysupgrade of broken firmware images

2019-08-30 Thread Jo-Philipp Wich
Hi, > [snip] > + blobmsg_parse(validation_policy, __VALIDATION_MAX, validation, > blob_data(b.head), blob_len(b.head)); > + > + valid = validation[VALIDATION_VALID] && > blobmsg_get_bool(validation[VALIDATION_VALID]); > + forceable = validation[VALIDATION_FORCEABLE] && >

Re: [OpenWrt-Devel] [PATCH procd] system: support passing "options" to the "sysupgrade" ubus method

2019-08-17 Thread Jo-Philipp Wich
Hi, > [...] > + > + blobmsg_for_each_attr(option, options, rem) { > + const char *prefix = "UPGRADE_OPT_"; > + char *name = malloc(strlen(prefix) + > strlen(blobmsg_name(option))); > + char value[11]; > + char *c; > + int tmp; > + >

Re: [OpenWrt-Devel] [PATCH] ubox: Run init script through shellcheck

2019-07-24 Thread Jo-Philipp Wich
Hi, I suppose this has no been runtime tested since `$(${PIDCOUNT} + 1)` will attempt to execute `${PIDCOUNT}` as command in a subshell with '+' and '1' passed as arguments to it: root@OpenWrt:~# PIDCOUNT=1; PIDCOUNT="$(${PIDCOUNT} + 1)"; echo "$PIDCOUNT" -ash: 1: not found I think the

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, the base repositories have been fully restored and should be safe to use again. Once again, please excuse any inconvenience caused. Will follow up with some more post mortem details later today. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, another update. I applied local workarounds to the phase2 builders to simply append the proper branch specification where missing in order to avoid the need to rebuild all SDKs first which will save some time. Additionally I diverted all free resources to the builder so that all targets

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, some updates. I managed to track down the root cause to some bad interaction between buildbot and Git. When buildbot tries to switch an already cloned repo back from a previously checked out tag to a branch, it performs this series of commands: git clean -f -d -x git fetch -t

[OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi all, unfortunately there appears to be an issue with the build cluster which causes it to produce slightly broken SDKs with a wrong embedded package feeds configuration. Due to yet unknown issues in the buildroot (or the build setup itself), the target/sdk Make target fails to identify the

Re: [OpenWrt-Devel] block bugged

2019-06-20 Thread Jo-Philipp Wich
Hi, make dirclean will fix it. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] LEDE 17.01.7 and OpenWrt 18.06.3 deadline on Friday

2019-06-20 Thread Jo-Philipp Wich
Hi, please merge any outstanding changes that should be part of LEDE 17.07.7 and OpenWrt 18.06.3 into the respective lede-17.01 and openwrt-18.06 branches until Friday, the 21st of June at 09:00 UTC. I will tag these branches then and start building corresponding binary releases shortly after.

Re: [OpenWrt-Devel] [PATCH v2 opkg] alternatives: special-case busybox as alternatives provider

2019-06-13 Thread Jo-Philipp Wich
> Signed-off-by: Yousong Zhou Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH opkg] alternatives: special-case busybox as alternatives provider

2019-06-13 Thread Jo-Philipp Wich
Hi, ACK on the patch. I was thinking about whether it makes sense to move out the hardcoded package "busybox" -> "/bin/busybox" path facts into some kind of external pkgname => multicall-executable-path mapping configuration but there's probably not that many other relevant packages where this

Re: [OpenWrt-Devel] [firewall3] utils: coverity resource leak warning

2019-06-12 Thread Jo-Philipp Wich
Hi Kevin, ACK. Feel free to push. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] lua bug introduction

2019-06-05 Thread Jo-Philipp Wich
Hi, > Does it zero out itself or when using LuCI? The commit above will > touch rc.local when LuCI is not used. This should have been: "will *not* touch rc.local when LuCI is not used" ~ Jo signature.asc Description: OpenPGP digital signature ___

Re: [OpenWrt-Devel] lua bug introduction

2019-06-05 Thread Jo-Philipp Wich
Hi, > Something has started zeroing out /etc/rc.local contents, maybe: > > https://git.openwrt.org/?p=project/luci.git;a=commit;h=1c09ee5e42550d6339bffa58d4cba3461948e19c Does it zero out itself or when using LuCI? The commit above will touch rc.local when LuCI is not used. ~ Jo

Re: [OpenWrt-Devel] [PATCH 2/2] script/feeds: add a new command that allows generating a new feeds.conf

2019-06-04 Thread Jo-Philipp Wich
Hi, comments inline. On 6/4/19 7:55 AM, John Crispin wrote: > This can be used inside build setups for easy feeds.conf generation. > > Signed-off-by: John Crispin > --- > scripts/feeds | 37 + > 1 file changed, 37 insertions(+) > > diff --git

Re: [OpenWrt-Devel] [PATCH 1/2] image: make the folder that gets included intot he RootFS configurable

2019-06-04 Thread Jo-Philipp Wich
Hi, comments inline. ~ Jo On 6/4/19 7:55 AM, John Crispin wrote: > This allows managing several different folder for varying env profiles. > > Signed-off-by: John Crispin > --- > config/Config-images.in | 6 ++ > package/Makefile| 2 +- > 2 files changed, 7 insertions(+), 1

Re: [OpenWrt-Devel] [PATCH][RFC] opkg: add License to info command

2019-05-13 Thread Jo-Philipp Wich
Hi, please make sure that the license info is only parsed when it is required by the toplevel command being executed, look at the other usages of the PFM_* macros in the source. Without this, the in-memory representation of the package trees will consume way more RAM due to the redundant license

Re: [OpenWrt-Devel] [PATCH] procd: add procd_running() helper for checking running state

2019-05-01 Thread Jo-Philipp Wich
Hi, comment inline below. > From: Rafał Miłecki > > This should be helpful for implementing service_running() in procd init > scripts. > > Signed-off-by: Rafał Miłecki > --- > package/system/procd/files/procd.sh | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git

Re: [OpenWrt-Devel] Backport request

2019-04-23 Thread Jo-Philipp Wich
Hi Rosen, > There are two patches in master that fix long range build failures: > > https://github.com/openwrt/openwrt/commit/042d68a19593ac796098845366a235f5465816da#diff-41aaa89c68b8575d420435d3e892f369 > https://github.com/openwrt/packages/commit/5c823596dd4f51969425b7a39f9b3c2730aa4e72 > >

Re: [OpenWrt-Devel] SDK enhancement proposal - add external toolchains via feeds

2019-04-23 Thread Jo-Philipp Wich
Hello Mirko, > Problem statement > > To support new chipsets, it is sometimes necessary to work with > vendor-specific toolchains. Until now, the process to add these > toolchains to the build environment is a manual one. This leads > companies to create their own automation scripts, creating a

Re: [OpenWrt-Devel] [PATCH 2/2 netifd] proto-shell: return error in case setup fails

2019-04-01 Thread Jo-Philipp Wich
Hi, minor nitpick below On 4/1/19 10:34 AM, Hans Dedecker wrote: > In case PROTO_CMD_SETUP cannot be handled due to an invalid state; return > -1 so the calling functions are aware the PROTO_CMD_SETUP has failed. > > Signed-off-by: Hans Dedecker > --- > proto-shell.c | 2 -- > 1 file

<    1   2   3   4   5   6   7   8   9   10   >