Re: [VOTE] New member proposal: Robimarko (Robert Marko)

On 30/01/2024 19:15, Christian Marangi (Ansuel) wrote: Robert is active in OpenWrt since 2017 and with some recent stats, he has more than 310 commits merged in OpenWrt. He also have uncounted Reviewed-by tag on various PR and merged commits and generally helps in everything related to IPQ

[PATCH] build: add $(STAGING_DIR) and $(BIN_DIR) preparation to target and package subdir compile dependencies

ols: keep stamp file in $(STAGING_DIR_HOST)") Signed-off-by: Matthias Schiffer --- package/Makefile | 2 ++ target/Makefile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/package/Makefile b/package/Makefile index 8e72d4ec726d..4663b41de4ae 100644 --- a/package/Makefile +++ b/packag

[PATCH netifd] system-linux: fix race condition in netlink socket error handing

://github.com/openwrt/openwrt/issues/13863 Signed-off-by: Matthias Schiffer --- system-linux.c | 38 +- 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a/system-linux.c b/system-linux.c index e7945e3330a8..4463a2a8282a 100644 --- a/system-linux.c

[PATCH uclient] uclient: cancel state change timeout in uclient_disconnect()

will be dangling, often resulting in a segfault when new timeouts are added or the timeout list is cleaned up in uloop_done(). Fix this by cancelling the timeout in uclient_disconnect(). Signed-off-by: Matthias Schiffer --- uclient.c | 1 + 1 file changed, 1 insertion(+) diff --git a/uclient.c b

Re: [PATCH v2] ath79: add support for Ubiquiti NanoBeam M5

On 27/03/2022 21:25, g...@aiyionpri.me wrote: From: Jan-Niklas Burfeind Ubiquiti NanoBeam M5 devices are CPE equipment for customer locations with one Ethernet port and a 5 GHz 300Mbps wireless interface. Please provide the output of dmesg after boot - I'd like to check a few things. Also

Re: [PATCH] firmware-utils: tplink-safeloader: replace BSD-2-Clause boilerplate with SPDX

On 8/4/21 2:33 PM, Rafał Miłecki wrote: From: Rafał Miłecki Signed-off-by: Rafał Miłecki Acked-by: Matthias Schiffer --- tools/firmware-utils/src/tplink-safeloader.c | 21 +--- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/tools/firmware-utils/src

Re: [PATCH opkg] libopkg: pkg_hash: prefer original packages to satisfy dependencies

On 3/13/21 3:52 AM, Daniel Golle wrote: On Sat, Mar 13, 2021 at 02:00:40AM +0100, Matthias Schiffer wrote: When one package "provides" another non-virtual package, prefer to use the original package instead of the providing package. Example: Consider packages "foo" a

[PATCH opkg] libopkg: pkg_hash: prefer original packages to satisfy dependencies

by name and use the last entry by default, so "foo" would be used to satisfy a dependency on "bar". Change the logic to prefer the actual package "bar" in this case. Signed-off-by: Matthias Schiffer --- libopkg/pkg_hash.c | 14 -- 1 file changed, 12 insertion

Re: [PATCH 1/2] mac80211: convert UniFi Outdoor+ HSR support to OF

On 1/23/21 1:58 AM, David Bauer wrote: Enable support for the Ubiquiti UniFi Outdoor+ RF filter via device-tree. The old way of using platform data is not required anymore, as it was only used on the now removed ar71xx target. Signed-off-by: David Bauer ---

Re: [PATCH v2] vxlan: allow for dynamic source ip selection

On 11/24/20 4:26 AM, Johannes Kimmel wrote: > By setting 'auto', the zero address or the empty string as source > address (option ipaddr, option ip6addr), vxlan will choose one > dynamically. This helps in setups where a wan ip or prefix changes. > > This corresponse to setting up an vxlan tunnel

Re: [PATCH] zones: fix max length of zone names

On 9/5/20 4:32 PM, David Bauer wrote: > Hi Matthias, > > On 9/5/20 4:08 PM, Matthias Schiffer wrote: >> On 9/5/20 1:11 AM, David Bauer wrote: >>> Hi Alexey, >>> >>> On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: >>>> Hi, >>>>

Re: [PATCH] zones: fix max length of zone names

On 9/5/20 1:11 AM, David Bauer wrote: > Hi Alexey, > > On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: >> Hi, >> please, see also >> https://patchwork.ozlabs.org/project/openwrt/patch/20200830211009.3359-1-dobrovolskiy.ale...@gmail.com/ > > I was not aware of this patch. Will merge yours in the

Re: tplink-safeloader support-list on CPE/WBS devices

On 8/31/20 9:37 PM, Adrian Schmutzler wrote: >>> For OpenWrt to OpenWrt upgrades (after a factory upgrade), I think you >>> are right that soft-version and support-list can be left untouched. >>> last_sysupgrade_partition could then be 'file-system', given the >>> modified partition table for

Re: tplink-safeloader support-list on CPE/WBS devices

On 8/31/20 11:18 AM, Sander Vanheule wrote: > Hi Adrian, > > On Sun, 2020-08-30 at 22:43 +0200, Adrian Schmutzler wrote: >> Hi, >> >> while increasing the kernel partition for the TP-Link CPE devices, I >> found that the partitions called "soft-version" and "support-list" >> are handled as a part

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

On 8/24/20 7:56 PM, Paul Spooren wrote: > > On 24.08.20 00:55, Jo-Philipp Wich wrote: >> Hi, >> >>> rules.mk always passes these as -I/-L to the toolchain. >>> >>> Fixes rare errors like: >>> cc1: error: staging_dir/target-aarch64_cortex-a53_musl/usr/include: No >>> such file or directory

Re: [PATCH] build: SDK/IB reproducible and faster compression

On 8/22/20 1:45 AM, Paul Spooren wrote: > > On 21.08.20 06:47, Matthias Schiffer wrote: >> Did you have a look at the zstd patches I sent a while ago? zstd is >> superior to xz in most cases - the only reason I didn't merge the patches >> yet was that all of our pha

Re: [PATCH] build: SDK/IB reproducible and faster compression

On 8/21/20 3:47 AM, Paul Spooren wrote: > As friends of reproducible builds please have a look at this patch. > > On 13.08.20 13:46, Paul Spooren wrote: >> Both IB and SDK now use the same logic for packing. >> >> This commit add reproducible multithread compression to the SDK and >> corrects the

Re: [OpenWrt-Devel] [PATCH 2/3] vxlan: remove mandatory peeraddr

On 6/8/20 4:14 PM, Johannes Kimmel wrote: > vxlan can be configured without a peer address. This is used to prepare > an interface and add peers later. > > Signed-off-by: Johannes Kimmel Acked-by: Matthias Schiffer > --- > package/network/config/vxlan/files/vxlan.sh | 12

Re: [OpenWrt-Devel] [PATCH 3/3] vxlan: add capability for multiple fdb entries

t; > diff --git a/package/network/config/vxlan/Makefile > b/package/network/config/vxlan/Makefile > index 5850c44..46970d9 100644 > --- a/package/network/config/vxlan/Makefile > +++ b/package/network/config/vxlan/Makefile > @@ -11,7 +11,7 @@ define Package/vxlan >CATEGORY:=Ne

Re: [OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

>>> I just think of ar71xx and ath79, where we have the same device but >> different targets. Of course, the name won't be exactly equal, as ath79 will >> have e.g. tplink_ prefix and ar71xx won't. >> Isn't ar71xx removed from master builds? It's neither at snapshot >>

Re: [OpenWrt-Devel] [PATCH] treewide: simplify inclusion of subtarget image files

On 6/7/20 1:11 PM, Adrian Schmutzler wrote: > Many target use a repetitive if-include scheme for their subtarget > image files, though their names are consistent with the subtarget > names. > > This patch removes these redundant conditions and just uses the > variable for the include where the

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

On 6/1/20 12:21 PM, Petr Štetiar wrote: > Matthias Schiffer [2020-05-31 11:08:47]: > > Hi, > >> For patch 4, I'd like to have an ACK from someone familiar with the buildbot >> setup. > > Disclaimer: I'm Buildbot setup noob, just helping occasionally with the >

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

On 5/29/20 9:18 PM, Matthias Schiffer wrote: > On 5/17/20 1:51 PM, Matthias Schiffer wrote: >> Comression level -19 was chosen as it provides a very good tradeoff >> between compression ratio and performance, especially in multithreaded >> operation. >> >>

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

On 5/31/20 12:06 AM, Adrian Schmutzler wrote: > Hi, > >> -Original Message- >> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] >> On Behalf Of mans0n >> Sent: Samstag, 30. Mai 2020 12:20 >> To: 'Matthias Schiffer' ; >> m...

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

On 5/30/20 12:20 PM, mans0n wrote: > Hi Adrian, Matthias, > > I was preparing my own patch for converting DEVICE_TYPE to a > device-specific variable. > https://github.com/mans0n/openwrt/commit/4d41dd963ae8d595ef38ea0a38ea08abdac1415d > > But I stumbled on some blockers so I left it behind... >

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

On 5/30/20 1:04 AM, m...@adrianschmutzler.de wrote: >> The variable is used rarely enough that we could well make this a bit more >> verbose. "TARGET_DEVICE_TYPE"? If it weren't for the busybox config change >> (which seems hacky to me at best*), we could also go with something like >>

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

On 5/29/20 10:52 PM, m...@adrianschmutzler.de wrote: >> Or we just drop the variable at all, and do >> DEFAULT_PACKAGES := DEFAULT_PACKAGES.basic DEFAULT_PACKAGES.router >> at the beginning (!) of target.mk, so targets (effectively just 3 of them) >> can just overwrite it with >>

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: rename DEVICE_TYPE to DEFAULT_TYPE

On 5/29/20 7:22 PM, Adrian Schmutzler wrote: > The prefix "DEVICE_" for Make variables is only used for per-device > variables with the only exception of DEVICE_TYPE. This is misleading > as it leads people to incorrectly assume it can be set per device like > all the other DEVICE_* variables, as

Re: [OpenWrt-Devel] [PATCH 1/3] treewide: drop DEVICE_TYPE when used as device variable

On 5/29/20 7:45 PM, m...@adrianschmutzler.de wrote: >>> Consequently, having it set anyway is misleading, so this drops all >>> cases. >> >> Well, I can tell you where it matters for devices. >> >> You'll have to look at this: >> >>

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

On 5/17/20 1:51 PM, Matthias Schiffer wrote: > Comression level -19 was chosen as it provides a very good tradeoff > between compression ratio and performance, especially in multithreaded > operation. > > Signed-off-by: Matthias Schiffer Jow, do you have any opinion on

[OpenWrt-Devel] [PATCH 0/2] musl: fix locking synchronization bug

/1263955586540089344 [4] https://git.openwrt.org/?p=openwrt/staging/neoraider.git;a=summary Matthias Schiffer (2): musl: fix locking synchronization bug musl: restore lock skipping for mostly-singlethreaded programs, and related patches ...ist-unlink-in-pthread_exit-after-all.patch | 51

[OpenWrt-Devel] [PATCH 2/2] musl: restore lock skipping for mostly-singlethreaded programs, and related patches

The remainder of the patch series proposed by upstream [2] for the locking synchronization issue [1]. [1] https://www.openwall.com/lists/musl/2020/05/22/3 [2] https://www.openwall.com/lists/musl/2020/05/22/10 Signed-off-by: Matthias Schiffer --- ...ist-unlink-in-pthread_exit-after-all.patch

[OpenWrt-Devel] [PATCH 1/2] musl: fix locking synchronization bug

/lists/musl/2020/05/22/10 Signed-off-by: Matthias Schiffer --- ...hreads_minus_1-as-relaxed-atomic-for.patch | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 toolchain/musl/patches/500-0002-don-t-use-libc.threads_minus_1-as-relaxed-atomic-for.patch diff --git

[OpenWrt-Devel] [PATCH v3] blob: make blob_parse_untrusted more permissive

Some tools like ucert use concatenations of multiple blobs. Account for this case by allowing the underlying buffer length to be greater than the blob length. Signed-off-by: Matthias Schiffer --- v2: added testcase v3: fixed typo in commit messages I forgot in v2. Ugh blob.c

[OpenWrt-Devel] [PATCH v2] blob: make blob_parse_untrusted more permissive

Some tools like ucert use concatenations of multiple blobs. Account for this case by allowing the underlying buffer length to be greater than the blog length. Signed-off-by: Matthias Schiffer --- v2: added testcase blob.c| 2 +- tests/cram/inputs/signature.ucert

Re: [OpenWrt-Devel] Uncompress image: trailing garbage ignored

On 5/4/20 10:40 AM, Rafał Miłecki wrote: > On 27.04.2020 00:48, Paul Spooren wrote: >> On Thu, 2020-04-23 at 23:29 +0300, Hannu Nyman wrote: >>> W. Michael Petullo kirjoitti 23.4.2020 klo 19.50: I have started to notice a gunzip warning when decompressing the OpenWrt images I build. This

Re: [OpenWrt-Devel] [PATCH] treewide: use "model" instead of ambiguous "boardname" in 01_leds

On 5/21/20 8:01 PM, Adrian Schmutzler wrote: > At the moment, several board.d/01_leds files use a variable for the > model part of their label. For historic reasons, this is called > "boardname", though when a vendor is present in the result of the > board_name function, it's only the model part

[OpenWrt-Devel] [PATCH v2 1/4] tools: add zstd

Signed-off-by: Matthias Schiffer --- Changes since v1: - build unconditionally to make is usable for pack/unpack of packages - explicitly disable unneeded features tools/Makefile| 2 +- tools/zstd/Makefile | 20 ++ ...re-portable

[OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

Comression level -19 was chosen as it provides a very good tradeoff between compression ratio and performance, especially in multithreaded operation. Signed-off-by: Matthias Schiffer --- target/imagebuilder/Makefile | 8 target/sdk/Makefile | 8 2 files changed, 8

[OpenWrt-Devel] [PATCH v2 2/4] build: add zstd support to pack/unpack functions

Signed-off-by: Matthias Schiffer --- include/download.mk | 1 + include/unpack.mk | 4 2 files changed, 5 insertions(+) diff --git a/include/download.mk b/include/download.mk index 14d68bf8f5e9..9c8ada052b04 100644 --- a/include/download.mk +++ b/include/download.mk @@ -50,6 +50,7

[OpenWrt-Devel] [PATCH v2 3/4] build: compress kernel debuginfo using zstd

ent) does not affect reproducibility with zstd. Signed-off-by: Matthias Schiffer --- include/kernel-build.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/kernel-build.mk b/include/kernel-build.mk index c371e78ab9b0..32c91a5b8359 100644 --- a/include/kernel-build.mk ++

[OpenWrt-Devel] [PATCH ucert 13/13] Do not print line number in debug messages

The line number does not add any significant information, and it makes the unit tests which check for these debug messages very fragile. Signed-off-by: Matthias Schiffer --- tests/cram/test_ucert.t | 4 ++-- ucert.c | 8 2 files changed, 6 insertions(+), 6 deletions

[OpenWrt-Devel] [PATCH ucert 10/13] usign-exec: return code fixes

- WEXITSTATUS() should only be called when WIFEXITED() returns true - Fix double WEXITSTATUS() in usign_f() Signed-off-by: Matthias Schiffer --- usign-exec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/usign-exec.c b/usign-exec.c index 0dde81ed647b..241d63077365

[OpenWrt-Devel] [PATCH ucert 11/13] usign-exec: improve usign -F output handling

/8ead1fd6a61117b54b4efd5111fe0d19e4eef9c5.1589642591.git.mschif...@universe-factory.net/ Signed-off-by: Matthias Schiffer --- usign-exec.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/usign-exec.c b/usign-exec.c index 241d63077365..482e51057124 100644 --- a/usign-exec.c +++ b/usign-exec.c

[OpenWrt-Devel] [PATCH ucert 12/13] Fix length checks in cert_load()

. Note that this issue currently does not pose a security threat, as an over-restrictive check in blob_parse_untrusted() broke parsing of buffers with multiple blobs completely. Signed-off-by: Matthias Schiffer --- ucert.c | 34 +++--- 1 file changed, 19 insertions

[OpenWrt-Devel] [PATCH ucert 06/13] usign-exec: do not close stdin and stderr before exec

FDs 0, 1 and 2 should always be available. This also allows the exec error message in the forked process to be displayed. Signed-off-by: Matthias Schiffer --- usign-exec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/usign-exec.c b/usign-exec.c index 22fdc14e7ebb

[OpenWrt-Devel] [PATCH ucert 00/13] ucert fixes and cleanup

/project/openwrt/patch/8ead1fd6a61117b54b4efd5111fe0d19e4eef9c5.1589642591.git.mschif...@universe-factory.net/ Matthias Schiffer (13): stdout/stderr improvements Fix return code of write_file() Introduce read_file() helper, improve error reporting usign-exec: simplify usign execv calls

[OpenWrt-Devel] [PATCH ucert 09/13] usign-exec: close writing end of pipe early in parent process

exited. Signed-off-by: Matthias Schiffer --- usign-exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usign-exec.c b/usign-exec.c index c9aecf99f9c0..0dde81ed647b 100644 --- a/usign-exec.c +++ b/usign-exec.c @@ -136,6 +136,8 @@ static int usign_f(char fingerprint[17], const

[OpenWrt-Devel] [PATCH ucert 02/13] Fix return code of write_file()

write_file() returns 1/true on success; it should return 0/false when opening the file fails. To make it more obvious that is function returns true and not 0 on success, also change its return type to bool. Signed-off-by: Matthias Schiffer --- ucert.c | 4 ++-- 1 file changed, 2 insertions

[OpenWrt-Devel] [PATCH ucert 08/13] usign-exec: remove redundant return statements

All switch() cases were already returning value or exiting. Instead, move the default case out of the switch to reduce indentation (only relevant for usign_f()). Signed-off-by: Matthias Schiffer --- usign-exec.c | 43 +-- 1 file changed, 17 insertions

[OpenWrt-Devel] [PATCH ucert 07/13] usign-exec: change usign_f_* fingerprint argument to char[17]

This makes it more obvious that a buffer with space for 17 characters is expected to be passed. The code still works the same (a char[17] is equivalent to char* as an argument). Signed-off-by: Matthias Schiffer --- usign-exec.c | 8 usign.h | 6 +++--- 2 files changed, 7

[OpenWrt-Devel] [PATCH ucert 04/13] usign-exec: simplify usign execv calls

When the executable to exec is passed as an absolute path, execv() and execvp() are equivalent, so there it no need to make the code hard to read with #ifdefs. Signed-off-by: Matthias Schiffer --- usign-exec.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff

[OpenWrt-Devel] [PATCH ucert 05/13] usign-exec: fix exec error handling

When execvp fails in the forked process, we must exit. Also add an error message. Signed-off-by: Matthias Schiffer --- ucert.c | 4 ++-- usign-exec.c | 40 usign.h | 8 +--- 3 files changed, 27 insertions(+), 25 deletions(-) diff --git

[OpenWrt-Devel] [PATCH ucert 01/13] stdout/stderr improvements

- Print error messages to stderr - fprintf(stdout, ...) is just printf(...) Signed-off-by: Matthias Schiffer --- ucert.c | 6 +++--- usign-exec.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ucert.c b/ucert.c index d822199eb7f8..2ea939947d72 100644 --- a/ucert.c

[OpenWrt-Devel] [PATCH ucert 03/13] Introduce read_file() helper, improve error reporting

This helper simplifies handling, ensures that there are no resource leaks, and checks for EOF more robustly. Also introduce error reporting at all call sites to give the user some feedback when something went wrong. Signed-off-by: Matthias Schiffer --- ucert.c | 97

[OpenWrt-Devel] [PATCH libubox] blob: make blob_parse_untrusted more permissive

Some tools like ucert use concatenations of multiple blobs. Account for this case by allowing the underlying buffer length to be greater than the blog length. Signed-off-by: Matthias Schiffer --- blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blob.c b/blob.c index

[OpenWrt-Devel] [PATCH usign] Always pad fingerprints to 16 characters

Fingerprints were not padded with zeros. This led to an ucert failure when the first byte of the fingerprint is 00, as it expects the fingerprint to have a constant length (and this expectation seems reasonable to me). Signed-off-by: Matthias Schiffer --- This issue was noticed as a spurious

Re: [OpenWrt-Devel] [PATCH 2/2] build: compress kernel debuginfo using zstd

On 5/16/20 3:38 AM, Paul Spooren wrote: > Could we use that for the SDK/ImageBuilder as well? > > Best, > Paul Sure, have some benchmark results with the current ath79 snapshot IB: * openwrt-imagebuilder-ath79-generic.Linux-x86_64.tar: 515M * xz -7e (current implementation): 96M, ~100s * zstd

[OpenWrt-Devel] [PATCH 1/2] tools: add zstd

Signed-off-by: Matthias Schiffer --- tools/zstd/Makefile | 20 ++ ...re-portable-header-prefix-usage-1987.patch | 61 +++ 2 files changed, 81 insertions(+) create mode 100644 tools/zstd/Makefile create mode 100644 tools/zstd/patches/0001-build

[OpenWrt-Devel] [PATCH 0/2] Switch to zstd for kernel debuginfo compression

/pull/1971 Matthias Schiffer (2): tools: add zstd build: compress kernel debuginfo using zstd include/kernel-build.mk | 2 +- tools/Makefile| 1 + tools/zstd/Makefile | 20 ++ ...re-portable-header-prefix

[OpenWrt-Devel] [PATCH 2/2] build: compress kernel debuginfo using zstd

ent) does not affect reproducibility with zstd. Signed-off-by: Matthias Schiffer --- include/kernel-build.mk | 2 +- tools/Makefile | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/kernel-build.mk b/include/kernel-build.mk index c371e78ab9b0..32c91a5b8359 100

Re: [OpenWrt-Devel] [PATCH] ramips: fix port setup for Ubiquiti EdgeRouter X (and SFP)

On 12/16/19 1:31 PM, Adrian Schmutzler wrote: > The EdgeRouter only has LAN ports labelled eth0 to eth4 (plus > unsupported eth5 for SFP version). Thus, there is no reason to set > up one of them as WAN. > > This patch sets all ports to "lan" and removes the unused wan_mac. > > Actually, stock

Re: [OpenWrt-Devel] ath10k memory leak on 19.07 branch and mikrotik RB952Ui-5ac2nD?

On 11/29/19 3:40 AM, Joe Ayers wrote: > Attempting to use the hAP ac lite model RB952Ui-5ac2nD with the 5GHz > radio0 802.11ac seems to be unstable and consume available memory. > This is only enabling radio0 with no other changes and bringing wifi > up/down to reproduce. Am I doing something

Re: [OpenWrt-Devel] [PATCH] base-files: Really check path in get_mac_binary

On 7/4/19 11:28 PM, Adrian Schmutzler wrote: > Currently, path argument is only checked for being not empty. > > This changes behavior to actually check whether path exists. > > Signed-off-by: Adrian Schmutzler This was applied already, but it seems the logic is reversed now? Regards,

Re: [OpenWrt-Devel] Fix TX power handling

This is just the factor of 1/2/3/4 (approximated) in dB: 10^0.0 = 1 10^0.3 ≈ 2 10^0.5 ≈ 3 10^0.6 ≈ 4 I've seen these numbers being used in WLAN drivers to account for the antenna array gain, so at least this part of the TX power computation might already be working as expected. Kind Regards,

Re: [OpenWrt-Devel] [PATCH iwinfo 1/2] Add support for regulatory rules

On 4/24/19 9:03 PM, Matthias Schiffer wrote: > The new regrulelist operation returns the list of regulatory rules, similar > to the `iw reg get` command. The passed ifname must either refer to a PHY, > or be NULL to retrieve the rules for the global regdomain. > > The new operation

[OpenWrt-Devel] [PATCH iwinfo 2/2] Add Lua support for regrulelist

"end_freq_khz": 525, "max_eirp_mbm": 2000, "start_freq_khz": 515, "max_bw_khz": 8 }, ... ] We only add flags that are set to the "flags" field to avoid bloating the output with a large number of entries for

[OpenWrt-Devel] [PATCH iwinfo 1/2] Add support for regulatory rules

The new regrulelist operation returns the list of regulatory rules, similar to the `iw reg get` command. The passed ifname must either refer to a PHY, or be NULL to retrieve the rules for the global regdomain. The new operation is implemented for nl80211 only. Signed-off-by: Matthias Schiffer

Re: [OpenWrt-Devel] LEDE > OpenWrt > TP-Link TL-WDR4900 1.0

os. > > Regards > Falko There is no 18.06.2 release yet, the latest stable release is 18.06.1. The next release will contain the fix. Matthias > > > > Am 02.10.2018 um 21:13 schrieb Matthias Schiffer: >> On 10/2/18 12:01 AM, Stefan Lippers-Hollmann wrote: >>> Hi

Re: [OpenWrt-Devel] LEDE > OpenWrt > TP-Link TL-WDR4900 1.0

On 10/2/18 12:01 AM, Stefan Lippers-Hollmann wrote: > Hi > > On 2018-10-01, blu.italia--- via openwrt-devel wrote: >> One Question: >> Is there a way to delete the old radios 0 and 1? > > Just remove them from /etc/config/wireless, using any text editor > (e.g. vi), this usually is a result of

Re: [OpenWrt-Devel] [PATCH 2/2] scripts/package-metadata.pl: prefer $vdep with the same name as $depend

On 9/6/18 5:04 AM, Yousong Zhou wrote: > On Thu, 6 Sep 2018 at 11:00, Yousong Zhou wrote: >> >> On Thu, 6 Sep 2018 at 04:15, Matthias Schiffer >> wrote: >>> >>> On 9/5/18 5:40 PM, Yousong Zhou wrote: >>>> The need arises when userspace package

Re: [OpenWrt-Devel] [PATCH 2/2] scripts/package-metadata.pl: prefer $vdep with the same name as $depend

On 9/5/18 5:40 PM, Yousong Zhou wrote: > The need arises when userspace package "openvswitch" selects > "kmod-openvswitch" which will be provided by both "kmod-openvswitch" and > "kmod-openvswitch-intree". In this case, we want it to prefer the > package with the same name as with virtual package

Re: [OpenWrt-Devel] ar71xx: add support for UniFi-AC-Mesh-Pro

On 07/07/2018 10:34 PM, Christoph Krapp wrote: > Hi, > > i'm writing to the mailing list because mkresin closed my github pr[1] > and pointed me here. > The PR adds model detection for Ubiquity UniFi-AC-Mesh-Pro to the > ar71xx target. The source of inspiration was the commit that added >

Re: [OpenWrt-Devel] [PATCH 1/4] scripts/feeds: add src-dummy method

On 07/11/2018 10:59 AM, Rafał Miłecki wrote: > On Tue, 10 Jul 2018 at 00:31, Matthias Schiffer > wrote: >> The src-dummy method does not actually obtain any feed, but it can be used >> to insert addtional entries into the opkg distfeeds.conf. > > Should that be

[OpenWrt-Devel] [PATCH 4/4] include/feeds.mk: rework generation of opkg distfeeds.conf

Allow enabling/commenting/disabling each feed individually by using a tristate config symbol. Signed-off-by: Matthias Schiffer --- include/feeds.mk | 11 +-- package/base-files/Makefile| 2 -- package/base-files/image-config.in | 14 -- scripts

[OpenWrt-Devel] [PATCH 0/4] Overhaul distfeeds.conf generation

/neoraider.git;a=summary Regards, Matthias Matthias Schiffer (4): scripts/feeds: add src-dummy method include/feeds.mk: always add available feeds to PACKAGE_SUBDIRS base-files: fix feed list in PKG_CONFIG_DEPENDS include/feeds.mk: rework generation of opkg distfeeds.conf include/feeds.mk

[OpenWrt-Devel] [PATCH 3/4] base-files: fix feed list in PKG_CONFIG_DEPENDS

FEEDS_ENABLED and FEEDS_DISABLED are derived from FEEDS_AVAILABLE, not FEEDS_INSTALLED. Signed-off-by: Matthias Schiffer --- package/base-files/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index

[OpenWrt-Devel] [PATCH 1/4] scripts/feeds: add src-dummy method

The src-dummy method does not actually obtain any feed, but it can be used to insert addtional entries into the opkg distfeeds.conf. Signed-off-by: Matthias Schiffer --- scripts/feeds | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/feeds b/scripts/feeds index

[OpenWrt-Devel] [PATCH 2/4] include/feeds.mk: always add available feeds to PACKAGE_SUBDIRS

(and that will consequently be built) not to be found during rootfs creation, breaking the build. All feeds that packages are emitted to should simply always be added to PACKAGE_SUBDIRS instead; the CONFIG_FEED_... only configure the generated distfeeds.conf like this. Signed-off-by: Matthias Schiffer

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] Add procd triggers only for interfaces that dnsmasq is interested in.

On 05/08/2018 12:37 AM, hux wrote: > Signed-off-by: hux > --- > Right now interface.update events are sent out by netifd upon interface > state, route, address (lifetime), prefix lifetime changes. Dnsmasq is only > interested in interface state changes and currently adds an interface trigger >

Re: [OpenWrt-Devel] sysupgrade broken by 30f61a34b4cf ("base-files: always use staged sysupgrade")

On 06/09/2018 02:54 PM, Rafał Miłecki wrote: > brcm47xx and bcm53xx targets support multiple firmware formats, most > of them are TRX files with vendor-specific header prepended. > > They are handled in [0] > target/linux/bcm53xx/base-files/lib/upgrade/platform.sh > by the platform_do_upgrade()

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] base-files: sysupgrade depends on sha256sum now

On 03/11/2018 02:33 PM, Bjørn Mork wrote: > commit 6ed389da85a9 ("base-files: sysupgrade: do not rely on opkg > to list changed conffile") adds a call to sha256sum. Make sure it > exists. > > Signed-off-by: Bjørn Mork > --- We generally do no add dependencies for busybox applets

Re: [OpenWrt-Devel] [LEDE-DEV] 18.03/4 -> GCC 5 or 7

On 03/09/2018 01:56 PM, Matthias Schiffer wrote: > On 03/07/2018 06:49 PM, Lucian Cristian wrote: >> testing r6395-6c194078db on a ramips Ralink RT5350 with 4.14 and GCC 7.3 >> gives this error in luci >> >> daemon.err uhttpd[873]: /usr/bin/lua: /usr/lib/lua/luci/debu

Re: [OpenWrt-Devel] [LEDE-DEV] 18.03/4 -> GCC 5 or 7

On 03/07/2018 06:49 PM, Lucian Cristian wrote: > testing r6395-6c194078db on a ramips Ralink RT5350 with 4.14 and GCC 7.3 > gives this error in luci > > daemon.err uhttpd[873]: /usr/bin/lua: /usr/lib/lua/luci/debug.lua:6: > attempt to call a number value > daemon.err uhttpd[873]: stack traceback:

[OpenWrt-Devel] [PATCH] ar71xx: disable devicetree support

While we'd like to convert ar71xx to DT-based configuration eventually, we aren't quite there yet, and shipping half-baked DT support that is not used at all wastes precious space. Saves ~120KB before LZMA, ~33KB after LZMA. Run-tested on TP-Link CPE510 and TL-WR841 v7. Signed-off-by: Matthias

[OpenWrt-Devel] [PATCH 02/15] metadata: make srcpackage extensible

Turn the srcpackage values into hashes to allow storing more information than just binary package names. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/feeds | 2 +- scripts/metadata.pm | 6 -- scripts/package-metadata.pl | 2 +- 3

[OpenWrt-Devel] [PATCH 11/15] metadata: handle target build depends together with host build depends

or to binary packages afterwards. This does lead to PKG_BUILD_DEPENDS entries referring to binary package names not working anymore, which requires some fixes in the package repositories. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/package-metadata.p

[OpenWrt-Devel] [PATCH 09/15] build: remove package preconfig feature

This feature has been unused for years, and its scope is too limited to be actually useful. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- include/package-dumpinfo.mk | 16 +--- package/Makefile| 3 --- scripts/metadata.pm

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

On 01/08/2018 03:52 PM, Matthias Schiffer wrote: > When attempting to fix FS#837, I decided to treat our metadata generator to > a greater refactoring, which resulted in this patchset. FS#837 is fixed in > patch 13. > > I also removed two seemingly obsolete features, "pre

[OpenWrt-Devel] [PATCH 12/15] metadata: simplify generation of build depends from runtime depends

packages. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/package-metadata.pl | 112 1 file changed, 41 insertions(+), 71 deletions(-) diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl index e492

[OpenWrt-Devel] [PATCH 15/15] include/package-dumpinfo.mk: don't duplicate source package information for every binary package

Eventually the BUILDONLY package flag could be replaced by simply creating a package Makefile without any BuildPackage calls. This will fail for now, as BuildPackage also causes the Makefile's compile target etc. to do something useful at all. Signed-off-by: Matthias Schiffer <mschif...@unive

[OpenWrt-Devel] [PATCH 10/15] treewide: fix build depends to refer to source package names

Build depends must refer to source packages rather than binary package names. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- include/autotools.mk | 4 ++-- include/nls.mk | 2 +- package/network/config/ltq-ad

[OpenWrt-Devel] [PATCH 14/15] build: remove obsolete "package feature" feature

Package "features" seem to be unused for some time. In any case, custom Config.in snippets and package PROVIDES are a much more flexible way to express similar options. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- include/package-

[OpenWrt-Devel] [PATCH 08/15] metadata: remove redundant fields from package hash

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/metadata.pm | 3 --- scripts/package-metadata.pl | 8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/scripts/metadata.pm b/scripts/metadata.pm index e636a45a33..50f91407d6

[OpenWrt-Devel] [PATCH 13/15] metadata: always resolve dependencies through provides list

Instead of adding virtual packages to the normal package list, keep a separate list for provides, make each package provide itself, and resolve all dependencies through this list. This allows to use PROVIDES to replace existing packages. Fixes FS#837. Signed-off-by: Matthias Schiffer <msc

[OpenWrt-Devel] [PATCH 07/15] metadata: replace %subdir hash with a path field in source packages

Every single reference to subdir was concatenated with the source package name, so it makes sense to store the concatenated value instead. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/metadata.pm | 12 +++- scripts/package-metadata.p

[OpenWrt-Devel] [PATCH 06/15] metadata: change pkg->{src} field to hold a reference

We often want to access fields of a source packages through pkg->{src}. Allow accessing them directly instead of resolving the source hash through srcpackages. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/feeds | 4 ++-- scripts/me

[OpenWrt-Devel] [PATCH 05/15] metadata: interate over source packages when generating Makefile

of the lexicographically first). Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/metadata.pm | 1 + scripts/package-metadata.pl | 61 ++--- 2 files changed, 36 insertions(+), 26 deletions(-) diff --git a/scripts/metadat

[OpenWrt-Devel] [PATCH 04/15] metadata: move 'builddepends' from binary to source packages

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/feeds | 20 +++- scripts/metadata.pm | 6 +++--- scripts/package-metadata.pl | 16 +++- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/scripts/f

[OpenWrt-Devel] [PATCH 03/15] metadata: move 'buildtypes' from binary to source packages

Build types are a property of source rather than binary packages. This is a preparation for followup cleanup. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/metadata.pm | 4 ++-- scripts/package-metadata.pl | 13 +++-- 2 files changed, 9 inse

  1   2   3   4   >