Re: [PATCH] base-files: make os-release symbolic link absolute

2021-09-10 Thread Paul Spooren
On 9/9/21 19:53, Florian Eckert wrote: * resolv.conf -> /tmp/resolv.conf * /tmp/TZmtab -> /proc/mounts For consistency, this should also apply to `/usr/lib/os-release`. Is there any other reason than consistency to change this? Yes, I have to elaborate on that. I have a small script that

[PATCH] base-files: reduce `mkdir` and `sed` calls

2021-09-08 Thread Paul Spooren
with partly the same files. Signed-off-by: Paul Spooren --- package/base-files/Makefile | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index 58ad08c63a..af5c0e6b00 100644 --- a/package

Re: [PATCH] base-files: make os-release symbolic link absolute

2021-09-08 Thread Paul Spooren
On 9/8/21 02:50, Florian Eckert wrote: The file `/etc/os-release` is currently a relative link to `../usr/lib/os-release`. The follwing links on my `/etc` are also absolute: * localtime -> /tmp/localtime * resolv.conf -> /tmp/resolv.conf * /tmp/TZmtab -> /proc/mounts For consistency, this

Re: [PATCH v2] x86: switch to 5.10 kernel

2021-09-07 Thread Paul Spooren
On 9/7/21 11:39, Paul Spooren wrote: Seems to be working fine in Docker containers. Signed-off-by: Paul Spooren --- Of course I mean QEMU not Docker (which uses the host Kernel) v2: Remove redundant TESTING_PATCHVER target/linux/x86/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v2] x86: switch to 5.10 kernel

2021-09-07 Thread Paul Spooren
Seems to be working fine in Docker containers. Signed-off-by: Paul Spooren --- v2: Remove redundant TESTING_PATCHVER target/linux/x86/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/linux/x86/Makefile b/target/linux/x86/Makefile index 0ab322d8bc

Re: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Paul Spooren
On 9/7/21 11:31, Rui Salvaterra wrote: Hi, Daniel, On Tue, 7 Sept 2021 at 22:09, Daniel Golle wrote: I'd remove the KERNEL_TESTING_PATCHVER line then until we add 5.14 or whatever it's going to be. Sure, I didn't know what the usual procedure was, so I just mimicked aparcar. ;) V2 coming

[PATCH] x86: switch to 5.10 kernel

2021-09-07 Thread Paul Spooren
Seems to be working fine in Docker containers. Signed-off-by: Paul Spooren --- target/linux/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/x86/Makefile b/target/linux/x86/Makefile index 0ab322d8bc..14cfba777c 100644 --- a/target/linux/x86/Makefile

[PATCH] build: Config-images: build ISO, VMDK and VDI for x86

2021-09-03 Thread Paul Spooren
These images are of interested for some cloud/VM people, build them by default when running the buildbot. Signed-off-by: Paul Spooren --- config/Config-images.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/Config-images.in b/config/Config-images.in index 92720fb84d..ea50d7d399

[PATCH buildbot] Bump to latest Buildbot release 3.3.0

2021-09-03 Thread Paul Spooren
See changelog: https://github.com/buildbot/buildbot/releases/tag/v3.3.0 Signed-off-by: Paul Spooren --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 07a0407..5b6f6eb 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml

[PATCH buildbot 2/2] docker: install `mkisofs` to worker container

2021-09-03 Thread Paul Spooren
x86 targets allow the creation of ISO images, however this is not possible because the `mkisofs` is missing. Install it. Signed-off-by: Paul Spooren --- docker/buildworker/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/docker/buildworker/Dockerfile b/docker/buildworker

[PATCH buildbot 1/2] docker: sort installed packages alphabetically

2021-09-03 Thread Paul Spooren
Signed-off-by: Paul Spooren --- docker/buildmaster/Dockerfile | 2 +- docker/buildworker/Dockerfile | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docker/buildmaster/Dockerfile b/docker/buildmaster/Dockerfile index 28dc9ed..b2134ce 100644 --- a/docker

Re: [PATCH] dropbear: add config options for agent-forwarding support

2021-07-25 Thread Paul Spooren
On 7/24/21 8:08 PM, Hauke Mehrtens wrote: On 7/16/21 12:44 AM, Sven Roederer wrote: * SSH agent forwarding might cause security issues, locally and on the jump    machine (https://defn.io/2019/04/12/ssh-forwarding/). So allow to    completely disabling it. * separate options for client and

Re: Enabling Wi-Fi on First boot

2021-07-08 Thread Paul Spooren
I'd argue that it merely completes the OEM options. If that isn't a valid argument we should drop all of VERSIONOPTs since it can be all modified via /files. -- Jul 7, 2021 21:39:59 Petr Štetiar : Paul Spooren [2021-07-07 15:10:59]: Hi, Feel free to check this out, it's not ready yet

Re: Enabling Wi-Fi on First boot

2021-07-07 Thread Paul Spooren
On 7/5/21 8:45 PM, Enrico Mioso wrote: Hello all!! I would like to know your opinion on a topic I know has already been discussed: enabling Wi-Fi on first boot. I would very very much like to see this feature present in OpenWRt: because I find myself in a scenario where plugging an Ethernet

Re: Enabling Wi-Fi on First boot

2021-07-06 Thread Paul Spooren
On 7/5/21 8:45 PM, Enrico Mioso wrote: Hello all!! I would like to know your opinion on a topic I know has already been discussed: enabling Wi-Fi on first boot. I would very very much like to see this feature present in OpenWRt: because I find myself in a scenario where plugging an Ethernet

Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-01 Thread Paul Spooren
On 7/1/21 9:51 AM, Petr Štetiar wrote: Paul Spooren [2021-07-01 07:45:02]: +++ b/package/libs/libjson-c/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=json-c PKG_VERSION:=0.12.1 -PKG_RELEASE:=3.1 +PKG_RELEASE:=3.2 I've never seen a non integer release

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Paul Spooren
On 7/1/21 9:50 AM, Arjun AK wrote: Signed-off-by: Arjun AK --- Could you please add a brief commit message describing why this package isn't needed in core? I'm all for moving it, don't get me wrong, we just try to have commit messages everywhere to keep context over time.

Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-01 Thread Paul Spooren
On 7/1/21 3:09 AM, Petr Štetiar wrote: From: Hannu Nyman Mark uci, ubus, libubox, lua, libnl-tiny and libjson-c as nonshared packages. This helps to keep coherent dependencies if these ABI versioned packages are later updated. Before this commit it is possible to get missing dependencies in

Re: [PATCH] x86: include kmod-fs-vfat by default in generic images

2021-06-29 Thread Paul Spooren
On 6/29/21 3:22 PM, Daniel Golle wrote: As x86/64 and x86/generic may be using UEFI, mounting the FAT-32 /boot is necessary in order not to loose configuration files accross sysupgrades. Include kmod-fs-vfat by default to make sure /boot can always be mounted. Signed-off-by: Daniel Golle ---

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Paul Spooren
On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to, not? this should be explained in the wiki, Agree, APU boards etc also need some extra

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Paul Spooren
On 6/28/21 8:53 AM, Piotr Dymacz wrote: Hi John, On 28.06.2021 20:32, John Crispin wrote: On 28.06.21 19:26, Piotr Dymacz wrote: I might be wrong here but I think we don't include packages from external feeds inside 'DEVICE_PACKAGES' (not sure/don't remember why). I am in favour of

Re: [PATCH v2] zram-swap: robustify mkswap/swapon/swapoff invocation

2021-06-24 Thread Paul Spooren
Hi, On 6/21/21 9:54 PM, Rui Salvaterra wrote: Instead of assuming /sbin contains the correct BusyBox symlinks, directly invoke the busybox executable. The required utilities are guaranteed to be present, since the zram-swap package selects them. Additionally, don't assume busybox resides in

Re: [PATCH] base-files: fix zoneinfo support

2021-06-23 Thread Paul Spooren
On 6/23/21 1:14 PM, Rosen Penev wrote: On Wed, Jun 23, 2021 at 3:40 PM Paul Spooren wrote: Hi, if I'm not mistaken this patch doesn't quite do the trick: You removed the removal of /tmp/TZ which seem to be preferred by `hwclock`, meaning even if $zonename (aka $zname) is found, /tmp/TZ

Re: [PATCH] base-files: fix zoneinfo support

2021-06-23 Thread Paul Spooren
Hi, if I'm not mistaken this patch doesn't quite do the trick: You removed the removal of /tmp/TZ which seem to be preferred by `hwclock`, meaning even if $zonename (aka $zname) is found, /tmp/TZ is still there. As a result both /tmp/TZ and /tmp/localtime exists both, allowing the user no

[PATCH] dante: move to packages.git

2021-06-23 Thread Paul Spooren
Rather than maintaining it in core, move it to packages.git where it's maintained by a community. CC: Jo-Philipp Wich Signed-off-by: Paul Spooren --- A new maintainer stepped up and like to take over the work over at packages.git, see https://github.com/openwrt/packages/pull/15939 package

Re: [PATCH 1/3] base-files: failsafe: Fix IP configuration

2021-06-20 Thread Paul Spooren
Not sure but is this PR related? "base-files: bring up vlan interface too #2734" https://github.com/openwrt/openwrt/pull/2734 On 6/19/21 8:36 AM, Hauke Mehrtens wrote: Adapt the preinit_config_board() to the board.json network changes. It now looks for the device and the ports variables to

[PATCH 3/3] squashfskit4: Remove obsolete package

2021-06-20 Thread Paul Spooren
With the introduction of `squashfs-tools-ng` the `squashfskit4` fork is no longer required. Signed-off-by: Paul Spooren --- tools/squashfskit4/Makefile | 41 -- .../patches/0001-fix-version.sh.patch | 21 - ...002-fix-build-failure-against-gcc

[PATCH 2/3] build,squashfs: switch to squashfs-tools-ng

2021-06-20 Thread Paul Spooren
Let the newly added `squasfs-tools-ng` handle the squashfs file creation. Signed-off-by: Paul Spooren --- include/image.mk | 23 --- tools/Makefile | 6 +++--- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/include/image.mk b/include/image.mk index

[PATCH 0/3] [RFT] Replace squashfskit with squashfs-tools-ng

2021-06-20 Thread Paul Spooren
/squashfskit/squashfskit [3]: https://github.com/AgentD/squashfs-tools-ng Paul Spooren (3): squashfs-tools-ng: add package build,squashfs: switch to squashfs-tools-ng squashfskit4: Remove obsolete package include/image.mk | 23 +++--- tools/Makefile

[PATCH 1/3] squashfs-tools-ng: add package

2021-06-20 Thread Paul Spooren
The `squashfs-tools-ng` is a reimplementation of `squashfs-tools` of which a fork called `squashfskit` is currently used withn OpenWrt. Signed-off-by: Paul Spooren --- tools/squashfs-tools-ng/Makefile | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 tools

Re: [PATCH] treewide: call check-size before append-metadata

2021-06-20 Thread Paul Spooren
On 6/20/21 6:56 AM, Adrian Schmutzler wrote: sysupgrade metadata is not flashed to the device, so check-size should be called _before_ adding metadata to the image. While at it, do some obvious wrapping improvements. Signed-off-by: Adrian Schmutzler --- Acked-by: Paul Spooren I'm

[PATCH] build: create profiles.json per default

2021-06-16 Thread Paul Spooren
of the ImageBuilder which always create the file and also increases the files visibility for downstream projects. Signed-off-by: Paul Spooren --- config/Config-build.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/Config-build.in b/config/Config-build.in index 342859b7c0..f0e1aaa695

Re: Should ubus be marked as target-specific "nonshared"? (broken 21.02 rc2 imagebuilder)

2021-06-05 Thread Paul Spooren
Sounds good to me. Do you mind investigate what other packages are affected ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH 21.02 v2] build/json: fix IMAGE_PREFIX and DEVICE_PACKAGES

2021-06-02 Thread Paul Spooren
These two variables were missing in the definition of DEFAULT_DEVICE_VARS which caused them to contain wrong values, messing up the resulting JSON files. This patch adds the two variables IMAGE_PREFIX and DEVICE_PACKAGES to DEFAULT_DEVICE_VARS. Suggested-by: Baptiste Jonglez Signed-off-by: Paul

[PATCH] build/json: fix DEVICE_PACKAGES

2021-06-02 Thread Paul Spooren
The variable was missing in the definition of DEFAULT_DEVICE_VARS which caused it to contain wrong values, messing up the resulting JSON files. This patch adds the variable DEVICE_PACKAGES to DEFAULT_DEVICE_VARS. Suggested-by: Baptiste Jonglez Signed-off-by: Paul Spooren --- include/image.mk

[PATCH 21.02] build/json: fix IMAGE_PREFIX and DEFAULT_PACKAGES

2021-06-02 Thread Paul Spooren
These two variables where missing in the definition of DEFAULT_DEVICE_VARS which caused them to contain wrong values, messing up the resuling JSON files. This patch add the two variables IMAGE_PREFIX and DEFAULT_PACKAGES to DEFAULT_DEVICE_VARS. Suggested-by: Baptiste Jonglez Signed-off-by: Paul

[PATCH] busybox: mention SRV support in help message

2021-05-20 Thread Paul Spooren
The SRV was added some time ago and should be mentioned in the short help message to avoid confusion about missing features. Signed-off-by: Paul Spooren --- Already sent to upstream: http://lists.busybox.net/pipermail/busybox/2021-May/088849.html .../540-nslookup-mention-QUERY_TYPE-SRV.patch

Re: Flagship AX routers

2021-05-18 Thread Paul Spooren
Hi, On 5/18/21 11:52 PM, Philip Prindeville wrote: Hi all, I noticed that there are several AX routers from TP-Link, Netgear, D-Link, etc. and some of them have even had OpenWRT ported to them. Which of these various platforms has the most CPU/RAM/FLASH? A few are discussed, but I'm not

Re: [RFC] OpenWrt within a Docker container

2021-05-18 Thread Paul Spooren
2021 15:39, Paul Spooren wrote: Hello, after some back and forth I'd like to request some more opinions on what kind of Docker containers to offer containing the OpenWrt rootfs. This is not about the SDK or ImageBuilder Docker containers. tl;dr: Should we ship `slim` containers only, running a Ope

[PATCH] busybox: use $(AUTORELEASE) and SPDX

2021-05-18 Thread Paul Spooren
use AUTORELEASE since BusyBox is often updaten and PKG_RELEASE is not consistently bumped. Also use SPDX license headers to be machine readable and bump the copyright year to 2021. Signed-off-by: Paul Spooren --- I'd like to see this backported as well. package/utils/busybox/Makefile | 9

Re: [PATCH 21.02] openwrt-keyring: Only copy sign key for 21.02

2021-05-17 Thread Paul Spooren
May 17, 2021 21:53:01 Hauke Mehrtens : On 5/17/21 8:10 PM, Paul Spooren wrote: On 5/16/21 3:57 PM, Hauke Mehrtens wrote: On 5/16/21 3:26 PM, Hauke Mehrtens wrote: Instead of adding all public signature keys from the openwrt-keyring repository only add the key which is used to sign

[RFC] OpenWrt within a Docker container

2021-05-17 Thread Paul Spooren
Hello, after some back and forth I'd like to request some more opinions on what kind of Docker containers to offer containing the OpenWrt rootfs. This is not about the SDK or ImageBuilder Docker containers. tl;dr: Should we ship `slim` containers only, running a OpenWrt shell (ash) and

Re: [PATCH 1/2] ethtool: update to version 5.12

2021-05-17 Thread Paul Spooren
On 5/16/21 6:01 PM, Robert Marko wrote: Update ethtool to newly released 5.12 version. Signed-off-by: Robert Marko --- Could this be moved to packages.git? package/network/utils/ethtool/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 19.07 2/2] openwrt-keyring: Only copy sign key for 19.07 and 21.02

2021-05-17 Thread Paul Spooren
this would not affect users of 19.07 release builds. Signed-off-by: Hauke Mehrtens --- Acked-by: Paul Spooren package/system/openwrt-keyring/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/package/system/openwrt-keyring/Makefile b/package/system/openwrt-keyring

Re: [PATCH] openwrt-keyring: Only copy sign key for snapshots

2021-05-14 Thread Paul Spooren
Hi, On 5/13/21 1:32 AM, Hauke Mehrtens wrote: Instead of adding all public signature keys from the openwrt-keyring repository only add the key which is used to sign the master feeds. If one of the other keys would be compromised this would not affect users of master snapshot builds.

Re: [PATCH ansible] inventories: prod: 21.02: include TLS support

2021-05-14 Thread Paul Spooren
References: https://lists.infradead.org/pipermail/openwrt-devel/2021-May/035056.html Acked-by: Hauke Mehrtens Signed-off-by: Petr Štetiar --- Acked-by: Paul Spooren inventories/prod/group_vars/all/02-openwrt-prod.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/inventories/prod/group_v

Re: [PATCH] added support for comfast jw-ew74

2021-05-05 Thread Paul Spooren
On 5/4/21 5:28 PM, e...@daloft.com wrote: From: eric --- Hi Eric, thank you very much for your contribution! Please read the following guide, there are some formal issues with this patch: https://openwrt.org/submitting-patches Patches should always include the full and real name of

Re: [PATCH] fstools: block: fix segfault on mount with no target

2021-05-05 Thread Paul Spooren
On 5/4/21 3:23 PM, Daniel Danzberger wrote: When a UCI fstab mount config doesn't contain a target option, a 'block mount' call segfaults when comparing a mount's target (NULL) to a found mount point returned by find_mount_point() Signed-off-by: Daniel Danzberger --- Acked-by: Paul Spooren

Re: [PATCH] Extend checks on build prerequisites for building OpenWRT core

2021-04-29 Thread Paul Spooren
On 4/20/21 1:08 AM, Bas Mevissen wrote: OpenWRT requires a number of Perl modules to be installed. It wasn't checking on all of them. This patch adds checks for Perl FindBin, File::Copy, File::Compare and Thread::Queue modules. Failing to install these, will have the build break at some

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-25 Thread Paul Spooren
Apr 25, 2021 8:34:06 AM Gaurav Pathak : inittab.c: Use "/dev/console" character device (5,1) if it is present, before trying "/sys/class/tty/console/active" in case if console kernel command line is not provided during boot and to allow container environment to use it as login PTY console.

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Paul Spooren
On 4/24/21 1:01 AM, Gaurav Pathak wrote: Modified inittab.c to use "/dev/console" as preferred console if exists. Signed-off-by: Gaurav Pathak --- Could you please elaborate why this is useful? Edited inittab.c to check and use "/dev/console" as the first console device before parsing

Re: [PATCH] maketag.sh/makebranch.sh: handle https download URLs

2021-04-19 Thread Paul Spooren
On 4/19/21 9:45 AM, Hauke Mehrtens wrote: Since OpenWrt 21.02 we use https for our download server, detect these URLs too. Signed-off-by: Hauke Mehrtens --- Can't you kick out anything lede-project related while at it? To use the https URLs I have to provide the URL manually now:

Re: Requiring 2FA on OpenWrt GitHub organization

2021-04-11 Thread Paul Spooren
I did so a week ago and asked everyone with direct emails to turn on 2FA. Everyone who didn't respond after 3 weeks and multiple mails lost their commit access. If there's someone with commit access and no 2FA, it was added afterwards. -- Apr 11, 2021 4:52:22 AM Etienne Champetier :

[PATCH keyring] usign: drop personal + outdated keys except 21.02

2021-03-30 Thread Paul Spooren
key, which is later renamed to the next release name (e.g. 21.08). This approach should allow secure upgrade between releases. Signed-off-by: Paul Spooren --- This commit should be merged into a `openwrt-21.02` branch which is then selected by the 21.02 release. usign/0b26f36ae0f4106d | 2

[PATCH 1/2] ncurses: split long line of supported terminfo

2021-03-29 Thread Paul Spooren
The terminfo files were all in one row which is terrible to read. Split them over multiple lines to improve readability. Signed-off-by: Paul Spooren --- package/libs/ncurses/Makefile | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/package/libs/ncurses/Makefile

[PATCH 2/2] ncurses: add screen-256color terminfo

2021-03-29 Thread Paul Spooren
The terminfo is required by the popular terminal multiplexer screen and tmux, offer it by default as the size impact is minimal with 885 Bytes. Signed-off-by: Paul Spooren --- package/libs/ncurses/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/libs

Re: [PATCH] build: remove GCC7 support

2021-03-26 Thread Paul Spooren
On Fr, Mär 26, 2021 at 02:28, Rosen Penev wrote: On Fri, Mar 26, 2021 at 1:49 AM Paul Spooren wrote: Since we recently branched a new release which already ships with GCC7, version 6 could be considered obsolete. version 6? Subject is right, body is wrong. So it's about removing

[PATCH] build: remove GCC7 support

2021-03-26 Thread Paul Spooren
Since we recently branched a new release which already ships with GCC7, version 6 could be considered obsolete. Signed-off-by: Paul Spooren --- toolchain/gcc/Config.in | 4 - toolchain/gcc/Config.version | 10 - toolchain/gcc/common.mk

[PATCH] build,json: 3rd fixup of default_packages

2021-03-25 Thread Paul Spooren
the list of default packages. Signed-off-by: Paul Spooren --- scripts/json_overview_image_info.py | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/scripts/json_overview_image_info.py b/scripts/json_overview_image_info.py index cd814a19c0..8dbd24af2d 100755

Re: [PATCH] mwlwifi: remove target dependency

2021-03-22 Thread Paul Spooren
On Di, Mär 23, 2021 at 00:17, Daniel Golle wrote: On Mon, Mar 22, 2021 at 11:14:39PM +0100, Hauke Mehrtens wrote: On 3/21/21 10:17 PM, Daniel Golle wrote: > Users complained that building images for various mvebu Linksys devices > fails when using the ImageBuilder, it complains about

Re: [PATCH] build: artifacts add dependency for builded images

2021-03-21 Thread Paul Spooren
On Sat Mar 20, 2021 at 10:58 PM HST, Oskari Lemmela wrote: > Add possibility to use images and initramfs in artifacts. > > Signed-off-by: Oskari Lemmela > --- Hi, could you please elaborate on your use-case? > include/image.mk | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

[PATCH] build,json: fix duplicates in default_packages

2021-03-21 Thread Paul Spooren
ects using the generated JSON files. While at it, apply `black` style to Python script. Signed-off-by: Paul Spooren --- scripts/json_overview_image_info.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/json_overview_image_info.py b/scripts/json_overview_image_inf

Re: [PATCH] procd: Adding support to detect Pantavisor Container Platform

2021-03-20 Thread Paul Spooren
On Sat, Mar 20, 2021 at 20:16, Gaurav Pathak wrote: Added a new file pv_platform.h having function is_pantavisor() to detect the pantavisor container platform, as it runs a custom modified version of LXC, so detecting LXC using is_container() is not returning expected result.

Re: compiling only packages that have patented functionality

2021-03-17 Thread Paul Spooren
Mar 17, 2021 12:37:26 AM Alberto Bursi : I'm investigating about making an unofficial third party repository with OpenWrt (non-kmod) packages where patented functionality is enabled. For example ffmpeg from packages is missing some functionality in its "non-patented" form and most end users

[PATCH] build,ib: add STRIP_ABI option for manifest

2021-03-15 Thread Paul Spooren
this function accessible for the ImageBuilder by adding a `STRIP_ABI` variable. Signed-off-by: Paul Spooren --- target/imagebuilder/files/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/imagebuilder/files/Makefile b/target/imagebuilder/files/Makefile index

[PATCH v3] scripts,ipkg-build: format code with shfmt

2021-03-15 Thread Paul Spooren
The script improves readability by using an automatic code formatter. Signed-off-by: Paul Spooren --- scripts/ipkg-build | 62 -- 1 file changed, 33 insertions(+), 29 deletions(-) diff --git a/scripts/ipkg-build b/scripts/ipkg-build index c112270a2b

Re: [PATCH v2 3/3] scripts,ipkg-build: format code with shfmt

2021-03-14 Thread Paul Spooren
]: https://github.com/mvdan/sh/issues/377 On Tue, Feb 9, 2021 at 13:36, Paul Oranje wrote: Op 5 feb. 2021, om 00:59 heeft Paul Spooren het volgende geschreven: The script improves readability by using an automatic code formatter. The decreases of the switch case indentation levels make

[PATCH] treewide: extend DEFAULT_PACKAGES before target.mk

2021-03-08 Thread Paul Spooren
-mod-pppoe Signed-off-by: Paul Spooren --- This behaviour also results in duplicates in produced JSON files: https://downloads.openwrt.org/snapshots/targets/mvebu/cortexa9/profiles.json The package kmod-gpio-button-hotplug is added twice to the default_packages array. target/linux/apm821xx

[PATCH 0/2] determineable package name with ABIVersions

2021-03-07 Thread Paul Spooren
the logic of rpcd/sys.c. Paul Spooren (2): package: store SourceName in Packages index include: store ABIVersion in Packages index include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.30.1

[PATCH 2/2] include: store ABIVersion in Packages index

2021-03-07 Thread Paul Spooren
mmits adds the `ABIVersion` field again. Knowing both the combined (SourceName + ABIVersion) and the `ABIVersion` it is possible to calculate the package `SourceName` without storing it in the on-device package list. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + 1 file changed, 1

[PATCH 1/2] package: store SourceName in Packages index

2021-03-07 Thread Paul Spooren
it is available on device. Signed-off-by: Paul Spooren --- package/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/Makefile b/package/Makefile index a89a6068fa..802100838c 100644 --- a/package/Makefile +++ b/package/Makefile @@ -87,7 +87,7 @@ $(curdir)/index: FORCE

Re: [PATCH 2/2] generic: enable netlink ethtool interface

2021-03-04 Thread Paul Spooren
What's the size change? -- Mar 4, 2021 12:59:22 PM David Bauer : The virtual cable tester depends on the netlink interface for ethtool. Thus, enable it in the generic kernel configuration. Signed-off-by: David Bauer --- target/linux/generic/config-5.10 | 2 +- 1 file changed, 1

Re: [PATCH 3/3] COPYING: add COPYING file to specify project licenses

2021-02-12 Thread Paul Spooren
On Fri, Feb 12, 2021 at 13:53, Adrian Schmutzler wrote: Since multiple licenses are provided now in the LICENSES folder, add a COPYING file to specify the project license. Signed-off-by: Adrian Schmutzler --- Acked-by: Paul Spooren COPYING | 12 1 file changed, 12

Re: Initial flashing over "OEM-OpenWrt"

2021-02-08 Thread Paul Spooren
Feb 8, 2021 5:06:28 AM Piotr Dymacz : Hi Adrian, On 06.02.2021 17:42, Adrian Schmutzler wrote: Hi, when reviewing device-support PRs, I frequently encounter the case that initial flashing means sysupgrading from an OEM-modified OpenWrt. This obviously means that the config of this

Re: [PATCH v2] acx-mac80211: replace dead URLs with OpenWrt CDN

2021-02-07 Thread Paul Spooren
On Sun Feb 7, 2021 at 9:53 AM HST, Ilya Lipnitskiy wrote: > Hi Paul, > > > > define Download/tiacx111c16_1 > > > FILE:=tiacx111c16_1.2.1_34 > > > - URL:=http://sites.google.com/site/atorkhov/files/ > > > + URL:=@OPENWRT > > > > This file is still available, does the download fail as well? > > >

Re: [PATCH] openpgm: Add Pragmatic General Multicast library

2021-02-07 Thread Paul Spooren
On Sun, Jan 3, 2021 at 19:42, yehol...@outlook.com wrote: From: Ye Holmes Signed-off-by: Ye Holmes --- Can't this package go to packages.git? libs/openpgm/Makefile | 64 +++ .../0001-Rename-openpgm-5.2.pc.in.patch | 22 +++

Re: [PATCH v2] acx-mac80211: replace dead URLs with OpenWrt CDN

2021-02-07 Thread Paul Spooren
Hi Ilya, thanks for the quick fixup! One comment below. On Fri Feb 5, 2021 at 7:11 PM HST, Ilya Lipnitskiy wrote: > erley.org no longer exists; attempting to connect to it during package > download results in lengthy timeouts. Use the new OpenWrt CDN alias to > download from reliable OpenWrt

Re: [PATCH] acx-mac80211: replace dead URLs with OpenWrt CDN

2021-02-05 Thread Paul Spooren
On Thu Feb 4, 2021 at 5:24 PM HST, Ilya Lipnitskiy wrote: > Signed-off-by: Ilya Lipnitskiy > --- Please use URL:=@OPENWRT instead of the full URL, added via: https://git.openwrt.org/8286f3a3d3a7d65d36ee312c6fd3828d4e4fd048 Also please provide a commit message, e.g. "erley.org does no longer

[PATCH v2 1/3] scripts,ipkg-build: apply shellcheck

2021-02-04 Thread Paul Spooren
Signed-off-by: Paul Spooren --- scripts/ipkg-build | 81 +++--- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/scripts/ipkg-build b/scripts/ipkg-build index 343aab6caf..8533c97fcc 100755 --- a/scripts/ipkg-build +++ b/scripts/ipkg-build @@ -

[PATCH v2 3/3] scripts,ipkg-build: format code with shfmt

2021-02-04 Thread Paul Spooren
The script improves readability by using an automatic code formatter. Signed-off-by: Paul Spooren --- scripts/ipkg-build | 71 -- 1 file changed, 37 insertions(+), 34 deletions(-) diff --git a/scripts/ipkg-build b/scripts/ipkg-build index c112270a2b

[PATCH v2 2/3] scripts,ipkg-build: use realpath for pkg_dir

2021-02-04 Thread Paul Spooren
This allows manual execution of the ipkg-build script even with releative path. Signed-off-by: Paul Spooren --- scripts/ipkg-build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ipkg-build b/scripts/ipkg-build index 8533c97fcc..c112270a2b 100755 --- a/scripts/ipkg

RE: 20.xx: state of the DSA

2021-02-02 Thread Paul Spooren
at 16:39, Adrian Schmutzler wrote: Hi, -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Paul Spooren Sent: Freitag, 20. November 2020 01:36 To: openwrt-devel@lists.openwrt.org Subject: 20.xx: state of the DSA Hi all, DSA

Re: Backporting opkg fixes to 19.07

2021-02-01 Thread Paul Spooren
On Sun, Jan 31, 2021 at 19:10, Baptiste Jonglez wrote: Hi, I've just pushed this to my (brand new) staging tree: https://git.openwrt.org/?p=openwrt/staging/zorun.git;a=shortlog;h=refs/heads/openwrt-19.07 If there are no objections, I will merge that in a couple of days. Thanks for

[PATCH v2] treewide: unify OpenWrt hosted source via @OPENWRT

2021-01-31 Thread Paul Spooren
g. Signed-off-by: Paul Spooren --- include/download.mk | 2 +- package/boot/fconfig/Makefile | 2 +- package/firmware/b43legacy-firmware/Makefile | 2 +- package/firmware/lantiq/dsl-vrx200-firmware-xdsl/Makefile | 2 +

Re: [PATCH] treewide: unify OpenWrt hosted source URL

2021-01-31 Thread Paul Spooren
On Sun, Jan 31, 2021 at 10:08, Hannu Nyman wrote: Paul Spooren kirjoitti 30.1.2021 klo 23.54: Multiple sources are hosted on OpenWrts source server only. The source URLs to point to the server vary based on different epochs in OpenWrts history. Unify them to use always the new source CDN

Re: [PATCHv3 1/2] tools/zstd: update to 1.4.8

2021-01-30 Thread Paul Spooren
On Wed Jan 20, 2021 at 6:54 PM HST, Rosen Penev wrote: > Switch to the normal tarball instead of the codeload generated one. The > latter has the potential to change hashes based on changes in the repo. > > Signed-off-by: Rosen Penev > --- Currently zstd fails to compile, is this meant s a fix

Re: [PATCHv3 2/2] tools/zstd: compile with cmake

2021-01-30 Thread Paul Spooren
On Wed Jan 20, 2021 at 6:54 PM HST, Rosen Penev wrote: > It's faster and more reliable. > > Removed ccache cmake build dependency as it's now implicit. > > Signed-off-by: Rosen Penev > --- > v3: converted to use CMake > tools/Makefile | 3 ++- > tools/zstd/Makefile | 9 +++-- > 2 files changed,

[PATCH] treewide: use CDN for downloads

2021-01-30 Thread Paul Spooren
Use CDN for opkg repositories. Signed-off-by: Paul Spooren --- Tested with browser and opkg running on router. HTTP works only for specific user-agents and `ipk` files, this is a *limitation* (or security precaution) of the origin server not influenced by the CDN. include/version.mk

[PATCH] treewide: unify OpenWrt hosted source URL

2021-01-30 Thread Paul Spooren
Multiple sources are hosted on OpenWrts source server only. The source URLs to point to the server vary based on different epochs in OpenWrts history. Unify them to use always the new source CDN and HTTPS. If the CDN fails, sources.o.o is used as a fallback via downloads.pl. Signed-off-by: Paul

[PATCH] build,package-defaults: AUTORELEASE as fallback

2021-01-29 Thread Paul Spooren
This commits changes the package defaults so that $(AUTORELEASE) is used whenever no explicit PKG_RELEASE is set and $(COMMITCOUNT) whenever neither is given. Previously an explicit definition of PKG_RELEASE=$(AUTORELEASE) would be required. Signed-off-by: Paul Spooren --- include/package

Re: [PATCH] rules: fix empty COMMITCOUNT/AUTORELEASE

2021-01-29 Thread Paul Spooren
On Fri, Jan 29, 2021 at 10:43, Petr Štetiar wrote: I guess, that the actual error from that dump.txt file would be more useful in this case :) Sorry, it was late: Makefile:48: *** Package/px5g-wolfssl is missing the VERSION field. Stop. VERSION is defined as PKG_VERSION-PKG_RELEASE, or

[PATCH] rules: fix empty COMMITCOUNT/AUTORELEASE

2021-01-29 Thread Paul Spooren
Signed-off-by: Paul Spooren --- rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules.mk b/rules.mk index 1b63b8fc45..fc2c2efa2d 100644 --- a/rules.mk +++ b/rules.mk @@ -432,8 +432,8 @@ $(shell \ ) endef -COMMITCOUNT = $(if $(DUMP),,$(call commitcount

Re: [PATCH] umdns: bump to 2021-01-26

2021-01-28 Thread Paul Spooren
On Wed, Jan 27, 2021 at 22:37, Petr Štetiar wrote: Can't this be a default which could be overriden when needed? Sure, see patch below. As it's a new feature I wanted it optionally rather than treewide for the beginning. I'll send a patch. ___

[PATCH] scripts: sources CDN as fallback in download.pl

2021-01-26 Thread Paul Spooren
In case the default sources for a package fail use the CDN rather than our own mirror. In case the CDN fails, fallback to our mirror. Also remove mirror1 which isn't available anymore. Signed-off-by: Paul Spooren --- scripts/download.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] umdns: bump to 2021-01-26

2021-01-26 Thread Paul Spooren
* i78aa36b umdns: fix 64-bit time format string * start using $(AUTORELEASE) * Update Copyright Signed-off-by: Paul Spooren --- package/network/services/umdns/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/network/services/umdns/Makefile b/package

Re: Job board support on openwrt.org?

2021-01-24 Thread Paul Spooren
On Sun, Jan 24, 2021 at 00:16, Sam Kuper wrote: On Sat, Jan 23, 2021 at 06:57:53PM -0500, Etienne Champetier wrote: Le sam. 23 janv. 2021 à 18:09, Sam Kuper a écrit : I suggest that if a vote is held, it should be a three-way vote between the following outcomes (which should probably

Re: Job board support on openwrt.org?

2021-01-23 Thread Paul Spooren
On Sa, Jan 23, 2021 at 07:25, Alberto Bursi wrote: On 22/01/21 20:03, Daniel Golle wrote: Hi Philip, On Fri, Jan 22, 2021 at 11:23:42AM -0700, Philip Prindeville wrote: Hi, Is anyone interested in adding a page to the openwrt.org site about developers willing to do commercial work?

Re: OpenWrt 19.07.6 service release

2021-01-22 Thread Paul Spooren
What's the size difference here. I'd be curious to replace dnsmasq for the default setup, but only if it brings an advantage in size and security. Just a personal interest. Best, Paul -- Jan 22, 2021 11:44:50 AM Philip Prindeville : On Jan 22, 2021, at 12:00 PM, Alberto Bursi

Re: [RFC PATCH] ath79: remove generic profiles

2021-01-21 Thread Paul Spooren
> > Signed-off-by: Adrian Schmutzler > --- Looks good to me. A quick check of target-metadata.pl reveals that the buildbot enables all profiles per default, so a shortcut via the generic "profile" isn't required on that end. >From my view, please proceed with other targets. Ac

[PATCH v2 3/4] uboot-envtools: use $(AUTORELEASE) for PKG_RELEASE

2021-01-19 Thread Paul Spooren
Use `$(AUTORELEASE)` variable rather than setting a PKG_RELEASE on every commit manually. Signed-off-by: Paul Spooren --- package/boot/uboot-envtools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/boot/uboot-envtools/Makefile b/package/boot/uboot-envtools

<    1   2   3   4   5   6   >