[PATCH v2] fstools: remove redundant F2FS_MINSIZE definition

2024-04-03 Thread Rui Salvaterra
It's defined in common.h, which rootdisk.c also includes. Remove the redundant definition from the latter. Signed-off-by: Rui Salvaterra --- libfstools/rootdisk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libfstools/rootdisk.c b/libfstools/rootdisk.c index ba7d8c3..910899a 100644

Re: [PATCH] fstools: remove redundant F2FS_MINSIZE definition

2024-04-03 Thread Rui Salvaterra
On Wed, 3 Apr 2024 at 09:30, Rui Salvaterra wrote: > > Keep only the rootdisk.c definition, where it's used. > > Signed-off-by: Rui Salvaterra > --- > libfstools/common.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libfstools/common.h b/libfstools/common

[PATCH] fstools: remove redundant F2FS_MINSIZE definition

2024-04-03 Thread Rui Salvaterra
Keep only the rootdisk.c definition, where it's used. Signed-off-by: Rui Salvaterra --- libfstools/common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libfstools/common.h b/libfstools/common.h index 28b82d2..24504d6 100644 --- a/libfstools/common.h +++ b/libfstools/common.h @@ -19,8

Re: [VOTE] New member proposal: Robimarko (Robert Marko)

2024-01-31 Thread Rui Salvaterra
Hi, everyone! On Tue, 30 Jan 2024 at 18:16, Christian Marangi (Ansuel) wrote: > > Robert is active in OpenWrt since 2017 and with some recent stats, he > has more than 310 commits merged in OpenWrt. > He also have uncounted Reviewed-by tag on various PR and merged commits > and generally helps

Re: OpenWrt Next Generation Ideas

2023-04-01 Thread Rui Salvaterra
Hi, everyone! On Fri, 31 Mar 2023 at 22:28, Daniel Golle wrote: > [snipped] > The point here is not optimization, but finding a good compromise to > not having to compile **all** packages for **all** CPU architectures. > The same is btw also true for MIPS and ARM targets. We pick a good >

Re: [PATCH] x86/c3000: Add Intel SoC C3000 series

2022-06-24 Thread Rui Salvaterra
Hi, jialelux, On Fri, 24 Jun 2022 at 09:50, wrote: > [snipped] > +SUBTARGETS:=generic legacy geode 64 c3000 [snipped] The Atom C3000 is a x86-64 CPU. What makes it so special as to require a dedicated subtarget? Cheers, Rui ___ openwrt-devel

Re: [PATCH v2] utrace: fix memory leak

2022-06-24 Thread Rui Salvaterra
free(_envp[0]); > + if (newenv == 2 && _envp[1]) > + free(_envp[1]); > free(_envp); > return ret; > } > -- > 2.21.0.windows.1 I'm not a C expert, but I see those array positions being allocated with asprintf(), s

Re: [PATCH] kernel 5.15: x86-64: enable CONFIG_SLS

2022-06-22 Thread Rui Salvaterra
Hi, everyone, On Fri, 10 Jun 2022 at 09:20, Rui Salvaterra wrote: > > Starting with GCC 12, we have the possibility of mitigating straight-line > speculation vulnerabilities in x86-64 targets. Make it so. [patch snipped] I've made this part of the 5.15 pull request [1], so

Fwd: Testing network / NAT performance

2022-06-14 Thread Rui Salvaterra
[Ugh, now with less HTML, sorry about that…] Hi, Rafał, On Tue, 14 Jun 2022 at 14:20, Rafał Miłecki wrote: > > As you can see 4e0c54bc5bc8 has accidentally moved -fno-reorder-blocks > from !CONFIG_CC_OPTIMIZE_FOR_SIZE to CONFIG_CC_OPTIMIZE_FOR_SIZE. > > I've noticed problem with

[PATCH] kernel 5.15: x86-64: enable CONFIG_SLS

2022-06-10 Thread Rui Salvaterra
Starting with GCC 12, we have the possibility of mitigating straight-line speculation vulnerabilities in x86-64 targets. Make it so. Reported-by: Stefan Lippers-Hollmann Signed-off-by: Rui Salvaterra --- target/linux/x86/64/config-5.15 | 1 + 1 file changed, 1 insertion(+) diff --git a/target

Re: [PATCH 1/4] pcre2: adds pcre2 to base

2022-05-20 Thread Rui Salvaterra
On Thu, 19 May 2022 at 18:35, Daniel Golle wrote: > > On Thu, May 19, 2022 at 06:37:28PM +0200, Dominick Grift wrote: > > libselinux-3.4 requires pcre2 > > > > Signed-off-by: Dominick Grift > > --- > > package/libs/pcre2/Config.in | 30 > > package/libs/pcre2/Makefile | 92

Re: [PATCH] toolchain: musl: Update to version 1.2.3

2022-04-11 Thread Rui Salvaterra
useful also for OpenWrt 22.03. For 22.03, this is definitely Acked-by: Rui Salvaterra Running without issues on my Omnia (master, though), so it's also Tested-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openw

[PATCH] x86: remove an upstreamed patch

2022-04-07 Thread Rui Salvaterra
012-pcengines-apu2-detect-apuv4-board.patch is upstream since Linux 5.5 [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/platform/x86/pcengines-apuv2.c?h=v5.5=3d00da1de3ea36ba44f4a7ba76c8c8b16f98204b Signed-off-by: Rui Salvaterra --- ...12-pcengines

[PATCH v2] ath9k: backport hw_random API support

2022-03-23 Thread Rui Salvaterra
://lore.kernel.org/all/20220216113323.53332-1-ja...@zx2c4.com/ Acked-by: Petr Štetiar Signed-off-by: Rui Salvaterra --- v2: make it actually build when CONFIG_ATH9K_HWRNG is selected (and rng-core.ko isn't built-in). package/kernel/mac80211/ath.mk| 2 +- ...dom-API-instead

Re: [PATCH] ath9k: backport hw_random API support

2022-03-23 Thread Rui Salvaterra
Hi again, On Wed, 2 Mar 2022 at 13:31, Rui Salvaterra wrote: > > Backport Jason's patch [1] implementing proper hw_random API support for the > ath9k hwrng. The original code invoked add_hwgenerator_randomness to directly > feed ADC entropy into the system pool. Since add_hwgenerato

Re: [PATCH] kernel: enable SERIAL_8250_16550A_VARIANTS

2022-03-14 Thread Rui Salvaterra
[patch snipped] Seems sensible to me. Reviewed-by: Rui Salvaterra Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: Drop CONFIG_IPV6 ?

2022-03-14 Thread Rui Salvaterra
Hi, Etienne, On Sun, 13 Mar 2022 at 23:33, Etienne Champetier wrote: > > We currently have some circular dependencies caused by the usage of > PROVIDES and @IPV6 > https://github.com/openwrt/openwrt/issues/9407 These don't seem unfixable. > One radical way to fix, suggested by Jow, is to

[PATCH] ath9k: backport hw_random API support

2022-03-02 Thread Rui Salvaterra
://lore.kernel.org/all/20220216113323.53332-1-ja...@zx2c4.com/ Acked-by: Petr Štetiar Signed-off-by: Rui Salvaterra --- ...dom-API-instead-of-directly-dumping-.patch | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 package/kernel/mac80211/patches/ath9k/020-v5.18-ath9k

[PATCH] firewall3: bump to latest git HEAD

2022-02-25 Thread Rui Salvaterra
4cd7d4f Revert "firewall3: support table load on access on Linux 5.15+" 50979cc firewall3: remove unnecessary fw3_has_table Signed-off-by: Rui Salvaterra --- package/network/config/firewall/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/netw

[PATCH] kernel: generic: add missing 5.10 symbols

2022-02-24 Thread Rui Salvaterra
Add the following kconfig symbols (disabled): CONFIG_DEFAULT_FQ CONFIG_DEFAULT_CODEL CONFIG_DEFAULT_SFQ Also resort the config with the kconfig.pl script. Fixes: f39872d966 ("kernel: generic: select the fq_codel qdisc by default") Signed-off-by: Rui Salvaterra --- I screwed up, s

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-21 Thread Rui Salvaterra
Hi, Ansuel, On Mon, 21 Feb 2022 at 16:09, Ansuel Smith wrote: > > Hi, sorry for the delay... I reverted my patch and applied this > and I can confirm that this works correctly on linux 5.15. No worries, thanks for confirming. I'll take it from here. :) Cheers, Rui

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-17 Thread Rui Salvaterra
Hi, guys, On Fri, 11 Feb 2022 at 19:12, Wenli Looi wrote: > > Sorry, forgot to reply all > > On Fri, Feb 11, 2022 at 11:09 AM Wenli Looi wrote: > > > > Hi Rui, > > > > Yes, I believe it still works. Every place where fw3_has_table is > > called, we check immediately after if fw3_ipt_open

Re: [PATCH] firewall3: remove unnecessary fw3_has_table

2022-02-11 Thread Rui Salvaterra
Hi, Wenli, On Thu, 10 Feb 2022 at 19:19, Wenli Looi wrote: > > Hi Rui and Ansuel, > > Can you take a look at this patch I sent a while ago for firewall3? I > think it is a better solution for the problem in kernel 5.15+ that is > identified here. > >

[PATCH] update_kernel.sh: fix unified version file updates

2022-02-08 Thread Rui Salvaterra
the unified file and do the version update accordingly. Fixes: cbb9d08 ("update_kernel.sh: update it to new kernel hash/version file way") Signed-off-by: Rui Salvaterra --- update_kernel.sh | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/update_k

Re: [PATCH] octeon: Switch to kernel 5.10 and mark source only

2022-02-04 Thread Rui Salvaterra
Hi, Hauke, On Fri, 4 Feb 2022 at 00:10, Hauke Mehrtens wrote: > > Stijn Tintel reported a memory leak in octeon with kernel 5.10. With > kernel 5.4 it worked fine. The memory leak was seen with IPsec tunnels, > VRRP IPs, conntrack syncing, full IPv6 BGP feed, etc. > See details here:

Re: [PATCH] bcm63xx: Remove patch already in Linux stable

2022-02-01 Thread Rui Salvaterra
turn ret; > - } > - > -- > 2.30.2 Oh, my…! I have no idea how I've missed this (or how quilt happily refreshed it without complaints, since the context doesn't seem to match at all). Reviewed-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-22 Thread Rui Salvaterra
Hi, Ansuel, On Sat, 22 Jan 2022 at 01:08, Ansuel Smith wrote: > > > So.. how should we proceed with this? From what I understand the idea is to > merge this ASAP. But not a moment sooner. ;) I'm sure we agree that this patch won't be merged upstream in its current form, according to the

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
On Fri, 21 Jan 2022 at 21:11, Ansuel Smith wrote: > > > Should we follow the suggestion and add a specific attribute just for DSA? I believe that would be the right thing to do, but I'd like to know what Daniel and Marek think about it too. ___

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-21 Thread Rui Salvaterra
[Apologies for resending, Gmail turned my message into HTML behind my back.] Hi, Ansuel, After reading the patch more carefully, I have to say I'm really not fond of it in its current form, especially considering that the original feedback from Stephen Hemminger and Vladimir Oltean [1] hasn't

Re: [PATCH v2] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-21 Thread Rui Salvaterra
Hi, Adrian On Thu, 20 Jan 2022 at 18:48, Adrian Schmutzler wrote: > > Hi, > > just a nitpick: Commit title prefix should be "kernel: 5.10: ...". Sure, no problem. May I push it with that fix? Cheers, Rui ___ openwrt-devel mailing list

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi again, On Thu, 20 Jan 2022 at 15:56, Rui Salvaterra wrote: > > Nice, but we'll need to do the same for BusyBox's ip applet. Let's not > force everyone who needs multi-CPU DSA to install iproute2's ip just > for this case. ;) Just to clarify, I'll take care of the BusyBox si

Re: [PATCH 2/2] iproute2: add support for link set

2022-01-20 Thread Rui Salvaterra
Hi, Ansuel, On Thu, 20 Jan 2022 at 15:11, Ansuel Smith wrote: > > Add support for link set useful to set CPU port for dsa drivers. > > Signed-off-by: Ansuel Smith > --- > ...-iplink_allow_to_change_iplink_value.patch | 94 +++ > 1 file changed, 94 insertions(+) > create mode

Re: [maintainer-tools PATCH] update_kernel.sh: update it to new kernel hash/version file way

2022-01-16 Thread Rui Salvaterra
-i include/kernel-${KERNEL} \ > -e "s|LINUX_VERSION-${KERNEL} =.*|LINUX_VERSION-${KERNEL} = > ${NEWVER}|" \ > -e > "s|LINUX_KERNEL_HASH-${KERNEL}.*|LINUX_KERNEL_HASH-${PATCHVER} = ${CHECKSUM}|" > fi > -- > 2.33.1 Looks good to me.

[PATCH v2] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-16 Thread Rui Salvaterra
They are required for container support, but are handled in Config-kernel.in. Signed-off-by: Rui Salvaterra --- v2: keep both ksyms (disabled) in the generic kconfig. target/linux/archs38/config-5.10 | 1 - target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux

Re: [PATCH] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-16 Thread Rui Salvaterra
Please don't merge this, removing the ksyms from the generic kconfigs will make make kernel_oldconfig prompt back for them, which definitely isn't what I intended. Will fix an resend a v2. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

[PATCH] firewall4: add DSCP Least Effort class

2022-01-10 Thread Rui Salvaterra
In compliance with RFC-8622 [1]. A similar patch was also applied to firewall3. [1] https://datatracker.ietf.org/doc/html/rfc8622 Signed-off-by: Rui Salvaterra --- root/usr/share/ucode/fw4.uc | 1 + 1 file changed, 1 insertion(+) diff --git a/root/usr/share/ucode/fw4.uc b/root/usr/share/ucode

[PATCH 2/2] procd: clean up /dev/pts mounts

2022-01-09 Thread Rui Salvaterra
The default mode is already 600, no need to specify it. Access times are also irrelevant. Signed-off-by: Rui Salvaterra --- initd/early.c | 2 +- plug/coldplug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/initd/early.c b/initd/early.c index 87fee65..4b7e61c 100644

[PATCH 0/2] procd: a couple of mount fixes

2022-01-09 Thread Rui Salvaterra
Fix a potential security issue in the way /dev is mounted. Clean up the /dev/pts mounts while at it. Rui Salvaterra (2): procd: mount /dev with noexec procd: clean up /dev/pts mounts initd/early.c | 4 ++-- plug/coldplug.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 1/2] procd: mount /dev with noexec

2022-01-09 Thread Rui Salvaterra
doesn't have a GPU, anyway. :) [1] https://lore.kernel.org/all/YcMfDOyrg647RCmd@debian-BULLSEYE-live-builder-AMD64/ [2] https://lore.kernel.org/all/CAPXgP12e5LpN6XVxaXOHhH=u8XXN==2retajdcock4tp4qd...@mail.gmail.com/ Signed-off-by: Rui Salvaterra --- initd/early.c | 2 +- plug/coldplug.c | 2 +- 2

Re: [PATCH] procd: mount /dev with noexec

2022-01-09 Thread Rui Salvaterra
On Wed, 5 Jan 2022 at 15:24, Rui Salvaterra wrote: > > /dev is writeable. Allowing execution inside it makes it a possible attack Bah. I just noticed a typo in the commit message. I also have a /dev/pts mount cleanup queued, so I'll resend as a series of two p

[PATCH] firewall3: don't cater to old iptables

2022-01-09 Thread Rui Salvaterra
It's been eight years, we can safely assume iptables is recent enough. Signed-off-by: Rui Salvaterra --- This has obviously been build/run-tested without any issues whatsoever. Even though firewall3 isn't a priority, this is a nice cleanup in itself. iptables.c| 13

Re: [PATCH v2] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Rui Salvaterra
{ "LE", 0x01 }, > { "AF11", 0x0a }, > { "AF12", 0x0c }, > { "AF13", 0x0e }, > -- > 2.32.0 (Apple Git-132) > Seems sensible to me. Nice description, and bonus points for the RFC reference. :) Reviewed-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Rui Salvaterra
Hi, Kevin, On Sat, 8 Jan 2022 at 15:38, Kevin Darbyshire-Bryant via openwrt-devel wrote: > > Signed-off-by: Kevin Darbyshire-Bryant > --- > options.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/options.c b/options.c > index 6131786..2f419a3 100644 > --- a/options.c > +++

Re: [firewall3 PATCH] firewall3: support async table init in 5.15+ kernel

2022-01-07 Thread Rui Salvaterra
continue; > + > + fw3_ipt_close(handle); > + } > + > for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; > table++) > { >

[PATCH] kernel/5.10: remove CONFIG_DEVTMPFS{,_MOUNT} from kconfigs

2022-01-05 Thread Rui Salvaterra
They are required for container support, but are handled in Config-kernel.in. Signed-off-by: Rui Salvaterra --- target/linux/archs38/config-5.10 | 1 - target/linux/generic/config-5.10 | 2 -- target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux

[PATCH] kernel/5.10: disable CONFIG_DEVTMPFS{,_MOUNT}

2022-01-05 Thread Rui Salvaterra
We rely on procd to create/populate /dev for us. These can be safely disabled. Signed-off-by: Rui Salvaterra --- target/linux/archs38/config-5.10 | 1 - target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux/layerscape/armv8_64b/config-5.10 | 2 -- target/linux/mediatek

[PATCH] procd: mount /dev with noexec

2022-01-05 Thread Rui Salvaterra
doesn't have a GPU, anyway. :) [1] https://lore.kernel.org/all/YcMfDOyrg647RCmd@debian-BULLSEYE-live-builder-AMD64/ [2] https://lore.kernel.org/all/CAPXgP12e5LpN6XVxaXOHhH=u8XXN==2retajdcock4tp4qd...@mail.gmail.com/ Signed-off-by: Rui Salvaterra --- initd/early.c | 2 +- plug/coldplug.c | 2

[PATCH] kernel/5.10: allocate last level PTEs in high memory

2022-01-03 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- 5.4 deemed unworthy, since it's going the way of the dodo. :) target/linux/bcm53xx/config-5.10 | 2 +- target/linux/ipq40xx/config-5.10 | 2 +- target/linux/ipq806x/config-5.10 | 2 +- target/linux/mediatek/mt7623/config-5.10 | 2

Re: [PATCH v2 3/8] toolchain/gcc: use ELFv2 ABI on ppc64 with musl

2021-12-21 Thread Rui Salvaterra
--with-gmp=$(TOPDIR)/staging_dir/host \ > --with-mpfr=$(TOPDIR)/staging_dir/host \ > --with-mpc=$(TOPDIR)/staging_dir/host \ > -- > 2.32.0 > Yes, please. I could be wrong, but I think all ppc64 targets in the kernel are migrating to the ELFv2 ABI. Reviewed-by

Re: [PATCH v2 1/8] build: add e5500 CPU_TYPE

2021-12-21 Thread Rui Salvaterra
E ?= powerpc64 > +CPU_CFLAGS_e5500:=-mcpu=e5500 > CPU_CFLAGS_powerpc64:=-mcpu=powerpc64 >endif >ifeq ($(ARCH),sparc) > -- > 2.32.0 > Reviewed-by: Rui Salvaterra Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH v2 7/8] qoriq: new target

2021-12-21 Thread Rui Salvaterra
Hi, Stijn, Nice to see this! :) A few nits/comments/questions below… On Mon, 20 Dec 2021 at 19:01, Stijn Tintel wrote: > > Add a new target named "qoriq", that will support boards using PowerPC > processors from NXP's QorIQ brand. > > This doesn't actually add support for any board yet, so that

[PATCH] kmod-sched-core: remove fq_codel from the package

2021-12-20 Thread Rui Salvaterra
Since fq_codel is the default (and built-in), it's unnecessary to make it part of kmod-sched-core. Remove it. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules/netsupport.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/kernel/linux/modules

[PATCH] kernel/generic: select the fq_codel qdisc by default

2021-12-19 Thread Rui Salvaterra
The kernel configuration allows us to select a default qdisc. Let's do this and get rid of the hacky patch we've been carrying. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 5 +- .../661-use_fq_codel_by_default.patch | 100 -- 2

Re: [PATCH] kernel: make zram honor available compressors when selecting the initial algo

2021-12-02 Thread Rui Salvaterra
Hi, Sven, On Thu, 2 Dec 2021 at 01:49, Sven Roederer wrote: > > I'm trying to make a as small as possible kernel (to safe RAM / flash). As I'm > already using the lzo-module I like to avoid to include both and keep the > choice to select any combination of them. I wholeheartedly agree with the

Re: zram-swap: default to lzo instead of lzo-rle compression

2021-12-01 Thread Rui Salvaterra
Hi, Felix, On Wed, 1 Dec 2021 at 12:45, Felix Fietkau wrote: > > Maybe upstream would accept a simple makefile change that merges both > into a single module without changing any of the source files. That's the most logical course of action, yes. Otherwise, this patch [1] I sent last year seems

Re: [PATCH] kernel: make zram honor available compressors when selecting the initial algo

2021-12-01 Thread Rui Salvaterra
Hi, Sven, [patch snipped] Why not just include the lzo-lre module in the lzo module package? We already agreed they're basically inseparable. In fact, I remember I had sent a patch [1] a while ago, in order to do just that. Thanks, Rui [1]

Re: zram-swap: default to lzo instead of lzo-rle compression

2021-11-29 Thread Rui Salvaterra
Hi, Sven, On Sun, 28 Nov 2021 at 01:40, Sven Roederer wrote: > > Rui, not sure if to call it a bug. At the end there is a hardcoded default > algo in the module, that is used initially when creating the device. The check > for the valid algo is done later at device-activation. > I spend some

[PATCH] dnsmasq: fix the dynamic dns object names patch

2021-11-12 Thread Rui Salvaterra
We can't use booleans, since we're not including stdbool.h. Use integers instead. Fixes: 0b79e7c01e ("dnsmasq: generate the dns object name dynamically") Signed-off-by: Rui Salvaterra --- .../services/dnsmasq/patches/200-ubus_dns.patch| 14 +++--- 1 file changed, 7 insert

[PATCH] tools/isl: update the download URL

2021-10-21 Thread Rui Salvaterra
isl.gforge.inria.fr has been dead since early this month [1]. Switch to libisl.sourceforge.io for the time being. [1] https://groups.google.com/g/isl-development/c/JGaMo2VUu_8 Signed-off-by: Rui Salvaterra --- Note: this needs to be backported to every supported OpenWrt version. tools/isl

Marvell EBU 32-bit performance benchmarks (VFPv3-D16 vs NEON builds, Turris Omnia).

2021-10-21 Thread Rui Salvaterra
Hi, guys, So, last meeting I proposed splitting the 32-bit mvebu target in vfpv3-d16 and neon subtargets. It seems this subject comes up every couple of years, or so. This time I hope to show solid evidence on why it would be an exercise in futility, closing the matter once and for all. In order

Re: Release goals for 22.XX

2021-10-10 Thread Rui Salvaterra
Hi, Sergey, On Sun, 10 Oct 2021 at 01:43, Sergey Ryazanov wrote: > > I am in the process of migrating ath25 to the 5.10 kernel. Initial > build was trivial. But I need to restore the Marvel swconfig driver > that was lost during the initial 5.10 kernel introduction, and > carefully run-time test

Re: Release goals for 22.XX

2021-10-08 Thread Rui Salvaterra
Hi, Paul, On Fri, 8 Oct 2021 at 11:09, Rui Salvaterra wrote: > > Nothing in this target has more than 32 MiB of RAM (most devices have > 16 MiB) [1]. Just put it out of its misery. :) Scratch that. After chatting with dangole, there may be some life in it, after all. I have an ath

Re: Release goals for 22.XX

2021-10-08 Thread Rui Salvaterra
Hi, Paul, On Fri, 8 Oct 2021 at 10:14, Paul Spooren wrote: > > > > - ath25 > > > Could this be dropped? Nothing in this target has more than 32 MiB of RAM (most devices have 16 MiB) [1]. Just put it out of its misery. :) [1] https://openwrt.org/?do=showtag=ath25 Cheers, Rui

Re: Release goals for 22.XX

2021-10-06 Thread Rui Salvaterra
Hi, Rich, On Wed, 6 Oct 2021 at 17:54, Rich Brown wrote: > > Paul, Rafał, > > I think our emails passed in the ether... > (http://lists.openwrt.org/pipermail/openwrt-devel/2021-October/036637.html) > > As I said in that message, I am very aware of the time constraints of the > volunteers for

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rui Salvaterra
Hi, David, On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > Does this mean parts of this patch are already applied upstream? Yes, the ag71xx_ring section. > Also are there already performance numbers available? Rosen has performance numbers comparing ar71xx to ath79 DSA including this

[PATCH v2] ath79: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rui Salvaterra
: 22 */ /* last cacheline: 24 bytes */ Signed-off-by: Rosen Penev [Reword and fix typos in the patch description] Signed-off-by: Rui Salvaterra --- v2: Change subject prefix to "ath79:". .../net/ethernet/atheros/ag71xx/ag71xx.h | 32 ++- 1 file changed, 17

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-25 Thread Rui Salvaterra
Hi, Adrian, On Fri, 24 Sept 2021 at 22:28, Adrian Schmutzler wrote: > > Commit title prefix should be "ath79: ag71xx:" or just "ath79:". To be honest, it makes more sense to me to have " ath79/ag71xx:", as it conveys the same information requiring one character less (and this format has often

[PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-19 Thread Rui Salvaterra
: 22 */ /* last cacheline: 24 bytes */ Signed-off-by: Rosen Penev [Fix typos in the patch description] Signed-off-by: Rui Salvaterra --- The ag71xx_ring changes are already part of the upstream driver. However, since we're not using it at all yet, let's apply this to our driver for the time

Re: Build issues gcc10

2021-09-13 Thread Rui Salvaterra
Hi, Adrian, On Mon, 13 Sept 2021 at 23:10, Adrian Schmutzler wrote: > > Just had one try before I went to bed, but it appears the problem is that > cc1plus generated by the toolchain has no execute bit set: How in blazes…? >

Re: Build issues gcc10

2021-09-12 Thread Rui Salvaterra
Hi, Adrian, On Sun, 12 Sept 2021 at 15:15, Adrian Schmutzler wrote: > > I'm having build issues with master and (default) gcc10 on ipq targets. I don't know about ipq, but I jumped straight to GCC 11.2. Does it make sense to bother with 10? That said… > xgcc: fatal error: cannot execute

Re: mvebu: switch to kernel 5.10 - MACCHIATObin Single Shot

2021-09-09 Thread Rui Salvaterra
Hi, Alexandra, On Thu, 9 Sept 2021 at 09:52, Alexandra Alth wrote: > > Hello Guys, > > Thanks a lot Rui Salvaterra for the mvebu switch to kernel 5.10. > > The SFP+ support for 10GE transceivers was broken in the Repository since at > least 9 months when build with kern

[PATCH] ramips: switch to kernel 5.10

2021-09-09 Thread Rui Salvaterra
Tested on mt7621 (Redmi AC2100) and running stable for several months. Signed-off-by: Rui Salvaterra --- target/linux/ramips/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile index d3f2d4b8fc..c9fc1aa58a

Re: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
Hi, Paul, On Tue, 7 Sept 2021 at 22:37, Paul Spooren wrote: > > This seems to be an ongoing thing, some add it and some remove it, I'm > happy to make this consistent: > > * Remove KERNEL_TESTING_PATCHVER when promoting > > or > > * Set KERNEL_{,TESTING}_PATCHVER to the same value until a new

[PATCH v2] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
It's been brewing on my cortexa9 subtarget (Turris Omnia) for months. Perfectly stable. Signed-off-by: Rui Salvaterra --- v2: remove KERNEL_TESTING_PATCHVER altogether, as per dangole's suggestion. target/linux/mvebu/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
Hi, Daniel, On Tue, 7 Sept 2021 at 22:09, Daniel Golle wrote: > > I'd remove the KERNEL_TESTING_PATCHVER line then until we add 5.14 or > whatever it's going to be. Sure, I didn't know what the usual procedure was, so I just mimicked aparcar. ;) V2 coming up. Thanks, Rui

[PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
It's been brewing on my cortexa9 subtarget (Turris Omnia) for months. Perfectly stable. Signed-off-by: Rui Salvaterra --- target/linux/mvebu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mvebu/Makefile b/target/linux/mvebu/Makefile index 3737a4aa23

Re: Broken ARP broadcast on master (commit 0f688797)

2021-09-06 Thread Rui Salvaterra
Hi, Felix, On Mon, 6 Sept 2021 at 13:19, Felix Fietkau wrote: > > Please try the latest version, it should resolve the issue I know I'm not the original complainer, but I tested a while ago and indeed this revert fixes the broadcast issue for me. :) Cheers, Rui

Re: [PATCH] octeontx: add linux 5.10 testing kernel support

2021-09-03 Thread Rui Salvaterra
Hi again, Daniel, On Fri, 3 Sept 2021 at 12:46, Daniel Danzberger wrote: > [snipped] > +CONFIG_EXT4_FS=y > +CONFIG_EXT4_FS_POSIX_ACL=y > +CONFIG_F2FS_FS=y > +CONFIG_FANOTIFY=y > +CONFIG_FAT_FS=y Do all of these filesystems have to be built-in? We have config options for them. [snipped] >

Re: [PATCH] octeontx: add linux 5.10 testing kernel support

2021-09-03 Thread Rui Salvaterra
Hi, Daniel, On Fri, 3 Sept 2021 at 10:18, Daniel Danzberger wrote: > [snipped for context] > +CONFIG_RCU_NEED_SEGCBLIST=y > +CONFIG_RCU_STALL_COMMON=y Please refresh your kernel configuration. At least these two symbols are part of the generic kconfigs. Thanks, Rui

[PATCH] kernel: add missing CONFIG_SECURITY_NETWORK_XFRM ksym

2021-09-01 Thread Rui Salvaterra
Paul noticed a build failure [1] due to this missing symbol. Add it as disabled to both generic kconfigs. [1] https://github.com/aparcar/openwrt/runs/3480872706?check_suite_focus=true#step:11:63 Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 1 + target/linux/generic

Re: [PATCH] kernel: Set CONFIG_RCU_CPU_STALL_TIMEOUT=21

2021-08-30 Thread Rui Salvaterra
eric configuration to 21 > seconds and removes the target specific configuration options. > > Signed-off-by: Hauke Mehrtens [patch snipped] This looks fine. Acked-by: Rui Salvaterra ___ openwrt-devel mailing list openwrt-de

Re: OpenWrt 21.02 status

2021-08-30 Thread Rui Salvaterra
+1 for release. It's just been too long since the last one. The idea of time-based releases is getting lost and this is a process issue we definitely should address. On Sun, 29 Aug 2021 at 11:44, Hannu Nyman wrote: > > Hauke Mehrtens wrote at Sun Aug 29 02:53:47 PDT 2021: > > > Should we just

[PATCH v2 1/2] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
. Additionally, remove the CONFIG_RCU_EXPERT symbol from the target kconfigs which contain it. [1] https://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- v2: no changes since v1, just resending the two

[PATCH v2 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
CONFIG_RCU_{NEED_SEGCBLIST,STALL_COMMON} are set basically everywhere. Move them to the generic kconfigs. And resort the generic kconfigs while at it. Signed-off-by: Rui Salvaterra --- v2: add back CONFIG_VIDEO_IRS1125, which fell off for some unfathomable reason. target/linux/arc770/config

Re: [PATCH 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 14:32, Hauke Mehrtens wrote: > > > -# CONFIG_VIDEO_IRS1125 is not set > > Why is this only removed? I'd love to have an answer to that question. I think the resorting got messed up (after reinserting the symbol and resorting, everything is fine, so I probably

[PATCH 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
CONFIG_RCU_{NEED_SEGCBLIST,STALL_COMMON} are set basically everywhere. Move them to the generic kconfigs. And resort the generic kconfigs while at it. Signed-off-by: Rui Salvaterra --- target/linux/arc770/config-5.4 | 2 -- target/linux/archs38/config-5.4 | 2

[PATCH 1/2] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
. Additionally, remove the CONFIG_RCU_EXPERT symbol from the target kconfigs which contain it. [1] https://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- target/linux/gemini/config-5.10 | 1

Re: [PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 13:45, Hauke Mehrtens wrote: > > Both options are hidden anyway, so we can manually change them: > > config RCU_STALL_COMMON > def_bool ( TREE_RCU || PREEMPT_RCU ) > help > > config RCU_NEED_SEGCBLIST > def_bool ( TREE_RCU || PREEMPT_RCU

Re: [PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 10:20, Hauke Mehrtens wrote: > > There are also some targets which explicitly unset CONFIG_RCU_EXPERT: [snipped] > This should be removed from the target config file. Sure thing, I'll clean up the targets and fold the changes into this patch. >

Re: [PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

2021-08-22 Thread Rui Salvaterra
Hi, Alberto, On Sun, 22 Aug 2021 at 01:07, Alberto Bursi wrote: > > Do you think adding the Watchguard M200 would be mostly a copy-paste > job? from what I have seen online it should be more or less the same > board but with a lower end CPU. > I might get one in the near future to do this myself

Re: [PATCH 0/6] qoriq: new target

2021-08-22 Thread Rui Salvaterra
Hi, Stijn, FWIW, the whole series is… Reviewed-by: Rui Salvaterra … even though I don't have the hardware for testing it. But being a new target, the whole thing is self-contained. :) Cheers, Rui ___ openwrt-devel mailing list openwrt-devel

[PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 7 +-- target/linux/generic/config-5.4 | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff

Re: [PATCH 0/6] use binutils 2.36.1 and gcc 10 by default

2021-08-15 Thread Rui Salvaterra
HI, guys, On Sun, 15 Aug 2021 at 13:00, Stijn Tintel wrote: > > On 15/08/2021 14:53, Hauke Mehrtens wrote: > > > > Did you check if the size of some of our images changed? > I did not. I can do that, but it'll take some time. I started regularly > wiping build_dir/ staging_dir/ and tmp/ due to

Re: [PATCH] kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets

2021-08-01 Thread Rui Salvaterra
Hi, Stijn, On Sat, 31 Jul 2021 at 11:01, Stijn Tintel wrote: > > Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why > it was enabled in the first place. If anyone knows, please do share. Yes, please! Personal note, CONFIG_RCU_EXPERT is one of those things I don't even

[PATCH] ath79: fix the AR7{1,2}00 USB PHY patches

2021-07-29 Thread Rui Salvaterra
PHY_SIMPLE is a bogus kconfig symbol, what we really need to select is GENERIC_PHY. Signed-off-by: Rui Salvaterra --- .../ath79/patches-5.10/0004-phy-add-ath79-usb-phys.patch | 4 ++-- .../linux/ath79/patches-5.4/0004-phy-add-ath79-usb-phys.patch | 4 ++-- 2 files changed, 4 insertions

[PATCH] kernel/generic: add CONFIG_KCSAN to the 5.10 kconfig

2021-07-27 Thread Rui Salvaterra
Add the missing CONFIG_KCSAN (disabled). Found while making kernel_oldconfig on an x86-64 subtarget. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 index

[PATCH] kernel/generic: fix the 5.10 arm gc-sections patch

2021-07-23 Thread Rui Salvaterra
KEEP(x)" change is bogus. It would only apply to !CONFIG_MMU devices (which we don't support in OpenWrt), and it would even break the build if referenced. Drop it. While at it, rename the patch in order to make it obvious that it's arm-specific. Signed-off-by: Rui Salvaterra --- ...ect

Re: [PATCH] toolchain/binutils: add binutils 2.37

2021-07-23 Thread Rui Salvaterra
Hi, Just a heads-up, if you want to play with it, binutils 2.37 breaks our 5.10 kernel build at the SORTTAB step, on mvebu/cortexa9 (at least), with the following error: no __ex_table in file: vmlinux Failed to sort kernel tables However, ramips/mt7621 (5.10) builds and runs without issues.

[PATCH] linux/rockchip: update the USB 3.0 controller node patch

2021-07-20 Thread Rui Salvaterra
This has been added in Linux 5.10.51 [1], but it's broken/incomplete. Update our patch and refresh the remaining patches. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.51=421aff50af5e4cdc56b3ac8d6b670e09697bc8ac Signed-off-by: Rui Salvaterra

Re: [PATCH] linux/rockchip: remove the USB 3.0 controller node patch

2021-07-20 Thread Rui Salvaterra
This isn't the correct fix, I'll send a proper one shortly. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

  1   2   3   4   >