[OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Kevin Darbyshire-Bryant
This patch stops SIGHUP from enabling dnssec timechecks if disabled by use of --dnssec-no-timecheck option. --dnssec-timestamp continues to work correctly. Enabling dnssec timechecks now requires restarting dnsmasq without the --dnssec-no-timecheck configuration option and closes a potential

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Etienne Champetier
Hi, 2015-10-01 12:19 GMT+02:00 Kevin Darbyshire-Bryant < ke...@darbyshire-bryant.me.uk>: > This patch stops SIGHUP from enabling dnssec timechecks if disabled by > use of --dnssec-no-timecheck option. --dnssec-timestamp continues to > work correctly. > I haven't really followed the previous

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Kevin Darbyshire-Bryant
On 01/10/15 11:37, Etienne Champetier wrote: > Hi, > > 2015-10-01 12:19 GMT+02:00 Kevin Darbyshire-Bryant > >: > > This patch stops SIGHUP from enabling dnssec timechecks if disabled by > use of --dnssec-no-timecheck

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Kevin Darbyshire-Bryant
On 01/10/15 12:56, Etienne Champetier wrote: > > > 2015-10-01 13:21 GMT+02:00 Kevin Darbyshire-Bryant > >: > > > > On 01/10/15 11:37, Etienne Champetier wrote: > > Hi, > > > > 2015-10-01 12:19 GMT+02:00 Kevin

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Etienne Champetier
2015-10-01 13:21 GMT+02:00 Kevin Darbyshire-Bryant < ke...@darbyshire-bryant.me.uk>: > > > On 01/10/15 11:37, Etienne Champetier wrote: > > Hi, > > > > 2015-10-01 12:19 GMT+02:00 Kevin Darbyshire-Bryant > > >: > > > > This

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > This patch stops SIGHUP from enabling dnssec timechecks if disabled by > use of --dnssec-no-timecheck option. --dnssec-timestamp continues to > work correctly. I'd argue that patching dnsmasq in this way is the wrong way to fix

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > Could I kindly ask you to read > https://patchwork.ozlabs.org/patch/521344/ particularly with regards to > Yousong's comments. You'll hopefully appreciate the irony of your > suggestion and how things (by which I mean 'I') have

Re: [OpenWrt-Devel] [PATCH] dnsmasq: remove dnssec timecheck enable on SIGHUP

2015-10-01 Thread Kevin Darbyshire-Bryant
On 01/10/15 16:20, Toke Høiland-Jørgensen wrote: > Kevin Darbyshire-Bryant writes: > >> This patch stops SIGHUP from enabling dnssec timechecks if disabled by >> use of --dnssec-no-timecheck option. --dnssec-timestamp continues to >> work correctly. > I'd argue