Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-02 Thread Sebastian Kemper
On Fri, Nov 01, 2019 at 01:04:04PM -0700, Rosen Penev wrote: > On Fri, Nov 1, 2019 at 12:21 PM Sebastian Kemper wrote: > > > > On Fri, Nov 01, 2019 at 12:06:39PM -0700, Rosen Penev wrote: > > > Would it also make sense to remove $(STAGING_DIR)/lib ? Locally, it > > > seems libpam gets installed

Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Rosen Penev
On Fri, Nov 1, 2019 at 12:21 PM Sebastian Kemper wrote: > > On Fri, Nov 01, 2019 at 12:06:39PM -0700, Rosen Penev wrote: > > Would it also make sense to remove $(STAGING_DIR)/lib ? Locally, it > > seems libpam gets installed there (probably a bug). > > Quoting FHS 3.0 regarding /lib's purpose:

Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Sebastian Kemper
On Fri, Nov 01, 2019 at 12:06:39PM -0700, Rosen Penev wrote: > Would it also make sense to remove $(STAGING_DIR)/lib ? Locally, it > seems libpam gets installed there (probably a bug). Quoting FHS 3.0 regarding /lib's purpose: "The /lib directory contains those shared library images needed to

Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Rosen Penev
On Fri, Nov 1, 2019 at 2:21 AM Jo-Philipp Wich wrote: > > Hi, > > [...] > > > Removing this directory from TARGET_CPPFLAGS will cut down the log noise > > a bit. Not only will CPPFLAGS be shorter, there will be less warnings > > set off by "-Wmissing-include-dirs" (or even failures when paired

Re: [OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Jo-Philipp Wich
Hi, [...] > Removing this directory from TARGET_CPPFLAGS will cut down the log noise > a bit. Not only will CPPFLAGS be shorter, there will be less warnings > set off by "-Wmissing-include-dirs" (or even failures when paired with > "-Werror"). After all the directory does not even _exist_ in the

[OpenWrt-Devel] [PATCH] rules.mk: remove "$(STAGING_DIR)/include"

2019-11-01 Thread Sebastian Kemper
"$(STAGING_DIR)/include" was carried over from buildroot-ng to OpenWrt in commit 60c1f0f64d23003a19a07d6b9638542130f6641d. buildroot has dropped this directory a long time ago. In OpenWrt the directory is still created by the PrepareStaging macro and is part of the default TARGET_CPPFLAGS. But