Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-15 Thread Rafał Miłecki
On 2019-09-11 12:55, Adrian Schmutzler wrote: diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files/files/lib/upgrade/common.sh index 8e7866f698..0d3162d4fc 100644 --- a/package/base-files/files/lib/upgrade/common.sh +++

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-15 Thread Rafał Miłecki
Hi, please use text/plain for your e-mails On 2019-09-15 11:54, m...@adrianschmutzler.de wrote: please also backport this to 19.07, since the variables for ath79 are still wrong there. That was on my list and I've just done that ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-15 Thread mail
. September 2019 12:56 To: 'Rafał Miłecki' ; openwrt-devel@lists.openwrt.org Cc: 'Rafał Miłecki' ; 'Jonas Gorski' ; 'Jo-Philipp Wich' ; 'John Crispin' Subject: RE: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup Hi, when looking at the merged patch

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-11 Thread Adrian Schmutzler
11 > To: openwrt-devel@lists.openwrt.org > Cc: Rafał Miłecki ; Jonas Gorski ; > Jo-Philipp Wich ; John Crispin > > Subject: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use > $UPGRADE_BACKUP to check for backup > > From: Rafał Miłecki > > Now that $UPGRADE_B

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-06 Thread Adrian Schmutzler
[OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use > $UPGRADE_BACKUP to check for backup > > On 2019-09-06 15:05, Adrian Schmutzler wrote: > >> diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > >> b/target/linux/ipq40xx/base-files/lib/upgrade/o

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-06 Thread Rafał Miłecki
On 2019-09-06 15:05, Adrian Schmutzler wrote: diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh index e313562017..8e02186eb8 100644 --- a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh +++

Re: [OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-06 Thread Adrian Schmutzler
Hi, just a nitpick: > diff --git a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > b/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > index e313562017..8e02186eb8 100644 > --- a/target/linux/ipq40xx/base-files/lib/upgrade/openmesh.sh > +++

[OpenWrt-Devel] [PATCH 3/3] treewide: sysupgrade: use $UPGRADE_BACKUP to check for backup

2019-09-05 Thread Rafał Miłecki
From: Rafał Miłecki Now that $UPGRADE_BACKUP is set conditionally there is no need to check the $UPGRADE_OPT_SAVE_CONFIG anymore. All conditions can be simplified. Signed-off-by: Rafał Miłecki --- package/base-files/files/lib/upgrade/common.sh | 2 +-