> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Karl Palsson
> Sent: Montag, 4. Januar 2021 12:58
> To: Adrian Schmutzler
> Cc: openwrt-devel
> Subject: Re: [PATCH] base-files: read all 5 bytes in get_
The fact that you had to introduce iflags to work around changing IBS/OBS which
afffected skip size would make me consider this sort of patch to be of
incredibly marginal utilty, largely even negative value if this isn't some sort
of hot path. You've made it more complicated for an _extremely_
While the speed improvement might be negligible, there is still no
reason to read individual bytes.
Suggested-by: Paul Spooren
Signed-off-by: Adrian Schmutzler
---
package/base-files/Makefile| 2 +-
package/base-files/files/lib/upgrade/common.sh | 2 +-
2 files changed, 2
