Re: realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-25 Thread Birger Koblitz
Hi, The layer 2 (MAC, VLAN, Ethernet frame contents) offloading in Linux is normally done over tc and not nftabels. With flower you can filter, redirect and modify packets based on VLAN IDs, VLAN PCP, MAC addresses, .. and so on. qdisc allows to configure traffic schedulers to do advance QoS

Re: realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-25 Thread Hauke Mehrtens
On 3/23/22 23:10, Birger Koblitz wrote: Hi, On 23/03/2022 21:09, Sander Vanheule wrote: Hi everyone, One extra argument in favour of keeping the firewall in the default config, is that the devices with more advanced stock FW also provide an ACL feature to filter out traffic based on MAC,

Re: realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-23 Thread Birger Koblitz
Hi, On 23/03/2022 21:09, Sander Vanheule wrote: Hi everyone, One extra argument in favour of keeping the firewall in the default config, is that the devices with more advanced stock FW also provide an ACL feature to filter out traffic based on MAC, IP, ethernet frame contents, etc.

Re: realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-23 Thread Sander Vanheule
Hi everyone, On Thu, 2022-03-03 at 15:58 +0100, Petr Štetiar wrote: > Daniel Golle [2022-03-01 21:11:49]: > > Hi, > > > I fully agree, none of those packages make much sense on this class of > > devices and all of them should be dropped from default installations. > > I think, that if you

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-13 Thread Sander Vanheule
On Tue, 2022-03-01 at 09:09 +0100, Petr Štetiar wrote: > Sander Vanheule [2022-02-28 23:00:34]: > > Hi, > > > Commit 9e7149f729e9 ("realtek: revert to "standard" management > > configuration") changed > > the > > default port configuration for realtek devices to only have LAN ports, > >

realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-03 Thread Petr Štetiar
Daniel Golle [2022-03-01 21:11:49]: Hi, > I fully agree, none of those packages make much sense on this class of > devices and all of them should be dropped from default installations. I think, that if you personaly don't care about other valid use cases, you should at least try to consider

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-02 Thread Raylynn Knight via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- > On Mar 1, 2022, at 4:11 PM,

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-01 Thread Birger Koblitz
Hi, On 01/03/2022 22:11, Daniel Golle wrote: We may need to add a 'switch' DEVICE_TYPE in include/target.mk selecting packages relevant for this class of devices. ('bridge' or 'ip-full', 'ethtool', ...)Indeed, these devices are really not routers. Let's have the right packages for them

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-01 Thread Daniel Golle
On Tue, Mar 01, 2022 at 09:51:32PM +0100, Bjørn Mork wrote: > Petr Štetiar writes: > > > Sander Vanheule [2022-02-28 23:00:34]: > > > >> I wonder if it doesn't make more sense to drop the firewall package from > >> the > >> default now, since there is only one interface, unless there is a

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-01 Thread Bjørn Mork
Petr Štetiar writes: > Sander Vanheule [2022-02-28 23:00:34]: > >> I wonder if it doesn't make more sense to drop the firewall package from the >> default now, since there is only one interface, unless there is a different >> reason to keep the firewall. > > 1. consistency With what exactly?

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-01 Thread Petr Štetiar
Sander Vanheule [2022-02-28 23:00:34]: Hi, > Commit 9e7149f729e9 ("realtek: revert to "standard" management > configuration") changed the > default port configuration for realtek devices to only have LAN ports, > instead of the > LAN/WAN VLANs that were used before. IMO default device

Re: [PATCH 1/2] realtek: Use firewall4

2022-02-28 Thread Petr Štetiar
Hauke Mehrtens [2022-02-28 22:37:29]: > The realtek target is not a router, but basic device, see DEVICE_TYPE. > The basic device type does not come with firewall by default, see > include/target.mk for details. The realtek target extended > DEFAULT_PACKAGES manually with firewall. > > This

Re: [PATCH 1/2] realtek: Use firewall4

2022-02-28 Thread Hauke Mehrtens
On 2/28/22 23:00, Sander Vanheule wrote: Hi Hauke, On Mon, 2022-02-28 at 22:37 +0100, Hauke Mehrtens wrote: The realtek target is not a router, but basic device, see DEVICE_TYPE. The basic device type does not come with firewall by default, see include/target.mk for details. The realtek target

Re: [PATCH 1/2] realtek: Use firewall4

2022-02-28 Thread Sander Vanheule
Hi Hauke, On Mon, 2022-02-28 at 22:37 +0100, Hauke Mehrtens wrote: > The realtek target is not a router, but basic device, see DEVICE_TYPE. > The basic device type does not come with firewall by default, see > include/target.mk for details. The realtek target extended > DEFAULT_PACKAGES manually