Re: [OpenWrt-Devel] netifd: per-interface MTU settings vs per-route MTU settings?

2020-06-01 Thread Reuben Dowle 
When changing an interface MTU direct through ip command, netifd will get be 
out of sync. The netifd internally tracked MTU (discoverable through ubus call 
network.device status '{"name":"xxx"}' call will always show 1500 (or whatever 
the value was when netifd discovered/created the interface).

I am not aware of any actual issues caused by this, but it is worth considering.

Finding some method to update through ubus is preferable in my opinion.

For the project I have been working on, we added a ubus network.device set_attr 
method to netifd to solve this problem – see attached patch. Then you can use 
this in the protocol handler:

[ -n "$mtu" ] && {
echo "Setting MTU to $mtu"
/sbin/ubus call network.device set_attr 
"{\"device\":\"$ifname\", \"mtu\":\"$mtu\"}"
}



[cid:4RFLogo(Custom)(2)_0f31a7de-6dd6-43cf-bc6a-a097a2b80b69.jpg]
Reuben Dowle
Software Architect

Phone:

Fax:
E-Mail:
Website:


+64 4 499 6000

+64 4 473 4447
reuben.do...@4rf.com
Https://www.4rf.com




[cid:Family_53c410b1-7227-4a5f-9acb-f09bd7617a39.png] 

From: openwrt-devel  On Behalf Of 
Michael Jones
Sent: Tuesday, 26 May 2020 5:21 am
To: Aleksander Morgado 
Cc: openwrt-devel 
Subject: Re: [OpenWrt-Devel] netifd: per-interface MTU settings vs per-route 
MTU settings?



On Mon, May 25, 2020 at 8:00 AM Aleksander Morgado 
mailto:aleksan...@aleksander.es>> wrote:
Other protocol handlers, like uqmi, are also able to setup the MTU,
and instead of doing it via proto_send_update, they just do it like
this:

[ -n "$mtu" ] && {
echo "Setting MTU to $mtu"
/sbin/ip link set dev $ifname mtu $mtu
}

I guess we can do the same in the ModemManager protocol handler.

That does seem like it would work, but I'm wary of race conditions with the 
message sent to netifd via ubus, and further feel like it would be better to 
have netifd learn how to set the mtu directly, if it doesn't already know how.

Are any of the netifd project's contributors able to comment on this?


The information in this email communication (inclusive of attachments) is 
confidential to 4RF Limited and the intended recipient(s). If you are not the 
intended recipient(s), please note that any use, disclosure, distribution or 
copying of this information or any part thereof is strictly prohibited and that 
the author accepts no liability for the consequences of any action taken on the 
basis of the information provided. If you have received this email in error, 
please notify the sender immediately by return email and then delete all 
instances of this email from your system. 4RF Limited will not accept 
responsibility for any consequences associated with the use of this email 
(including, but not limited to, damages sustained as a result of any viruses 
and/or any action or lack of action taken in reliance on it).


add_device_attribute_set_ubus.patch
Description: add_device_attribute_set_ubus.patch
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Felix Fietkau 
On 2020-06-01 19:11, Michael Jones wrote:
> 
> 
> On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin  > wrote:
> 
> Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR).
> This allows to do clean and dirclean. Cache hit rate for test build
> after dirclean is ~65%.
> If CCACHE is enabled stats are printed out at the end of building
> process.
> 
> Signed-off-by: Roman Yeryomin mailto:ro...@advem.lv>>
> 
> 
> This certainly looks like an improvement.
> 
> However, there is an important usage case that this change doesn't address.
> 
> Frequently when I am working on OpenWRT related things, I have many
> different workspaces all tied to the same git repository hosted
> externally. The reason for this is to allow multiple builds to live and
> run independently.
> 
> Having the CCACHE_DIR be located *inside* the repository doesn't share
> the cache between multiple workspaces.
> 
> So can the CCACHE_DIR be made configurable at build time based on the
> .config file? Perhaps it can default to this, and only be set to the
> value in .config if provided? For my purposes, I would always set the
> CCACHE_DIR to a path that all of my workspaces use.
I don't think there's a need for that config option. You could simply
add a .ccache symlink in your source dir and point it to your shared
cache. I do the same with dl on my trees.

- Felix

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Petr Štetiar 
Roman Yeryomin  [2020-06-01 18:32:26]:

Hi,

> Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR).

this changes location of ccache directory (people would need to move it,
symlink back or override it) and with CCACHE_BASEDIR it probably also
invalidates the current cache/hashes, doesn't it?

BTW you've missed following hardcoded patterns:

 target/toolchain/Makefile:EXCLUDE_DIRS:=*/ccache
 target/sdk/Makefile:EXCLUDE_DIRS:=*/ccache/*

> This allows to do clean and dirclean.

Isn't it desired to remove potentially broken ccache as well with
clean/dirclean? Do I want to remove my config, downloads, feeds etc. in order
to remove ccache?

> +++ b/include/host-build.mk
> +  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_COMPILERCHECK:=%compiler% 
> -dumpmachine; %compiler% -dumpversion)

you've missed to describe this change

>  distclean:
>   rm -rf bin build_dir .config* dl feeds key-build* logs package/feeds 
> package/openwrt-packages staging_dir tmp
> + rm -rf $(TOPDIR)/.ccache

Other CCACHE_DIR variable occurencies can be overriden, this is hardcoded
path.

Michael Jones  [2020-06-01 13:34:51]:

> Having build behavior change based on a symlink is undesirable.

`make CCACHE_DIR=/whatever` should work as well

> Additionally, having the ccache directory be a configuration option allows
> it to persist across clones of the git repository, if the .config file is
> stored in git.

BTW .config is .gitignored for a reason.

Anyway, I don't think, that bloating the menu config with every Make variable
from now on is desired. System has sane defaults and is flexible enough to
allow fine tunning if needed.

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Michael Jones 
On Mon, Jun 1, 2020 at 1:22 PM Felix Fietkau  wrote:

> On 2020-06-01 19:11, Michael Jones wrote:
> >
> >
> > On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin  > > wrote:
> >
> > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR).
> > This allows to do clean and dirclean. Cache hit rate for test build
> > after dirclean is ~65%.
> > If CCACHE is enabled stats are printed out at the end of building
> > process.
> >
> > Signed-off-by: Roman Yeryomin mailto:ro...@advem.lv
> >>
> >
> >
> > This certainly looks like an improvement.
> >
> > However, there is an important usage case that this change doesn't
> address.
> >
> > Frequently when I am working on OpenWRT related things, I have many
> > different workspaces all tied to the same git repository hosted
> > externally. The reason for this is to allow multiple builds to live and
> > run independently.
> >
> > Having the CCACHE_DIR be located *inside* the repository doesn't share
> > the cache between multiple workspaces.
> >
> > So can the CCACHE_DIR be made configurable at build time based on the
> > .config file? Perhaps it can default to this, and only be set to the
> > value in .config if provided? For my purposes, I would always set the
> > CCACHE_DIR to a path that all of my workspaces use.
> I don't think there's a need for that config option. You could simply
> add a .ccache symlink in your source dir and point it to your shared
> cache. I do the same with dl on my trees.
>
> - Felix
>

I disagree.

Having build behavior change based on a symlink is undesirable.

If it were a config option, it becomes a documented feature that is easily
discoverable in the menu config.

Additionally, having the ccache directory be a configuration option allows
it to persist across clones of the git repository, if the .config file is
stored in git. A symlink would need to be manually re-configured on each
clone.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Roman Yeryomin 
Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR).
This allows to do clean and dirclean. Cache hit rate for test build
after dirclean is ~65%.
If CCACHE is enabled stats are printed out at the end of building process.

Signed-off-by: Roman Yeryomin 
---
 .gitignore| 1 +
 Makefile  | 3 +++
 include/host-build.mk | 4 +++-
 include/package.mk| 4 +++-
 include/toplevel.mk   | 1 +
 rules.mk  | 3 +++
 6 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 6549af83be..b6bfe1a525 100644
--- a/.gitignore
+++ b/.gitignore
@@ -28,3 +28,4 @@ TAGS*~
 git-src
 .project
 .cproject
+.ccache
diff --git a/Makefile b/Makefile
index 32c050bb48..dfeaf83e2c 100644
--- a/Makefile
+++ b/Makefile
@@ -119,6 +119,9 @@ world: prepare $(target/stamp-compile) 
$(package/stamp-compile) $(package/stamp-
$(_SINGLE)$(SUBMAKE) -r package/index
$(_SINGLE)$(SUBMAKE) -r json_overview_image_info
$(_SINGLE)$(SUBMAKE) -r checksum
+ifneq ($(CONFIG_CCACHE),)
+   $(STAGING_DIR_HOST)/bin/ccache -s
+endif
 
 .PHONY: clean dirclean prereq prepare world package/symlinks 
package/symlinks-install package/symlinks-clean
 
diff --git a/include/host-build.mk b/include/host-build.mk
index 9fc14241c6..4adac0883e 100644
--- a/include/host-build.mk
+++ b/include/host-build.mk
@@ -132,7 +132,9 @@ define Host/Exports/Default
   $(1) : export STAGING_PREFIX=$$(HOST_BUILD_PREFIX)
   $(1) : export 
PKG_CONFIG_PATH=$$(STAGING_DIR_HOST)/lib/pkgconfig:$$(HOST_BUILD_PREFIX)/lib/pkgconfig
   $(1) : export PKG_CONFIG_LIBDIR=$$(HOST_BUILD_PREFIX)/lib/pkgconfig
-  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_DIR:=$(STAGING_DIR_HOST)/ccache)
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_BASEDIR:=$(TOPDIR))
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_DIR:=$(TOPDIR)/.ccache)
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_COMPILERCHECK:=%compiler% 
-dumpmachine; %compiler% -dumpversion)
   $(if $(HOST_CONFIG_SITE),$(1) : export CONFIG_SITE:=$(HOST_CONFIG_SITE))
   $(if $(IS_PACKAGE_BUILD),$(1) : export PATH=$$(TARGET_PATH_PKG))
 endef
diff --git a/include/package.mk b/include/package.mk
index 0575692742..eee5bbbf80 100644
--- a/include/package.mk
+++ b/include/package.mk
@@ -173,7 +173,9 @@ define Build/Exports/Default
   $(1) : export CONFIG_SITE:=$$(CONFIG_SITE)
   $(1) : export PKG_CONFIG_PATH:=$$(PKG_CONFIG_PATH)
   $(1) : export PKG_CONFIG_LIBDIR:=$$(PKG_CONFIG_PATH)
-  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_DIR:=$(STAGING_DIR)/ccache)
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_BASEDIR:=$(TOPDIR))
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_DIR:=$(TOPDIR)/.ccache)
+  $(if $(CONFIG_CCACHE),$(1) : export CCACHE_COMPILERCHECK:=%compiler% 
-dumpmachine; %compiler% -dumpversion)
 endef
 Build/Exports=$(Build/Exports/Default)
 
diff --git a/include/toplevel.mk b/include/toplevel.mk
index 5cf93ce7ef..f4a9dccd5e 100644
--- a/include/toplevel.mk
+++ b/include/toplevel.mk
@@ -253,6 +253,7 @@ help:
 
 distclean:
rm -rf bin build_dir .config* dl feeds key-build* logs package/feeds 
package/openwrt-packages staging_dir tmp
+   rm -rf $(TOPDIR)/.ccache
@$(_SINGLE)$(SUBMAKE) -C scripts/config clean
 
 ifeq ($(findstring v,$(DEBUG)),)
diff --git a/rules.mk b/rules.mk
index 66ddea2883..fb2f6bf57f 100644
--- a/rules.mk
+++ b/rules.mk
@@ -298,6 +298,9 @@ ifneq ($(CONFIG_CCACHE),)
   TARGET_CXX:= ccache_cxx
   HOSTCC:= ccache $(HOSTCC)
   HOSTCXX:= ccache $(HOSTCXX)
+  export CCACHE_BASEDIR:=$(TOPDIR)
+  export CCACHE_DIR:=$(TOPDIR)/.ccache
+  export CCACHE_COMPILERCHECK:=%compiler% -dumpmachine; %compiler% -dumpversion
 endif
 
 TARGET_CONFIGURE_OPTS = \
-- 
2.20.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] octeontx: enable Cavium CPT and ZIP drivers

2020-06-01 Thread Tim Harvey 
The CPT module requires firmware which we add here as well.

Signed-off-by: Tim Harvey 
---
 target/linux/octeontx/config-5.4 |  11 +++
 target/linux/octeontx/files/firmware/cpt8x-mc-ae.out | Bin 0 -> 9760 bytes
 target/linux/octeontx/files/firmware/cpt8x-mc-se.out | Bin 0 -> 35584 bytes
 3 files changed, 11 insertions(+)
 create mode 100644 target/linux/octeontx/files/firmware/cpt8x-mc-ae.out
 create mode 100644 target/linux/octeontx/files/firmware/cpt8x-mc-se.out

diff --git a/target/linux/octeontx/config-5.4 b/target/linux/octeontx/config-5.4
index cfb8b19..9fcd12b 100644
--- a/target/linux/octeontx/config-5.4
+++ b/target/linux/octeontx/config-5.4
@@ -134,6 +134,7 @@ CONFIG_BLK_MQ_PCI=y
 CONFIG_BLK_MQ_VIRTIO=y
 CONFIG_BLK_PM=y
 CONFIG_BLK_SCSI_REQUEST=y
+CONFIG_CAVIUM_CPT=y
 CONFIG_CAVIUM_ERRATUM_22375=y
 CONFIG_CAVIUM_ERRATUM_23144=y
 CONFIG_CAVIUM_ERRATUM_23154=y
@@ -169,6 +170,7 @@ CONFIG_CRC16=y
 CONFIG_CRC7=y
 CONFIG_CRC_ITU_T=y
 CONFIG_CRC_T10DIF=y
+CONFIG_CRYPTO_ACOMP2=y
 CONFIG_CRYPTO_AEAD=y
 CONFIG_CRYPTO_AEAD2=y
 CONFIG_CRYPTO_AES_ARM64=y
@@ -183,6 +185,9 @@ CONFIG_CRYPTO_CRC32C=y
 CONFIG_CRYPTO_CRCT10DIF=y
 # CONFIG_CRYPTO_CRCT10DIF_ARM64_CE is not set
 CONFIG_CRYPTO_CRYPTD=y
+CONFIG_CRYPTO_DEFLATE=y
+CONFIG_CRYPTO_DEV_CAVIUM_ZIP=y
+CONFIG_CRYPTO_DEV_CPT=y
 CONFIG_CRYPTO_DRBG=y
 CONFIG_CRYPTO_DRBG_HMAC=y
 CONFIG_CRYPTO_DRBG_MENU=y
@@ -192,6 +197,7 @@ CONFIG_CRYPTO_GHASH_ARM64_CE=y
 CONFIG_CRYPTO_HASH=y
 CONFIG_CRYPTO_HASH2=y
 CONFIG_CRYPTO_HMAC=y
+CONFIG_CRYPTO_HW=y
 CONFIG_CRYPTO_JITTERENTROPY=y
 CONFIG_CRYPTO_LIB_SHA256=y
 CONFIG_CRYPTO_MANAGER=y
@@ -233,6 +239,8 @@ CONFIG_EEPROM_AT24=y
 CONFIG_EFI_EARLYCON=y
 CONFIG_EXT4_FS=y
 CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_EXTRA_FIRMWARE="cpt8x-mc-ae.out cpt8x-mc-se.out"
+CONFIG_EXTRA_FIRMWARE_DIR="firmware"
 CONFIG_F2FS_FS=y
 CONFIG_F2FS_FS_XATTR=y
 CONFIG_F2FS_STAT_FS=y
@@ -536,6 +544,7 @@ CONFIG_SERIAL_MCTRL_GPIO=y
 CONFIG_SERIAL_OF_PLATFORM=y
 CONFIG_SERIAL_XILINX_PS_UART=y
 CONFIG_SERIAL_XILINX_PS_UART_CONSOLE=y
+CONFIG_SGL_ALLOC=y
 CONFIG_SG_POOL=y
 CONFIG_SMP=y
 CONFIG_SPARSEMEM=y
@@ -599,4 +608,6 @@ CONFIG_WATCHDOG_CORE=y
 CONFIG_XARRAY_MULTI=y
 CONFIG_XPS=y
 CONFIG_XXHASH=y
+CONFIG_ZLIB_DEFLATE=y
+CONFIG_ZLIB_INFLATE=y
 CONFIG_ZONE_DMA32=y
diff --git a/target/linux/octeontx/files/firmware/cpt8x-mc-ae.out 
b/target/linux/octeontx/files/firmware/cpt8x-mc-ae.out
new file mode 100644
index 
..39e63398fea133f1a882ceef432adaf8f051787a
GIT binary patch
literal 9760
zcma(%3s@B8+A{;}%wE_*Qc2RBUD(Ua?y_VOm5F0oN4$|#URd#hc*&?Zn(Morht9SwIbW+pfaud9rEcK}Wsl-J?`!%{AJ(c>u-wXuxoSy%eN9LRF^4`Ap
zK9FN3zwr1f$D}ci(a$(0jZU8Ih>wqdgy{1xGP}dnwKLh{hNPkA`Ro(qfKljYw_ug^QC3+AY()tdG0?~9ki6#^A
zQ+MA93_xK>m5=ES6~`3a#}5(K>oH4#K040tip6?7ElhD2%|b6>i{*OQ22)H>g2
z5``1!G1xT#PI#Of3D~pv4ufo8$3zSHYSqFBHgvNqw~0Z>Z2vkCW;9woEJ-5%1KS5A
zLMm2V_+qc3O!PfZQx?vfeEB+L`5dU8A@*|F5XM95nx!KhjSn;pU
zwrpGHne6A3_u=-=w?^I}4DXM4g^o!5uY#B264eqstSJ7>#2;&78G3Enb(V)
z9UZNYsIPw1Pd8%Hgem=^uU_caZ$y(ky39uOiv=nk&>WT`M|5bXtZ`~p_Mk9$)I@tQ
zrVKw>!g1M@<9t^LI*jU2w`DRJG1XpX^X?uk?0((BsxU5VM|*fhVj+(+|=iVq74D_OAU5|7KM}(48W~qUZ-zlmf|LEef_^%-iDgbUR8ApTiR6
zgWP(4kala*&(<{2;-nP~0;s0Oe~x!<2;2k;26=fEwlquFb(bFtuww
zWy&;LB}yG3_0vw5wDwON!K$@6E12mLBhP(^XEZ-a(JX0pQ^QHZDoxrU4?

Re: [OpenWrt-Devel] [PATCH] octeontx: enable Cavium CPT and ZIP drivers

2020-06-01 Thread Hauke Mehrtens 
On 6/1/20 6:00 PM, Tim Harvey wrote:
> The CPT module requires firmware which we add here as well.
> 
> Signed-off-by: Tim Harvey 
> ---
>  target/linux/octeontx/config-5.4 |  11 +++
>  target/linux/octeontx/files/firmware/cpt8x-mc-ae.out | Bin 0 -> 9760 bytes
>  target/linux/octeontx/files/firmware/cpt8x-mc-se.out | Bin 0 -> 35584 bytes
>  3 files changed, 11 insertions(+)
>  create mode 100644 target/linux/octeontx/files/firmware/cpt8x-mc-ae.out
>  create mode 100644 target/linux/octeontx/files/firmware/cpt8x-mc-se.out

Please add a license file for these firmware binaries.

Hauke



signature.asc
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Michael Jones 
On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin  wrote:

> Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR).
> This allows to do clean and dirclean. Cache hit rate for test build
> after dirclean is ~65%.
> If CCACHE is enabled stats are printed out at the end of building process.
>
> Signed-off-by: Roman Yeryomin 
>

This certainly looks like an improvement.

However, there is an important usage case that this change doesn't address.

Frequently when I am working on OpenWRT related things, I have many
different workspaces all tied to the same git repository hosted externally.
The reason for this is to allow multiple builds to live and run
independently.

Having the CCACHE_DIR be located *inside* the repository doesn't share the
cache between multiple workspaces.

So can the CCACHE_DIR be made configurable at build time based on the
.config file? Perhaps it can default to this, and only be set to the value
in .config if provided? For my purposes, I would always set the CCACHE_DIR
to a path that all of my workspaces use.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

2020-06-01 Thread Petr Štetiar 
Matthias Schiffer  [2020-05-31 11:08:47]:

Hi,

> For patch 4, I'd like to have an ACK from someone familiar with the buildbot
> setup.

Disclaimer: I'm Buildbot setup noob, just helping occasionally with the
maintenance burden, but from my limited understanding it's not just about ACK,
some additional work is needed:

 1. Someone has to provide patches against Buildbot[1] repo with the zstd
naming changes
 2. Someone has to build and publish updated Docker images for buildbot 
master/slave
 3. Someone has to deploy this on machines under our control (having root
access), we need to notify owners of the buildslave machines to upgrade 
their
buildslaves to the updated Docker images built/published in step 2. 

I can probably help with 2. and 3., I would ideally done this with Buildbot
version bump which is in the works[1], so we don't bother people with
buildslaves upgrades that often.

1. https://git.openwrt.org/?p=buildbot.git
2. 
https://git.openwrt.org/?p=buildbot.git;a=shortlog;h=refs/heads/buildbot-2.4.1

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

2020-06-01 Thread Etienne Champetier 
Hi Petr and Matthias

Le lun. 1 juin 2020 à 06:21, Petr Štetiar  a écrit :

> Matthias Schiffer  [2020-05-31 11:08:47]:
>
> Hi,
>
> > For patch 4, I'd like to have an ACK from someone familiar with the
> buildbot
> > setup.
>
> Disclaimer: I'm Buildbot setup noob, just helping occasionally with the
> maintenance burden, but from my limited understanding it's not just about
> ACK,
> some additional work is needed:
>
>  1. Someone has to provide patches against Buildbot[1] repo with the zstd
> naming changes
>  2. Someone has to build and publish updated Docker images for buildbot
> master/slave
>  3. Someone has to deploy this on machines under our control (having root
> access), we need to notify owners of the buildslave machines to
> upgrade their
> buildslaves to the updated Docker images built/published in step 2.
>

4. Fixup some of the feed repo CI
https://github.com/openwrt/packages/blob/master/.circleci/config.yml#L9
https://github.com/openwrt/telephony/blob/master/.circleci/config.yml#L9
(not sure the docker image has zstd, might also need to rebuild it)

Regards
Etienne


> I can probably help with 2. and 3., I would ideally done this with Buildbot
> version bump which is in the works[1], so we don't bother people with
> buildslaves upgrades that often.
>
> 1. https://git.openwrt.org/?p=buildbot.git
> 2.
> https://git.openwrt.org/?p=buildbot.git;a=shortlog;h=refs/heads/buildbot-2.4.1
>
> -- ynezz
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

2020-06-01 Thread Matthias Schiffer 
On 6/1/20 12:21 PM, Petr Štetiar wrote:
> Matthias Schiffer  [2020-05-31 11:08:47]:
> 
> Hi,
> 
>> For patch 4, I'd like to have an ACK from someone familiar with the buildbot
>> setup.
> 
> Disclaimer: I'm Buildbot setup noob, just helping occasionally with the
> maintenance burden, but from my limited understanding it's not just about ACK,
> some additional work is needed:
> 
>  1. Someone has to provide patches against Buildbot[1] repo with the zstd
> naming changes

I can write the patch, but it seems this is only a default value, and the
config file defines the actual value - which makes sense, as only master
snapshots would use the new value, while 19.07 and older would still use
.xz. Where are these per-instances variables defined?

Matthias



>  2. Someone has to build and publish updated Docker images for buildbot 
> master/slave
>  3. Someone has to deploy this on machines under our control (having root
> access), we need to notify owners of the buildslave machines to upgrade 
> their
> buildslaves to the updated Docker images built/published in step 2. 
> 
> I can probably help with 2. and 3., I would ideally done this with Buildbot
> version bump which is in the works[1], so we don't bother people with
> buildslaves upgrades that often.
> 
> 1. https://git.openwrt.org/?p=buildbot.git
> 2. 
> https://git.openwrt.org/?p=buildbot.git;a=shortlog;h=refs/heads/buildbot-2.4.1
> 
> -- ynezz
> 




signature.asc
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

2020-06-01 Thread Petr Štetiar 
Matthias Schiffer  [2020-06-01 14:38:16]:

Hi,

> On 6/1/20 12:21 PM, Petr Štetiar wrote:
> > 
> >  1. Someone has to provide patches against Buildbot[1] repo with the zstd
> > naming changes
> 
> I can write the patch, but it seems this is only a default value, and the
> config file defines the actual value - which makes sense, as only master
> snapshots would use the new value, while 19.07 and older would still use
> .xz. Where are these per-instances variables defined?

Ah, right, it's in roles/buildslave/templates/config.ini.j2 in ansible.git

 [rsync]
 {% if master_data.branch == "master" %}
 sdk_pattern = openwrt-sdk-*.tar.xz
 {% else %}
 sdk_pattern = {{ distribution }}-sdk-*.tar.xz
 {% endif %}

I can change this Ansible part once needed.

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel