[OpenWrt-Devel] NOHZ: local_softirq_pending 08 -- IPQ4019 on master

2019-06-22 Thread Jeff Kletsky

Just flashed a build off `master` and am seeing "new" error messages
starting after the network has started, a couple times,
then every 20 seconds, seemingly like clockwork.

root@test:/# dmesg | fgrep NOHZ
[   36.955401] NOHZ: local_softirq_pending 08
[   57.439420] NOHZ: local_softirq_pending 08
[   98.397107] NOHZ: local_softirq_pending 08
[  118.881226] NOHZ: local_softirq_pending 08
[  139.356879] NOHZ: local_softirq_pending 08
[  159.840218] NOHZ: local_softirq_pending 08
[  180.315962] NOHZ: local_softirq_pending 08
[  200.799979] NOHZ: local_softirq_pending 08
[  221.275747] NOHZ: local_softirq_pending 08
[  241.756644] NOHZ: local_softirq_pending 08

Still looking into it, but curious if anyone else is seeing this.

Linux 4.19.53

commit 629e6538a1 (openwrt/master, openwrt/HEAD, master)
Author: Christian Lamparter 
Date:   Sat Jun 22 12:23:10 2019 +0200


Similar behavior on the alternate firmware on the device

commit eaad2211db
Author: Jo-Philipp Wich 
Date:   Fri Jun 21 17:41:28 2019 +0200

root@test:/# dmesg | fgrep NOHZ
[   56.800024] NOHZ: local_softirq_pending 08
[   77.281594] NOHZ: local_softirq_pending 08
[   97.763395] NOHZ: local_softirq_pending 08
[  138.718065] NOHZ: local_softirq_pending 08
[  138.720722] NOHZ: local_softirq_pending 08
[  159.197431] NOHZ: local_softirq_pending 08
[  200.157115] NOHZ: local_softirq_pending 08
[  220.636004] NOHZ: local_softirq_pending 08
[  241.116778] NOHZ: local_softirq_pending 08
[  241.119413] NOHZ: local_softirq_pending 08


Some mention of `NOHZ: local_softirq_pending 08` back in 2012
https://groups.google.com/forum/#!topic/linux.kernel/YeH1CTNT9vU

Other mention at
https://askubuntu.com/questions/878030/occasional-dmesg-log-nohz-local-softirq-pending-08


Add nohz=off to the kernel parameters during boot to disable it.


This option causes RCU to attempt to accelerate grace periods
in order to allow CPUs to enter dynticks-idle state more quickly.
On the other hand, this option increases the overhead
of the dynticks-idle checking, particularly on systems
with large numbers of CPUs.


I'm not sure I'd consider an IPQ4019 to have "large numbers of CPUs"
but I figured I'd lay out what I have found so far.


Jeff

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] toolchain: Don't force GCC8 on ARC

2019-06-22 Thread Rosen Penev
On Sat, Jun 22, 2019 at 7:37 AM Christian Lamparter  wrote:
>
> On Thursday, June 20, 2019 9:33:04 PM CEST Rosen Penev wrote:
> > This prevents overriding it to use GCC9.
> >
> > Signed-off-by: Rosen Penev 
> > ---
> >  toolchain/gcc/Config.version | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/toolchain/gcc/Config.version b/toolchain/gcc/Config.version
> > index ef9bbb82e2..e635244827 100644
> > --- a/toolchain/gcc/Config.version
> > +++ b/toolchain/gcc/Config.version
> > @@ -4,7 +4,6 @@ config GCC_VERSION_5
> >
> >  config GCC_VERSION_8
> >   default y if GCC_USE_VERSION_8
> > - default y if arc
> >   bool
> >
> >  config GCC_VERSION_9
> >
> From what I know this would select the default GCC 7.4.
It does. On the other hand, if you select Advanced options and select
to build GCC9, it still builds GCC8.
> Do you know if the special ARC patches got into the 7.x branch?
They did not. GCC8 is definitely a minimum. But there's the problem above.
> Because from what I can tell (from 7.1) this was a problem and
> the reason why GCC 8 was selected since it had the patches from
> the beginning.
>
> Regards,
> Christian
>
>

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] toolchain: Don't force GCC8 on ARC

2019-06-22 Thread Christian Lamparter
On Thursday, June 20, 2019 9:33:04 PM CEST Rosen Penev wrote:
> This prevents overriding it to use GCC9.
> 
> Signed-off-by: Rosen Penev 
> ---
>  toolchain/gcc/Config.version | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/toolchain/gcc/Config.version b/toolchain/gcc/Config.version
> index ef9bbb82e2..e635244827 100644
> --- a/toolchain/gcc/Config.version
> +++ b/toolchain/gcc/Config.version
> @@ -4,7 +4,6 @@ config GCC_VERSION_5
>  
>  config GCC_VERSION_8
>   default y if GCC_USE_VERSION_8
> - default y if arc
>   bool
>  
>  config GCC_VERSION_9
> 
>From what I know this would select the default GCC 7.4.
Do you know if the special ARC patches got into the 7.x branch?
Because from what I can tell (from 7.1) this was a problem and
the reason why GCC 8 was selected since it had the patches from
the beginning.

Regards,
Christian



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] ramips: mt7621: Add new device AsiaRF AP7621-001

2019-06-22 Thread Rafał Miłecki

On 21.06.2019 17:50, Daniel Danzberger wrote:

diff --git a/target/linux/ramips/dts/AP7621-001.dts 
b/target/linux/ramips/dts/AP7621-001.dts
new file mode 100644
index 00..587c26457e
--- /dev/null
+++ b/target/linux/ramips/dts/AP7621-001.dts
@@ -0,0 +1,157 @@
+/dts-v1/;


Please include licensing info for your DTS file, see
https://openwrt.org/submitting-patches#dts_checklist
e.g. a line like:
`// SPDX-License-Identifier: GPL-2.0-or-later OR MIT`
above the `/dts-v1/;`



+m25p80@0 {
+#address-cells = <1>;
+#size-cells = <1>;
+compatible = "jedec,spi-nor";
+reg = <0>;
+spi-max-frequency = <1000>;
+m25p,chunked-io = <32>;
+
+partition@0 {
+label = "u-boot";
+reg = <0x0 0x3>;
+read-only;
+};


Use "partitions" subnode for storing all partition nodes.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in 10_fix_wifi_mac

2019-06-22 Thread mail
Hi,

> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Jonas Gorski
> Sent: Samstag, 22. Juni 2019 14:14
> To: Adrian Schmutzler 
> Cc: OpenWrt Development List 
> Subject: Re: [OpenWrt-Devel] [PATCH 1/2] openwrt-19.07: ath79: Code style
> fixes in 10_fix_wifi_mac
> 
> Hi,
> 
> On Sat, 22 Jun 2019 at 11:33, Adrian Schmutzler
>  wrote:
> > Subject: [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in
> > 10_fix_wifi_mac
> 
> the openwrt-19.07 belongs between the [ ], so [PATCH openwrt-19.07 1/2].

okay, I will do that next time.

> 
> >
> > This fixes one comparison and several useless echos.
> >
> > Signed-off-by: Adrian Schmutzler 
> 
> Are these fixes present in master? If no, then please submit these for
> master. If yes, please generate these patches with cherry-pick -x, so they
> have a reference to the master commit (makes it easier to see if these are
> backports or not).

The patch for master is the direct predecessor in patchwork:
https://patchwork.ozlabs.org/patch/1120551/
(Unfortunately the commit title is not exactly the same.)

I like to send master and backport patches (if there are any) in one bunch. If 
this is discouraged, please tell me.

Note that for ar71xx I only sent a patch for openwrt-19.07 (2/2), since I see 
no point to still patch in master.
If I'm supposed to patch ar71xx in master first although it is semi-retired, 
please tell me.

Thanks for your input.

Best

Adrian

> 
> 
> Regards
> Jonas
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] lua5.3: package Lua 5.3 version

2019-06-22 Thread Rafał Miłecki
From: Rafał Miłecki 

This package provides an interpreter and compiler for Lua 5.3.5. It has
been decided to use separated package due to a backward incompatibility
of Lua 5.2 and 5.3.

This package/version:
1) Does not include lnum patch as its author didn't decide to port it to
   the new version.
2) Does not provide shared library as the old patch doesn't apply
   anymore. It can be added later if needed.
3) Does not come with examples package as tests were dropped by upstream
   developers.

That said there is definitely a room for improvement and any further
work is highly appreciated. It works however and can be safely pushed as
a basic/early package release.

Signed-off-by: Rafał Miłecki 
---
 package/utils/lua5.3/Makefile | 127 ++
 .../001-include-version-number.patch  |  67 +
 .../lua5.3/patches-host/100-no_readline.patch |  54 
 .../patches/001-include-version-number.patch  |  67 +
 .../lua5.3/patches/100-no_readline.patch  |  54 
 5 files changed, 369 insertions(+)
 create mode 100644 package/utils/lua5.3/Makefile
 create mode 100644 
package/utils/lua5.3/patches-host/001-include-version-number.patch
 create mode 100644 package/utils/lua5.3/patches-host/100-no_readline.patch
 create mode 100644 
package/utils/lua5.3/patches/001-include-version-number.patch
 create mode 100644 package/utils/lua5.3/patches/100-no_readline.patch

diff --git a/package/utils/lua5.3/Makefile b/package/utils/lua5.3/Makefile
new file mode 100644
index 00..f308fe6c1a
--- /dev/null
+++ b/package/utils/lua5.3/Makefile
@@ -0,0 +1,127 @@
+#
+# Copyright (C) 2006-2014 OpenWrt.org
+#
+# This is free software, licensed under the GNU General Public License v2.
+# See /LICENSE for more information.
+#
+
+include $(TOPDIR)/rules.mk
+
+PKG_NAME:=lua
+PKG_VERSION:=5.3.5
+PKG_RELEASE:=1
+
+PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
+PKG_SOURCE_URL:=http://www.lua.org/ftp/ \
+   http://www.tecgraf.puc-rio.br/lua/ftp/
+PKG_HASH:=0c2eed3f960446e1a3e4b9a1ca2f3ff893b6ce41942cf54d5dd59ab4b3b058ac
+PKG_BUILD_PARALLEL:=1
+
+PKG_LICENSE:=MIT
+PKG_LICENSE_FILES:=COPYRIGHT
+
+HOST_PATCH_DIR := ./patches-host
+
+include $(INCLUDE_DIR)/package.mk
+include $(INCLUDE_DIR)/host-build.mk
+
+define Package/lua5.3/Default
+  SUBMENU:=Lua
+  SECTION:=lang
+  CATEGORY:=Languages
+  TITLE:=Lua programming language
+  URL:=http://www.lua.org/
+  MAINTAINER:=Jo-Philipp Wich 
+endef
+
+define Package/lua5.3/Default/description
+  Lua is a powerful, efficient, lightweight, embeddable scripting language. It
+  supports procedural programming, object-oriented programming, functional
+  programming, data-driven programming, and data description.
+endef
+
+define Package/lua5.3
+$(call Package/lua5.3/Default)
+  TITLE+= (interpreter)
+  PROVIDES:=lua
+endef
+
+define Package/lua5.3/description
+$(call Package/lua5.3/Default/description)
+  This package contains the Lua language interpreter.
+endef
+
+define Package/luac5.3
+$(call Package/lua5.3/Default)
+  TITLE+= (compiler)
+  PROVIDES:=luac
+endef
+
+define Package/luac5.3/description
+$(call Package/lua5.3/Default/description)
+  This package contains the Lua language compiler.
+endef
+
+TARGET_CFLAGS += -DLUA_USE_LINUX $(FPIC) -std=gnu99
+
+define Build/Compile
+   $(MAKE) $(PKG_JOBS) -C $(PKG_BUILD_DIR) \
+   CC="$(TARGET_CROSS)gcc" \
+   AR="$(TARGET_CROSS)ar rcu" \
+   RANLIB="$(TARGET_CROSS)ranlib" \
+   INSTALL_ROOT=/usr \
+   CFLAGS="$(TARGET_CPPFLAGS) $(TARGET_CFLAGS)" \
+   PKG_VERSION=$(PKG_VERSION) \
+   linux
+   rm -rf $(PKG_INSTALL_DIR)
+   mkdir -p $(PKG_INSTALL_DIR)
+   $(MAKE) -C $(PKG_BUILD_DIR) \
+   INSTALL_TOP="$(PKG_INSTALL_DIR)/usr" \
+   install
+endef
+
+define Host/Configure
+   $(SED) 's,"/usr/local/","$(STAGING_DIR_HOSTPKG)/",' 
$(HOST_BUILD_DIR)/src/luaconf.h
+endef
+
+ifeq ($(HOST_OS),Darwin)
+   LUA_OS:=macosx
+else
+   ifeq ($(HOST_OS),FreeBSD)
+   LUA_OS:=freebsd
+   else
+   LUA_OS:=linux
+   endif
+endif
+
+define Host/Compile
+   $(MAKE) -C $(HOST_BUILD_DIR) \
+   CC="$(HOSTCC) -std=gnu99" \
+   $(LUA_OS)
+endef
+
+define Host/Install
+   $(MAKE) -C $(HOST_BUILD_DIR) \
+   INSTALL_TOP="$(STAGING_DIR_HOSTPKG)" \
+   install
+endef
+
+define Build/InstallDev
+   $(INSTALL_DIR) $(1)/usr/include
+   $(CP) $(PKG_INSTALL_DIR)/usr/include/lua5.3/lua{,lib,conf}.h 
$(1)/usr/include/
+   $(CP) $(PKG_INSTALL_DIR)/usr/include/lua5.3/lauxlib.h $(1)/usr/include/
+endef
+
+define Package/lua5.3/install
+   $(INSTALL_DIR) $(1)/usr/bin
+   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/lua5.3 $(1)/usr/bin/
+endef
+
+define Package/luac5.3/install
+   $(INSTALL_DIR) $(1)/usr/bin
+   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/luac5.3 $(1)/usr/bin/
+endef
+
+$(e

Re: [OpenWrt-Devel] Dependency problem after changing package name

2019-06-22 Thread Jonas Gorski
On Sat, 22 Jun 2019 at 13:50, Rafał Miłecki  wrote:
>
> On 22.06.2019 13:37, Rafał Miłecki wrote:
> > I renamed locally package "lua" to "luax" and updated dependency of
> > "lua-examples". A pretty simple change.
> >
> >
> > After that change I can't build OpenWrt anymore.
> >
> > # make V=s
> > (...)
> > Collected errors:
> >   * satisfy_dependencies_for: Cannot satisfy the following dependencies for 
> > lua-examples:
> >   *  luax
> >   * opkg_install_cmd: Cannot install package lua-examples.
> > make[2]: *** [package/Makefile:68: package/install] Error 255
> > (...)
>
> Jonas has just helped me. I forgot to change
> Package/lua/install
> to
> Package/luax/install
>
> Is that possible to make error message somehow more meaningful?

At this stage the damage is already done, and opkg does not know about
any of the Makefile stuff. We can try to warn when creating the ipks
though; something like
https://git.openwrt.org/76971461b77d8ace7c4ff208de0510301e75ecc1
should do the trick.


Regards
Jonas


>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in 10_fix_wifi_mac

2019-06-22 Thread Jonas Gorski
Hi,

On Sat, 22 Jun 2019 at 11:33, Adrian Schmutzler
 wrote:
> Subject: [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in 10_fix_wifi_mac

the openwrt-19.07 belongs between the [ ], so [PATCH openwrt-19.07 1/2].

>
> This fixes one comparison and several useless echos.
>
> Signed-off-by: Adrian Schmutzler 

Are these fixes present in master? If no, then please submit these for
master. If yes, please generate these patches with cherry-pick -x, so
they have a reference to the master commit (makes it easier to see if
these are backports or not).


Regards
Jonas

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH V2 1/2] lua: include version number in installed files

2019-06-22 Thread Rafał Miłecki
From: Rafał Miłecki 

This will allow installing Lua 5.1 and newer versions at the same time.

Signed-off-by: Rafał Miłecki 
---
V2: Bump PKG_RELEASE
---
 package/utils/lua/Makefile|  8 ++--
 .../001-include-version-number.patch  | 48 +++
 .../patches/001-include-version-number.patch  | 48 +++
 .../013-lnum-strtoul-parsing-fixes.patch  | 11 +
 .../utils/lua/patches/020-shared_liblua.patch |  8 ++--
 5 files changed, 107 insertions(+), 16 deletions(-)
 create mode 100644 
package/utils/lua/patches-host/001-include-version-number.patch
 create mode 100644 package/utils/lua/patches/001-include-version-number.patch

diff --git a/package/utils/lua/Makefile b/package/utils/lua/Makefile
index 077a60fbf3..c911c6a913 100644
--- a/package/utils/lua/Makefile
+++ b/package/utils/lua/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=lua
 PKG_VERSION:=5.1.5
-PKG_RELEASE:=3
+PKG_RELEASE:=4
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 PKG_SOURCE_URL:=http://www.lua.org/ftp/ \
@@ -154,12 +154,14 @@ endef
 
 define Package/lua/install
$(INSTALL_DIR) $(1)/usr/bin
-   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/lua $(1)/usr/bin/
+   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/lua5.1 $(1)/usr/bin/
+   $(LN) lua5.1 $(1)/usr/bin/lua
 endef
 
 define Package/luac/install
$(INSTALL_DIR) $(1)/usr/bin
-   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/luac $(1)/usr/bin/
+   $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/luac5.1 $(1)/usr/bin/
+   $(LN) luac5.1 $(1)/usr/bin/luac
 endef
 
 define Package/lua-examples/install
diff --git a/package/utils/lua/patches-host/001-include-version-number.patch 
b/package/utils/lua/patches-host/001-include-version-number.patch
new file mode 100644
index 00..b7056fd47c
--- /dev/null
+++ b/package/utils/lua/patches-host/001-include-version-number.patch
@@ -0,0 +1,48 @@
+From 96576b44a1b368bd6590eb0778ae45cc9ccede3f Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= 
+Date: Fri, 21 Jun 2019 14:08:38 +0200
+Subject: [PATCH] include version number
+
+Including it allows multiple lua versions to coexist.
+
+Signed-off-by: Rafał Miłecki 
+---
+
+diff --git a/Makefile b/Makefile
+--- a/Makefile
 b/Makefile
+@@ -41,10 +41,10 @@ RANLIB= ranlib
+ PLATS= aix ansi bsd freebsd generic linux macosx mingw posix solaris
+ 
+ # What to install.
+-TO_BIN= lua luac
++TO_BIN= lua$V luac$V
+ TO_INC= lua.h luaconf.h lualib.h lauxlib.h ../etc/lua.hpp
+ TO_LIB= liblua.a
+-TO_MAN= lua.1 luac.1
++TO_MAN= lua$V.1 luac$V.1
+ 
+ # Lua version and release.
+ V= 5.1
+diff --git a/doc/lua.1 b/doc/lua5.1.1
+rename from doc/lua.1
+rename to doc/lua5.1.1
+diff --git a/doc/luac.1 b/doc/luac5.1.1
+rename from doc/luac.1
+rename to doc/luac5.1.1
+diff --git a/src/Makefile b/src/Makefile
+--- a/src/Makefile
 b/src/Makefile
+@@ -29,10 +29,10 @@ CORE_O=lapi.o lcode.o ldebug.o ldo.o ldump.o lfunc.o 
lgc.o llex.o lmem.o \
+ LIB_O=lauxlib.o lbaselib.o ldblib.o liolib.o lmathlib.o loslib.o 
ltablib.o \
+   lstrlib.o loadlib.o linit.o
+ 
+-LUA_T=lua
++LUA_T=lua$V
+ LUA_O=lua.o
+ 
+-LUAC_T=   luac
++LUAC_T=   luac$V
+ LUAC_O=   luac.o print.o
+ 
+ ALL_O= $(CORE_O) $(LIB_O) $(LUA_O) $(LUAC_O)
diff --git a/package/utils/lua/patches/001-include-version-number.patch 
b/package/utils/lua/patches/001-include-version-number.patch
new file mode 100644
index 00..b7056fd47c
--- /dev/null
+++ b/package/utils/lua/patches/001-include-version-number.patch
@@ -0,0 +1,48 @@
+From 96576b44a1b368bd6590eb0778ae45cc9ccede3f Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= 
+Date: Fri, 21 Jun 2019 14:08:38 +0200
+Subject: [PATCH] include version number
+
+Including it allows multiple lua versions to coexist.
+
+Signed-off-by: Rafał Miłecki 
+---
+
+diff --git a/Makefile b/Makefile
+--- a/Makefile
 b/Makefile
+@@ -41,10 +41,10 @@ RANLIB= ranlib
+ PLATS= aix ansi bsd freebsd generic linux macosx mingw posix solaris
+ 
+ # What to install.
+-TO_BIN= lua luac
++TO_BIN= lua$V luac$V
+ TO_INC= lua.h luaconf.h lualib.h lauxlib.h ../etc/lua.hpp
+ TO_LIB= liblua.a
+-TO_MAN= lua.1 luac.1
++TO_MAN= lua$V.1 luac$V.1
+ 
+ # Lua version and release.
+ V= 5.1
+diff --git a/doc/lua.1 b/doc/lua5.1.1
+rename from doc/lua.1
+rename to doc/lua5.1.1
+diff --git a/doc/luac.1 b/doc/luac5.1.1
+rename from doc/luac.1
+rename to doc/luac5.1.1
+diff --git a/src/Makefile b/src/Makefile
+--- a/src/Makefile
 b/src/Makefile
+@@ -29,10 +29,10 @@ CORE_O=lapi.o lcode.o ldebug.o ldo.o ldump.o lfunc.o 
lgc.o llex.o lmem.o \
+ LIB_O=lauxlib.o lbaselib.o ldblib.o liolib.o lmathlib.o loslib.o 
ltablib.o \
+   lstrlib.o loadlib.o linit.o
+ 
+-LUA_T=lua
++LUA_T=lua$V
+ LUA_O=lua.o
+ 
+-LUAC_T=   luac
++LUAC_T=   luac$V
+ LUAC_O=   luac.o print.o
+ 
+ ALL_O= $(CORE_O) $(LIB_O) $(LUA_O) $(LUAC_O)
diff --git a/package/util

[OpenWrt-Devel] [PATCH V2 2/2] lua: rename package to lua5.1

2019-06-22 Thread Rafał Miłecki
From: Rafał Miłecki 

This will allow adding packages for new Lua releases cleanly. At the
same time it doesn't break existing packages thanks to the PROVIDES.

Signed-off-by: Rafał Miłecki 
---
V2: Update /install sections to make packages work actually
---
 package/utils/{lua => lua5.1}/Makefile| 62 ++-
 .../001-include-version-number.patch  |  0
 .../010-lua-5.1.3-lnum-full-260308.patch  |  0
 .../patches-host/011-lnum-use-double.patch|  0
 ...2-lnum-fix-ltle-relational-operators.patch |  0
 .../013-lnum-strtoul-parsing-fixes.patch  |  0
 .../patches-host/015-lnum-ppc-compat.patch|  0
 .../030-archindependent-bytecode.patch|  0
 .../patches-host/100-no_readline.patch|  0
 .../patches/001-include-version-number.patch  |  0
 .../010-lua-5.1.3-lnum-full-260308.patch  |  0
 .../patches/011-lnum-use-double.patch |  0
 ...2-lnum-fix-ltle-relational-operators.patch |  0
 .../013-lnum-strtoul-parsing-fixes.patch  |  0
 .../patches/015-lnum-ppc-compat.patch |  0
 .../patches/020-shared_liblua.patch   |  0
 .../030-archindependent-bytecode.patch|  0
 .../patches/040-use-symbolic-functions.patch  |  0
 .../patches/050-honor-cflags.patch|  0
 .../patches/100-no_readline.patch |  0
 .../patches/200-lua-path.patch|  0
 .../patches/300-opcode_performance.patch  |  0
 22 files changed, 32 insertions(+), 30 deletions(-)
 rename package/utils/{lua => lua5.1}/Makefile (77%)
 rename package/utils/{lua => 
lua5.1}/patches-host/001-include-version-number.patch (100%)
 rename package/utils/{lua => 
lua5.1}/patches-host/010-lua-5.1.3-lnum-full-260308.patch (100%)
 rename package/utils/{lua => lua5.1}/patches-host/011-lnum-use-double.patch 
(100%)
 rename package/utils/{lua => 
lua5.1}/patches-host/012-lnum-fix-ltle-relational-operators.patch (100%)
 rename package/utils/{lua => 
lua5.1}/patches-host/013-lnum-strtoul-parsing-fixes.patch (100%)
 rename package/utils/{lua => lua5.1}/patches-host/015-lnum-ppc-compat.patch 
(100%)
 rename package/utils/{lua => 
lua5.1}/patches-host/030-archindependent-bytecode.patch (100%)
 rename package/utils/{lua => lua5.1}/patches-host/100-no_readline.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/001-include-version-number.patch 
(100%)
 rename package/utils/{lua => 
lua5.1}/patches/010-lua-5.1.3-lnum-full-260308.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/011-lnum-use-double.patch (100%)
 rename package/utils/{lua => 
lua5.1}/patches/012-lnum-fix-ltle-relational-operators.patch (100%)
 rename package/utils/{lua => 
lua5.1}/patches/013-lnum-strtoul-parsing-fixes.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/015-lnum-ppc-compat.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/020-shared_liblua.patch (100%)
 rename package/utils/{lua => 
lua5.1}/patches/030-archindependent-bytecode.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/040-use-symbolic-functions.patch 
(100%)
 rename package/utils/{lua => lua5.1}/patches/050-honor-cflags.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/100-no_readline.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/200-lua-path.patch (100%)
 rename package/utils/{lua => lua5.1}/patches/300-opcode_performance.patch 
(100%)

diff --git a/package/utils/lua/Makefile b/package/utils/lua5.1/Makefile
similarity index 77%
rename from package/utils/lua/Makefile
rename to package/utils/lua5.1/Makefile
index c911c6a913..4fb93a9c8f 100644
--- a/package/utils/lua/Makefile
+++ b/package/utils/lua5.1/Makefile
@@ -25,7 +25,7 @@ HOST_PATCH_DIR := ./patches-host
 include $(INCLUDE_DIR)/package.mk
 include $(INCLUDE_DIR)/host-build.mk
 
-define Package/lua/Default
+define Package/lua5.1/Default
   SUBMENU:=Lua
   SECTION:=lang
   CATEGORY:=Languages
@@ -34,56 +34,59 @@ define Package/lua/Default
   MAINTAINER:=Jo-Philipp Wich 
 endef
 
-define Package/lua/Default/description
+define Package/lua5.1/Default/description
  Lua is a powerful light-weight programming language designed for extending 
  applications. Lua is also frequently used as a general-purpose, stand-alone 
  language. Lua is free software.
 endef
 
-define Package/liblua
-$(call Package/lua/Default)
+define Package/liblua5.1
+$(call Package/lua5.1/Default)
   SUBMENU:=
   SECTION:=libs
   CATEGORY:=Libraries
   TITLE+= (libraries)
+  PROVIDES:=liblua
   ABI_VERSION:=5.1.5
 endef
 
-define Package/liblua/description
-$(call Package/lua/Default/description)
+define Package/liblua5.1/description
+$(call Package/lua5.1/Default/description)
  This package contains the Lua shared libraries, needed by other programs.
 endef
 
-define Package/lua
-$(call Package/lua/Default)
-  DEPENDS:=+liblua
+define Package/lua5.1
+$(call Package/lua5.1/Default)
+  DEPENDS:=+liblua5.1
   TITLE+= (interpreter)
+  PROVIDES:=lua
 endef
 
-define Package/lua/description
-$(call Package/lua/Default/description)
+define Pack

Re: [OpenWrt-Devel] Dependency problem after changing package name

2019-06-22 Thread Rafał Miłecki

On 22.06.2019 13:37, Rafał Miłecki wrote:

I renamed locally package "lua" to "luax" and updated dependency of
"lua-examples". A pretty simple change.


After that change I can't build OpenWrt anymore.

# make V=s
(...)
Collected errors:
  * satisfy_dependencies_for: Cannot satisfy the following dependencies for 
lua-examples:
  *  luax
  * opkg_install_cmd: Cannot install package lua-examples.
make[2]: *** [package/Makefile:68: package/install] Error 255
(...)


Jonas has just helped me. I forgot to change
Package/lua/install
to
Package/luax/install

Is that possible to make error message somehow more meaningful?

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] Dependency problem after changing package name

2019-06-22 Thread Rafał Miłecki

I renamed locally package "lua" to "luax" and updated dependency of
"lua-examples". A pretty simple change.


After that change I can't build OpenWrt anymore.

# make V=s
(...)
Collected errors:
 * satisfy_dependencies_for: Cannot satisfy the following dependencies for 
lua-examples:
 *  luax
 * opkg_install_cmd: Cannot install package lua-examples.
make[2]: *** [package/Makefile:68: package/install] Error 255
(...)

# ./scripts/diffconfig.sh | grep -v "CONFIG_TARGET_DEVICE_"
CONFIG_TARGET_bcm53xx=y
CONFIG_TARGET_MULTI_PROFILE=y
CONFIG_TARGET_ALL_PROFILES=y
CONFIG_TARGET_PER_DEVICE_ROOTFS=y
CONFIG_PACKAGE_libiwinfo=y
CONFIG_PACKAGE_liblua=y
CONFIG_PACKAGE_lua-examples=y
CONFIG_PACKAGE_luax=y


I've verified this problem occurs when building from a scratch.

# git clone g...@git.openwrt.org:openwrt/openwrt.git openwrt-19.07-tmp
# git checkout c26420b9145759ca99aceef0510ab8b725867c7e
# patch -p1 < ~/lua.diff
# make menuconfig
# make V=s


Any idea what's causing it? Is that some bug in handling dependencies in
OpenWrt? I noticed this while testing
[PATCH 2/2] lua: rename package to lua5.1


diff --git a/package/utils/lua/Makefile b/package/utils/lua/Makefile
index 077a60fbf3..3075c8dc18 100644
--- a/package/utils/lua/Makefile
+++ b/package/utils/lua/Makefile
@@ -54,13 +54,13 @@ $(call Package/lua/Default/description)
  This package contains the Lua shared libraries, needed by other programs.
 endef

-define Package/lua
+define Package/luax
 $(call Package/lua/Default)
   DEPENDS:=+liblua
   TITLE+= (interpreter)
 endef

-define Package/lua/description
+define Package/luax/description
 $(call Package/lua/Default/description)
  This package contains the Lua language interpreter.
 endef
@@ -78,7 +78,7 @@ endef

 define Package/lua-examples
 $(call Package/lua/Default)
-  DEPENDS:=lua
+  DEPENDS:=luax
   TITLE+= (examples)
 endef

@@ -169,8 +169,7 @@ define Package/lua-examples/install
 endef

 $(eval $(call BuildPackage,liblua))
-$(eval $(call BuildPackage,lua))
+$(eval $(call BuildPackage,luax))
 $(eval $(call BuildPackage,luac))
 $(eval $(call BuildPackage,lua-examples))
 $(eval $(call HostBuild))
-

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 1/2] openwrt-19.07: ath79: Code style fixes in 10_fix_wifi_mac

2019-06-22 Thread Adrian Schmutzler
This fixes one comparison and several useless echos.

Signed-off-by: Adrian Schmutzler 
---
 .../base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac| 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac 
b/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
index 2da2e8bfb0..bdb8b71ff7 100644
--- a/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
+++ b/target/linux/ath79/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
@@ -1,6 +1,6 @@
 #!/bin/ash
 
-[ "$ACTION" == "add" ] || exit 0
+[ "$ACTION" = "add" ] || exit 0
 
 PHYNBR=${DEVPATH##*/phy}
 
@@ -17,18 +17,18 @@ case "$board" in
# There is no eeprom data for 5 GHz wlan in "art" partition
# which would allow to patch the macaddress
[ "$PHYNBR" -eq 1 ] && \
-   echo $(macaddr_add "$(mtd_get_mac_ascii u-boot-env 
ethaddr)" 1) > /sys${DEVPATH}/macaddress
+   macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1 
> /sys${DEVPATH}/macaddress
;;
iodata,wn-ac1600dgr)
# There is no eeprom data for 5 GHz wlan in "art" partition
# which would allow to patch the macaddress
[ "$PHYNBR" -eq 0 ] && \
-   echo $(macaddr_add "$(mtd_get_mac_ascii u-boot-env 
ethaddr)" 1) > /sys${DEVPATH}/macaddress
+   macaddr_add "$(mtd_get_mac_ascii u-boot-env ethaddr)" 1 
> /sys${DEVPATH}/macaddress
;;
phicomm,k2t)
# The K2T factory firmware does use LAN mac address as the 2.4G 
wifi mac address
[ "$PHYNBR" -eq 1 ] && \
-   echo $(k2t_get_mac "lan_mac") > 
/sys${DEVPATH}/macaddress
+   k2t_get_mac "lan_mac" > /sys${DEVPATH}/macaddress
;;
*)
;;
-- 
2.20.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 2/2] openwrt-19.07: ar71xx: Code style fixes in 10_fix_wifi_mac

2019-06-22 Thread Adrian Schmutzler
This fixes one comparison and one useless echo.

Signed-off-by: Adrian Schmutzler 
---
 .../ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac 
b/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
index b58cf9b591..1082ad4ad3 100644
--- a/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
+++ b/target/linux/ar71xx/base-files/etc/hotplug.d/ieee80211/10_fix_wifi_mac
@@ -1,6 +1,6 @@
 #!/bin/ash
 
-[ "$ACTION" == "add" ] || exit 0
+[ "$ACTION" = "add" ] || exit 0
 
 PHYNBR=${DEVPATH##*/phy}
 
@@ -17,7 +17,7 @@ case "$board" in
archer-c59-v2|\
archer-c60-v1|\
archer-c60-v2)
-   echo $(macaddr_add $(mtd_get_mac_binary mac 8)  $(($PHYNBR - 
1)) ) > /sys${DEVPATH}/macaddress
+   macaddr_add $(mtd_get_mac_binary mac 8) $(($PHYNBR - 1)) > 
/sys${DEVPATH}/macaddress
;;
*)
;;
-- 
2.20.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [openwrt] Patch notification: 1 patch updated

2019-06-22 Thread Patchwork
Hello,

The following patch (submitted by you) has been updated in Patchwork:

 * openwrt: [OpenWrt-Devel] nghttp2: deduplicate files in staging_dir
 - http://patchwork.ozlabs.org/patch/1120220/
 - for: OpenWrt development
was: New
now: Accepted

This email is a notification only - you do not need to respond.

Happy patchworking.

--

This is an automated mail sent by the Patchwork system at
patchwork.ozlabs.org. To stop receiving these notifications, edit
your mail settings at:
  http://patchwork.ozlabs.org/mail/

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] nghttp2: deduplicate files in staging_dir

2019-06-22 Thread Hans Dedecker
On Fri, Jun 21, 2019 at 3:05 PM Eneas U de Queiroz via openwrt-devel
 wrote:
>
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
>
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
>
>
> -- Forwarded message --
> From: Eneas U de Queiroz 
> To: openwrt-devel@lists.openwrt.org
> Cc: Eneas U de Queiroz 
> Bcc:
> Date: Fri, 21 Jun 2019 10:05:23 -0300
> Subject: [PATCH] nghttp2: deduplicate files in staging_dir
> '38b22b1e: deduplicate files in libnghttp2' missed duplicates in
> staging_dir by Build/InstallDev.
>
> Signed-off-by: Eneas U de Queiroz 
Patch pushed to master; thx

Hans
>
> diff --git a/package/libs/nghttp2/Makefile b/package/libs/nghttp2/Makefile
> index b96ebd8acb..2f0b4bcabc 100644
> --- a/package/libs/nghttp2/Makefile
> +++ b/package/libs/nghttp2/Makefile
> @@ -35,7 +35,7 @@ define Build/InstallDev
> $(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/include/nghttp2/*.h 
> $(1)/usr/include/nghttp2/
> $(INSTALL_DIR) $(1)/usr/lib/pkgconfig
> $(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/*.pc 
> $(1)/usr/lib/pkgconfig/
> -   $(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/lib/libnghttp2.so* 
> $(1)/usr/lib/
> +   $(CP) $(PKG_INSTALL_DIR)/usr/lib/libnghttp2.so* $(1)/usr/lib/
>  endef
>
>  define Package/libnghttp2/install
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel