Re: [PATCH 1/3] rules: add commitcount function

2021-01-07 Thread Jo-Philipp Wich
Hi, I think this change will introduce massive overhead during the DUMP phase of the buildroot when scanning package metadata. You should wrap the logic into an `ifneq ($(DUMP),1)` or similar and simply return a static placeholder value if DUMP==1 ~ Jo signature.asc Description: OpenPGP digit

Re: R: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-06 Thread Jo-Philipp Wich
Hi, > I didn't add the check here as we can assume that ht_operation are always > present. > Should I add this anyway? why can we assume it? They way I see it, HT info is only populated if IE type 61 was present, valid and parsed from BSS info, otherwise the structure mightr be present but zero

Re: [RPCD PATCH v4 4/4] iwinfo: export center channel for info ubus call

2021-01-05 Thread Jo-Philipp Wich
Hi, comment below. > [...] > diff --git a/iwinfo.c b/iwinfo.c > index 45ca784..94fa822 100644 > --- a/iwinfo.c > +++ b/iwinfo.c > @@ -364,6 +364,8 @@ rpc_iwinfo_info(struct ubus_context *ctx, struct > ubus_object *obj, > > rpc_iwinfo_call_int("mode", iw->mode, IWINFO_OPMODE_NAMES); >

Re: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > @@ -441,6 +441,20 @@ rpc_iwinfo_scan(struct ubus_context *ctx, struct > ubus_object *obj, > blobmsg_add_u32(&buf, "quality", e->quality); > blobmsg_add_u32(&buf, "quality_max", e->quality_max); > Only add the "ht_operat

Re: [IWINFO PATCH v4 2/4] iwinfo: export center_chan info for local wifi

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > diff --git a/include/iwinfo.h b/include/iwinfo.h > index 676db91..680f384 100644 > --- a/include/iwinfo.h > +++ b/include/iwinfo.h > @@ -282,6 +282,8 @@ struct iwinfo_ops { > int (*survey)(const char *, char *, int *); > int (*lookup_phy)(const char *, ch

Re: [IWINFO PATCH v4 1/4] iwinfo: export ht and vht operation in scan results

2021-01-05 Thread Jo-Philipp Wich
Hi, comments inline below. > [...]@@ -2306,6 +2306,16 @@ static void nl80211_get_scanlist_ie(struct nlattr > **bss, > iwinfo_parse_rsn(&e->crypto, ie + 6, ie[1] - 4, >IWINFO_CIPHER_TKIP, > IWINFO_KMGMT_PSK); >

Re: [PATCH 1/2 iwinfo] iwinfo: add support for GCMP cipher

2021-01-05 Thread Jo-Philipp Wich
Hi, before merging this, please extend the cmake rules in iwinfo.git to add a SOVERSION property to the resulting libiwinfo library, this way we can adopt ABI versio ntracking when we bump it the next time in OpenWrt. ~ Jo signature.asc Description: OpenPGP digital signature __

Merged: libnetfilter-conntrack: update to 1.0.8

2020-12-14 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] uhttpd: don't redirect to HTTPS by default

2020-12-14 Thread Jo-Philipp Wich
Hi, > So we can ship px5g-wolfssl by default in the release image, but still > make the HTTPS for LuCI optional. This small change with addition of > `CONFIG_PACKAGE_px5g-wolfssl=y` into the buildbot's seed config for the > next release should provide optional HTTPS in the next release. please no

Re: [luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics

2020-12-11 Thread Jo-Philipp Wich
Hi, > This is significantly faster. great work! I like it :) Minor nitpick below. > [...] > -var callLuciDSLStatus = rpc.declare({ > - object: 'luci-rpc', > - method: 'getDSLStatus', > +var call_dsl_metrics = rpc.declare({ > + object: 'dsl', > + method: 'metrics', > exp

Merged: firewall3: fix duplicate defaults section detection

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Merged: ipsets: allow blank/commented lines withloadfile

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: Lightweight policy-based routing

2020-12-04 Thread Jo-Philipp Wich
Hi Philip, ip rules are possible in uci, but not sure if all the bits you require are covered: https://openwrt.org/docs/guide-user/network/ucicheatsheet#ip_rules_for_both_rule_and_rule6 `config route` sections allow specifying `option table` as well to stage the routes in the non-main rttable.

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Jo-Philipp Wich
Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. -- 8< -- { flock -x 1000 command command command ... } 1000>/var/lock/dsl_pipe -- >8 -- See also the fourth example at

Re: [PATCH] netifd: add segment routing support

2020-12-02 Thread Jo-Philipp Wich
Hi, the chosen option name does not really fit other existing bool options which do not use an enable(d) or disable(d) prefix/suffix. I'd call the new option simply `seg6` or even better `ip6segmentrouting` to fall in line with other IPv6 specific options [1] ~ Jo 1: https://lxr.openwrt.org/sou

Re: [PATCH] openvpn: update to 2.5.0

2020-11-30 Thread Jo-Philipp Wich
Hi, [...] > @@ -137,6 +143,7 @@ allow_recursive_routing > auth_nocache > auth_user_pass_optional > bind > +block-ipv6 I suppose this needs to be `block_ipv6` ? > ccd_exclusive > client > client_to_client > @@ -185,10 +192,13 @@ tls_server > up_delay > up_restart > username_as_common_nam

Download server downtime

2020-11-24 Thread Jo-Philipp Wich
int to our mirrors [1] which you can use to download OpenWrt binaries in case the main download server is unavailable. Please excuse the inconvenience and troubles caused. Kind regards, Jo-Philipp Wich 1: https://openwrt.org/downloads#mirrors ___ ope

Re: [PATCH v4] build: create $(PKG_SYMVERS_DIR) if non-existent

2020-11-19 Thread Jo-Philipp Wich
Hi Sebastian, thanks for following up with a v4. I merged this change in https://git.openwrt.org/2127accd441b1c979c8f3f56f3ad5264542e185a now. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinf

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-11-14 Thread Jo-Philipp Wich
Hi, > Are there any real blockers left? LuCI support for bridge-vlan config is unmerged/unpolished yet. I'd rather not ship 20.x without functioning switch config support in the ui. ~ Jo signature.asc Description: OpenPGP digital signature ___ open

Re: [PATCH] rpcd: Add support for plugin command input via argv[3] ($3)

2020-11-11 Thread Jo-Philipp Wich
Hi, the request payload can theoretically become very big, something in the few hundred kilobyte to one megabyte ballpark. I am not sure if it is a good idea to pass that via the argv vector. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.open

Re: x86/64 SDK segfaults on some hosts [Was: Re: [PATCH 1/2] fakeroot: make fakeroot script relocatable]

2020-11-09 Thread Jo-Philipp Wich
Hi, > it seems like mixing dynamic loader from the host and libraries from SDK > doesn't work reliably in all cases and may result in crash. Yes, that is why we wrap the SDK executables to forcibly invoke them through the bundled loader. Attempting to use SDK executables or librries with the hos

Re: [PATCH v2] scripts: bundle-libraries.sh: fix broken SDK compiler

2020-11-01 Thread Jo-Philipp Wich
*) > + file "$bin" | grep -sqE "ELF.*(executable|interpreter)" && > return 0 Apart from this apparently inconsistent indentation (tabs vs. spaces?) - LGTM. Assuming the white space is straightened out... Acked-by: Jo-Philipp Wich ___

Re: [PATCH] scripts: bundle-libraries.sh: fix broken SDK compiler

2020-11-01 Thread Jo-Philipp Wich
Hi Petr, instead of meddling with the file permissions (which might cause unwanted side effects for .so's that *are* supposed to be executable) I'd suggest to simply skip *.so files by name. Something along the lines of: case "$BIN" in *.so|*.so.[0-9]*) : ;; *) [ -n "$LDD" ] && [ -x "$BI

Merged: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Hi again, > please disregard, I made a logical mistake and forgot that the OS X check is > about the *.dylib vs. *.so extension, not the library location. actually it seems fine after all since the proper extension is embedded in the fakeroot script according to whats applicable to the host system

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Hi, please disregard, I made a logical mistake and forgot that the OS X check is about the *.dylib vs. *.so extension, not the library location. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@li

[PATCH 1/2] fakeroot: make fakeroot script relocatable

2020-09-10 Thread Jo-Philipp Wich
invoke fakeroot and subsequently allows us to drop OS X specific logic. Signed-off-by: Jo-Philipp Wich --- tools/fakeroot/patches/000-relocatable.patch | 25 1 file changed, 25 insertions(+) create mode 100644 tools/fakeroot/patches/000-relocatable.patch diff --git a/tools

[PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Since fakeroot is patched to discover related ressources relative to the STAGING_DIR_HOST environment variable, there is no need to pass the path to faked or the preload library manually anymore. Signed-off-by: Jo-Philipp Wich --- rules.mk | 7 +-- 1 file changed, 1 insertion(+), 6

Re: [OpenWrt-Devel] [PATCHv3] mdadm: revised mdadm config & init logic

2020-09-10 Thread Jo-Philipp Wich
Hi, comments inline. On 1/23/20 3:56 AM, Rosen Penev wrote: > From: Joseph Tingiris > > This is a significant revision of /etc/init.d/mdadm. It adds new > features, support for new configuration options, safer error > handling, (configurable) verbose output, and contains multiple bug > fixes.

Re: [PATCH] libcxxabi: fix compilation under the SDK

2020-09-10 Thread Jo-Philipp Wich
Hi, > + $(MAKE) -C $(TOPDIR)/$(if > $(CONFIG_IN_SDK),feeds/base/)package/libs/libcxx prepare this looks like an ugly hack, also the feed is not guaranteed to reside in feeds/base/ - the user can theoretically change the name of the base feed. Why does this package need to trigger an prepare

Re: UCI: Making a config read-only?

2020-08-26 Thread Jo-Philipp Wich
Hi, > Is there a way to truly make a configuration read only in UCI, so that > changes are rejected, and not stored in /tmp/.uci/ ? there is no such facility implemented in uci or libuci. ~ Jo signature.asc Description: OpenPGP digital signature ___

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-25 Thread Jo-Philipp Wich
Hi, > Pretty much all packages stage into staging_dir/target-*/usr - I don't > think there are any -I/-L flags we can remove. we're patching the gcc specs [1], [2] to implicitly add $STAGING_DIR/usr/lib to the link- and $STAGING_DIR/usr/include to the CPP flags. There is no need to globally pass

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-24 Thread Jo-Philipp Wich
Hi, > Isn't that breaking some packages which currently use `/usr/lib`? > > packages.git/boost: > https://github.com/openwrt/packages/blob/e2e152da599ceeacf06b4a045b5b391107d194df/libs/boost/Makefile#L485 I don't see how. The code you quoted creates the destination directory directly in the line

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-24 Thread Jo-Philipp Wich
Hi, > rules.mk always passes these as -I/-L to the toolchain. > > Fixes rare errors like: > cc1: error: staging_dir/target-aarch64_cortex-a53_musl/usr/include: No such > file or directory [-Werror=missing-include-dirs] > > Signed-off-by: Andre Heider NAK - I'd prefer if we remove the faulty/r

Re: Announcement: Removal of 4.14 kernel from master

2020-08-20 Thread Jo-Philipp Wich
Hi, > Why is ar71xx no longer going to be supported? because development shifted towards the upstream-approved and device tree based ath79 target. > This includes Netgear WNDR-3700-v4 which is a very popular and reliable router > in the OpenWRT community. The Netgear WNDR-3700-v4 is supported b

Merged: options: fix parsing of boolean attributes

2020-08-20 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: jsonfilter and queries with '-' in them

2020-08-13 Thread Jo-Philipp Wich
Hi, > Could you write a little bit about the underlying cause of this just > so I can understand better? it is basically mimicking JavaScript object access syntax where labels after a dot must be valid identifiers. In JS, an expression `obj.foo-bar.baz` would be interpreted as `obj.foo` minus `b

Re: jsonfilter and queries with '-' in them

2020-08-12 Thread Jo-Philipp Wich
Hi, as already implied by Dirk, you need to use bracket notation for labels that are not valid variable identifiers. So instead of `@.foo-bar` use `@["foo-bar"]`. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing li

Merged: tools/firmware-utils: use UTC for image timestamps

2020-08-07 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 3/4] build: image: remove strange useless comment

2020-08-06 Thread Jo-Philipp Wich
Hi Adrian, > compat_version=$(if $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0) > json_quote=$(subst ','\'',$(subst ",\",$(1))) > -#")') This commit was most likely added to aid text editors with naive syntax highlighting capabilities that fail to properly detect the end of the string d

Re: [PATCH uhttpd] ubus: rename JSON-RPC format related functions

2020-08-06 Thread Jo-Philipp Wich
Hi, > Use "_json_rpc_" in their names so it's clear they are related to the > JSON-RPC format. This cleans up code a bit and will allow adding more > formats in the future. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.asc Descript

Re: [PATCH V2 uhttpd] ubus: add new RESTful API

2020-08-04 Thread Jo-Philipp Wich
Hi, > Regarding parsing events stream, event names with spaces seem to be OK: > https://html.spec.whatwg.org/multipage/server-sent-events.html#parsing-an-event-stream To me it feels quirky to separate the path and the type of the event by space. Personally I'd only report the type as "event:" an

Re: github private respositories

2020-08-01 Thread Jo-Philipp Wich
Hi, > Is there a way to compile github private repositories as package in openwrt? PKG_SOURCE_URL:=https://githubuser:githubp...@github.com/project/repo.git or PKG_SOURCE_URL:=g...@github.com:project/repo.git or PKG_SOURCE_URL:=ssh://g...@github.com/project/repo.git The first one only works

Re: [PATCH] kernel: add missing config symbol

2020-07-31 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Stijn Tintel Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 0/3] Support TLS/SSL and WPA3-Personal/SAE by default

2020-07-27 Thread Jo-Philipp Wich
Hi, >> How stable is the ABI of wolfssl? > > I assume, that we're going to find the answer in the upcoming years :-) see https://abi-laboratory.pro/index.php?view=timeline&l=wolfssl for the historic track record. Compared to OpenSSL here: https://abi-laboratory.pro/index.php?view=timeline&l=open

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Jo-Philipp Wich
Hi Felix, > [...] > > For a simple default config, you could have this: > > # network > config device option type bridge # I assume this is needed as well > option name switch0 > > config bridge-vlan > option vlan 1 > option ports "lan1 lan2 lan3 lan4" > > conf

Re: [RFC] Writing sysupgrade.tgz directly to overlay for block-device sysupgrade

2020-07-24 Thread Jo-Philipp Wich
Hi David, > Instead of using the overlay filesystem du jour, perhaps it makes more > sense to simply put the tarball itself, raw, on the loop device > immediately after the end of the squashfs? I suppose the limiting factor for the maximum backup size would be the amount of available RAM then? Be

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Jo-Philipp Wich
Hi Luiz, I mostly agree with your proposal (though I'd call "device_for" simply "bridge" instead but that's details). I don't think everything can be simply switched in one go but I do think your proposal could be broken down into the following measures. The simple things: - Rename "config wif

Re: [PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-24 Thread Jo-Philipp Wich
Hi, > Fixes FS#3231 > > Signed-off-by: Yousong Zhou Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinf

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi again, > What about spelling out the dependency explicitly? Instead of overloading the > meaning of "option network", add an "option bridge" instead which reuses the > existing vlan notation followed by a vlan id spec as defined by the "option > ports" notation for bridge devices, e.g. That sh

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > 1. Have VLAN devices on top of vlan-enabled bridges to define hotplug > ops where applicable, so LAN could be a plain VLAN interface switch0.1 > instead of its own bridge. > 2. With these wrapper hotplug ops, a default VLAN would be passed as > well, unless overwritten by other VLAN settings

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, yeah I forgot to elaborate that in my last mail. The problem of dynamic / not explicitly addressable wifi interface names in the network config remains. The best solution I can think of is fixing the wifi ifnames using "option ifname" in the wifi-iface sections (which causes some very interes

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > Related to this, is it possible to add a wireless interface to a > bridge specifying a non-default PVID? I would have expected that something like config bridge-vlan option device mybridge0 option vlan 100 option ports 'wlan0:u*' achieves that effect. The wlan0 interface would be a

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > One thing which is a bit awkward as long as the bridge itself is > configured as an interface, is that as far as I have understood, > creating a tagged interface to the bridge requires first setting up an > interface for the bridge, e.g. with protocol Unmanaged, and then > setting up one or

Re: [PATCH firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-22 Thread Jo-Philipp Wich
Hi Yousong, On 7/23/20 6:05 AM, Yousong Zhou wrote: > Fixes FS#3231 > > Signed-off-by: Yousong Zhou > --- > zones.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/zones.c b/zones.c > index 68b02ab..d5e756c 100644 > --- a/zones.c > +++ b/zones.c > @@ -580,6 +580,14 @@ print_i

Re: [PATCH uhttpd] ubus: parse "call" method params only for relevant call

2020-07-22 Thread Jo-Philipp Wich
Hi, > There is no point in parsing "call" specific params for other ("list") > method calls. This is a minor cleanup that doesn't change uhttpd ubus > behaviour. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.as

Re: [PATCH umdns] service.c: fix build on gcc 10

2020-07-20 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Jo-Philipp Wich ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-18 Thread Jo-Philipp Wich
Hi, > Where? I don't see a merge request on the git link referenced in the Makefile. sent a patch to the author using git send-email. Couldn't figure out how to open a MR on that Gitlab thing after looking for 30 seconds. ~ Jo ___ openwrt-devel mailin

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Jo-Philipp Wich
Hi, I've sent a fix using extern declarations upstream, lets see what happens. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > I'm not sure whether using an asterisk is wise here, as it might pose > interesting problems when people use scripts to set/evaluate uci > config (as you have to be extra careful to not have it treated as a > wildcard.) I'd be happy if we could find another symbol here. hm, can you elaborat

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > If we can't come up with a working automatic scheme, maybe we could have > an option to disable the cpu port per vlan? Having a default-enabled "option self" or "option local" was my idea as well. Any idea which name fits better? ~ Jo ___ openwr

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > Changes: > - The device is created as a netifd bridge > - Bridge vlan sections should always refer to the bridge instead of > automatically be applied to the first one > - Use = instead of . to mark tagging modifiers. "." is already used > for vlan interface names and reusing it here c

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Jo-Philipp Wich
Hi, > [...] > The same feeling is still with this DSA proposal. The syntax "lan2.t > lan2 lan3 lan5" is unstructured and it does not help too. What is unstructured about it? The fact that it is not a uci list? That can be easily changed. > The use of "switch0" for cpu interface is good and I thi

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Jo-Philipp Wich
Hi, > [...] > Isn't it conceptually more correct in this case for the vlan filtering > to be configured as part of the "interface" in uci? > Ie I configure an interface of type "bridge" which bridges the switch > ports, then the vlan filtering is a configuration property of this > interface (just

[RFC PATCH v2 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
fault, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philipp Wich

[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
s since v1: - Rename switch, switch_vlan and switch_port sections to dsa, dsa_vlan and dsa_port respectively - Forcibly move DSA ports to the switch bridge if they're part of another bridge yet - Disallow VLAN ID 0 - Properly display unassigned ports as empty in "dsacon

[PATCH 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
by default, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philip

[RFC PATCH] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
de to reduce the amount of required external dependencies and to allow for improved performance when processing large configurations. Open questions/topics: - Ensure that the chosen configuration approach actually works with DSA_TAG_PROTO_NONE switches - Consider changing the types of the UCI

Re: [missing subjects]

2020-06-26 Thread Jo-Philipp Wich
Hi, I think this was a misconfiguration in mailman (global "from_is_list" was set to "Wrap message"). Let's see if this reply mail looks better. Regards, Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-d

Re: [PATCH RFC procd] service: add "init_action" ubus method for /etc/init.d/ scripts

2020-06-22 Thread Jo-Philipp Wich
Hi, in addition to the inline comments, I'd personally prefer to see such functionality as rpcd plugin, not in procd itself. Not all init scripts are procd enabled and not all procd processes have init scripts, due to that I think that init script enumeration methods should reside elsewhere since

[OpenWrt-Devel] Merged: hostapd: fix compilation of wpa_supplicant

2020-06-18 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: Use autoclear for overlay loopbackdevice

2020-06-17 Thread Jo-Philipp Wich
Merged into project/fstools.git, branch master at http://git.openwrt.org/?p=project/fstools.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v3] uclient-fetch: add option to read POST data from file

2020-06-17 Thread Jo-Philipp Wich
86/64. > > Signed-off-by: Gioacchino Mazzurco > Signed-off-by: Daniel Golle Acked-by: Jo-Philipp Wich > --- > v3: use 1024 bytes buffer instead of 1000, use sizeof() > As original wget also only supports "application/x-www-form-urlencoded" > as Content-Type for the

Re: [OpenWrt-Devel] [PATCH uclient v2] uclient-fetch: add option to read POST data from file

2020-06-12 Thread Jo-Philipp Wich
Hi Gio, Daniel, > [...] > --- > v2: make it compile, handle errors, add usage info, fix typos > > uclient-fetch.c | 31 +-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/uclient-fetch.c b/uclient-fetch.c > index a06be5d..6119328 100644 > --- a/u

Re: [OpenWrt-Devel] iwinfo: DFS channels are not listed

2020-06-11 Thread Jo-Philipp Wich
Hi, since nobody really uses the `restricted` field (apart from LuCI itself I believe) and since I'd like to avoid changing the ABI, I would be fine with changing the condition to NO_IR || DFS or even just DFS. Initially the restricted flag was supposed to give a hint to the ui which channels are

Re: [OpenWrt-Devel] Problems with e-mail DMARC policy, and other usability issues

2020-06-11 Thread Jo-Philipp Wich
Hi, > ... does it though? I know it does traditionally, but... is that really > the only way? IFF you keep this, then yeah, sure, all the other > justifications are fine, but it's clearly not working well. in the past we did rewrite the sender to the list mail address and (iirc) added the origi

Re: [OpenWrt-Devel] [PATCH v2 4/4] build: use zstd for SDK and ImageBuilder tarballs

2020-06-03 Thread Jo-Philipp Wich
Hi, I tend to NAK this as it has the potential to interrupt a lot of downstream tooling. Up until now I also never heard about about Zstd - while this doesn't mean anything in the grand scheme of things I think it is a bit too "new" to be used widely yet. Seems tar only supports it since beginning

Re: [OpenWrt-Devel] [PATCH usign] Always pad fingerprints to 16 characters

2020-05-17 Thread Jo-Philipp Wich
Hi, > Fingerprints were not padded with zeros. [...] > > Signed-off-by: Matthias Schiffer Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.

Re: [OpenWrt-Devel] [PATCH v2 1/1] firewall3: harden string functions that might overflow

2020-05-14 Thread Jo-Philipp Wich
Hi, the sprintf() to snprintf() changes are fine to me. Please omit the conversions to strlcpy() and please don't use fmemopen(). ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] Ubus based service watchdog?

2020-05-14 Thread Jo-Philipp Wich
Hi, I like the ubus watchdog ping/pong idea. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Sysupgrade and Failed to kill all processes

2020-05-13 Thread Jo-Philipp Wich
Hi, > > That loop-kill-all thing should be a kind of last resort really, what's > actually needed is some kind of "init 1" procd equivalent which shuts > down all > services in a more or less clean manner. > > > Oddly enough, the /lib/upgrade/stage2 script has some aspect of this.

Re: [OpenWrt-Devel] Sysupgrade and Failed to kill all processes

2020-05-13 Thread Jo-Philipp Wich
Hi Michael, > [...] > > Now that the very rough summary is out of the way, I have 4 questions. > > 1) I notice that the shell script /lib/upgrade/stage2 is doing a tight loop > with kill -9 to terminate processes. However, it's only looping a maximum of > 10 times, and its going as fast as the s

Re: [OpenWrt-Devel] Jsonfilter, return partial subobject?

2020-04-23 Thread Jo-Philipp Wich
Hi, > [...] > What I want to do is return a JSON string with this representation: > [ >     { "interface" : "lan", "uptime" : 1 }, >     ... > ] > > E.g., I want to filter the json not down to a single value, but to a > collection of key-value pairs by excluding items that don't match. that

Re: [OpenWrt-Devel] Port labels for DSA targets/devices

2020-04-20 Thread Jo-Philipp Wich
Hi, > Note that DSA devices might have additional separate devices labelled ethX > as well, additional to the switch ports. do these fullfill a similar role to swconfig's "CPU ports" ? > E.g. ucidef_set_interfaces_lan_wan > "lan1 lan2 lan3 lan4 lan5 lan6" "eth0 eth2" > > So, this might become c

Re: [OpenWrt-Devel] Port labels for DSA targets/devices

2020-04-20 Thread Jo-Philipp Wich
Hi, I'd also prefer approach #2 to eventually allow for some generic configuration and port layout discovery mechanism without the need for shipping mappings for each device. In case we cannot go this route and need to stick to whatever mixture upstream or the vendors are using, I propose to ret

Re: [OpenWrt-Devel] [PATCH v2 0/6] build: update scritps/config to kconfig-v5.6

2020-04-12 Thread Jo-Philipp Wich
Hi Eneas, > I'm really sorry--and embarrassed, really--to have caused all this > trouble. I'll see what I can do from here, but I'm not familiar > enough with the build bot system to do much on my own--and that was > the origin of all problems. no need to be embarrassed, I just figured that reve

Re: [OpenWrt-Devel] [PATCH v2 0/6] build: update scritps/config to kconfig-v5.6

2020-04-11 Thread Jo-Philipp Wich
Hi Eneas, I am sorry but I had to completely revert the kconfig bump. It thoroughly broke the package repository builds since multiple days and the fatal recursive dependencies make it a no-go for master, at least as far as our build infrastructure is concerned. Right now, a single malformed feed

Re: [OpenWrt-Devel] [PATCH fstools V3 1/2] Revert "block: mount_action: handle mount/umount deps"

2020-04-02 Thread Jo-Philipp Wich
Hi Rafał, instead of reverting the hierarchical mount handling, isn't fixing the unintended mounts just a matter of doing a prefix compare during vlist_for_first_to_element() traversal? Assuming that `the_dev` refers to the block we do want to mount and `dev` is the iterator pointing to each `dev

[OpenWrt-Devel] [PATCH v2] generic: drop 616-net_optimize_xfrm_calls.patch

2020-03-31 Thread Jo-Philipp Wich
: Jo-Philipp Wich --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- 3 files changed, 60 deletions(-) delete mode 100644 target/l

[OpenWrt-Devel] [PATCH] target: drop 616-net_optimize_xfrm_calls.patch

2020-03-31 Thread Jo-Philipp Wich
: Jo-Philipp Wich --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- .../616-net_optimize_xfrm_calls.patch | 20 --- 3 files changed, 60 deletions(-) delete mode 100644 target/l

Re: [OpenWrt-Devel] libuci help

2020-03-28 Thread Jo-Philipp Wich
Hi, first of all, dashes are not allowed in section names. Unfortunately, libuci does not really perform any argument validation so it'll happily allow invalid names in various places but fail later on, as you've observed. Furthermore, I suggest to create a named section directly instead of doing

Re: [OpenWrt-Devel] [RFC PATCH] ath79: clarify purpose of factory image

2020-03-26 Thread Jo-Philipp Wich
Hi, +1 from me. I think the approach makes sense. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] busybox: remove date -k patch

2020-03-26 Thread Jo-Philipp Wich
Hi, > The kernel generally only cares about the timezone in a few places: last time I checked, iptables xt_time was affected. Without a properly set timezone, rules will kick in at unexpected times and --utc / --localtz / --kerneltz will not work as expected. Did you runtime test this? ~ Jo s

Re: [OpenWrt-Devel] Repository for release or snapshot build configuration?

2020-03-22 Thread Jo-Philipp Wich
Hi Lars, see https://git.openwrt.org/?p=buildbot.git;a=blob;f=docker/docker-compose.yml for an example configuration of the build infrastructure. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@l

[OpenWrt-Devel] Merged: session: deny access if password loginis disabled

2020-03-17 Thread Jo-Philipp Wich
Merged into project/rpcd.git, branch master at http://git.lede-project.org/?p=project/rpcd.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ubus: lua binding does not allow a reply with 64 bit numbers

2020-03-15 Thread Jo-Philipp Wich
Hi, applied with slight changes in https://git.openwrt.org/?p=project/ubus.git;a=commitdiff;h=171469e3138cce191892e20b6fd35b52c9368064 - thanks! ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@li

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
Hi Wes, > That sounds ideal. Is this with or without the "[OpenWrt-Devel] [PATCH > ustream-ssl] ustream-openssl: clear error stack before SSL_read/SSL_write" > patch? it is including the error stack patch. Without it, I wasn't even able to fully load the page most of the time. Regards, Jo si

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
Hi Wes, > Are there *new* security implications of allowing keep-alive? I don't see any immediate concerns. You can trigger resource intensive calls via GET, HEAD, PATCH, PUT or DELETE as well, all of them were allowed for keep-alive previously, only POST was filtered for unknown reasons. > Slow

[OpenWrt-Devel] [PATCH] pkgconf: always retain -I and -L flags

2020-03-13 Thread Jo-Philipp Wich
fd6e65989bee184 Signed-off-by: Jo-Philipp Wich --- tools/pkgconf/files/pkg-config | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/pkgconf/files/pkg-config b/tools/pkgconf/files/pkg-config index fa1faccc6c..2c6fd08b4a 100755 --- a/tools/pkgconf/files/pkg-config +++ b/tools/pkgconf/files/pkg

[OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
: Jo-Philipp Wich --- client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/client.c b/client.c index 92f7609..2a2393f 100644 --- a/client.c +++ b/client.c @@ -194,8 +194,7 @@ static int client_parse_request(struct client *cl, char *data) req->method = h_met

<    1   2   3   4   5   6   7   8   9   10   >