Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread John Crispin
On 10/01/2016 08:16, open...@daniel.thecshore.com wrote: > +else whitespace error > + local curtime="$(date +%s)" > + lo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] lantiq: Change the xbar register range to match the datasheet

2016-01-11 Thread John Crispin
On 11/01/2016 15:15, Martin Blumenstingl wrote: > On Mon, Jan 11, 2016 at 2:59 PM, John Crispin <blo...@openwrt.org> wrote: >> 0x1F40-0x1F400FFF means that its size is 0x1000. i think you having >> a off-by-one thinko ... > ...and I think you are right! > Sorry

Re: [OpenWrt-Devel] Can drop LXC tar.gz patch from patchwork

2016-01-13 Thread John Crispin
On 13/01/2016 18:10, Daniel Dickinson wrote: > As per Felix's suggestion I have implemented a detection of 'in lxc' > logic and modified base-files and busybox sysntpd script to use that > check to avoid actions inappropriate for an LXC guest, and to act > normally otherwise. The patch still

Re: [OpenWrt-Devel] [PATCH] Add support for Netgear D7800

2016-01-19 Thread John Crispin
gards, > Tathagata > > > -Original Message- > From: John Crispin [mailto:blo...@openwrt.org] > Sent: 19 January 2016 13:45 > To: Tathagata Das; openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] Add support for Netgear D7800 > > same as

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-19 Thread John Crispin
On 19/01/2016 09:59, Felix Fietkau wrote: > If you remove the zynq.sh, the variable will always be empty. So you can > just do: > case "$(cat /tmp/sysinfo/board_name)" in > ... > esac > > - Felix dont we have a unified helper for this since jows cleanup 2 weeks ago ?

Re: [OpenWrt-Devel] [PATCH] dnsmasq: add dhcp relay option

2016-01-19 Thread John Crispin
On 08/01/2016 16:24, dbugnar wrote: > Signed-off-by: dbugnar > --- > package/network/services/dnsmasq/files/dhcp.conf| 6 ++ > package/network/services/dnsmasq/files/dnsmasq.init | 19 +++ > 2 files changed, 25 insertions(+) > > diff --git

Re: [OpenWrt-Devel] [PATCH 3/4] firmware-utils: kernel image generator for TP-Link RE450

2016-01-19 Thread John Crispin
can this not be merged into one of the other tplink tools ? On 07/01/2016 01:40, Tal Keren wrote: > The firmware image that is used in TP-Link RE450 (and some more devices from > the RE series) is tplink-safeloader. > In the kernel partition, the kernel is compressed in a regular tp-link >

Re: [OpenWrt-Devel] [PATCH] Add support for Netgear D7800

2016-01-19 Thread John Crispin
please do that. On 19/01/2016 09:38, Tathagata Das wrote: > Do you mean to say that I have to prepare the patch against latest code of > trunk and send that it again? > > Regards, > Tathagata > > > -Original Message----- > From: John Crispin [mailto:blo...@openw

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-01-19 Thread John Crispin
On 11/01/2016 12:40, John Crispin wrote: > > > On 11/01/2016 12:28, Hannu Nyman wrote: >> Are there any plans for a CC 15.05.1 maintenance release? Or will DD >> 16.xx be the next one? >> >> There have been so many fixes to 15.05 that personally I would lik

Re: [OpenWrt-Devel] [PATCH] Add support for Netgear D7800

2016-01-19 Thread John Crispin
Hi, i applied this now and made some formal changes. next time please add a proper subject prefix and description. John On 19/01/2016 09:57, Tathagata Das wrote: > Signed-off-by: Tathagata Das > --- > .../linux/ipq806x/base-files/etc/board.d/01_leds | 1 + >

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-01-19 Thread John Crispin
week too late for them i am afraid. John > Best, > Alfie > > On Tue, Jan 19, 2016 at 4:57 PM, John Crispin <blo...@openwrt.org > <mailto:blo...@openwrt.org>> wrote: > > > > On 11/01/2016 12:40, John Crispin wrote: > > > >

Re: [OpenWrt-Devel] [PATCH 1/4] base-files: add option to specify netdev led mode in configuration generation

2016-01-19 Thread John Crispin
On 07/01/2016 01:40, Tal Keren wrote: > This is necessary for controlling leds of RJ45 port, when one indicate the > link > status and the other indicate data transfer. > > Signed-off-by: Tal Keren > --- > package/base-files/files/bin/config_generate | 7 --- >

Re: [OpenWrt-Devel] [PATCH 4/4] a71xx: add support for TP-Link RE450

2016-01-19 Thread John Crispin
Hi, again lots of changes all thrown into one patch. changes like > -define Image/Build/TPLINK-SAFELOADER > +define Image/Build/TPLINK-SAFELOADER-ELF need to be in their own patch. and the following > +# mktplinkfw-kernel > +define Build/mktplinkfw-kernel > +

Re: [OpenWrt-Devel] [PATCH] Add support for Netgear D7800

2016-01-19 Thread John Crispin
same as before, we are waiting on you to send a version that applies. patchwork 566597 --2016-01-17 06:23:22-- http://patchwork.ozlabs.org/patch/566597/mbox/ Resolving patchwork.ozlabs.org (patchwork.ozlabs.org)... 103.22.144.67 Connecting to patchwork.ozlabs.org

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2016-01-19 Thread John Crispin
On 19/01/2016 10:21, Bastian Bittorf wrote: > * amine ahd [19.01.2016 10:12]: >> start_service() { >> -local server enabled enable_server peer >> - >> +local server enabled enable_server peer ntpservers iface status >> ntpserver dump >> +local

Re: [OpenWrt-Devel] imports from LEDE to OpenWrt github repo

2016-06-25 Thread John Crispin
On 25/06/2016 10:47, Zoltan HERPAI wrote: > > > On Sat, 25 Jun 2016, Mathias Kresin wrote: > >> Hi Zoltan, >> >> I've noticed that you have imported a lot of patches from the LEDE >> repo into the OpenWrt github repo. >> >> I'm concerted about the fact that you have omitted at least a few of

Re: [OpenWrt-Devel] imports from LEDE to OpenWrt github repo

2016-06-25 Thread John Crispin
On 25/06/2016 14:01, Zoltan HERPAI wrote: > On Sat, 25 Jun 2016, John Crispin wrote: > >> >> >> On 25/06/2016 10:47, Zoltan HERPAI wrote: >>> >>> >>> On Sat, 25 Jun 2016, Mathias Kresin wrote: >>> >>>> Hi Zoltan, >

Re: [OpenWrt-Devel] [PATCH v3] ramips: Add support for Netgear EX2700

2016-02-07 Thread John Crispin
Hi, the patch is whitespace broken. please fix and resend John On 21/01/2016 23:23, Joseph C. Lehner wrote: > This patch adds support for the Netgear EX2700 and builds an approriate > sysupgrade image. > > What's missing is the option to build a factory image flashable via the >

Re: [OpenWrt-Devel] [RFC] replace outdated udev by eudev?

2016-02-07 Thread John Crispin
On 07/02/2016 10:22, Daniel Golle wrote: > The main reason why I'd like to have udev is persistent aliasing of > (hotpluggable) serial devices like wwan modems and input devices; udev > is required for libinput to build. why dont we just add this to the procd code ?

Re: [OpenWrt-Devel] [RFC] replace outdated udev by eudev?

2016-02-07 Thread John Crispin
On 07/02/2016 10:22, Daniel Golle wrote: > Hi! > > I recently bumped into eudev, a fork of systemd-udev 220 which doesn't > require all the rest of systemd. The gentoo folks came up with it as > many of them still use OpenRC or SystemV init. > It was easy to port it to OpenWrt by re-using and

Re: [OpenWrt-Devel] [RFC] replace outdated udev by eudev?

2016-02-07 Thread John Crispin
On 07/02/2016 10:53, Daniel Golle wrote: > Hi John! > > On Sun, Feb 07, 2016 at 10:28:25AM +0100, John Crispin wrote: >> maybe i am missing the point but why would you want udev on your system >> in the first place ? > > There are situations when ude

Re: [OpenWrt-Devel] [RFC] replace outdated udev by eudev?

2016-02-07 Thread John Crispin
On 07/02/2016 11:29, Daniel Golle wrote: > Hi John, > > On Sun, Feb 07, 2016 at 11:03:16AM +0100, John Crispin wrote: >>>> maybe i am missing the point but why would you want udev on your system >>>> in the first place ? >>> >>> There

Re: [OpenWrt-Devel] [PATCH] Added support for TL-WA801NDv3

2016-02-07 Thread John Crispin
Hi, 2 small nitpicks 1) please prefix the subject with "ar71xx:" [...] > diff --git a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h > b/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h > index a170e8d..967a012 100644 > --- a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h >

Re: [OpenWrt-Devel] [PATCH RESEND] openconnect: add mising liblz4 dependency

2016-02-07 Thread John Crispin
this package is hosted on github. please submit the patch there On 07/02/2016 14:17, Mauro Carvalho Chehab wrote: > Fixes the following build issue: > find > openwrt/build_dir/target-mips_34kc_musl-1.1.12/openconnect-7.06/ipkg-ar71xx/openconnect > -name 'CVS' -o -name '.svn' -o -name

Re: [OpenWrt-Devel] [PATCH v4 6/8] ar71xx: WNR2000v3: exclude USB modules from image

2016-02-07 Thread John Crispin
On 01/02/2016 22:59, Michal wrote: > From: Michal Cieslakiewicz > Subject: [PATCH v4 6/8] ar71xx: WNR2000v3: exclude USB modules from image > > Netgear WNR2000v3 has no USB port yet default system image > includes USB kernel modules. This patch fixes that. > >

Re: [OpenWrt-Devel] [PATCH] comgt: NCM protocol propagate defaultroute, peerdns, metric to dynamic ifaces

2016-02-09 Thread John Crispin
Hi Jakub, could it be that you manually edited the patch because (see inline) On 08/02/2016 11:57, Jakub Janco wrote: > NCM protocol now propagate defaultroute, peerdns, metric to its dynamic dhcp > ifaces to maintain these options defined in /etc/config/network. > > Signed-off-by: Jakub

Re: [OpenWrt-Devel] Native IPv6 Broken in recent trunk

2016-02-09 Thread John Crispin
Hi Adam, please do not hijack threads. if you want to send us a mail then dont click Reply on an un-related thread and then change the subject. this will mess up patchwork, which did notice what you did ;) --> https://patchwork.ozlabs.org/patch/580275/ John On 09/02/2016 05:42, Adam

Re: [OpenWrt-Devel] Build error for IPQ806X

2016-02-09 Thread John Crispin
where is the patch that you sent to fix the issue ? i can merge it now. John On 09/02/2016 06:42, Tathagata Das wrote: > I am still facing same issue whenever compiling latest trunk with D7800 is > selected. When this issue will be fixed? > > Regards, > Tathagata > > > -Original

Re: [OpenWrt-Devel] [PATCHv2] ar71xx: add support for the TP-LINK TL-WR1043ND v3

2016-02-09 Thread John Crispin
Hi, On 07/02/2016 16:34, Sven Roederer wrote: > The hardware of the v3 is identical to the v2. > > - adds support via old-style-definition. So less code is changed and there is > less potential to break other projects NAK, please use the new image building infra for trunk and the old one for

Re: [OpenWrt-Devel] Patch: Support for TP-Link WR-802N

2016-02-12 Thread John Crispin
Hi Rick, please read the howto for submitting patches. the actual patches look fine at first glance, but they format in which you sent them is bad i am afraid. the howto explains how to send the patches properly. John On 21/01/2016 18:17, Rick Pannen wrote: > Hi, > > I added support

Re: [OpenWrt-Devel] [PATCH 2/2] linux/net: Add dependency for crypto echainiv module on 4.4

2016-02-12 Thread John Crispin
Hi, On 30/01/2016 23:15, André Valentin wrote: > This dependency is needed to be able to create ipsec xfrm states. > > Signed-off-by: André Valentin > --- > package/kernel/linux/modules/netsupport.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [OpenWrt-Devel] [PATCH] fstools: add reusable function for getting fs type txt

2016-02-12 Thread John Crispin
Hi Tymon, few comments inline On 31/01/2016 14:01, tymon wrote: > > Add 'volume_identity_txt()' function so that we can use it to print the > coressponding fs > type as 'char *' type when we need. > > Signed-off-by: tymon > --- > libfstools/overlay.c | 10

Re: [OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"

2016-02-12 Thread John Crispin
On 12/02/2016 10:54, Bob Ham wrote: > Hi there, > > I've received a message from patchwork saying that this patch > > http://patchwork.ozlabs.org/patch/576676/ > > now has the state of "Not applicable" but there are no comments and it > doesn't say who changed the status. > > Is there a

Re: [OpenWrt-Devel] [PATCH] libubus.h: marking unused variables

2016-02-11 Thread John Crispin
On 10/02/2016 14:04, Emanuel Taube wrote: > > diff --git a/libubus.h b/libubus.h > index 08dac49..d419205 100644 > --- a/libubus.h > +++ b/libubus.h > @@ -285,7 +285,7 @@ int ubus_invoke_async(struct ubus_context *ctx, uint32_t > obj, const char *method > int ubus_send_reply(struct

Re: [OpenWrt-Devel] [PATCH] ramips: Support LEDs on D-Link DIR-860L B1

2016-02-11 Thread John Crispin
On 11/02/2016 14:46, Johannes Wienke wrote: > Adds the required gpio definitions. > > Signed-off-by: Johannes Wienke Hi Johannes, patch fails to apply. please fix and resend. John > --- > target/linux/ramips/dts/DIR-860L-B1.dts | 20 > 1

Re: [OpenWrt-Devel] [PATCH] [v4] ar71xx: Support for Ubiquiti UniFi AP AC LITE

2016-02-12 Thread John Crispin
On 12/02/2016 08:48, p.wa...@gmx.at wrote: > From: P.Wassi > > Add support for the Ubiquiti UniFi AP AC LITE > Signed-off-by: P.Wassi Hi, we need a proper name and please replace the at with the real symbol John > --- > RESUBMISSION since the last patch sent had problems with >

Re: [OpenWrt-Devel] [PATCH v2] kernel: crypto: add fsl CAAM package

2016-02-12 Thread John Crispin
On 08/02/2016 20:52, Pushpal Sidhu wrote: > Kernel package enables the Freescale CAAM (crypto accelerator and assurance > module, aka SEC4). Sets kernel defaults for ringsize, intc, and debug. > > Signed-off-by: Pushpal Sidhu > --- > v2 changes: > - Move package location

Re: [OpenWrt-Devel] Patchwork patch state mysteriously changed to "Not applicable"

2016-02-12 Thread John Crispin
On 12/02/2016 11:43, Bob Ham wrote: > On Fri, 2016-02-12 at 11:03 +0100, Bastian Bittorf wrote: >> * Bob Ham [12.02.2016 11:00]: >>> now has the state of "Not applicable" but there are no comments and it >>> doesn't say who changed the status. >> >> what I see is, that >>

Re: [OpenWrt-Devel] [PATCH 3/4] uci: add support for speed_mask to switch LED init scripts

2016-02-12 Thread John Crispin
On 12/02/2016 00:45, Michal wrote: > From: Michal Cieslakiewicz > Subject: [PATCH 3/4] uci: add support for speed_mask to switch LED init > scripts > > This patch adds extra parameter to switch LED trigger initialization > functions. > New functionality maintains

Re: [OpenWrt-Devel] patch for ticket 13249

2016-02-09 Thread John Crispin
On 09/02/2016 18:27, Jeff R. Allen wrote: > Ping? > > -jeff the patch was not formatted properly so that patchwork did not pick it up and hence it got lost. try using git "send-email" to avoid this problem. John > > On Fri, Feb 5, 2016 at 9:35 AM, Jeff R. Allen

Re: [OpenWrt-Devel] [PATCH v3] base-files: For sysfixtime use hwclock if RTC available

2016-01-26 Thread John Crispin
On 26/01/2016 21:35, Petr Štetiar wrote: > Bastian Bittorf [2016-01-21 12:53:48]: > >> * Petr Štetiar [21.01.2016 12:22]: >>> boot() { >>> + [ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && >>> exit 0 >> >> thank you! can you

Re: [OpenWrt-Devel] [PATCH][ar71xx] Routerboard 951G Switch Fix

2016-01-27 Thread John Crispin
On 27/01/2016 17:03, Anton Kalmykov wrote: > > Hi, 951G owners! > I have RB951G-2HnD device with AR9344 rev 3. It is configured like that: > - Balanced 2 WAN ports (mwan3) > - ipsec LAN-to-LAN > - OpenVPN server > - about 30 clients (wi-fi, lan) > > My results for different

Re: [OpenWrt-Devel] loading calibration data from UBI volume

2016-01-31 Thread John Crispin
On 31/01/2016 23:38, Martin Blumenstingl wrote: > Hello, > > currently we (Mathias and I) are planning to simplify the installation > procedure for a lantiq based device (HH5A). > Currently the installation steps require copying the calibration data > from an UBI volume on the original firmware

Re: [OpenWrt-Devel] [PATCH 1/2] wwan: Add support for CDC (Huawei 'HiLink') Modems

2016-02-23 Thread John Crispin
On 23/02/2016 18:26, Bruno Randolf wrote: > On 02/23/2016 07:11 AM, Matti Laakso wrote: >>> Huawei HiLink ("h" model names) modems just provide a CDC Ethernet >>> interface >>> where we have to run DHCP to get an IP address (usually in the >>> 192.168.8.0 >>> range). While this may be bad design

Re: [OpenWrt-Devel] [PATCH] leds: support oneshot as well as timer triggers

2016-02-23 Thread John Crispin
On 23/02/2016 18:25, Karl Palsson wrote: > +__ucidef_set_led_timer_oneshot() { i think __ucidef_set_led_timer() is a more appropriate name John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] NEW FEATURE IP Virtual Server Load Balancer

2016-02-22 Thread John Crispin
Hi, On 22/02/2016 20:52, Mauro Mozzarelli wrote: > I am not having success with git, so I will submit this new feature as patch. > I hope this is acceptable to all. > > commit c7d7abd075117739e6a784df5477a3e66a0533bd > Author: Mauro Mozzarelli > Date: Mon Feb 22 18:49:28

Re: [OpenWrt-Devel] [PATCH 1/2] wwan: Add support for CDC (Huawei 'HiLink') Modems

2016-02-22 Thread John Crispin
On 23/02/2016 08:47, Torbjorn Jansson wrote: > On 2016-02-23 08:11, Matti Laakso wrote: >>> Huawei HiLink ("h" model names) modems just provide a CDC Ethernet >>> interface >>> where we have to run DHCP to get an IP address (usually in the >>> 192.168.8.0 >>> range). While this may be bad design

Re: [OpenWrt-Devel] A quick note

2016-02-22 Thread John Crispin
On 23/02/2016 08:23, Daniel Dickinson wrote: > I am reprioritizing my project queue and as my attempts at openwrt > contributions get either curt/rude (sorry John, I know you complain > about my wordiness, but for the majority of world who aren't robots > *excessive* brevity comes across as rude

Re: [OpenWrt-Devel] [PATCH] [ltq-vdsl-app] Enable T1.413 in xTSE set for Annex A

2016-02-22 Thread John Crispin
Hi, do not send attached patches, they are impossible to review by hitting "reply" here is what you need to change for V2 * send the patch inline * use "ltq-vdsl-app:" as a prefix * please add a description. the patch is correct but add a small text so the next person knows why/what/how ... *

Re: [OpenWrt-Devel] [PATCH 2/5] lantiq/xrx200-net: fix PCE_MAPx handling

2016-02-22 Thread John Crispin
On 22/02/2016 19:05, Felix Fietkau wrote: > On 2016-02-22 13:17, Martin Schiller wrote: >> On 02/20/2016 at 10:59 AM, Felix Fietkau wrote: >>> On 2016-02-18 14:13, Martin Schiller wrote: Remove unnecessary MPMAP (PCE_MAP1) initialization and make >>> DMCPMAP (PCE_MAP2) and UUCMAP

Re: [OpenWrt-Devel] [PATCH] kernel: mtdsplit: support uimage with UBI

2016-02-23 Thread John Crispin
On 23/02/2016 12:26, John Crispin wrote: > hi, > > the patch is line wrapped. please use git send-email to send the patches > to avoid this problem > > John > you were faster than me ;) > On 23/02/2016 10:20, YounJae Rho wrote: >> This patch add

Re: [OpenWrt-Devel] [PATCH] kernel: mtdsplit: support uimage with UBI

2016-02-23 Thread John Crispin
hi, the patch is line wrapped. please use git send-email to send the patches to avoid this problem John On 23/02/2016 10:20, YounJae Rho wrote: > This patch add uimage firmware split support for ubi. > > Signed-off-by: YounJae Rho > --- >

Re: [OpenWrt-Devel] [PATCH] [packages] opkg: Make opkg understand old md5

2016-02-25 Thread John Crispin
Hi, few comments inline On 25/02/2016 13:39, Michal Hrusecky wrote: > Opkg now uses sha256 by default and expects them. Making it optionally > understand md5s also and detect md5 sum so we can migrate from configuration > that used md5. > > Signed-off-by: Michal Hrusecky

Re: [OpenWrt-Devel] [PATCH v2] [CC] ar71xx: backport support for TP-LINK TL-WR1043ND v3

2016-02-26 Thread John Crispin
Hi, i cant merge this without a correct patch for trunk. John On 08/02/2016 15:27, Sven Roederer wrote: > The hardware of the v3 is identical to the v2. > > - adding support for WR1043v3 > - resending this patch after fixing the original from >

Re: [OpenWrt-Devel] [PATCH 1/2] wwan: Add support for CDC (Huawei 'HiLink') Modems

2016-02-25 Thread John Crispin
On 25/02/2016 08:23, John Crispin wrote: > > > On 24/02/2016 09:08, Bruno Randolf wrote: >> On 02/24/2016 06:11 AM, Matti Laakso wrote: >>>> The reason is that I want different types of Modems to work with the >>>> same interface configuration,

Re: [OpenWrt-Devel] [PATCH v2] lantiq, xrx200-net: add devicetree aliases support for port->mac mapping

2016-02-26 Thread John Crispin
On 22/12/2015 10:36, Martin Schiller wrote: >>> And there are also situations, where you even can't do it in >> > hardware: >>> > > when you use the xrx200 in Gigabit mode, you can use mac 0,1,2,4,5. >>> > > mac/port 3 is dead in this case. >>> > > >>> > > But you can't tell an enduser/customer

Re: [OpenWrt-Devel] [PATCH] [ubus 1/2] cli: static keyword tweak

2016-02-25 Thread John Crispin
Description of what the patch does is missing John On 26/02/2016 03:27, Zhao, Gang wrote: > Signed-off-by: Zhao, Gang > --- > cli.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cli.c b/cli.c > index f3a041a..c476f35 100644 >

Re: [OpenWrt-Devel] [PATCH] [ubus 2/2] cli: add timeout support for listen command

2016-02-25 Thread John Crispin
Description of what the patch does is missing John On 26/02/2016 03:27, Zhao, Gang wrote: > Signed-off-by: Zhao, Gang > --- > cli.c | 25 - > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/cli.c b/cli.c > index

Re: [OpenWrt-Devel] [PATCH] [ubus 2/2] cli: add timeout support for listen command

2016-02-26 Thread John Crispin
please resend both patches in that format. John On 26/02/2016 09:33, Zhao, Gang wrote: > > > On Fri, Feb 26, 2016 at 2:33 PM, John Crispin <blo...@openwrt.org > <mailto:blo...@openwrt.org>> wrote: > > Description of what the patch does is missing &

Re: [OpenWrt-Devel] [PATCH 2/3] ar71xx: Add OOLITE profile to the Gainstrong manufacturer profile.

2016-02-25 Thread John Crispin
Hi patch 2 and 3 need to be merged together into 1 patch. John On 24/02/2016 22:10, Stijn Segers wrote: > This patch adds the Gainstrong OOLITE profile into the manufacturer > profile file. > > Signed-off by: Stijn Segers > > --- >

Re: [OpenWrt-Devel] [PATCH] comgt: NCM protocol now propagate defaultroute, peerdns, metric to dynamic ifaces

2016-02-26 Thread John Crispin
Hi, can you change this and put the functionality in a more generic place so that it works for all virtual interfaces ? felix explained in the hilink thread that bruno started where he thinks this should go. John On 09/02/2016 21:38, Jakub Janco wrote: > NCM protocol now propagate

Re: [OpenWrt-Devel] [PATCH] [packages] opkg: Make opkg understand old md5

2016-02-26 Thread John Crispin
[...] >>> >>> +define Package/opkg-smime/config >>> +config OPKG_SMIME_SUPPORT_MD5 >>> + bool >>> + default n >>> + depends on PACKAGE_opkg-smime >>> + prompt "Support reading old md5 hashes." >>> + help >>> + Old opkg used md5s, new uses sha. This options enables understanding >>>

Re: [OpenWrt-Devel] [PATCH] dnsmasq: add host-specific lease time option for static hosts

2016-02-26 Thread John Crispin
Hi, this does not apply anymore. mind to rebase and resend it please ? John On 05/01/2016 12:48, Hannu Nyman wrote: > Enable setting a host-specific lease time for static hosts. > The new option is called "leasetime" and the format is similar > as for the default lease time: e.g. 12h, 3d,

Re: [OpenWrt-Devel] [PATCH 2/5] ltq-vdsl-app: load the vrx200 firmware or patch it

2016-02-27 Thread John Crispin
On 28/02/2016 08:44, Felix Fietkau wrote: > On 2016-02-28 08:42, Felix Fietkau wrote: >> On 2016-02-28 08:40, Felix Fietkau wrote: >>> On 2016-02-27 23:59, Hauke Mehrtens wrote: This checks for the VRX firmware provided in the OpenWrt package. Signed-off-by: Hauke Mehrtens

Re: [OpenWrt-Devel] [PATCH 0/3] ar71xx: fix imagenames for some TPlink units

2016-02-25 Thread John Crispin
On 14/02/2016 23:31, Sven Roederer wrote: > These patches change the image-name of some TPlink-routers. > Esp. for the TPlink WR841N + WR841ND some users are confused by the fact > that some images have "nd"-names and others "n"-names only. > In addition this also corrects a missed "D" on WA701

Re: [OpenWrt-Devel] [PATCH] ramips: fix wan port on Dovado Tiny AC

2016-02-25 Thread John Crispin
Hi, comments inline On 22/02/2016 00:40, Andrej Vlašić wrote: > From: Andrej Vlasic > > Wan port on Dovado Tiny AC requires delay on a icplus ip1001 phy receive side > in order to work properly. > > Signed-off-by: Andrej Vlasic > --- >

Re: [OpenWrt-Devel] [PATCH v3] ramips: mt7621: fix WF-2881 for ubi split

2016-02-25 Thread John Crispin
what has changed between V2 and V3 ? On 25/02/2016 09:33, YounJae Rho wrote: > This patch fix firmware split for WF-2881 which was previously manually > partitioned. > > Signed-off-by: YounJae Rho > --- > target/linux/ramips/dts/WF-2881.dts | 14 ++ >

Re: [OpenWrt-Devel] [PATCH 1/2] wwan: Add support for CDC (Huawei 'HiLink') Modems

2016-02-24 Thread John Crispin
On 24/02/2016 09:08, Bruno Randolf wrote: > On 02/24/2016 06:11 AM, Matti Laakso wrote: >>> The reason is that I want different types of Modems to work with the >>> same interface configuration, using 'wwan'. E.g. it's configured like >>> this (/etc/config/network): >>> >>> config interface

Re: [OpenWrt-Devel] [PATCH] package/libs/lzo: update version to 2.09

2016-02-24 Thread John Crispin
Hi, this patch and the other 2 you sent are mangled. i am not sure what happened but even patchwork failed to pick them up properly. please consider using git send-email to send us patches to avoid these issues. John On 24/02/2016 10:27, Daniel Engberg wrote: > Updates lzo to version

Re: [OpenWrt-Devel] [PATCH 1/3] IP Virtual Server - Load Balancer - kernel modules configuration

2016-02-24 Thread John Crispin
Hi Mauro, for the future please add the series version info the the subject. for example [PATCH V3 1/3] that allows us to see what version we are on without having to look at the backlog. additionally you need to put the extra info below the tear line the correct format would be

Re: [OpenWrt-Devel] [PATCH] ramips: mt7621: fix WF-2881 for firmware split

2016-02-24 Thread John Crispin
On 25/02/2016 02:52, YounJae Rho wrote: > Is there anyone who can accept this patch? > It's crucial fix for device WF-2881 > Because WF-2881 currently isn't working without it > > Thanks! you did not even wait 24 hours before complaining, are you joking ? > > -Original Message- >

Re: [OpenWrt-Devel] [PATCH] package/libs/lzo: update version to 2.09 (repost)

2016-02-25 Thread John Crispin
Hi, same issue as before. please send the patch to yourself and try applying the result using "git am" once that works feel free to repost your patches. using git send-email avoids these issues John On 25/02/2016 10:17, Daniel Engberg wrote: > Updates lzo to version 2.09 and changes

Re: [OpenWrt-Devel] [PATCH] [packages] opkg: Make opkg understand old md5

2016-02-25 Thread John Crispin
On 25/02/2016 11:13, Michal Hrusecky wrote: > Felix Fietkau - 10:22 25.02.16 wrote: >> On 2016-02-25 10:05, Michal Hrusecky wrote: >>> Opkg now uses sha256 by default and expects them. Making it understand md5s >>> also >>> and detect md5 sum so we can migrate from configuration that used md5.

Re: [OpenWrt-Devel] [PATCH] Ralink RT288x/RT3xxx: Added support for ZBT-826 / ZBT-1026

2016-02-29 Thread John Crispin
Hi, On 29/02/2016 11:30, Jamie Stuart wrote: > --- a/target/linux/ramips/base-files/lib/ramips.sh > +++ b/target/linux/ramips/base-files/lib/ramips.sh > @@ -478,6 +478,9 @@ ramips_board_detect() { > *"ZBT-WG2626") > name="zbt-wg2626" > ;; > + *"ZBT-WE826") >

Re: [OpenWrt-Devel] [PATCH v3] base-files: For sysfixtime use hwclock if RTC available

2016-01-21 Thread John Crispin
On 21/01/2016 12:53, Bastian Bittorf wrote: > * Petr Štetiar [21.01.2016 12:22]: >> boot() { >> +[ -e "$RTC_DEV" ] && [ -e "$HWCLOCK" ] && $HWCLOCK -s -f $RTC_DEV && >> exit 0 > > thank you! can you please do in this line a: > && return > > and introduce a helper (maybe

Re: [OpenWrt-Devel] [PATCH] ramips: Setup missing gpio exports and fine-tune the memory model number.

2016-01-21 Thread John Crispin
there are 4-5 patches all intermingled into 1 patch. please split it up. one change per patch John On 21/01/2016 13:52, John Clark wrote: >> +pinctrl-0; >>> are you sure this bit is correct ? > > That is there to override the setting from the parent dtsi file. One > could

Re: [OpenWrt-Devel] [PATCH] build: download.mk: bugfix download.pl argument call order

2016-01-20 Thread John Crispin
On 21/01/2016 08:49, Florian Eckert wrote: > From: Florian Eckert > NAK, the description is missing > Signed-off-by: Florian Eckert > --- > include/download.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [OpenWrt-Devel] [PATCH] ramips: Setup missing gpio exports and fine-tune the memory model number.

2016-01-21 Thread John Crispin
On 20/01/2016 04:26, John Clark wrote: > GPIO Changes > > The HLK-RM04 uses i2c and the top half of the uartf port for gpio. HiLink has > labeled the RT5350 gpio1 pin as gpio0 on the device pinout, so it seems to > make sense to export it as "hlk-rm04:gpio0" to avoid confusing it

Re: [OpenWrt-Devel] [PATCH] Ubnt EdgeRouter: Use mmcblk0p3 as ext4 rootfs for default ?

2016-01-20 Thread John Crispin
On 20/01/2016 17:15, daniel wrote: > The UBNT EdgeRouter has an internal mmc flash card. > (unlike the EdgeRouter Lite) > > The factory mmc flash card layout is: > > Device Boot Start End Sectors Size Id Type > /dev/mmcblk0p1 *63 17135 17073 8.3M 83 Linux >

Re: [OpenWrt-Devel] [PATCH] ramips: Add support for Netgear EX2700

2016-01-21 Thread John Crispin
Hi, few comments inline. On 19/01/2016 22:42, Joseph C. Lehner wrote: > This patch adds support for the Netgear EX2700 and builds an approriate > sysupgrade image. > > What's missing is the option to build a factory image flashable via the > router's stock web interface, but this approach is

Re: [OpenWrt-Devel] [PATCH] udpxy: don't disable by default

2016-02-13 Thread John Crispin
On 13/02/2016 23:44, Nerijus Baliūnas wrote: > This patch changes option disabled to '0' as the package has init file and > could be made disabled in System->Startup. It is difficult for new users > to edit /etc/config/udpxy manually. > > Signed-off-by: Nerijus Baliūnas

Re: [OpenWrt-Devel] [EXPERIMENTAL] [PATCH] base-files busybox: Detect LXC guest and act appropriately

2016-02-15 Thread John Crispin
i think having lxc specific hooks sprayed over a pile a scripts is the wrong approach, so NAK on this one. John On 16/02/2016 08:03, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > I have a patch that it will be some time before I

Re: [OpenWrt-Devel] [PATCH] [ar71xx] enable PLC support on DHP-1565 board

2016-02-15 Thread John Crispin
Hi, patch is whitespace broken. please resubmit a fixed version. John On 15/02/2016 22:31, Frédéric Basse wrote: > Enable port 6 of AR8327 switch on DHP-1565 board to allow > communication between CPU & AR7400 PLC chipset. > > Signed-off-by: Frédéric Basse >

Re: [OpenWrt-Devel] write/read from mtd ART partition

2016-02-16 Thread John Crispin
On 16/02/2016 11:43, John kerry wrote: > Hi > > I am trying to write mac address and Serial number in ART partition. > > Creating 6 MTD partitions on "spi0.0": > 0x-0x0004 : "u-boot" > 0x0004-0x0005 : "u-boot-env" > 0x0005-0x0068 : "rootfs" >

Re: [OpenWrt-Devel] [PATCH] lldp: Upgrade to 0.9.0

2016-02-16 Thread John Crispin
On 16/02/2016 11:52, b...@benjii.net wrote: > From: Ben Kelly > > Tested OK in our environment. this description is pretty useless. either list the changes that are in the upstream changelog or point at the release notes. > > Signed-off-by: Ben Kelly > ---

Re: [OpenWrt-Devel] [PATCH v4] ramips: Add support for Netgear EX2700

2016-02-16 Thread John Crispin
label = "reset"; >> +gpios = < 1 1>; >> +linux,code = <0x198>; >> +}; >> + >> +wps { >> +label = "wps"; >> +gpios

Re: [OpenWrt-Devel] [PATCH v4] ramips: Add support for Netgear EX2700

2016-02-16 Thread John Crispin
On 16/02/2016 16:00, Joseph C. Lehner wrote: > I've received a notification from patchwork that the patch status has > been changed to "Accepted" 9 days ago, but it hasn't been merged yet. > > Since I have another patch depending on v4, should I submit v5, or wait > until v4 has been

Re: [OpenWrt-Devel] [PATCH v4] ramips: Add support for Netgear EX2700

2016-02-16 Thread John Crispin
16:31, Joseph C. Lehner wrote: > Sorry, yeah, must have missed that! Thanks! > > On 2016-02-16 16:24, John Crispin wrote: >> >> >> >> >> >> >> >> On 16/02/2016 16:00, Joseph C. Lehner wrote: >>> I've received a notification from pa

Re: [OpenWrt-Devel] [PATCH] [RESEND] [ar71xx] enable PLC support on DHP-1565 board

2016-02-16 Thread John Crispin
Hi, patch is still heavily broken. please try sending it to yourself until you can apply it with "git am" once that works feel free to resend. also try to use git to send the patch, this will make it alot easier for yourself John On 16/02/2016 10:58, Basse, Frederic wrote: > Enable

Re: [OpenWrt-Devel] [PATCH] dropbear: fix forever hanging startup when jffs2 fails to mount

2016-02-16 Thread John Crispin
On 16/02/2016 12:13, Bastian Bittorf wrote: > if something goes wrong while mounting jffs2 (e.g. full flash > and the mount is readonly) the dropbear-init script will hang > forever (and so the startup-procedure) asking: > > root@OpenWrt:~ /etc/init.d/dropbear boot > mv: overwrite

Re: [OpenWrt-Devel] [PATCH 1/3] [ar71xx] matchup of TPlink WR841N(D)-names

2016-02-16 Thread John Crispin
Hi, patch 0/3 has a correct subject prefix, the other 3 dont. please fix and resend using "ar71xx:" John On 14/02/2016 23:31, Sven Roederer wrote: > - remove the suffix (N, ND) to indicate that the image is for all > WR841-models > - some of these models have a "N"-suffix, others have

Re: [OpenWrt-Devel] [PATCH] [v5] ar71xx: Support for Ubiquiti UniFi AP AC LITE

2016-02-16 Thread John Crispin
Hi, apparently i did merge V4 and not V5, sorry about that. looks like only the SoB changed between those 2 versions so no real bad damage John On 12/02/2016 12:25, p.wa...@gmx.at wrote: > From: Paul Wassi > > Add support for the Ubiquiti UniFi AP AC LITE >

Re: [OpenWrt-Devel] [PATCH] sysfixtime and ntpd conflict

2016-02-16 Thread John Crispin
Hi, NAK for various reasons * bad/missing subject prefix * the description is not very verbose and the first sentence has bad grammar * most importantly, this bug needs to be fixed inside ntpd rather than adding a hackish work around to a init.d script have you analyzed what goes wrong inside

Re: [OpenWrt-Devel] [PATCH] ramips: build factory images for Netgear EX2700

2016-02-16 Thread John Crispin
Hi, we do something very similar on some lantiq boards. On 16/02/2016 21:25, Joseph C. Lehner wrote: > This patch adds support for building factory and sysupgrade images > for the Netgear EX2700 that don't require modification of u-boot > environment variables. > could you please briefly

Re: [OpenWrt-Devel] [PATCH v3] ramips: build factory images for Netgear EX2700

2016-02-16 Thread John Crispin
Hi see below On 16/02/2016 23:35, Joseph C. Lehner wrote: > This patch adds support for building factory and sysupgrade images > for the Netgear EX2700 that don't require modification of u-boot > environment variables. > > The bootloader on this device expects the kernel partition to end > on a

Re: [OpenWrt-Devel] [PATCH 0/3 v2] ar71xx: fix imagenames for some TPlink units

2016-02-16 Thread John Crispin
On 17/02/2016 00:57, Sven Roederer wrote: > These patches change the image-name of some TPlink-routers. > Esp. for the TPlink WR841N + WR841ND some users are confused by the fact > that some images have "nd"-names and others "n"-names only. > In addition this also corrects a missed "D" on WA701

Re: [OpenWrt-Devel] [PATCH] [trunk] oldpackages: fix mdk3 build issue

2016-02-18 Thread John Crispin
On 18/02/2016 11:40, Tomislav Požega wrote: > Create a patch that fixes an issue with mdk3 package that would break > build process when enabled with -Werror=format-security message. Closes > ticket https://dev.openwrt.org/ticket/20698 > > Signed-off-by: Tomislav Požega

Re: [OpenWrt-Devel] [PATCH 2/2] Add support for 'metric' to QMI, NCM, MBIM and DirectIP

2016-02-18 Thread John Crispin
On 18/02/2016 17:36, Bruno Randolf wrote: > On 02/18/2016 02:00 PM, Jakub Jančo wrote: >> You should add all important options to networking: >> metric >> defaultroute >> peerdns >> These are important for remote management and dns resolving. >> >> You can see my not yet applied patch >>

Re: [OpenWrt-Devel] [PATCH 4/5] lantiq/xrx200-net: add FID (filtering identifier) setting

2016-02-18 Thread John Crispin
On 18/02/2016 14:13, Martin Schiller wrote: > By setting the FID of a VLAN group to a value other then the default (0) it > is possible to switch from Shared VLAN Learning to Independant VLAN Learning. > and what are the pro / cons of doing so ? [...] > +static int

Re: [OpenWrt-Devel] [PATCH 4/5] lantiq/xrx200-net: add FID (filtering identifier) setting

2016-02-19 Thread John Crispin
On 19/02/2016 08:29, Martin Schiller wrote: > On 02/19/2016 at 6:32 AM, John Crispin wrote: >> >> >> On 18/02/2016 14:13, Martin Schiller wrote: >>> By setting the FID of a VLAN group to a value other then the default (0) it >>> is possible to switch from S

<    10   11   12   13   14   15   16   17   18   19   >