Re: [OpenWrt-Devel] [PATCH 1/3] [Lantiq] [P2812HNUFX] Remove old dts

2015-01-08 Thread John Crispin
On 27/12/2014 11:32, Sylwester Petela wrote: Remove unused P2812HNUFX board definition. Signed-off-by: Sylwester Petela ssc...@gmail.com --- please change the patch to * make use of 1 dtsi file and 2 dts files * after applying your patch 1/3 the tree will not build. please remove old file

Re: [OpenWrt-Devel] [PATCH] Comgt: Add option to ignore ioctl errors

2015-01-08 Thread John Crispin
On 29/12/2014 17:54, Matti Laakso wrote: Some Huawei mobile broadband sticks utilizing the NCM protocol expose the control channel as a cdc-wdm device node instead of a virtual serial port. This device node does not support the serial port ioctls. Add command line option to not check whether

Re: [OpenWrt-Devel] [PATCH] octeon: Add MMC support for EdgeRouter ER8

2015-03-18 Thread John Crispin
On 18/03/2015 14:50, Jonathan Thibault wrote: This adds in-kernel support for the octeon mmc controller so that Ubiquiti ER8 are now bootable from their internal storage. Aimed at the BB branch but should work on trunk as well. Pay attention to the change in default value for bb_size in

Re: [OpenWrt-Devel] [PATCH 1/2] toolchain: The glorious return of glibc, ver 2.21

2015-03-15 Thread John Crispin
mailto:j...@bethesignal.org escreveu: On Fri, Mar 13, 2015 at 6:25 AM, John Crispin blo...@openwrt.org mailto:blo...@openwrt.org wrote: Please don't just compile test. Right now /usr/lib is not added as a searchable path for so-libs which renders it pretty much unusable

Re: [OpenWrt-Devel] [PATCH] kernel: Support kernel options required by systemd

2015-03-15 Thread John Crispin
On 12/03/2015 13:54, Jeff Waugh wrote: +config KERNEL_FHANDLE + bool Compile the kernel with support for fhandle syscalls + default n + Hi, support for fhandle was added in r44765 John ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH 1/3] [rpcd] file: add md5sum support

2015-03-15 Thread John Crispin
Hi, On 15/03/2015 22:00, Luka Perkov wrote: wbuf = blobmsg_alloc_string_buffer(buf, md5, 33); + + for (i = 0; i 16; i++) + sprintf((wbuf + (i * 2)), %02x, (uint8_t) md5[i]); there is a set of brackets too many here + + *(wbuf + 33) = 0; is this not off by 1 ? if we

Re: [OpenWrt-Devel] [PATCH 2/3] [rpcd] file: add support for base64

2015-03-15 Thread John Crispin
On 15/03/2015 22:00, Luka Perkov wrote: b64encode and b64decode functions were taken from zstream project which was written by Steven Barth and John Crispin. i did not write this :) Signed-off-by: Luka Perkov l...@openwrt.org --- file.c | 197

Re: [OpenWrt-Devel] [PATCH 3/3] [rpcd] file: add support for setting mode when writing files

2015-03-15 Thread John Crispin
On 15/03/2015 22:00, Luka Perkov wrote: Signed-off-by: Luka Perkov l...@openwrt.org --- file.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/file.c b/file.c index 54f5d8a..95dd4d4 100644 --- a/file.c +++ b/file.c @@ -92,6 +92,7 @@ static const struct

Re: [OpenWrt-Devel] [PATCH] ralink: mt7621 fix pinctrl config

2015-03-17 Thread John Crispin
Hi, some comments inline On 17/03/2015 08:24, wengbj wrote: From: zouxf fl.serv...@t-firefly.com Signed-off-by: zouxf fl.serv...@t-firefly.com --- target/linux/ramips/dts/mt7621.dtsi| 18 +++--- .../patches-3.18/0062-mt7621-fix-pinctrl.patch | 58

Re: [OpenWrt-Devel] [PATCH] kernel: Support kernel options required by systemd

2015-03-17 Thread John Crispin
On 17/03/2015 09:00, Jeff Waugh wrote: On Mon, Mar 16, 2015 at 5:09 PM, Jeff Waugh j...@bethesignal.org mailto:j...@bethesignal.org wrote: On Mon, Mar 16, 2015 at 4:56 PM, Rafał Miłecki zaj...@gmail.com mailto:zaj...@gmail.com wrote: If you want to put some comments in your

Re: [OpenWrt-Devel] [PATCH] ar71xx: fix LED GPIO definitions for NETGEAR WNR2200

2015-03-17 Thread John Crispin
hi, some more comments inline On 13/03/2015 14:51, Markus Kohls wrote: Signed-off-by: Markus Kohls mar...@kola.li Now with corrected whitespaces and signed --- .../ar71xx/files/arch/mips/ath79/mach-wnr2200.c| 77 ++ 1 file changed, 35 insertions(+), 42

Re: [OpenWrt-Devel] [PATCH 1/3] [rpcd] file: add md5sum support

2015-03-17 Thread John Crispin
On 16/03/2015 18:47, Luka Perkov wrote: + *(wbuf + 33) = 0; is this not off by 1 ? No. ?!?! you are accessing the memory behind wbuf. my question was a statement wrapped as a question to be polite. let me rephrase this is a definate off by one. please fix it.

Re: [OpenWrt-Devel] [PATCH 1/2] gccgo/libgo toolchain support for OpenWrt

2015-03-17 Thread John Crispin
Hi, comment inline On 04/03/2015 19:53, Jeff Waugh wrote: Hi all, I'm sure there are style weirdnesses with this. Commentary much appreciated! - Jeff - It won't work with uClibc 0.99.33.x because it requires make/get/setcontext - It DOES work with a recent uClibc snapshot (with

Re: [OpenWrt-Devel] [PATCH] lantiq/xrx200/TDW8970: add ltq-ptm-vr9 to default packages

2015-03-17 Thread John Crispin
On 17/03/2015 08:17, John Crispin wrote: Hi, does this work with default images ? i recall that when both drivers are loaded, neither works, or only the first caller. the drivers register a call back with the mei driver and there is only a slot for one caller if i remember correctly

Re: [OpenWrt-Devel] [PATCH] lantiq/xrx200/TDW8970: add ltq-ptm-vr9 to default packages

2015-03-17 Thread John Crispin
Hi, does this work with default images ? i recall that when both drivers are loaded, neither works, or only the first caller. the drivers register a call back with the mei driver and there is only a slot for one caller if i remember correctly. John On 16/03/2015 23:14, Alexander Couzens

Re: [OpenWrt-Devel] [PATCH] octeon: Add MMC support for EdgeRouter ER8

2015-03-20 Thread John Crispin
On 18/03/2015 21:04, Jonathan Thibault wrote: On 18/03/15 09:53 AM, John Crispin wrote: Hi Jonathan, nice one, i saw the patch on the lmo mailing list and had this on my todo list for the next days, will give it a shot later on my ER8. do you fancy also sending a version that we can apply

Re: [OpenWrt-Devel] [PATCH 2/2] ralink: MT7621 add i2c controller driver on linux kernel 3.18

2015-03-21 Thread John Crispin
Hi, please see comments inline. also please the checkpatch.pl script on this patch before sending a V2 John On 21/03/2015 06:06, wengbj wrote: ralink i2c driver is not working on MT7621 platform. Porting a new drivers from MTK's source code. Signed-off-by: wengbj

Re: [OpenWrt-Devel] [PATCH 1/2] ralink: add FireWRT power button

2015-03-21 Thread John Crispin
Hi On 21/03/2015 06:06, wengbj wrote: Signed-off-by: wengbj fl.serv...@t-firefly.com --- target/linux/ramips/dts/FIREWRT.dts |5 + 1 file changed, 5 insertions(+) diff --git a/target/linux/ramips/dts/FIREWRT.dts b/target/linux/ramips/dts/FIREWRT.dts index 54f0e55..2b018e6

Re: [OpenWrt-Devel] [PATCH 1/2] ralink: add FireWRT power button

2015-03-21 Thread John Crispin
On 21/03/2015 23:15, Rafał Miłecki wrote: On 21 March 2015 at 06:06, wengbj fl.serv...@t-firefly.com wrote: Signed-off-by: wengbj fl.serv...@t-firefly.com --- target/linux/ramips/dts/FIREWRT.dts |5 + 1 file changed, 5 insertions(+) diff --git

Re: [OpenWrt-Devel] [PATCH 1/2] ralink: add FireWRT power button

2015-03-22 Thread John Crispin
On 22/03/2015 00:31, Rafał Miłecki wrote: On 21 March 2015 at 23:18, John Crispin blo...@openwrt.org wrote: On 21/03/2015 23:15, Rafał Miłecki wrote: On 21 March 2015 at 06:06, wengbj fl.serv...@t-firefly.com wrote: Signed-off-by: wengbj fl.serv...@t-firefly.com --- target/linux/ramips

Re: [OpenWrt-Devel] BB14.07 - no auto build/update from source to download server

2015-03-20 Thread John Crispin
On 20/03/2015 09:53, Christian Schoenebeck wrote: Today I checked my BB 14.07 installation to update ca-certificates. On the download server is still version 20140325 Inside build-tree it's version 20141019 Is there no auto build/update of the download server ? we are working on it. we have

Re: [OpenWrt-Devel] [RFC] glibc 2.21 for OpenWrt

2015-03-11 Thread John Crispin
On 11/03/2015 18:02, Jeff Waugh wrote: On Wed, Mar 11, 2015 at 3:56 AM, Jeff Waugh j...@bethesignal.org wrote: Not content with adding support for uClibc snapshots, I've also tackled glibc 2.21, as eglibc is no longer an actively maintained project. Here's the branch I've been working on

Re: [OpenWrt-Devel] [PATCH] [kernel] wnr2200 gpio

2015-03-11 Thread John Crispin
Hi, Sorry, we require a full name including last name and please add a line such as - Signed-off-by: Markus $lastname m...@kola.li to the patches description John On 11/03/2015 16:53, markus wrote: I tested this and it works with my wnr2200 Apply fixed gpio from Ticket

Re: [OpenWrt-Devel] [PATCH] x86: update to kernel 3.18

2015-03-11 Thread John Crispin
On 02/03/2015 08:20, Russell Senior wrote: copied target/linux/x86/config-3.14 and target/linux/x86/patches-3.14 to 3.18 equivalents and then tweaked until it built. Tested on alix2, soekris net4826 and soekris net4521. Still having trouble with net4826 booting from Grub, alix2 and

Re: [OpenWrt-Devel] [PATCH 2/2] Include bits.h in handler.h to prevent linker error

2015-03-11 Thread John Crispin
Hi, what kind of linker error are you seeing ? John On 06/03/2015 11:41, Simon Hoinkis wrote: --- handler.h | 1 + 1 file changed, 1 insertion(+) diff --git a/handler.h b/handler.h index e3e2af5..d17674a 100644 --- a/handler.h +++ b/handler.h @@ -16,6 +16,7 @@ #include

Re: [OpenWrt-Devel] [PATCH 1/2] Add pkg-config for libnl (3.2) and json-c (0.12) in CMakeLists.txt

2015-03-11 Thread John Crispin
Hi, can you also rebase this patch on the recent CMakeList change i made in netifd and resend the patch John On 06/03/2015 11:41, Simon Hoinkis wrote: --- CMakeLists.txt | 17 + handler.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git

Re: [OpenWrt-Devel] [PATCH] [kernel] wnr2200 gpio

2015-03-11 Thread John Crispin
Hi, On 11/03/2015 13:40, mar wrote: Hi I tested this and it works with my wnr2200 Apply fixed gpio from Ticket https://dev.openwrt.org/ticket/15267 I checkout the latest thruk the Signed-off-by: line is missing. please add it with your full name and resend the patch Thanks,

Re: [OpenWrt-Devel] Why OpenWrt sucks?

2015-03-10 Thread John Crispin
On 10/03/2015 12:39, elektra wrote: Hi folks – OpenWrt is f***ing awesome. Many kudos for this excellent work. My 0.2 BTC, Elektra Hi Elektra, agreed, but we need more cats and unicorns John ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH] ramips: Fix failsafe switch workaround for RT5350 introduced in r42179.

2015-03-10 Thread John Crispin
On 08/03/2015 02:44, Vittorio G (VittGam) wrote: This patch fixes the failsafe switch workaround to avoid soft-bricking routers where the only exposed Ethernet port is not 0 (it is 4 for the HT-TM02 for instance). This is a follow-up of http://patchwork.ozlabs.org/patch/424017/ (sorry

Re: [OpenWrt-Devel] [PATCH] ramips: Fix failsafe switch workaround for RT5350 introduced in r42179.

2015-03-12 Thread John Crispin
On 10/03/2015 20:16, Vittorio G (VittGam) wrote: Il 10.03.2015 14:18 John Crispin ha scritto: hi can you send a version that has the pattern shown below please and 0 1 2 3 4 5 6 is wrong, exclude the wan port from the list please. John The problem is that it's not easy

Re: [OpenWrt-Devel] [PATCH] x86: update to kernel 3.18

2015-03-11 Thread John Crispin
On 11/03/2015 18:54, Russell Senior wrote: John On 02/03/2015 08:20, Russell Senior wrote: copied target/linux/x86/config-3.14 and target/linux/x86/patches-3.14 to 3.18 equivalents and then tweaked until it built. Tested on alix2, soekris net4826 and soekris net4521. Still having

Re: [OpenWrt-Devel] [PATCH 1/1] kernel: refined one of 514-yaffs-3.6-use-delayed-work-instead-of-write_super.patch

2015-03-12 Thread John Crispin
the bit which i am missing here is how do you enable YAFFS_HAS_WRITE_SUPER ? On 02/03/2015 06:11, ngc wrote: Modified 514-yaffs-3.6-use-delayed-work-instead-of-write_super.patch which was included old trunk, to fit the current trunk kernel. This needs to support the behavior when

Re: [OpenWrt-Devel] [PATCH] uClibc: fix syscall() for syscalls with 6 arguments on PowerPC

2015-03-12 Thread John Crispin
i bet you had a lot of fun tracking down this one :) i've just added it to my local queue On 11/03/2015 20:27, Matthias Schiffer wrote: Patch from the uClibc master. Fixes the package fastd on PowerPC. Signed-off-by: Matthias Schiffer mschif...@universe-factory.net ---

Re: [OpenWrt-Devel] [PATCH 1/2] toolchain: The glorious return of glibc, ver 2.21

2015-03-12 Thread John Crispin
Hi Jeff, i am merging the whole lot now with a small change On 11/03/2015 18:17, Jeff Waugh wrote: prompt Preferred standard C++ library - default USE_LIBSTDCXX if USE_EGLIBC + default USE_LIBSTDCXX if USE_GLIBC || USE_EGLIBC i will make eglibc select

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx: rename and extend wrt160nl's trx partition parser

2015-03-05 Thread John Crispin
Hi the patches should be self contained and buildable. if i understand 2/3 correct it is needed for the fixes in 1/3 to build. also in 1/3 you rename and change a file in 1 go, which is not that good. could you resend the series with the following layout 1/3 - only do the renaming 2/3 - add

Re: [OpenWrt-Devel] [PATCH 2/5] kernel: enable AES-NI for x86

2015-03-06 Thread John Crispin
On 06/03/2015 13:01, Ulrich Weber wrote: Hi John, On 06.03.2015 09:19, John Crispin wrote: define KernelPackage/crypto-aes/x86 - FILES+=$(LINUX_DIR)/arch/x86/crypto/aes-i586.ko - AUTOLOAD:=$(call AutoLoad,09,aes-i586) + FILES+=$(LINUX_DIR)/arch/x86/crypto/aes-i586.ko

Re: [OpenWrt-Devel] json-c update

2015-03-06 Thread John Crispin
On 06/03/2015 14:01, Karl Palsson wrote: John Crispin blo...@openwrt.org wrote: while doing so i also noticed that the nes jscon-c has a dependency on -lm which i just killed. Could you elaborate on this please? Is this going to remove support for int64, or change the behaviour of NaN

Re: [OpenWrt-Devel] json-c update

2015-03-06 Thread John Crispin
On 06/03/2015 11:46, John Crispin wrote: while doing so i also noticed that the nes jscon-c has a dependency on -lm which i just killed. i am having a bad typo day apparently ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https

[OpenWrt-Devel] json-c update

2015-03-06 Thread John Crispin
Hi, i am working on updating json-c today to 0.12. we will set 0.12 as a requirement and update all service in one go that use json-c. please dont send any more patches for json-c related updates as we wont use any pkgconfig hacks but simply change to code to use the new abi/folder layout.

Re: [OpenWrt-Devel] [PATCH] x86: update to kernel 3.18

2015-03-13 Thread John Crispin
Hi Russel, can you also send a boot log of the failing soekris so we can see if we have an idea on how to fix it ? John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] rules.mk: add newline definition

2015-03-13 Thread John Crispin
Hi Alexandru, what do you need this for ? John On 12/03/2015 20:14, Alexandru Ardelean wrote: To be used for stuff like $(subst $(space),$(newline),$(SOME_VAR)) Signed-off-by: Alexandru Ardelean ardeleana...@gmail.com --- rules.mk | 5 + 1 file changed, 5 insertions(+) diff

Re: [OpenWrt-Devel] [PATCH 1/2] toolchain: The glorious return of glibc, ver 2.21

2015-03-12 Thread John Crispin
On 12/03/2015 20:22, Mirko Vogt wrote: On 03/11/2015 06:17 PM, Jeff Waugh wrote: It's the eglibc packaging with a bit of spit-polishing. And testing. :-) Signed-off-by: Jeff Waugh j...@bethesignal.org [..] On 03/11/2015 06:02 PM, Jeff Waugh wrote: With those applied, a default (VoCore,

Re: [OpenWrt-Devel] e2fsprogs broken on ARM...

2015-03-30 Thread John Crispin
On 30/03/2015 21:02, John Szakmeister wrote: Commit 988e3615e52b2cd9b9e07f4bbbd76494f7e0cb24 broke building e2fsprogs on an ARM platform. It looks like that in version 1.42.10 the decision was made to drop locally defined versions of both sync_file_range() and fallocate() because they were

Re: [OpenWrt-Devel] [Patch v2] [dnsmasq] backport --tftp-no-fail to ignore missing tftp root

2015-04-01 Thread John Crispin
Hi, please don't use [dnsmasq]. use dnsmasq: instead. otherwise git am does not pick it up. i fixed this manually now so you dont need to send a v3 John On 01/04/2015 01:11, Stefan Tomanek wrote: This patch backports the option --tftp-no-fail to dnsmasq and prevents the service from

Re: [OpenWrt-Devel] [PATCH] spi-ks8995: switch to upstream

2015-04-01 Thread John Crispin
Hi, did you runtime test this ? John On 01/04/2015 01:50, Sergey Ryazanov wrote: This driver is upstream since 2012 (commit: a8e510f682f), so switch to it and remove own sources. Also place it under Network Devices menu together with other phy drivers. Signed-off-by: Sergey

[OpenWrt-Devel] mbim / Sierra Wireless AirCard 340U

2015-04-01 Thread John Crispin
Hi, it seems that umbim has problems talking to this device. without hardware to test on it will be hard to figure out what is wrong. does anyone have a spare/unlocked Sierra Wireless AirCard 340U ? John ___ openwrt-devel mailing list

[OpenWrt-Devel] adding seccomp and service jailing to procd

2015-03-27 Thread John Crispin
OpenWrt service hardening and jailing = Current firmware builds have the problem, that a lot of services are running as root. This is especially critical for those services exposed to the network. Once an attacker has managed to compromise such a service he has

Re: [OpenWrt-Devel] adding seccomp and service jailing to procd

2015-03-27 Thread John Crispin
On 27/03/2015 13:45, Etienne Champetier wrote: Hi, 2015-03-27 10:42 GMT+01:00 John Crispin blo...@openwrt.org mailto:blo...@openwrt.org: OpenWrt service hardening and jailing = ... If there are features that we are not aware

Re: [OpenWrt-Devel] mbim / Sierra Wireless AirCard 340U

2015-04-01 Thread John Crispin
. Downgrade if necessary. -- Davey On Wed, Apr 1, 2015 at 8:19 AM, John Crispin blo...@openwrt.org wrote: Hi, it seems that umbim has problems talking to this device. without hardware to test on it will be hard to figure out what is wrong. does anyone have a spare/unlocked Sierra

Re: [OpenWrt-Devel] [PATCH] lantiq: vr9-vdsl-fw: update w921v firmware version

2015-03-02 Thread John Crispin
On 02/03/2015 19:16, Daniel Golle wrote: Hi Felix! On Tue, Mar 03, 2015 at 07:04:25AM +1300, Felix Fietkau wrote: Signed-off-by: Daniel Golle dan...@makrotopia.org Did you test this properly? Not really tested, yet. w921v_fw_cutter does recognize all the magics and the file header and

Re: [OpenWrt-Devel] [PATCH][RFT] adm5120: switch kernel to 3.18

2015-03-01 Thread John Crispin
On 01/03/2015 14:28, Jonas Gorski wrote: Adding the low_mem feature do you mean zram ? ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH][RFT] adm5120: switch kernel to 3.18

2015-03-01 Thread John Crispin
On 01/03/2015 14:54, Jonas Gorski wrote: On Sun, Mar 1, 2015 at 2:46 PM, John Crispin j...@phrozen.org wrote: if you have time it would be nice if you can build/boot an image with zram for testing Sure, what do I need to do for that? just add zram-swap? I'm unable to find any

Re: [OpenWrt-Devel] [PATCH][RFT] adm5120: switch kernel to 3.18

2015-03-01 Thread John Crispin
On 01/03/2015 14:44, Jonas Gorski wrote: On Sun, Mar 1, 2015 at 2:30 PM, John Crispin blo...@openwrt.org wrote: On 01/03/2015 14:28, Jonas Gorski wrote: Adding the low_mem feature do you mean zram ? Adding low_mem to target's FEATURES changes the default squashfs block size from 256k

Re: [OpenWrt-Devel] minimal work needed to build just the toolchain

2015-03-03 Thread John Crispin
On 03/03/2015 12:27, Claudio Thomas wrote: Hi, the same question was already discussed on 2008-01, but it seems to me, that some iterim steps are no more necessary... I guess that there has been some improvements made in the last 7 years :-) Therefore, I would thankful for a confirmation

Re: [OpenWrt-Devel] lantiq v3.18

2015-02-23 Thread John Crispin
could you also show me the bootlog on 3.14 please On 22/02/2015 20:40, Roger Pueyo Centelles wrote: Sure. U-Boot 2013.10-openwrt5-00014-g0b78b5c-dirty (Mar 11 2014 - 22:56:27) arv7519rw Board: Lantiq ARV7519RW VRX200 Family Board SoC: Lantiq VRX288 v1.1 CPU: 500 MHz IO:250 MHz

Re: [OpenWrt-Devel] lantiq v3.18

2015-02-22 Thread John Crispin
On 22/02/2015 15:26, Roger Pueyo Centelles wrote: *ARV7519RW22* Boot: No (kernel panic, see ³ and attached dmesg) Works with 14.07 image. can i see the full bootlog please ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH v2] ar71xx: TL-WA7210n v2 support

2015-02-22 Thread John Crispin
Hi, patch fails to apply, however i fail to see why. does it apply for you ? John On 19/02/2015 22:06, Hendrik Frenzel wrote: This patch adds support for TP-Link TL-WA7210n[0] [0] http://www.tplink.com/en/products/details/?model=TL-WA7210N Signed-off-by: Hendrik Frenzel

Re: [OpenWrt-Devel] [PATCH] comgt: add hso support

2015-02-23 Thread John Crispin
Hi, some comments inline On 22/02/2015 10:19, Cezary Jackiewicz wrote: Add HSO support to comgt. This is work of Kyklas (see https://dev.openwrt.org/ticket/6995), tested with Option GTM382. Signed-off-by: Cezary Jackiewicz cezary.jackiew...@gmail.com --- diff --git

Re: [OpenWrt-Devel] lantiq v3.18

2015-02-25 Thread John Crispin
On 26/02/2015 02:57, Daniel Gimpelevich wrote: On Sun, 15 Feb 2015 05:21:34 +, Daniel Gimpelevich wrote: On Sat, 14 Feb 2015 19:55:03 +0100, John Crispin wrote: ok, i think the spi clock is just really slow m25p80@0 { #address-cells = 1

Re: [OpenWrt-Devel] adding seccomp and service jailing to procd

2015-03-27 Thread John Crispin
On 27/03/2015 19:56, Luka Perkov wrote: Hi John, On Fri, Mar 27, 2015 at 03:37:33PM +0100, John Crispin wrote: Also i would love to hear the pro and cons of extending ubus vs switching to kdbus (i'm not trying to start a debate, and i really have no idea of the work involved, just curious

Re: [OpenWrt-Devel] seccomp patch lead to build failures

2015-03-26 Thread John Crispin
On 26/03/2015 19:17, Dirk Neukirchen wrote: procd: add jail support 45010 leads to build errors on some? arches On omap I get: /jail/seccomp-bpf.h:72:3: error: #w$ # warning Platform does not support seccomp filter yet which fails the build completely (-Werror issue) I think

Re: [OpenWrt-Devel] seccomp patch lead to build failures

2015-03-26 Thread John Crispin
On 26/03/2015 19:47, Kevin Darbyshire-Bryant wrote: On 26/03/2015 18:39, John Crispin wrote: On 26/03/2015 19:17, Dirk Neukirchen wrote: procd: add jail support 45010 leads to build errors on some? arches On omap I get: /jail/seccomp-bpf.h:72:3: error: #w$ # warning Platform does

Re: [OpenWrt-Devel] seccomp patch lead to build failures

2015-03-26 Thread John Crispin
On 26/03/2015 19:17, Dirk Neukirchen wrote: procd: add jail support 45010 leads to build errors on some? arches On omap I get: /jail/seccomp-bpf.h:72:3: error: #w$ # warning Platform does not support seccomp filter yet which fails the build completely (-Werror issue) I think

Re: [OpenWrt-Devel] [PATCH] scripts: fix ubinize-image on OS X

2015-03-05 Thread John Crispin
Hi Álvaro, On 05/03/2015 16:31, Álvaro Fernández Rojas wrote: Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com --- scripts/ubinize-image.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/ubinize-image.sh b/scripts/ubinize-image.sh index

Re: [OpenWrt-Devel] [PATCH 2/5] kernel: enable AES-NI for x86

2015-03-06 Thread John Crispin
Hi Ulrich, comments inline On 17/02/2015 16:54, Ulrich Weber wrote: Signed-off-by: Ulrich Weber u...@ocedo.com --- package/kernel/linux/modules/crypto.mk | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/package/kernel/linux/modules/crypto.mk

Re: [OpenWrt-Devel] [PATCH] hostapd: add switch_chan and set_vendor_elements ubus methods

2015-03-06 Thread John Crispin
Hi Zefir, if we switch the channel via ubus, then the channel specified inside uci and the one actually used are not consistent. could you tell us what your use case for this is ? John On 10/02/2015 10:30, Zefir Kurtisi wrote: Signed-off-by: Zefir Kurtisi zefir.kurt...@neratec.com

Re: [OpenWrt-Devel] [PATCH 1/3] ralink: add ethernet macaddr to dts for FireWRT

2015-01-30 Thread John Crispin
On 30/01/2015 08:59, Yousong Zhou wrote: Hi, On 30 January 2015 at 15:19, wengbj fl.serv...@t-firefly.com wrote: --- .../linux/ramips/base-files/etc/board.d/02_network |7 +++ target/linux/ramips/dts/FIREWRT.dts|5 + 2 files changed, 12 insertions(+)

Re: [OpenWrt-Devel] [PATCH 1/3] ralink: add ethernet macaddr to dts for FireWRT

2015-01-30 Thread John Crispin
also the Signed-off-by line is missing from all 3 patches On 30/01/2015 08:19, wengbj wrote: --- .../linux/ramips/base-files/etc/board.d/02_network |7 +++ target/linux/ramips/dts/FIREWRT.dts|5 + 2 files changed, 12 insertions(+) diff --git

Re: [OpenWrt-Devel] [PATCH 1/3] ralink: add ethernet macaddr to dts for FireWRT

2015-01-30 Thread John Crispin
On 30/01/2015 12:10, Yousong Zhou wrote: Hi, wengbj It's just that OpenWrt requires a Signed-off-by line for patches to be accepted [1]. That line can be generated by option -s in command `git format-patch -s ...' [1] https://dev.openwrt.org/wiki/SubmittingPatches Regards yousong

Re: [OpenWrt-Devel] [PATCH 3/6] ipq806x: enable usb support

2015-04-03 Thread John Crispin
On 03/04/2015 20:47, Felix Fietkau wrote: On 2015-04-03 05:30, Mathieu Olivari wrote: This change doesn't make USB functional but it does make it selectable from a configuration perspective. Signed-off-by: Mathieu Olivari math...@codeaurora.org I think this should be added to the generic

Re: [OpenWrt-Devel] [PATCH] ar71xx: Add uThing support

2015-04-10 Thread John Crispin
Hi, please read the howto that explains how to submit patches. a few pointers are * subject i wrong * patch is attached and not inline * SoB line is missing * inside the patch there is commented out code. remove it please * // is a c++ style comment. please use /* ... */ syntax --

Re: [OpenWrt-Devel] [PATCH] build: fix postinst generation for AutoProbe modules.

2015-04-11 Thread John Crispin
Hi, On 10/04/2015 14:48, Yousong Zhou wrote: Fixes ticket #19352. Signed-off-by: Yousong Zhou yszhou4t...@gmail.com --- This patch will help generate CONTROL/postinst file in the resulting .ipk file. It was only compile tested and posted here just in case it can help CC rc1. thanks

Re: [OpenWrt-Devel] [PATCH V2 fstools 1/2] jffs2reset: avoid code duplication in jffs2_reset and jffs2_mark

2015-04-11 Thread John Crispin
Hi, On 10/04/2015 21:45, Rafał Miłecki wrote: + /* TODO: Check for /overlay filesystem */ + if (find_filesystem(overlay)) { + ULOG_ERR(overlayfs not supported by kernel\n); + return -1; + } + why did you add the TODO ? what part is missing there ?

Re: [OpenWrt-Devel] [PATCH 1/2] ar71xx: merge ap81 patches into one

2015-04-21 Thread John Crispin
On 21/04/2015 11:49, John Crispin wrote: On 15/04/2015 23:37, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin ro...@advem.lv --- ...ath79-make-chipselect-logic-more-flexible.patch | 21 - .../patches-3.18/604-MIPS-ath79-ap81-fixes.patch | 50

Re: [OpenWrt-Devel] [PATCH 1/2] ar71xx: merge ap81 patches into one

2015-04-21 Thread John Crispin
On 15/04/2015 23:37, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin ro...@advem.lv --- ...ath79-make-chipselect-logic-more-flexible.patch | 21 - .../patches-3.18/604-MIPS-ath79-ap81-fixes.patch | 50 ++

Re: [OpenWrt-Devel] [PATCH 1/4] kernel: mips jump only works with memory less then 256mb. when enable HIGHMEM use long jump

2015-05-06 Thread John Crispin
Hi, what is the difference between this and the previous version ? Johnn On 07/05/2015 04:25, wengbj wrote: Signed-off-by: wengbj fl.serv...@t-firefly.com --- .../patches-3.18/305-mips_module_reloc.patch |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread John Crispin
hi, comments inline On 12/04/2015 03:56, Luka Perkov wrote: Signed-off-by: Luka Perkov l...@openwrt.org --- changes in v2: * no need to null-terminate string after sprintf() file.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/file.c

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
with these patches applied none of the 4MB image build ?! /openwrt/trunk/staging_dir/host/bin/mktplinkfw -H 0x00100101 -W 0x1 -F 4Mlzma -N OpenWrt -V r45435 -k /openwrt/trunk/build_dir/target-mips_34kc_uClibc-0.9.33.2/linux-ar71xx_generic/vmlinux-initramfs -r

Re: [OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

2015-04-14 Thread John Crispin
[...] + if (!S_ISREG(s.st_mode)) + return UBUS_STATUS_NOT_SUPPORTED; should this not be - UBUS_STATUS_INVALID_ARGUMENT I think not supported in response to md5sum of a non-regular file (like a chardev or directory) makes sense here - imho. your codebase, so your call :-)

Re: [OpenWrt-Devel] [Patch] wpan: rework bluetooth / wpan and 6lowpan dependencies

2015-04-14 Thread John Crispin
Hi Dirk, patch does not apply anymore, could you send a rebased version please John On 10/04/2015 18:35, Dirk Neukirchen wrote: Is there a reason for Kernel 4.0 as all the modules already exist in 3.18 - fix: lines are doubled - fix: 6lowpan symbol integrated into a bluetooth

Re: [OpenWrt-Devel] [PATCH] [libubox][v3] b64: add base64 support

2015-04-14 Thread John Crispin
hi comments inline On 13/04/2015 02:34, Luka Perkov wrote: The base code has been taken from zstream project which was written by Steven Barth. Signed-off-by: Luka Perkov l...@openwrt.org CC: Steven Barth ste...@midlink.org --- = changes in v2: Use new API: size_t b64decode(void

Re: [OpenWrt-Devel] [PATCH] ar71xx: add TP-LINK TL-WR710N v2

2015-04-18 Thread John Crispin
Hi, the patch does not apply anymore as we merges the patches that lynxis sent. can you rebase it please John On 18/04/2015 06:43, Cezary Jackiewicz wrote: TP-Link TL-WR710n v2 looks like v1, but has less memory (4MB). Signed-off-by: Cezary Jackiewicz cezary.jackiew...@gmail.com

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
On 14/04/2015 20:48, Alexander Couzens wrote: Hi John, i'm looking into it. I haven't build these with initramfs. Best, lynxis thanks ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH 1/3] ar71xx/image: fix imagesize of template tplink-8mlzma

2015-04-14 Thread John Crispin
On 14/04/2015 21:29, Alexander Couzens wrote: I've found the issue. It was already present on the previous tplink images. The new Build/mktplinkfw step duplicated the rootfs. Once within kernel image and once when using mktplinkfw initramfs. I'll send another patch to this list, but it

Re: [OpenWrt-Devel] mbim / Sierra Wireless AirCard 340U

2015-04-07 Thread John Crispin
On 07/04/2015 12:31, Bjørn Mork wrote: David Hutchison dhutchi...@bluemesh.net writes: Hello John, One of our customers use the 340U, and the latest firmware revision that fixes Windows 8 support.. broke linux support ( http://mtekk.us/archives/guides/netgear-aircard-340u-linux/ ) We

Re: [OpenWrt-Devel] [PATCH] ramips:Add support for MakerModule MicroWRT

2015-04-06 Thread John Crispin
Hi, comments inline On 06/04/2015 02:15, 郭传鈜 wrote: First of all,this patch is not created by me.I just help him to send this patch:-D MicroWRT is an wireless router with 2 USB,1 ethernet port. It has a 16M flash and 64M DDR2 RAM. You can use most interface, such as i2c, SPI, i2s and

Re: [OpenWrt-Devel] OpenWrt release name

2015-04-06 Thread John Crispin
i think we have a winner with 96 vs 50 votes. == Dirty Diamond == 2 cl Rum 2 cl Vodka 2 cl Tequila Silver 2 cl Campari 2 cl Curaçao Blue 2 cl Lime syrup 2 1/2 cl Orange juice Coca Cola ___ openwrt-devel mailing

Re: [OpenWrt-Devel] [PATCH] kernel: add rtl8723au driver (staging)

2015-04-06 Thread John Crispin
On 06/04/2015 11:38, Dirk Neukirchen wrote: On 05.04.2015 10:21, Dirk Neukirchen wrote: - move config symbol to separate package (Why was it there in the first place?) - 8723au might be used in some USB sticks or on some sunxi boards compile tested only Signed-off-by: Dirk Neukirchen

Re: [OpenWrt-Devel] [PATCH] kernel: add rtl8723au driver (staging)

2015-04-06 Thread John Crispin
On 06/04/2015 11:38, Dirk Neukirchen wrote: On 05.04.2015 10:21, Dirk Neukirchen wrote: - move config symbol to separate package (Why was it there in the first place?) - 8723au might be used in some USB sticks or on some sunxi boards compile tested only Signed-off-by: Dirk Neukirchen

Re: [OpenWrt-Devel] [PATCH 0/3] umbim fixes

2015-04-07 Thread John Crispin
On 07/04/2015 15:22, Bjørn Mork wrote: That was a bit too quick of course. Here's a small set of patches which should fix both errors and help debugging similar issues. Bjørn Mork (3): fix subscriber response segfault add command done status to verbose output avoid parsing

Re: [OpenWrt-Devel] Help required for LED toggling for SATA host controller

2015-04-07 Thread John Crispin
On 07/04/2015 15:50, Deepanjan Kar wrote: Dear All, I have introduced a new file in the linux-3.10.49/drivers/leds directory for SATA LED toggling. I however find that the callback registered for LED activity is not getting called. Underneath is the snippet of code and the

Re: [OpenWrt-Devel] [PATCH] [packages] ntpd: fix hotplug script

2015-04-04 Thread John Crispin
Hi, ntpd is part of the packages feed hosted on github. please send a PR with the patch there. John On 04/04/2015 10:30, Sebastian Kemper wrote: Currently the hotplug script never starts because it assumes the wrong path to the binary. Fix the path. Signed-off-by: Sebastian Kemper

Re: [OpenWrt-Devel] [PATCH] logread: add support for non-transparent-framing for Syslog over TCP

2015-04-01 Thread John Crispin
Hi, i have just cooked up an alternative patch to do this. i think we should make \0 or \n a default and then add an option to switch to the other. which one would make more sense as a default ? John On 01/04/2015 18:33, Etienne CHAMPETIER wrote:

Re: [OpenWrt-Devel] [PATCH v2 0/7] updated umbim fixes

2015-04-09 Thread John Crispin
thanks for the series, i also merged 7/7, had that on my list for a while On 08/04/2015 15:31, Bjørn Mork wrote: Sorry about sending the previous version without doing any runtime testing. I overlooked the fact that 'struct command_done_message' doesn't include the header like 'struct

Re: [OpenWrt-Devel] CC-release kernel version

2015-04-09 Thread John Crispin
On 09/04/2015 16:09, Claudio Thomas wrote: On 09.04.2015 15:44, Michael Richardson wrote: And, it would be be nice if all the drivers were up-to-date... :- which will be the CC-release kernel version? 3.18? Thanks, Claudio yes, the builders have been doing test build for 2 weeks now

Re: [OpenWrt-Devel] [PATCH] ubox: make remote logging send \0 or \n on tcp connections as a trailer

2015-04-01 Thread John Crispin
(nc -l 5140) and watching with tcpdump -i any port 5140 -vvvX Your code is cleaner but it's 2 syscalls instead of 1 each time Thanks for your work, Etienne 2015-03-30 6:48 GMT+02:00 John Crispin blo...@openwrt.org mailto:blo...@openwrt.org: Signed-off-by: John Crispin blo

Re: [OpenWrt-Devel] [PATCH] transmission: fallocate64 was bacported to uClibc

2015-04-03 Thread John Crispin
Hi, transmission is hosted in the github feed. please file an issue there. John On 03/04/2015 02:57, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin ro...@advem.lv --- .../patches/010-remove-fallocate64-definition.patch| 14 ++

Re: [OpenWrt-Devel] How to use wm8960-audio driver

2015-06-09 Thread John Crispin
Hi, i tried to make it work before but failed. the dma and pcm drivers seem to be functional. i am able to talk to the codec via i2c, however i failed to get it setup properly and make it play music. while doing some debugging i attached a logic analyzer to the pcm bus and i can actually see

Re: [OpenWrt-Devel] [PATCH 1/1] ramips: Add support for RT5350F-OLinuXino

2015-06-03 Thread John Crispin
Hi, there are lots of places where the tabs were replaced with spaces. maybe your mail client chewed the mail ? the patch as such is fine though. please fix the whitespace problem and resend John On 03/06/2015 11:49, gamis...@gmail.com wrote: From: Dimitar Gamishev HeHoPMaJIeH

Re: [OpenWrt-Devel] Porting OpenWRT to a MediaTek MT7688

2015-06-04 Thread John Crispin
Hi, there is no wifi support fro mt7688 yet. please post your other patches though. John On 04/06/2015 18:06, Thomas David Paynter wrote: Hello All, This is my first post to the list so please let me know if I'm not following list etiquette. I'm currently working on porting

<    5   6   7   8   9   10   11   12   13   14   >