[OpenWrt-Devel] [PATCH] gemini: Drop switch kmod and swconfig

2019-06-30 Thread Linus Walleij
The DIR-685 needs this module compiled in for safety (it is facing the LAN ports) and it is now (as of kernel v4.19) using the DSA switch architecture so swconfig is not needed. Signed-off-by: Linus Walleij --- target/linux/gemini/image/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [OpenWrt-Devel] [PATCH] gpio-button-hotplug: gpio-keys: read initial state

2019-06-18 Thread Linus Walleij
On Tue, Jun 18, 2019 at 12:53 PM David Bauer wrote: > On 17.06.19 22:26, Linus Walleij wrote: > > I think it makes a lot of sense on mechanical pushbuttons to > > implement generic debounce. > > This is, however, not the job of the GPIO driver or is it? If the GPIO bl

Re: [OpenWrt-Devel] [PATCH] gpio-button-hotplug: gpio-keys: read initial state

2019-06-17 Thread Linus Walleij
nd idea as dropping interrupts without feedback > is probably not > what we want. I think it makes a lot of sense on mechanical pushbuttons to implement generic debounce. Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] gpio-button-hotplug: gpio-keys: read initial state

2019-06-16 Thread Linus Walleij
ile (ath79_gpio_read(ctrl, AR71XX_GPIO_REG_INT_PENDING) & mask) {} This way we wait for the status to go low before we allow any IRQs to fire after enableing. Maybe not so good since we may want to turn on IRQs that are asserted at some point, but worth a try. Yours, Linus Walleij ___

[OpenWrt-Devel] [PATCH] ARM: dts: gemini Fix up DNS-313 compatible string

2019-06-16 Thread Linus Walleij
It's a simple typo in the DNS file, which was pretty serious. No scripts were working properly. Fix it up. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts

Re: [OpenWrt-Devel] [PATCH] gpio-button-hotplug: gpio-keys: read initial state

2019-06-15 Thread Linus Walleij
this patch, if this solves the problem I will commit it upstream as well: >From ce4b6db51658e0954f97837095393c5fd1416db2 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 15 Jun 2019 10:18:48 +0200 Subject: [PATCH] gpio: ath79: Clear pending IRQs The ath79 gpio driver may emit "gho

Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-06-14 Thread Linus Walleij
://git.openwrt.org/?p=openwrt/staging/chunkeey.git;a=commit;h=b106a522001e970378c38279fe598acbc867d0f4 > > Let me know if this works now with the ip tool. Yes! I applied this series and all comes up nicely, right MAC address and writeable root filesystem. Feel free to push this and thanks so much

Re: [OpenWrt-Devel] [PATCH] gemini: Fix up patch format

2019-06-11 Thread Linus Walleij
On Tue, Jun 11, 2019 at 11:28 PM Linus Walleij wrote: > One of the patches were not properly refreshed. Fix it up. > > Signed-off-by: Linus Walleij Bah, drop this patch. I was fixing my own out-of-tree patches :P Sorry for the buzz Linu

[OpenWrt-Devel] [PATCH] gemini: Fix up patch format

2019-06-11 Thread Linus Walleij
One of the patches were not properly refreshed. Fix it up. Signed-off-by: Linus Walleij --- .../0008-ARM-dts-Enable-Gemini-flash-access.patch | 7 --- 1 file changed, 7 deletions(-) diff --git a/target/linux/gemini/patches-4.19/0008-ARM-dts-Enable-Gemini-flash-access.patch b

[OpenWrt-Devel] [PATCH v2] gemini: Make root filesystem writeable

2019-06-11 Thread Linus Walleij
] mount_root: reading rootfs failed [ 25.726426] mount_root: mounting /dev/root Well that is not very strange since the whole firmware partition is made read-only in the device tree. Let's fix that by augmenting the OpenWrt patch. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Refresh the patch

[OpenWrt-Devel] [PATCH 2/3 v2] gemini: Make a per-board case for ethernet MAC

2019-06-11 Thread Linus Walleij
The DNS-313 isn't the only special board so let's bite the bullet and create a case ladder in preparation for DIR-685. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebase on the new patch using library functions --- .../lib/preinit/05_set_ether_mac_gemini |

[OpenWrt-Devel] [PATCH 3/3 v2] gemini: Fix MAC address assignment for DIR-685

2019-06-11 Thread Linus Walleij
The DIR-685 has the MAC addresses in the RedBoot code just like DNS-313. Check some magic numbers to determine that the MAC address is where we want it and extract it from RedBoot. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebase on the other patches - Use library functions to

[OpenWrt-Devel] [PATCH 1/3 v2] gemini: Use library functions to assign MAC address

2019-06-11 Thread Linus Walleij
This simplifies the ethernet address extraction script by using standard library functions to locate the MTD partitions and extract ethernet address from a binary offset location in the flash. Suggested-by: Christian Lamparter Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New pa

Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-06-11 Thread Linus Walleij
ot;ip link set dev eth0 address $MAC1" Testing this: ip link set eth0 address 00:50:c2:11:11:11 ip: socket(AF_PACKET,2,0): Address family not supported by protocol Any hints? According to the help it should work ... Yours, Linus Walleij ___ openwr

Re: [OpenWrt-Devel] [PATCH] kernel: Move some DSA config options to generic config

2019-05-27 Thread Linus Walleij
On Sun, May 26, 2019 at 11:46 PM Hauke Mehrtens wrote: > On 5/24/19 11:09 PM, Linus Walleij wrote: > > Hi Hauke, > > > > this patch regresses my Gemini systems because I really need these switches > > to come up and this patch: > > Sorry Linus, > > I didn

[OpenWrt-Devel] [PATCH 3/3] gemini: Fix MAC address assignment for DIR-685

2019-05-24 Thread Linus Walleij
The DIR-685 has the MAC addresses in the RedBoot code just like DNS-313. Check some magic numbers to determine that the MAC address is where we want it and extract it from RedBoot. Signed-off-by: Linus Walleij --- .../lib/preinit/05_set_ether_mac_gemini | 15 +++ 1 file

[OpenWrt-Devel] [PATCH 2/3] gemini: Fix possible hexdump error on MAC assignment

2019-05-24 Thread Linus Walleij
hexdump. Signed-off-by: Linus Walleij --- .../linux/gemini/base-files/lib/preinit/05_set_ether_mac_gemini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/gemini/base-files/lib/preinit/05_set_ether_mac_gemini b/target/linux/gemini/base-files/lib/preinit/05_set_et

[OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-05-24 Thread Linus Walleij
The DNS-313 isn't the only special board so let's bite the bullet and create a case ladder in preparation for DIR-685. Signed-off-by: Linus Walleij --- .../lib/preinit/05_set_ether_mac_gemini | 30 --- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/target

Re: [OpenWrt-Devel] [PATCH] kernel: Move some DSA config options to generic config

2019-05-24 Thread Linus Walleij
_NET_DSA_TAG_DSA is not set > # CONFIG_NET_DSA_TAG_EDSA is not set > +# CONFIG_NET_DSA_VITESSE_VSC73XX is not set Adds them to the generic config as "not set" (disabled). It seems this needs to be partially reverted for Gemini to work

[OpenWrt-Devel] [PATCH] gemini: Make root filesystem writeable

2019-05-24 Thread Linus Walleij
] mount_root: reading rootfs failed [ 25.726426] mount_root: mounting /dev/root Well that is not very strange since the whole firmware partition is made read-only in the device tree. Let's fix that by augmenting the OpenWrt patch. Signed-off-by: Linus Walleij --- ...-DIR-685-partition-table

Re: [OpenWrt-Devel] [PATCH v3] gemini: Support sysupgrade on DIR-685

2019-05-20 Thread Linus Walleij
chime in on how you want people to do generic checksum etc. Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH v3] gemini: Support sysupgrade on DIR-685

2019-05-20 Thread Linus Walleij
This makes sysupgrade work on the D-Link DIR-685 after initial factory install. We create the platform.sh script to support sysupgrade on more targets as we move on with sysupgrade support. Cc: Petr Štetiar Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Drop the WRGG magic check: af

[OpenWrt-Devel] [PATCH 1/2] mtd: Make fixwrgg command work on DIR-685

2019-05-15 Thread Linus Walleij
ect. The magic number is always stored in little endian format however, so make sure this is always read in LE32 format. I chose to create a straight-forward le32_to_cpu() static inline that IMO is simple and easy to read. Cc: Stijn Tintel Signed-off-by: Linus Walleij --- It'd be great if some

[OpenWrt-Devel] [PATCH 2/2] gemini: Fix up firmware checksum on DIR-685

2019-05-15 Thread Linus Walleij
. This works around the problem of the machine not booting after factory install unless the sysupgrade is applied immediately. Based on commit e3875350f3e4185020b64e0588bba521cd1d6e64 "ar71xx: add support for D-Link DAP-2695 rev. A1" Cc: Stijn Tintel Signed-off-by: Linus Walleij --- p

Re: [OpenWrt-Devel] [PATCH v2] gemini: Support sysupgrade on DIR-685

2019-05-14 Thread Linus Walleij
[Adding Stijn Tintel as DAP-2695 A1 maintainer, I think he want to know how we solve this.] On Tue, May 14, 2019 at 2:07 PM Petr Štetiar wrote: > Linus Walleij [2019-05-14 13:16:50]: > > On Tue, May 14, 2019 at 10:30 AM Petr Štetiar wrote: > > > > > Linus Walle

Re: [OpenWrt-Devel] [PATCH v2] gemini: Support sysupgrade on DIR-685

2019-05-14 Thread Linus Walleij
On Tue, May 14, 2019 at 10:30 AM Petr Štetiar wrote: > Linus Walleij [2019-05-12 21:13:17]: > > +REQUIRE_IMAGE_METADATA=1 > > once you set this, you don't need to check for the image magic, do you? If so, > please provide the reason for that. The image magic is necessary f

[OpenWrt-Devel] [PATCH v2] gemini: Support sysupgrade on DIR-685

2019-05-12 Thread Linus Walleij
This makes sysupgrade work on the D-Link DIR-685 after initial factory install. We create the platform.sh script to support sysupgrade on more targets as we move on with sysupgrade support. Cc: Petr Štetiar Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Append metadata to sysupgr

[OpenWrt-Devel] [PATCH] gemini: Support sysupgrade on DIR-685

2019-05-05 Thread Linus Walleij
This makes sysupgrade work on the D-Link DIR-685 after initial factory install. We create the platform.sh script to support sysupgrade on more targets as we move on with sysupgrade support. Signed-off-by: Linus Walleij --- .../gemini/base-files/lib/upgrade/platform.sh | 54

Re: [OpenWrt-Devel] Commit 8dcc1087602e breaks FA526 (Gemini) compile

2019-05-02 Thread Linus Walleij
plying this patch a mere make menuconfig && make clean && make will not do it, you have to rm -rf build_dir. After I did this and rebuilt the whole universe overnight it works again, so I am happy now! :D Thanks for your help anyway! Yours, Linus Walleij _

[OpenWrt-Devel] Commit 8dcc1087602e breaks FA526 (Gemini) compile

2019-05-01 Thread Linus Walleij
uot; CONFIG_arm=y CONFIG_ARCH="arm" CONFIG_SOFT_FLOAT=y Any hints? Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 2/2] gemini: Generate padded kernel+rootfs images for DIR-685

2019-03-11 Thread Linus Walleij
from stock firmware using the web UI and the serial console boot loader. Signed-off-by: Linus Walleij --- target/linux/gemini/config-4.14 | 2 + target/linux/gemini/config-4.19 | 2 + target/linux/gemini/image/Makefile| 23 +++- ...emini-Indent-DIR-685-p

[OpenWrt-Devel] [PATCH 1/2] kernel: mtdsplit: wrgg: Support big and little endian

2019-03-11 Thread Linus Walleij
nness like this: if the kernel entity size gets silly big (bigger than the flash memory) we are probably using the wrong endianness. Example: my kernel of 0x0067ff64 was switched around by wrong endianness and detected as 0x64ff67a0 (the actual size in swapped endianness + header 0xa0). Signed-off

Re: [OpenWrt-Devel] [PATCH v2] net: Allow class-e address assignment via ifconfig ioctl

2019-02-17 Thread Linus Walleij
On Sun, Feb 17, 2019 at 7:22 PM Sasha Levin wrote: > On Thu, Feb 14, 2019 at 02:16:04PM +0100, Linus Walleij wrote: > >From: Dave Taht > > > >commit 65cab850f0eeaa9180bd2e10a231964f33743edf upstream. > > > >While most distributions long ago switched to the ipro

Re: [OpenWrt-Devel] [PATCH 1/8 v3] bridge: multicast to unicast

2019-02-17 Thread Linus Walleij
On Sun, Feb 17, 2019 at 7:16 PM Sasha Levin wrote: > On Thu, Feb 14, 2019 at 02:23:56PM +0100, Linus Walleij wrote: > >From: Felix Fietkau > > > >commit 6db6f0eae6052b70885562e1733896647ec1d807 upstream. > > > >Implements an optional, per bridge port flag an

Re: [OpenWrt-Devel] [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

2019-02-17 Thread Linus Walleij
On Sun, Feb 17, 2019 at 7:16 PM Sasha Levin wrote: > On Thu, Feb 14, 2019 at 02:24:00PM +0100, Linus Walleij wrote: > >From: Rafał Miłecki > > > >commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream. > > > >Values of these fields are set during init and never

Re: [OpenWrt-Devel] [PATCH 6/8 v3] ubifs: Use dirty_writeback_interval value for wbuf timer

2019-02-17 Thread Linus Walleij
On Sun, Feb 17, 2019 at 7:18 PM Sasha Levin wrote: > On Thu, Feb 14, 2019 at 02:24:01PM +0100, Linus Walleij wrote: > >From: Rafał Miłecki > > > >commit 1b7fc2c0069f3864a3dda15430b7aded31c0bfcc upstream. > > > >Right now wbuf timer has hardcoded timeouts an

Re: [OpenWrt-Devel] [PATCH 2/2] gemini: Generate harddisk image for DNS-313

2019-02-17 Thread Linus Walleij
config-4.14 and config-4.19 and added > the f2fs tools. I put them into this separate patch on my staging area: > > https://git.openwrt.org/?p=openwrt/staging/chunkeey.git;a=commit;h=1626b5ca1d963e70a979fc4e6262149208608d46 > > if these work out, please let me know. I'll git it a spi

[OpenWrt-Devel] [PATCH 1/2] firmware-tools/ptgen: Allow generation 0 size partitions

2019-02-15 Thread Linus Walleij
The firmware on the D-Link DNS-313 NAS require two blank partitions before the boot partition. Support this if explicitly requested with a "-n" flag. Tested on the D-Link DNS-313. Signed-off-by: Christian Lamparter [Broken out from original patch] Signed-off-by: Linus Walleij

[OpenWrt-Devel] [PATCH 2/2] gemini: Generate harddisk image for DNS-313

2019-02-15 Thread Linus Walleij
to version 1 so that the firmware bootloader will properly recognize it. We patch a bit around the build files to make sure we get the rootfs size set and that genext2fs is properly built. Tested on the D-Link DNS-313. Signed-off-by: Christian Lamparter [Fixing and tricksing] Signed-off-by: Linus

[OpenWrt-Devel] [PATCH 8/8 v3] netfilter: nf_tables: fix mismatch in big-endian system

2019-02-14 Thread Linus Walleij
stem. So introduce some wrapper functions to store/load an u8 or u16 integer to/from the u32 data register, and use them in the right place. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso Signed-off-by: Linus Walleij --- - This was applied upstream in v4.11 - Should be applied t

[OpenWrt-Devel] [PATCH 7/8 v3] usb: dwc2: Remove unnecessary kfree

2019-02-14 Thread Linus Walleij
From: John Youn commit cd4b1e34655d46950c065d9284b596cd8d7b28cd upstream. This shouldn't be freed by the HCD as it is owned by the core and allocated with devm_kzalloc. Signed-off-by: John Youn Signed-off-by: Felipe Balbi Signed-off-by: Linus Walleij --- - This was applied upstream in v4.10

[OpenWrt-Devel] [PATCH 6/8 v3] ubifs: Use dirty_writeback_interval value for wbuf timer

2019-02-14 Thread Linus Walleij
Weinberger Signed-off-by: Linus Walleij --- - This was applied upstream in v4.10 - Should be applied to stable v4.9.y --- fs/ubifs/io.c| 8 fs/ubifs/ubifs.h | 4 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c index 4d6ce4a2a4b6

[OpenWrt-Devel] [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

2019-02-14 Thread Linus Walleij
visible gain. Signed-off-by: Rafał Miłecki Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Linus Walleij --- - This was applied upstream in v4.10 - Should be applied to stable v4.9.y --- fs/ubifs/io.c| 18 ++ fs/ubifs/ubifs.h | 5 - 2

[OpenWrt-Devel] [PATCH 4/8 v3] kaweth: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
-by: David S. Miller Signed-off-by: Linus Walleij --- - This was applied upstream in v4.11 - Should be applied to stable v4.9.y --- drivers/net/usb/kaweth.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c

[OpenWrt-Devel] [PATCH 3/8 v3] ch9200: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
: New driver for QinHeng CH9200 devices") Signed-off-by: Eric Dumazet Cc: James Hughes Cc: Matthew Garrett Signed-off-by: David S. Miller Signed-off-by: Linus Walleij --- - This was applied upstream in v4.11 - Should be applied to stable v4.9.y --- drivers/net/usb/ch9200.c | 9 ++-

[OpenWrt-Devel] [PATCH 0/8 v3] Stable material from OpenWrt for v4.9.y

2019-02-14 Thread Linus Walleij
This is a series of patches used in OpenWrt's v4.9 backports that seem to be of generic interest to v4.9.y For the remaining patches I cherry-picked the upstream commits except for (8/8) "netfilter: nf_tables: fix mismatch in big-endian system" where I used OpenWrt's backport. ChangeLog v2->v3:

[OpenWrt-Devel] [PATCH 2/8 v3] smsc95xx: Use skb_cow_head to deal with cloned skbs

2019-02-14 Thread Linus Walleij
Acked-by: Woojung Huh Signed-off-by: David S. Miller Signed-off-by: Linus Walleij --- - This was applied upstream in v4.11 - Should be applied to stable v4.9.y --- drivers/net/usb/smsc95xx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb

[OpenWrt-Devel] [PATCH 1/8 v3] bridge: multicast to unicast

2019-02-14 Thread Linus Walleij
Felix Fietkau. Signed-off-by: Felix Fietkau [linus.luess...@c0d3.blue: various bug + style fixes, commit message] Signed-off-by: Linus Lüssing Reviewed-by: Nikolay Aleksandrov Signed-off-by: David S. Miller Signed-off-by: Linus Walleij --- - This was applied upstream in v4.11 - Should be applied

[OpenWrt-Devel] [PATCH v2] uapi/if_ether.h: prevent redefinition of struct ethhdr

2019-02-14 Thread Linus Walleij
this they can just define __UAPI_DEF_ETHHDR 0 to make it work with the kernel. Signed-off-by: Hauke Mehrtens Signed-off-by: David S. Miller Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add SoB line - This is upstream in v4.15 - This should be applied for stable v4.14.y and v4.

[OpenWrt-Devel] [PATCH v2] net: Allow class-e address assignment via ifconfig ioctl

2019-02-14 Thread Linus Walleij
. Signed-off-by: Dave Taht Signed-off-by: David S. Miller Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add SoB-line - This commit is upstream in v4.20 - This should ve applied for stable v4.19.y, v4.14.y and v4.9.y --- include/uapi/linux/in.h | 10 +++--- net/ipv4/devinet.c |

Re: [OpenWrt-Devel] [PATCH] uapi/if_ether.h: prevent redefinition of struct ethhdr

2019-02-14 Thread Linus Walleij
On Thu, Feb 14, 2019 at 1:45 PM Greg Kroah-Hartman wrote: > On Thu, Feb 14, 2019 at 01:27:20PM +0100, Linus Walleij wrote: > > From: Hauke Mehrtens > > > > commit 6926e041a8920c8ec27e4e155efa760aa01551fd upstream. > > > > Musl provides its own ethhdr struct d

[OpenWrt-Devel] [PATCH 7/8 v2] usb: dwc2: Remove unnecessary kfree

2019-02-14 Thread Linus Walleij
From: John Youn commit cd4b1e34655d46950c065d9284b596cd8d7b28cd upstream. This shouldn't be freed by the HCD as it is owned by the core and allocated with devm_kzalloc. Signed-off-by: John Youn Signed-off-by: Felipe Balbi --- - This was applied upstream in v4.10 - Should be applied to stable

[OpenWrt-Devel] [PATCH 6/8 v2] ubifs: Use dirty_writeback_interval value for wbuf timer

2019-02-14 Thread Linus Walleij
From: Rafał Miłecki commit 1b7fc2c0069f3864a3dda15430b7aded31c0bfcc upstream. Right now wbuf timer has hardcoded timeouts and there is no place for manual adjustments. Some projects / cases many need that though. Few file systems allow doing that by respecting dirty_writeback_interval that can

[OpenWrt-Devel] [PATCH 8/8 v2] netfilter: nf_tables: fix mismatch in big-endian system

2019-02-14 Thread Linus Walleij
From: Liping Zhang commit 10596608c4d62cb8c1c2b806debcbd32fe657e71 upstream. Currently, there are two different methods to store an u16 integer to the u32 data register. For example: u32 *dest = >data[priv->dreg]; 1. *dest = 0; *(u16 *) dest = val_u16; 2. *dest = val_u16; For method 1,

[OpenWrt-Devel] [PATCH 5/8 v2] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

2019-02-14 Thread Linus Walleij
From: Rafał Miłecki commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream. Values of these fields are set during init and never modified. They are used (read) in a single function only. There isn't really any reason to keep them in a struct. It only makes struct just a bit bigger without any

[OpenWrt-Devel] [PATCH 4/8 v2] kaweth: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: Eric Dumazet commit 39fba7835aacda65284a86e611774cbba71dac20 upstream. We can use skb_cow_head() to properly deal with clones, especially the ones coming from TCP stack that allow their head being modified. This avoids a copy. Signed-off-by: Eric Dumazet Cc: James Hughes Signed-off-by:

[OpenWrt-Devel] [PATCH 3/8 v2] ch9200: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: Eric Dumazet commit 6bc6895bdd6744e0136eaa4a11fbdb20a7db4e40 upstream. We need to ensure there is enough headroom to push extra header, but we also need to check if we are allowed to change headers. skb_cow_head() is the proper helper to deal with this. Fixes: 4a476bd6d1d9 ("usbnet: New

[OpenWrt-Devel] [PATCH 2/8 v2] smsc95xx: Use skb_cow_head to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: James Hughes commit e9156cd26a495a18706e796f02a81fee41ec14f4 upstream. The driver was failing to check that the SKB wasn't cloned before adding checksum data. Replace existing handling to extend/copy the header buffer with skb_cow_head. Signed-off-by: James Hughes Acked-by: Eric Dumazet

[OpenWrt-Devel] [PATCH 1/8 v2] bridge: multicast to unicast

2019-02-14 Thread Linus Walleij
From: Felix Fietkau commit 6db6f0eae6052b70885562e1733896647ec1d807 upstream. Implements an optional, per bridge port flag and feature to deliver multicast packets to any host on the according port via unicast individually. This is done by copying the packet per host and changing the multicast

[OpenWrt-Devel] [PATCH 0/8 v2] Stable material from OpenWrt for v4.9.y

2019-02-14 Thread Linus Walleij
This is a series of patches used in OpenWrt's v4.9 backports that seem to be of generic interest to v4.9.y For the remaining patches I cherry-picked the upstream commits except for (8/8) "netfilter: nf_tables: fix mismatch in big-endian system" where I used OpenWrt's backport. ChangeLog v1->v2:

[OpenWrt-Devel] [PATCH] uapi/if_ether.h: prevent redefinition of struct ethhdr

2019-02-14 Thread Linus Walleij
From: Hauke Mehrtens commit 6926e041a8920c8ec27e4e155efa760aa01551fd upstream. Musl provides its own ethhdr struct definition. Add a guard to prevent its definition of the appropriate musl header has already been included. glibc does not implement this header, but when glibc will implement

[OpenWrt-Devel] [PATCH] net: Allow class-e address assignment via ifconfig ioctl

2019-02-14 Thread Linus Walleij
From: Dave Taht commit 65cab850f0eeaa9180bd2e10a231964f33743edf upstream. While most distributions long ago switched to the iproute2 suite of utilities, which allow class-e (240.0.0.0/4) address assignment, distributions relying on busybox, toybox and other forms of ifconfig cannot assign

Re: [OpenWrt-Devel] [PATCH 00/10] Stable material from OpenWrt

2019-02-14 Thread Linus Walleij
dress assignment via ifconfig > ioctl") is one such example of that type of patch. > > So I can't take these as-is, sorry. OK I will look closer for each of them and try to mention which stable each of them should go to, I thought they would all be for v4.9 but I was wrong. I'll update and

[OpenWrt-Devel] [PATCH 10/10] uapi/if_ether.h: prevent redefinition of struct ethhdr

2019-02-14 Thread Linus Walleij
From: Hauke Mehrtens Musl provides its own ethhdr struct definition. Add a guard to prevent its definition of the appropriate musl header has already been included. glibc does not implement this header, but when glibc will implement this they can just define __UAPI_DEF_ETHHDR 0 to make it work

[OpenWrt-Devel] [PATCH 09/10] net: Allow class-e address assignment via ifconfig ioctl

2019-02-14 Thread Linus Walleij
From: Dave Taht While most distributions long ago switched to the iproute2 suite of utilities, which allow class-e (240.0.0.0/4) address assignment, distributions relying on busybox, toybox and other forms of ifconfig cannot assign class-e addresses without this kernel patch. While CIDR has

[OpenWrt-Devel] [PATCH 08/10] netfilter: nf_tables: fix mismatch in big-endian system

2019-02-14 Thread Linus Walleij
From: Liping Zhang Currently, there are two different methods to store an u16 integer to the u32 data register. For example: u32 *dest = >data[priv->dreg]; 1. *dest = 0; *(u16 *) dest = val_u16; 2. *dest = val_u16; For method 1, the u16 value will be stored like this, either in big-endian

[OpenWrt-Devel] [PATCH 05/10] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf

2019-02-14 Thread Linus Walleij
From: Rafał Miłecki Values of these fields are set during init and never modified. They are used (read) in a single function only. There isn't really any reason to keep them in a struct. It only makes struct just a bit bigger without any visible gain. Signed-off-by: Rafał Miłecki Reviewed-by:

[OpenWrt-Devel] [PATCH 07/10] usb: dwc2: Remove unnecessary kfree

2019-02-14 Thread Linus Walleij
From: John Youn This shouldn't be freed by the HCD as it is owned by the core and allocated with devm_kzalloc. Signed-off-by: John Youn Signed-off-by: Felipe Balbi --- drivers/usb/dwc2/hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c

[OpenWrt-Devel] [PATCH 06/10] ubifs: Use dirty_writeback_interval value for wbuf timer

2019-02-14 Thread Linus Walleij
From: Rafał Miłecki Right now wbuf timer has hardcoded timeouts and there is no place for manual adjustments. Some projects / cases many need that though. Few file systems allow doing that by respecting dirty_writeback_interval that can be set using sysctl (dirty_writeback_centisecs). Lowering

[OpenWrt-Devel] [PATCH 01/10] bridge: multicast to unicast

2019-02-14 Thread Linus Walleij
From: Felix Fietkau Implements an optional, per bridge port flag and feature to deliver multicast packets to any host on the according port via unicast individually. This is done by copying the packet per host and changing the multicast destination MAC to a unicast one accordingly.

[OpenWrt-Devel] [PATCH 04/10] kaweth: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: Eric Dumazet We can use skb_cow_head() to properly deal with clones, especially the ones coming from TCP stack that allow their head being modified. This avoids a copy. Signed-off-by: Eric Dumazet Cc: James Hughes Signed-off-by: David S. Miller --- drivers/net/usb/kaweth.c | 18

[OpenWrt-Devel] [PATCH 03/10] ch9200: use skb_cow_head() to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: Eric Dumazet We need to ensure there is enough headroom to push extra header, but we also need to check if we are allowed to change headers. skb_cow_head() is the proper helper to deal with this. Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices") Signed-off-by: Eric

[OpenWrt-Devel] [PATCH 02/10] smsc95xx: Use skb_cow_head to deal with cloned skbs

2019-02-14 Thread Linus Walleij
From: James Hughes The driver was failing to check that the SKB wasn't cloned before adding checksum data. Replace existing handling to extend/copy the header buffer with skb_cow_head. Signed-off-by: James Hughes Acked-by: Eric Dumazet Acked-by: Woojung Huh Signed-off-by: David S. Miller

[OpenWrt-Devel] [PATCH 00/10] Stable material from OpenWrt

2019-02-14 Thread Linus Walleij
This is a series of patches used in OpenWrt's v4.9 backports that seem to be of generic interest to v4.9.y As a bunch of commits hit networking I CC DaveM and here so the can nod/object to these, I think the want a bit of control over what goes into networking stable. I avoided two patch sets

[OpenWrt-Devel] [PATCH 2/2] gemini: Name binary "bootpart.tar.gz"

2019-02-07 Thread Linus Walleij
This factory binary i supposed to actually be unzipped and untarred by the user as part of the installation process (this NAS boots from harddisk), so name it "bootpart.tar.gz" and not "factory.bin" so it is helpful for users. Signed-off-by: Linus Walleij --- target/linux/g

[OpenWrt-Devel] [PATCH 1/2] gemini: Fix typo

2019-02-07 Thread Linus Walleij
It's kmod-ledtrig-* not kmod-led-trig-*. Signed-off-by: Linus Walleij --- target/linux/gemini/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/gemini/Makefile b/target/linux/gemini/Makefile index 03f0fdbb1d6c..38a4f254de4a 100644 --- a/target/linux

[OpenWrt-Devel] [PATCH 1/2 v3] gemini: Add v4.19 kernel patches

2019-01-26 Thread Linus Walleij
This is the remainder of kernel patches for the v4.19 kernel. A whole slew of the previous patch stack is now upstream, so this mainly contains the stuff that was added upstream between v4.19 and v5.0-rc1, and then the USB FOTG201 patches from Hans. Signed-off-by: Linus Walleij --- ChangeLog v2

[OpenWrt-Devel] [PATCH 2/2 v3] gemini: Add a config for kernel v4.19

2019-01-26 Thread Linus Walleij
This adds a config for kernel v4.19 to the Gemini target. Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Just add the new config, don't switch kernel yet. - Add missing CONFIG_USB_ROLE_SWITCH as disabled. ChangeLog v1->v2: - Run the config through OpenWrt make kernel_old

[OpenWrt-Devel] [PATCH 0/2 v3] Add Gemini kernel v4.19 files

2019-01-26 Thread Linus Walleij
available here: https://dflund.se/~triad/krad/gemini/openwrt/ On popular request also pushed to github: https://github.com/linusw/openwrt Branch "gemini-v4.19" The patches on that branch include full v4.19 enablement (which should not be applied to OpenWrt) Linus Walleij (2): gemini:

Re: [OpenWrt-Devel] [PATCH 2/4 v2] gemini: Switch to kernel v4.19

2019-01-26 Thread Linus Walleij
On Sat, Jan 26, 2019 at 12:29 PM Linus Walleij wrote: > On Sat, Jan 26, 2019 at 9:29 AM Petr Štetiar wrote: > > then I had to add missing generic symbol CONFIG_USB_ROLE_SWITCH[1] and > > CONFIG_DRM_PANEL_SEIKO_43WVF1G[2] in order to get past kernel config step > > while run

Re: [OpenWrt-Devel] [PATCH 4/4 v2] gemini: Add SL93512R Support

2019-01-26 Thread Linus Walleij
end-rootfs > > Produces similar/compatible files? > (This would make the extra Build/sl93512r-images obsolete). It does, I have a new patch for this. I will not submit it again until we switch to v4.19 though, just sending the kernel patches and config-v4.19 for next iteration. Yours, L

Re: [OpenWrt-Devel] [PATCH 2/4 v2] gemini: Switch to kernel v4.19

2019-01-26 Thread Linus Walleij
ed by Kconfig itself, I think upstream needs patching). I'm not good with USB, it's one of those things I need to learn better, but I didn't need that config symbol at least, make V=s looks fine for me. Yours, Linus Walleij ___ openwrt-devel mailing l

Re: [OpenWrt-Devel] [PATCH 2/4 v2] gemini: Switch to kernel v4.19

2019-01-25 Thread Linus Walleij
On Thu, Jan 24, 2019 at 7:19 PM Stijn Tintel wrote: > On 23/01/19 19:59, Linus Walleij wrote: > > This adds a config and augments the gemini makefile to > > use kernel v4.19. > > > > These devices work so much better with v4.19 so let's > > immediately make it

[OpenWrt-Devel] [PATCH 1/4 v2] gemini: Add v4.19 kernel patches

2019-01-23 Thread Linus Walleij
This is the remainder of kernel patches for the v4.19 kernel. A whole slew of the previous patch stack is now upstream, so this mainly contains the stuff that was added upstream between v4.19 and v5.0-rc1, and then the USB FOTG201 patches from Hans. Signed-off-by: Linus Walleij --- ChangeLog v1

[OpenWrt-Devel] [PATCH 4/4 v2] gemini: Add SL93512R Support

2019-01-23 Thread Linus Walleij
This generates images for the StorLink SL93512R reference design which is supported in kernel v4.19. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Resend. --- target/linux/gemini/image/Makefile | 21 + 1 file changed, 21 insertions(+) diff --git a/target/linux/gem

[OpenWrt-Devel] [PATCH 2/4 v2] gemini: Switch to kernel v4.19

2019-01-23 Thread Linus Walleij
This adds a config and augments the gemini makefile to use kernel v4.19. These devices work so much better with v4.19 so let's immediately make it the default. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Run the config through OpenWrt make kernel_oldconfig and inspect the res

[OpenWrt-Devel] [PATCH 3/4 v2] gemini: Drop switch kmod and swconfig

2019-01-23 Thread Linus Walleij
The DIR-685 needs this module compiled in for safety (it is facing the LAN ports) and it is now using the DSA switch architecture so swconfig is not needed. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Resend. --- target/linux/gemini/image/Makefile | 1 - 1 file changed, 1 delet

[OpenWrt-Devel] [PATCH 0/4 v2] Update Gemini to kernel v4.19

2019-01-23 Thread Linus Walleij
v4.19" Linus Walleij (4): gemini: Add v4.19 kernel patches gemini: Switch to kernel v4.19 gemini: Drop switch kmod and swconfig gemini: Add SL93512R Support target/linux/gemini/Makefile | 2 +- target/linux/gemini/config-4.19 | 494 ++ ta

Re: [OpenWrt-Devel] [PATCH 0/4] Update Gemini to kernel v4.19

2019-01-22 Thread Linus Walleij
m there is that make target for OpenWrt that cleans up the defconfig now that I remember it, I'll try running that. Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 0/4] Update Gemini to kernel v4.19

2019-01-21 Thread Linus Walleij
On Mon, Jan 21, 2019 at 9:39 AM Petr Štetiar wrote: > Linus Walleij [2019-01-19 21:28:58]: > > If the first patch is too big, the patches are also available here: > > https://dflund.se/~triad/krad/gemini/openwrt/ > > is it possible to fetch it somewhere directly in Git?

[OpenWrt-Devel] [PATCH 4/4] gemini: Add SL93512R Support

2019-01-19 Thread Linus Walleij
This generates images for the StorLink SL93512R reference design which is supported in kernel v4.19. Signed-off-by: Linus Walleij --- target/linux/gemini/image/Makefile | 21 + 1 file changed, 21 insertions(+) diff --git a/target/linux/gemini/image/Makefile b/target/linux

[OpenWrt-Devel] [PATCH 2/4] gemini: Switch to kernel v4.19

2019-01-19 Thread Linus Walleij
This adds a config and augments the gemini makefile to use kernel v4.19. These devices work so much better with v4.19 so let's immediately make it the default. Signed-off-by: Linus Walleij --- target/linux/gemini/Makefile| 2 +- target/linux/gemini/config-4.19 | 453

[OpenWrt-Devel] [PATCH 0/4] Update Gemini to kernel v4.19

2019-01-19 Thread Linus Walleij
or swconfig anymore. A new reference design named SL93512R is available so support it. If the first patch is too big, the patches are also available here: https://dflund.se/~triad/krad/gemini/openwrt/ Linus Walleij (4): gemini: Add v4.19 kernel patches gemini: Switch to kernel v4.19 gemini

[OpenWrt-Devel] [PATCH 3/4] gemini: Drop switch kmod and swconfig

2019-01-19 Thread Linus Walleij
The DIR-685 needs this module compiled in for safety (it is facing the LAN ports) and it is now using the DSA switch architecture so swconfig is not needed. Signed-off-by: Linus Walleij --- target/linux/gemini/image/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/gemini

[OpenWrt-Devel] [PATCH 1/4] gemini: Add v4.19 kernel patches

2019-01-19 Thread Linus Walleij
This is the remainder of kernel patches for the v4.19 kernel. A whole slew of the previous patch stack is now upstream, so this mainly contains the stuff that was added upstream between v4.19 and v5.0-rc1, and then the USB FOTG201 patches from Hans. Signed-off-by: Linus Walleij --- ...pinctrl

[OpenWrt-Devel] [PATCH 3/5] ARM: dts: Fix up SQ201 flash access

2018-12-08 Thread Linus Walleij
This sets the partition information on the SQ201 to be read out from the RedBoot partition table, removes the static partition table and sets our boot options to mount root from /dev/mtdblock2 where the squashfs+JFFS2 resides. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-sq201.dts

[OpenWrt-Devel] [PATCH 2/5] ARM: dts: Enable Gemini flash access

2018-12-08 Thread Linus Walleij
flash handling code to switch this in and out when accessed so these lines can be used for GPIO when flash is not accessed, and enable flash access. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 35 +++--- arch/arm/boot/dts/gemini-sq

[OpenWrt-Devel] [PATCH 4/5] ARM: dts: Add the FOTG210 USB host to Gemini boards

2018-12-08 Thread Linus Walleij
This adds the FOTG210 USB host controller to the Gemini device trees. In the main SoC DTSI it is flagged as disabled and then it is selectively enabled on the devices that utilize it. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 8 ++ arch/arm/boot/dts

[OpenWrt-Devel] [PATCH 5/5] ARM: dts: Bump Gemini platforms to use 100ms debounce

2018-12-08 Thread Linus Walleij
The 50ms debounce is too low and give ghost bounces on some platforms. Bump it to 100ms to make it stable. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 4 ++-- arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 +- arch/arm/boot/dts/gemini-nas4220b.dts | 4

[OpenWrt-Devel] [PATCH 1/5] ARM: dts: Fix up the D-Link DIR-685 MTD partition info

2018-12-08 Thread Linus Walleij
0002 "LangPack" Inspecting the flash at 0x1f8000 and 0x1fa000 reveals each of these starting with "RGCFG1" so we assume 0x1f8000-1fbfff is "rgdb" of 0x4. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 16 ++--

<    1   2   3   4   5   6   >