Re: [OpenWrt-Devel] Rebuilding for specific hardware, example ar71xx/image for TP-Link TL-WR841ND

2015-03-23 Thread Yousong Zhou
On 23 March 2015 at 20:07, Jean-Michel Pouré - GOOZE wrote: >> I read buildroot WIKI page: >> http://wiki.openwrt.org/doc/howto/build > > I am getting confused about the build system. > > I am comparing .config generated by buildroot (today's GIT) with > https://downloads.openwrt.org/snapshots/tru

Re: [OpenWrt-Devel] Rebuilding for specific hardware, example ar71xx/image for TP-Link TL-WR841ND

2015-03-23 Thread Yousong Zhou
On 23 March 2015 at 21:07, Jean-Michel Pouré - GOOZE wrote: >> but it works and you can tweak it individually via 'make menuconfig'. >> what we do here, is e.g.: >> echo >.config 'CONFIG_TARGET_ar71xx_generic_TLWR1043=y' > > Thanks. Due to ignorance, I could not figure it out. > > So my script be

Re: [OpenWrt-Devel] Is PPPoE broken in Barrier Breaker?

2015-03-25 Thread Yousong Zhou
On 25 March 2015 at 14:21, valent.turko...@gmail.com wrote: > Hi, > I don't see lots of people using PPPoE with OpenWrt, at least PPPoE is > not mentioned much on forums. > > My first opportunity to use PPPoE with OpenWrt was yesterday and I > lost few hours on troubleshooting few issues and final

Re: [OpenWrt-Devel] Is PPPoE broken in Barrier Breaker?

2015-03-25 Thread Yousong Zhou
>>> Here is a link to this issue on the forum (it is not only me): >>> https://forum.openwrt.org/viewtopic.php?pid=269850 >>> >>> It looks like pppd after sending request for IP address instead >>> getting response with IP data instead package to terminate LCP is >>> received. Does somebody have i

Re: [OpenWrt-Devel] uci -P no longer working correctly

2015-03-30 Thread Yousong Zhou
Hi, On Mar 30, 2015 10:28 PM, "Mark Mentovai" wrote: > > In the latest OpenWrt trunk, I found that config_get has stopped loading uncommitted uci changes from /tmp/.uci. I rely on this behavior, which had worked well for years. > > I found a change[1] in uci that’s responsible. > Sorry for the in

[OpenWrt-Devel] [PATCH 1/2] tests: add test cases for -P and -p options.

2015-03-31 Thread Yousong Zhou
--- test/references/options.delta.result |5 + test/tests.d/090_cli_options | 38 ++ 2 files changed, 43 insertions(+) create mode 100644 test/references/options.delta.result create mode 100644 test/tests.d/090_cli_options diff --git a/test/refe

[OpenWrt-Devel] [PATCH 2/2] Fix delta path handling.

2015-03-31 Thread Yousong Zhou
- Make ctx->savedir sit at the end of ctx->delta_path. - Add notes to uci_set_savedir() and uci_add_delta_path() to document the behaviour changes. --- delta.c | 39 +-- libuci.c |1 + uci.h|6 -- 3 files changed, 38 insertions(+), 8 dele

Re: [OpenWrt-Devel] uci -P no longer working correctly

2015-03-31 Thread Yousong Zhou
On Mar 30, 2015 11:27 PM, "Yousong Zhou" wrote: > > Hi, > > On Mar 30, 2015 10:28 PM, "Mark Mentovai" wrote: > > > > In the latest OpenWrt trunk, I found that config_get has stopped loading uncommitted uci changes from /tmp/.uci. I rely on th

[OpenWrt-Devel] [PATCH 1/2] tests: add test coverage for uci export with -P option.

2015-04-01 Thread Yousong Zhou
- With "uci -P xxx/ export", changes in "xxx/" should be applied last. - With "uci -p xxx/ commit", changes in "xxx/" should be applied before ctx->savedir. Signed-off-by: Yousong Zhou --- test/references/cli.options.delta.

[OpenWrt-Devel] [PATCH 2/2] delta: fix adding new savedir.

2015-04-01 Thread Yousong Zhou
Newly added savedir should be at the last position while uci_add_delta_path() will add it to the position second to the last. Signed-off-by: Yousong Zhou --- delta.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/delta.c b/delta.c index 357f5c7..459d2c7 100644 --- a

Re: [OpenWrt-Devel] UCI config bug or intent?

2015-04-03 Thread Yousong Zhou
On Apr 3, 2015 2:27 PM, "Dominik Taborsky" wrote: > > Any thoughts on this? > > If anything, could anyone point me the right direction so I can fix it myself? > > > > On 03/25/2015 11:28 AM, Dominik Taborsky wrote: >> >> Hello, >> >> a colleague of mine discovered a problem when using UCI: when th

Re: [OpenWrt-Devel] [BUG] UCI parsing regression?

2015-04-08 Thread Yousong Zhou
On Apr 8, 2015 10:36 PM, "Russell Senior" wrote: > > > I just mentioned this on IRC last night, and have not had time to > investigate, but a uci-defaults script (http://sprunge.us/EAYF) that was > working about a month ago, now gives me this: http://sprunge.us/LTWi, > and the uci commit fails. T

Re: [OpenWrt-Devel] [PATCH] [ramips] HiWiFi HC5661 Support for Openwrt

2015-04-18 Thread Yousong Zhou
Hi, Yunhao The patch is not in plaintext format and is whitespace broken. You can work around this by generating a patch with git-format-patch, then send it with git-send-email. On 18 April 2015 at 19:39, 田韵豪 wrote: > HiWiFi HC5661 (Ji 1s) support. > > Signed-off-by: B Tian < tianyh2...@163.com

Re: [OpenWrt-Devel] [PATCH][RFC] ramips:Add support for HiWiFi HC5761.

2015-04-24 Thread Yousong Zhou
Hi, Chuanhong Sorry for this late reply, but the email was placed in my Spam folder by Gmail. Looks like there is something wrong with your mail setup. On 19 April 2015 at 00:02, 郭传鈜 wrote: > Hi,all! > I'm trying to add support for HiWiFi HC5761 router,This patch works > fine.Because the mac

[OpenWrt-Devel] [PATCH] gemini: image: fix race condition when building copy-kernel.bin

2019-09-10 Thread Yousong Zhou
-ext4-factory.bin] Error 2 With this change, output files are directed to $(KDIR) Signed-off-by: Yousong Zhou --- target/linux/gemini/image/Makefile | 9 + target/linux/gemini/image/copy-kernel/Makefile | 14 ++ 2 files changed, 15 insertions(+), 8 deletions(-) d

[OpenWrt-Devel] [PATCH 1/2] config: kernel: add KERNEL_X86_VSYSCALL_EMULATION

2019-09-10 Thread Yousong Zhou
Binaries in container images may need this. E.g. nginx:1.7.9 used in k8s default deployment manifest file for demostration [1] [1] https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#creating-a-deployment Signed-off-by: Yousong Zhou --- config/Config-kernel.in | 18

[OpenWrt-Devel] [PATCH 2/2] config: kernel: remove KERNEL_LXC_MISC

2019-09-10 Thread Yousong Zhou
Kernel features are neutral. The two cascaded features can also be useful for other container related tools It's also less error-prone if only kconfig symbols from the kernel are prefixed KERNEL_ Signed-off-by: Yousong Zhou --- Changes will also need to be applied to packages feed, s

[OpenWrt-Devel] [PATCH 2/3] imx6: install-dtb as separate IMAGE

2019-09-12 Thread Yousong Zhou
--- target/linux/imx6/image/Makefile | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/linux/imx6/image/Makefile b/target/linux/imx6/image/Makefile index b0933d77d2..d1e9e9034e 100644 --- a/target/linux/imx6/image/Makefile +++ b/target/linux/imx6/image/Makefile

[OpenWrt-Devel] [PATCH 3/3] apm821xx: image: remove unused kernel.dtb from IMAGES

2019-09-12 Thread Yousong Zhou
It's a leftover from 2271967f ("pm821xx: utilize build ARTIFACTs") Signed-off-by: Yousong Zhou --- target/linux/apm821xx/image/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/apm821xx/image/Makefile b/target/linux/apm821xx/image

[OpenWrt-Devel] [PATCH 1/3] build: install-dtb: fix race condition when copying dtb

2019-09-12 Thread Yousong Zhou
musl_eabi/linux-at91_sam9x/tmp/openwrt-at91-sam9x-at91sam9263ek-ubifs-dtb' failed make[4]: *** [/builder/shared-workdir/build/build_dir/target-arm_arm926ej-s_musl_eabi/linux-at91_sam9x/tmp/openwrt-at91-sam9x-at91sam9263ek-ubifs-dtb] Error 1 Signed-off-by: Yousong Zhou --- include/im

Re: [OpenWrt-Devel] [PATCH 2/2] sunxi: enable audio for sun4i

2019-09-26 Thread Yousong Zhou
On Mon, 23 Sep 2019 at 22:01, Andre Heider wrote: > > Enable SND_SUN4I_CODEC and SND_SUN4I_SPDIF. > > Tested on cubieboard2. > > Signed-off-by: Andre Heider The module should be available as package kmod-sound-soc-sunxi. See target/linux/sunxi/modules.mk . Does this work for you?

[OpenWrt-Devel] [PATCH] libpcap: build with cmake

2019-10-18 Thread Yousong Zhou
8384bfc50b [2] https://github.com/openwrt/packages/issues/10270 Signed-off-by: Yousong Zhou --- package/libs/libpcap/Makefile | 72 .../patches/100-debian_shared_lib.patch | 168 -- .../102-makefile_disable_manpages.patch | 77 .../libpca

[OpenWrt-Devel] [PATCH v2] libpcap: build with cmake

2019-10-18 Thread Yousong Zhou
mp-group/libpcap/commit/93ca5ff7030aaf1219e1de05ec89a68384bfc50b [2] https://github.com/openwrt/packages/issues/10270 Signed-off-by: Yousong Zhou --- v2 <- v1 - Added PKG_LICENSE_FILES definition - Removed custom Build/InstallDev to use the cmake.mk provided one. It will install .a libs. T

Re: [OpenWrt-Devel] [PATCH] libpcap: build with cmake

2019-10-18 Thread Yousong Zhou
On Sat, 19 Oct 2019 at 04:15, Rosen Penev wrote: ... > > + $(INSTALL_DIR) $(1)/usr/lib/pkgconfig > > + $(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/libpcap.pc > > $(1)/usr/lib/pkgconfig/ > I would check the generated pkgconfig file to see if the file paths > are correct. Example of co

Re: [OpenWrt-Devel] OpenWrt 19.07 release schedule ?

2019-10-18 Thread Yousong Zhou
On Thu, 17 Oct 2019 at 16:19, Jo-Philipp Wich wrote: > ... > > * rpcd leaks memory I will give this a try and see how many leaks I can uncover in the weekend. Regards, yousong ___ openwrt-devel mailing list openwrt-devel@lists.openwr

[OpenWrt-Devel] [PATCH rpcd 2/4] exec: properly free memory on rpc_exec() error

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- exec.c | 7 ++- plugin.c | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index eb52966..f490ad7 100644 --- a/exec.c +++ b/exec.c @@ -313,7 +313,7 @@ rpc_exec(const char **args, rpc_exec_write_cb_t in, switch

[OpenWrt-Devel] [PATCH rpcd 4/4] uci: free configs list memory on return

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- uci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uci.c b/uci.c index 1587a19..7667505 100644 --- a/uci.c +++ b/uci.c @@ -1284,6 +1284,7 @@ rpc_uci_changes(struct ubus_context *ctx, struct ubus_object *obj, uci_unload(cursor, p

[OpenWrt-Devel] [PATCH rpcd 3/4] exec: alway call finish_cb to allow plugin to free up memory

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- exec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index f490ad7..1b05a91 100644 --- a/exec.c +++ b/exec.c @@ -131,13 +131,12 @@ rpc_exec_reply(struct rpc_exec_context *c, int rv

[OpenWrt-Devel] [PATCH rpcd 1/4] plugin: exec: properly free memory on parse error

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- plugin.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/plugin.c b/plugin.c index 3740622..d3526aa 100644 --- a/plugin.c +++ b/plugin.c @@ -321,11 +321,16 @@ rpc_plugin_parse_exec(const char *name, int fd) obj_type = calloc

Re: [OpenWrt-Devel] rpcd memory leaks [Was: Re: OpenWrt 19.07 release schedule ?]

2019-10-20 Thread Yousong Zhou
On Sat, 19 Oct 2019 at 13:02, Petr Štetiar wrote: > > Yousong Zhou [2019-10-19 12:11:08]: > > Hi, > > > > * rpcd leaks memory > > > > I will give this a try and see how many leaks I can uncover in the weekend. > > great! BTW that release blocking one mig

[OpenWrt-Devel] [PATCH rpcd v2 3/6] exec: alway call finish_cb to allow plugin to free up memory

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- exec.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index f490ad7..1b05a91 100644 --- a/exec.c +++ b/exec.c @@ -131,13 +131,12 @@ rpc_exec_reply(struct rpc_exec_context *c, int rv

[OpenWrt-Devel] [PATCH rpcd v2 4/6] uci: free configs list memory on return

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- uci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uci.c b/uci.c index 1587a19..7667505 100644 --- a/uci.c +++ b/uci.c @@ -1284,6 +1284,7 @@ rpc_uci_changes(struct ubus_context *ctx, struct ubus_object *obj, uci_unload(cursor, p

[OpenWrt-Devel] [PATCH rpcd v2 1/6] plugin: exec: properly free memory on parse error

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- plugin.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/plugin.c b/plugin.c index 3740622..d3526aa 100644 --- a/plugin.c +++ b/plugin.c @@ -321,11 +321,16 @@ rpc_plugin_parse_exec(const char *name, int fd) obj_type = calloc

[OpenWrt-Devel] [PATCH rpcd v2 0/6] memory issue fixes

2019-10-20 Thread Yousong Zhou
v2 <- v1 - Added two fixes suggested by scan-build result [1] [1] https://ynezz.gitlab.io/-/openwrt-rpcd/-/jobs/323420230/artifacts/build/scan/2019-10-17-075741-163-1/index.html Yousong Zhou (6): plugin: exec: properly free memory on parse error exec: properly free memory on rpc_e

[OpenWrt-Devel] [PATCH rpcd v2 2/6] exec: properly free memory on rpc_exec() error

2019-10-20 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- exec.c | 7 ++- plugin.c | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index eb52966..f490ad7 100644 --- a/exec.c +++ b/exec.c @@ -313,7 +313,7 @@ rpc_exec(const char **args, rpc_exec_write_cb_t in, switch

[OpenWrt-Devel] [PATCH rpcd v2 5/6] file: exec: properly free memory on error

2019-10-21 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- file.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/file.c b/file.c index b1adcb7..47fcd9a 100644 --- a/file.c +++ b/file.c @@ -823,13 +823,15 @@ rpc_file_exec_run(const char *cmd, const struct blob_attr *sid, if

[OpenWrt-Devel] [PATCH rpcd v2 6/6] main: exec_self: make clang analyzer happy

2019-10-21 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/main.c b/main.c index 1db3241..12cb4c5 100644 --- a/main.c +++ b/main.c @@ -47,12 +47,16 @@ static void exec_self(int argc, char **argv) { int i; - const char

Re: [OpenWrt-Devel] [PATCH rpcd v2 0/6] memory issue fixes

2019-10-21 Thread Yousong Zhou
On Mon, 21 Oct 2019 at 18:44, Petr Štetiar wrote: > > Yousong Zhou [2019-10-21 06:10:25]: > > Hi, > > > Yousong Zhou (6): > > seems like two patches didn't made it to the mailing list and/or patchwork. > > -- ynezz Oops.. Resent the two patches a

[OpenWrt-Devel] [PATCH] toolchain: gcc: allow sanitizers when USE_GLIBC

2019-10-21 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/libs/toolchain/Makefile | 172 toolchain/gcc/final/Makefile| 5 +- 2 files changed, 176 insertions(+), 1 deletion(-) diff --git a/package/libs/toolchain/Makefile b/package/libs/toolchain/Makefile index a63746c448

Re: [OpenWrt-Devel] [PATCH rpcd v2 6/6] main: exec_self: make clang analyzer happy

2019-10-21 Thread Yousong Zhou
On Tue, 22 Oct 2019 at 12:49, Petr Štetiar wrote: > > Petr Štetiar [2019-10-22 06:26:14]: > > > Yousong Zhou [2019-10-21 12:59:24]: > > > > almost happy: > > > > main.c:65:1: warning: Potential leak of memory pointed to by 'args' > >

[OpenWrt-Devel] [PATCH fstools] libblkid-tiny: ntfs: fix use-after-free

2019-10-25 Thread Yousong Zhou
The memory pointed to by ns can be reallocated when checking mft records Signed-off-by: Yousong Zhou --- libblkid-tiny/ntfs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libblkid-tiny/ntfs.c b/libblkid-tiny/ntfs.c index 3a9d5cb..dfe22e2 100644 --- a/libblkid

[OpenWrt-Devel] [PATCH fstools v2] libblkid-tiny: ntfs: fix use-after-free

2019-10-25 Thread Yousong Zhou
The memory pointed to by ns can be reallocated when checking mft records Fixes FS#2129 Signed-off-by: Yousong Zhou --- v2 <- v1 -Fix bad DBG() call in previous patch missing volume_serial as arg libblkid-tiny/ntfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) d

[OpenWrt-Devel] [PATCH fstools] block: use fsck.fat instead of dosfsck

2019-10-25 Thread Yousong Zhou
Dosfsck is only available when --enable-compat-symlinks was given when configuring dosfstools. These symlinks are not enabled in OpenWrt dosfstools package Suggested by Reiner Otto in FS#2408 Signed-off-by: Yousong Zhou --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [OpenWrt-Devel] [PATCH] rpcd: uci: fix segfault and double free on set method

2019-10-28 Thread Yousong Zhou
Hi Daniel, On Mon, 28 Oct 2019 at 18:32, Daniel Danzberger wrote: > > Invalid reuse of pointers from uci_ptr can cause the rcpd to segfault on > already freed memory. > This bug could be trigged by calling 'set' with emtpy values on multiple non > existing or already cleard options. > > For exa

[OpenWrt-Devel] [PATCH fstools 2/5] block: support hierarchical mount/umount

2019-10-29 Thread Yousong Zhou
nce of mount info, then strlen(mount.target), then strcmp(probe_info.dev) Resolves FS#2214 Signed-off-by: Yousong Zhou --- block.c | 152 +--- 1 file changed, 101 insertions(+), 51 deletions(-) diff --git a/block.c b/block.c index 99672fb..66dcf9c 1006

[OpenWrt-Devel] [PATCH fstools 1/5] block: umount: skip / unless -a is given

2019-10-29 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- block.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index a849500..99672fb 100644 --- a/block.c +++ b/block.c @@ -1118,7 +1118,7 @@ static int mount_device(struct probe_info *pr, int type) return 0

[OpenWrt-Devel] [PATCH fstools 3/5] block: mount_action: handle mount/umount deps

2019-10-29 Thread Yousong Zhou
This is required at least in system startup when "block hotplug" will be triggered by udevtrigger. E.g. /dev/vdb needs to be mounted at /mnt/s and /dev/vdc /mnt. It does not work if /dev/vdb was triggered then mounted first Signed-off-by: Yousong Zhou --- bl

[OpenWrt-Devel] [PATCH fstools 5/5] block: mount_device: err log only when mp deviates from spec

2019-10-29 Thread Yousong Zhou
Fixes possible memleak of mp as well Resolves FS#1523 Signed-off-by: Yousong Zhou --- block.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 084e7fc..1972c50 100644 --- a/block.c +++ b/block.c @@ -1092,10 +1092,14 @@ static int

[OpenWrt-Devel] [PATCH fstools 4/5] block: mount_device: skip extroot earlier

2019-10-29 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- block.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 15caaba..084e7fc 100644 --- a/block.c +++ b/block.c @@ -1087,6 +1087,10 @@ static int mount_device(struct device *dev, int type) return 0

[OpenWrt-Devel] [PATCH libubox] vlist: add more macros for loop iteration

2019-10-29 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- vlist.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/vlist.h b/vlist.h index 8170abf..ff6b138 100644 --- a/vlist.h +++ b/vlist.h @@ -72,4 +72,19 @@ void vlist_flush_all(struct vlist_tree *tree); #define vlist_for_each_element(tree, element

Re: [OpenWrt-Devel] [PATCH uci 2/2] build: Add -Wclobbered to detect problems with longjmp

2019-11-03 Thread Yousong Zhou
Hi Hauke On Sat, 2 Nov 2019 at 00:07, Hauke Mehrtens wrote: > > When we jump back to a save point in UCI_THROW() with longjmp all the > registers will be reset to the old values when we called UCI_TRAP_SAVE() > last time, but the memory is not restored. This will revert all the > variables which

Re: [OpenWrt-Devel] [PATCH] x86: generate reproducible UUID

2019-11-03 Thread Yousong Zhou
On Mon, 4 Nov 2019 at 07:47, Paul Spooren wrote: > > This commit changes the behaviour of UUID generation. Instead of using > the rand module of perl, generating a random UUID per compile, it now > hashes the SOURCE_DATE_EPOCH, resulting in a reproducible UUID. > > Signed-off-by: Paul Spooren > -

Re: [OpenWrt-Devel] [PATCH] build: make GCC version 6+ minimal host build requirement

2019-11-12 Thread Yousong Zhou
On Tue, 12 Nov 2019 at 16:16, Petr Štetiar wrote: > > Currently minimal GNU supported GCC version is 7 (from May 2, 2017), buildbots > are using default GCC version 6 on Debian 9 (old stable), current Debian > stable 10 has GCC version 8. > > Signed-off-by: Petr Štetiar > --- > > While adding CI

Re: [OpenWrt-Devel] [PATCH] build: make GCC version 6+ minimal host build requirement

2019-11-12 Thread Yousong Zhou
On Tue, 12 Nov 2019 at 17:12, Petr Štetiar wrote: > > Yousong Zhou [2019-11-12 16:26:14]: > > Hi, > > > Not quite sure how much benefit enforcing -Wextra can bring to the > > whole code base. > > I'm adding -Wextra for some time already to any C project I t

[OpenWrt-Devel] [PATCH] kernel: nf_conntrack_rtcache: fix cleanup on netns delete and rmmod

2019-11-13 Thread Yousong Zhou
Fixes FS#1472, FS#2353, FS#2426 Fixes: b3f95490 ("kernel: generic: Add kernel 4.14 support") Signed-off-by: Yousong Zhou --- .../020-backport_netfilter_rtcache.patch | 14 +- .../020-backport_netfilter_rtcache.patch | 14 +- 2 files c

Re: [OpenWrt-Devel] [PATCH libubox 9/9] avl: guard against theoretical null pointer dereference

2019-11-20 Thread Yousong Zhou
On Wed, 20 Nov 2019 at 20:01, Petr Štetiar wrote: > > clang-10 analyzer reports following: > > avl.c:671:25: warning: Access to field 'parent' results in a dereference of > a null pointer (loaded from field 'right') > node->right->parent = parent; >~ ^ > > Which seem

Re: [OpenWrt-Devel] [PATCH libubox 9/9] avl: guard against theoretical null pointer dereference

2019-11-20 Thread Yousong Zhou
On Wed, 20 Nov 2019 at 21:33, Petr Štetiar wrote: > > Yousong Zhou [2019-11-20 20:33:06]: > > Hi, > > thanks for review! > > > The first check (node->left == NULL && node->right == NULL) if > > matched, will return. > > You can see the code pa

Re: [OpenWrt-Devel] [PATCH libubox 9/9] avl: guard against theoretical null pointer dereference

2019-11-20 Thread Yousong Zhou
On Wed, 20 Nov 2019 at 21:46, Yousong Zhou wrote: > > On Wed, 20 Nov 2019 at 21:33, Petr Štetiar wrote: > > > > Yousong Zhou [2019-11-20 20:33:06]: > > > > Hi, > > > > thanks for review! > > > > > The first check (node->left =

Re: [OpenWrt-Devel] [PATCH libubox 8/9] blobmsg_json: fix possible uninitialized struct member

2019-11-20 Thread Yousong Zhou
On Wed, 20 Nov 2019 at 20:01, Petr Štetiar wrote: > > clang-10 analyzer reports following: > > blobmsg_json.c:285:2: warning: The expression is an uninitialized value. The > computed value will also be garbage > s->indent_level++; > ^ Add else branch to initial

[OpenWrt-Devel] Running k3s on OpenWrt

2019-11-27 Thread Yousong Zhou
Hi list, I am sending this email in case it's also interesting to someone in the community, and to also avoid it bit rotting in my repo [1] A few months ago, I started working on bringing up k3s on OpenWrt. I managed to have a small k8s cluster with nodes running centos and openwrt. Likely othe

Re: [OpenWrt-Devel] Running k3s on OpenWrt

2019-11-28 Thread Yousong Zhou
On Fri, 29 Nov 2019 at 00:32, Paul Spooren wrote: > > Hi Yousong, > > > A few months ago, I started working on bringing up k3s on OpenWrt. I > > managed to have a small k8s cluster with nodes running centos and > > openwrt. Likely other linux distros will also do, but I didn't test > > combinati

[OpenWrt-Devel] [PATCH] zones: enforce forward policy with zone_NAME_src_POLICY

2019-12-12 Thread Yousong Zhou
one_NAME_dest_POLICY that matches "-o br-lan" Fixes FS#2525 Signed-off-by: Yousong Zhou --- zones.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/zones.c b/zones.c index 310583d..f268615 100644 --- a/zones.c +++ b/zones.c @@ -317,11 +317,11 @@ fw3_load

Re: [OpenWrt-Devel] [PATCH] zones: enforce forward policy with zone_NAME_src_POLICY

2019-12-13 Thread Yousong Zhou
On Fri, 13 Dec 2019 at 16:58, Jo-Philipp Wich wrote: > > Hi, > > per definition, zone forward policies were only ever meant to apply to > traffic between interfaces within the same zone *not* to traffic > anywhere else. > > Your patch would break that assumption as far as I can see. > > ~ Jo I se

Re: [OpenWrt-Devel] [PATCH fstools] Revert "block: mount_action: handle mount/umount deps"

2019-12-27 Thread Yousong Zhou
On Fri, 27 Dec 2019 at 16:53, Rafał Miłecki wrote: > > From: Rafał Miłecki > > This reverts commit 32c3126b2f0464106d74317336b6aef1d7d5f82f. > > Internal list of devices guarantees some basic sorting (by device type > and then a name) but nothing more. In particular it's not guaranteed > (and it'

Re: [OpenWrt-Devel] [PATCH fstools] Revert "block: mount_action: handle mount/umount deps"

2019-12-29 Thread Yousong Zhou
On Sat, 28 Dec 2019 at 18:27, Rafał Miłecki wrote: > > On 27.12.2019 13:25, Yousong Zhou wrote: > > On Fri, 27 Dec 2019 at 16:53, Rafał Miłecki wrote: > >> > >> From: Rafał Miłecki > >> > >> This reverts commit 32c3126b2f0464106d74317336b6

[PATCH 2/3] netfilter: add kmod-nft-socket

2022-02-24 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- include/netfilter.mk | 2 ++ package/kernel/linux/modules/netfilter.mk | 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/netfilter.mk b/include/netfilter.mk index 751fabef19..83455cc378 100644 --- a/include

[PATCH 3/3] netfilter: add kmod-nft-tproxy

2022-02-24 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- include/netfilter.mk | 2 ++ package/kernel/linux/modules/netfilter.mk | 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/netfilter.mk b/include/netfilter.mk index 83455cc378..2ef8f83e4c 100644 --- a/include

[PATCH 1/3] netfilter: separate packages for kmod-ipt-socket and kmod-ipt-tproxy

2022-02-24 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- include/netfilter.mk | 13 package/kernel/linux/modules/netfilter.mk | 39 ++- 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/include/netfilter.mk b/include/netfilter.mk index 4602a1d412

[RFC 2/2] ath79: port HiWiFi HC6361 from ar71xx

2022-04-08 Thread Yousong Zhou
hsmt image 81b193b95ea5f8e5c30cd62fa9facf275f39233be4fdeed7038f3deed2736156 After the bootstrap step, current build of OpenWrt can be installed there fine. Signed-off-by: Yousong Zhou --- .../linux/ath79/dts/ar9331_hiwifi_hc6361.dts | 156 ++ .../generic/base-files/etc/board.d/01_leds| 4 + target/linux/a

[RFC 0/2] Backport HiWiFi HC6361 support from ar71xx

2022-04-08 Thread Yousong Zhou
t; was added the the tree. But later the probe will fail with -EPROBE_DEFER because of PHY connect failure. Then on the 2nd call of ag71xx_probe and of_get_mac_address, the incremented address will be found and incremented again Yousong Zhou (2): ath79: add nvmem cell mac-address-ascii support

[RFC 1/2] ath79: add nvmem cell mac-address-ascii support

2022-04-08 Thread Yousong Zhou
This is needed for devices with mac address stored in ascii format, e.g. HiWiFi HC6361 to be ported in the following patch. Signed-off-by: Yousong Zhou --- ...of_net-add-mac-address-ascii-support.patch | 103 ++ .../408-mtd-redboot_partition_scan.patch | 4 +- ...of_net

[OpenWrt-Devel] [PATCH 1/2] ramips: mt7530: remove redundant global attrs for port mirroring

2020-02-29 Thread Yousong Zhou
swconfig dev switch0 port 4 set enable_mirror_tx 1 Signed-off-by: Yousong Zhou --- .../drivers/net/ethernet/mediatek/mt7530.c| 88 --- 1 file changed, 88 deletions(-) diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mt7530.c b/target/linux/ramips

[OpenWrt-Devel] [PATCH 2/2] ramips: mt7530: more detailed output for unexpected etag_ctrl

2020-02-29 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- .../ramips/files-4.14/drivers/net/ethernet/mediatek/mt7530.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mt7530.c b/target/linux/ramips/files-4.14/drivers/net/ethernet

Re: [OpenWrt-Devel] jffs2: Erase at 0x01ab0000 failed immediately: errno -22 on ZBT-WG3526 (32M)

2020-03-01 Thread Yousong Zhou
On Mon, 2 Mar 2020 at 10:21, Enrico Mioso wrote: > > Hi! I flashed OpenWRt master (commit > 4349d4c6823bfe09caabbdd3c9a65198addc76d6) on this device. All seems to work > fine, but I sawthis in the dmesg. > > should I worry about my flash chip? > thank you guys!! > > Enrico This could be a softw

[OpenWrt-Devel] [PATCH 1/4] kernel: 5.4: move some kconfig options to generic

2020-03-04 Thread Yousong Zhou
CONFIG_64BIT_TIME=y CONFIG_KASAN_STACK=1 CONFIG_UBSAN_ALIGNMENT=y CONFIG_UNIX_SCM=y CONFIG_DMA_DECLARE_COHERENT=y CONFIG_OF_RESERVED_MEM=y --- target/linux/apm821xx/config-5.4| 6 -- target/linux/ath79/config-5.4 | 6 -- t

[OpenWrt-Devel] [PATCH 2/4] malta: add kernel 5.4 config

2020-03-04 Thread Yousong Zhou
Copied from config-4.19 Signed-off-by: Yousong Zhou --- target/linux/malta/config-5.4 | 336 ++ 1 file changed, 336 insertions(+) create mode 100644 target/linux/malta/config-5.4 diff --git a/target/linux/malta/config-5.4 b/target/linux/malta/config-5.4 new

[OpenWrt-Devel] [PATCH 0/4] malta: kernel 5.4 support

2020-03-04 Thread Yousong Zhou
First patch in this series tries to move some common 5.4 options to generic config. Then it moves on to switching malta target to using 5.4 kernel by default Yousong Zhou (4): kernel: 5.4: move some kconfig options to generic malta: add kernel 5.4 config malta: update kernel config-5.4

[OpenWrt-Devel] [PATCH 3/4] malta: update kernel config-5.4

2020-03-04 Thread Yousong Zhou
With malta/be selected make kernel_menuconfig CONFIG_TARGET=subtarget_platform Signed-off-by: Yousong Zhou --- target/linux/malta/config-5.4 | 50 --- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/target/linux/malta/config-5.4 b/target

[OpenWrt-Devel] [PATCH 4/4] malta: switch to kernel 5.4 by default

2020-03-04 Thread Yousong Zhou
--- target/linux/malta/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/malta/Makefile b/target/linux/malta/Makefile index 05969c8bff..3a1f50b77f 100644 --- a/target/linux/malta/Makefile +++ b/target/linux/malta/Makefile @@ -13,7 +13,7 @@ SUBTARGETS:=le be

Re: [OpenWrt-Devel] [PATCH] malta: fix missing watchdog dependency in hwmon-sch5627

2020-03-05 Thread Yousong Zhou
a 2d8c7ff52c24 > ("hwmon/sch56xx: Depend on watchdog for watchdog core functions") in > v3.5. Does it make we actually package watchdog.ko as a module? Lots of targets already set it as builtin, but I do not remember ever interacting with it directly on ar71xx, ramips. Regards,

Re: [OpenWrt-Devel] [PATCH] malta: fix missing watchdog dependency in hwmon-sch5627

2020-03-05 Thread Yousong Zhou
On Thu, 5 Mar 2020 at 20:43, Petr Štetiar wrote: > > Yousong Zhou [2020-03-05 19:56:40]: > > > > Fixes following error uncovered while building malta/be on 5.4: > > > > > > Package kmod-hwmon-sch5627 is missing dependencies for the following > > > l

Re: [OpenWrt-Devel] [PATCH] malta: fix missing watchdog dependency in hwmon-sch5627

2020-03-09 Thread Yousong Zhou
a 2d8c7ff52c24 > ("hwmon/sch56xx: Depend on watchdog for watchdog core functions") in > v3.5. > > Cc: Yousong Zhou > Signed-off-by: Petr Štetiar > --- > target/linux/malta/config-4.19 | 1 + > target/linux/malta/config-5.4 | 1 + > 2 files changed, 2 insertion

Re: [OpenWrt-Devel] [PATCH 06/12] malta: Remove kernel 4.14 support

2020-03-10 Thread Yousong Zhou
> 4.14 in addition to kernel 4.19 and 5.4. > > Signed-off-by: Hauke Mehrtens Acked-by: Yousong Zhou Regards, yousong > --- > target/linux/malta/config-4.14 | 326 - > 1 file changed, 326 deletions(-) > delete mode 100644 targ

Re: [OpenWrt-Devel] [PATCH 01/12] armvirt: Remove kernel 4.14 support

2020-03-10 Thread Yousong Zhou
> 4.14 in addition to kernel 4.19 and 5.4. > > Signed-off-by: Hauke Mehrtens Acked-by: Yousong Zhou Regards, yousong > --- > target/linux/armvirt/32/config-4.14 | 121 --- > target/linux/armvirt/64/config-4.14 | 179 --- >

Re: [OpenWrt-Devel] [PATCH v4 4/4] ath79: add DEVICE_VARIANT for ubnt_bullet-m-xw

2020-03-10 Thread Yousong Zhou
On Wed, 11 Mar 2020 at 09:07, Russell Senior wrote: > > Signed-off-by: Russell Senior > --- > target/linux/ath79/image/generic-ubnt.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/ath79/image/generic-ubnt.mk > b/target/linux/ath79/image/generic-ubnt.mk > index 5808d8f42

Re: [OpenWrt-Devel] [PATCH] treewide: 5.4: move WATCHDOG_CORE symbol into generic

2020-03-17 Thread Yousong Zhou
On Tue, 17 Mar 2020 at 17:01, Petr Štetiar wrote: > > WATCHDOG_CORE config symbol provides driver/framework for all watchdog > timer drivers and gives them the /dev/watchdog interface (and later also > the sysfs interface). > > WATCHDOG_CORE config symbol was changed from bool to tristate in v5.2

[OpenWrt-Devel] [PATCH] generic: mips: exclude more dsemul code when fpu-emu is not enabled

2020-03-26 Thread Yousong Zhou
:00 0 [stack] 7ff63000-7ff64000 r--p 00:00 0 [vvar] 7ff64000-7ff65000 r-xp 00:00 0 [vdso] Signed-off-by: Yousong Zhou --- ...e-dsemul-code-when-CONFIG_MIPS_FP_SU.patch | 140 ++ 1 file changed, 140 insertions(+) create mode 100644

Re: [OpenWrt-Devel] [PATCH] generic: mips: exclude more dsemul code when fpu-emu is not enabled

2020-03-29 Thread Yousong Zhou
On Mon, 30 Mar 2020 at 07:17, Rosen Penev wrote: > > On Sun, Mar 29, 2020 at 8:34 AM Hauke Mehrtens wrote: > > > > On 3/27/20 5:28 AM, Yousong Zhou wrote: > > > The patch is backported from mips-next. In addition to minor reduction > > > of code size and r

Re: [OpenWrt-Devel] [PATCH v2] scripts: add docker-run-rootfs.sh

2020-04-14 Thread Yousong Zhou
Hi Paul, On Wed, 15 Apr 2020 at 08:40, Paul Spooren wrote: > > The script allows to run a OpenWrt x86/64 rootfs in no time. It is > possible to access the web interface and SSH via 192.168.1.1. > > By using docker volume mounts you can easily share files/folders between > container and host, allo

Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-12 Thread Yousong Zhou
On Sat, 2 May 2020 at 03:21, Philip Prindeville wrote: > > From: Philip Prindeville > > If the start_time > stop_time on a rule, then the --contiguous arg > should be included in the rule. It seems that start_time >= stop_time has its defined meaning in xt_time module. Better add another uci op

Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-12 Thread Yousong Zhou
On Wed, 13 May 2020 at 00:39, Philip Prindeville wrote: > > > > > On May 12, 2020, at 7:08 AM, Yousong Zhou wrote: > > > > On Sat, 2 May 2020 at 03:21, Philip Prindeville > > wrote: > >> > >> From: Philip Prindeville > >> > >&g

[PATCH firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-22 Thread Yousong Zhou
Fixes FS#3231 Signed-off-by: Yousong Zhou --- zones.c | 8 1 file changed, 8 insertions(+) diff --git a/zones.c b/zones.c index 68b02ab..d5e756c 100644 --- a/zones.c +++ b/zones.c @@ -580,6 +580,14 @@ print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state

Re: [PATCH firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-23 Thread Yousong Zhou
Hi Jo, On Thu, 23 Jul 2020 at 14:31, Jo-Philipp Wich wrote: > > Hi Yousong, > > > On 7/23/20 6:05 AM, Yousong Zhou wrote: > > Fixes FS#3231 > > > > Signed-off-by: Yousong Zhou > > --- > > zones.c | 8 > > 1 file changed, 8 insertions(

[PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-23 Thread Yousong Zhou
Fixes FS#3231 Signed-off-by: Yousong Zhou --- zones.c | 8 1 file changed, 8 insertions(+) diff --git a/zones.c b/zones.c index 68b02ab..d45077a 100644 --- a/zones.c +++ b/zones.c @@ -580,6 +580,14 @@ print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state

Re: [PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-26 Thread Yousong Zhou
On Fri, 24 Jul 2020 at 23:41, Baptiste Jonglez wrote: > > Hi, > > On 24-07-20, Yousong Zhou wrote: > > Fixes FS#3231 > > It looks like this bug also affects 18.06 and 19.07, so the fix should > probably be backported. > Done. For the record, i backported it as patc

Re: [PATCH 3/3] treewide: switch to HTTPS by default

2020-07-27 Thread Yousong Zhou
On Mon, 27 Jul 2020 at 17:03, Petr Štetiar wrote: > > Henrique de Moraes Holschuh [2020-07-24 13:02:30]: > > > On 24/07/2020 11:29, Petr Štetiar wrote: > > > As there is now WolfSSL included by default due to SAE/WPA3 we can > > > finally switch to TLS/SSL in other parts as well. > > > > > +DEFAU

Re: [PATCHv2] libunwind: update to 1.4.0

2020-07-28 Thread Yousong Zhou
ME) > -PKG_HASH:=43997a3939b6ccdf2f669b50fdb8a4d3205374728c2923ddc2354c65260214f8 > -PKG_FIXUP:=autoreconf > -PKG_INSTALL:=1 > +PKG_HASH:=df59c931bd4d7ebfd83ee481c943edf015138089b8e50abed8d9c57ba9338435 > > +PKG_MAINTAINER:=Yousong Zhou > PKG_LICENSE:=X11 > PKG_LICENSE_FILES:=LICENSE > PKG_CPE_ID:=cpe:/a:libunwin

Re: [PATCHv2] libunwind: update to 1.4.0

2020-07-28 Thread Yousong Zhou
On Wed, 29 Jul 2020 at 11:56, Rosen Penev wrote: > > On Tue, Jul 28, 2020 at 6:57 PM Yousong Zhou wrote: > > > > On Wed, 29 Jul 2020 at 04:29, Rosen Penev wrote: > > > > > > Cleanup Makefile for consistency with other ones. > > > > > >

Re: [PATCH] busybox: fix fwmark and add fwmask support to ip rule

2020-08-03 Thread Yousong Zhou
On Tue, 4 Aug 2020 at 06:58, Rui Salvaterra wrote: > > BusyBox ip (rule) applet supports fwmark for policy routing (albeit through > the > old and deprecated RTA_PROTOINFO message attribute), but fwmask is completely > unsupported. For this reason, mwan3 depends on ip(-tiny), which compiles to >

[PATCH] dnsmasq: abort when dnssec requested but not available

2020-08-04 Thread Yousong Zhou
error (unlikely but less so ;) So this is just being proactive. on/off choices with uci option "dnssec" are still available like before Link: https://github.com/openwrt/openwrt/pull/3265#issuecomment-667795302 Signed-off-by: Yousong Zhou --- package/network/services/dnsmasq/Makefil

<    1   2   3   4   5   6   7   8   >