Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-12 Thread Michael Büsch 
On Mon, 12 Oct 2015 14:04:09 +0200
Felix Fietkau  wrote:

> If we do everything in git, we either have to constantly remember to tag
> revisions,

Only some milestones would have to be tagged on a regular basis. This
could even be done automatically with a daily tag or such.
git describe will do the rest. It will do even more than svn revisions,
because it includes (part of) the hash.

-- 
Michael


pgpnElG2SDkAc.pgp
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [packages] ddns-scripts: Support Mythic Beast's Dynamic DNS API

2014-04-12 Thread Michael Büsch 
On Sat, 12 Apr 2014 08:48:24 +0100
Liam Fraser l...@mythic-beasts.com wrote:

  # Winco DDNS
  ddns.com.br
 http://[DOMAIN]:[PASSWORD]@members.ddns.com.br/nic/update?hostname=[DOMAIN]myip=[IP];
 +
 +# Mythic Beasts (https://www.mythic-beasts.com) Dynamic DNS
 +mythic-beasts.com  
 http://dnsapi4.mythic-beasts.com/?domain=[USERNAME]password=[PASSWORD]command=REPLACE%20[DOMAIN]%2060%20A%20DYNAMIC_IP;


Doesn't this support https?
Sending username and password over http seems dangerous.


-- 
Michael.


Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E



signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] /dev/watchdog from shell script

2011-12-29 Thread Michael Büsch 
On Thu, 29 Dec 2011 06:52:18 +
Bastian Bittorf bitt...@bluebottle.com wrote:

   A better way would be IMHO to use a cron.minutely which fire's
   an ioctl to /dev/watchdog. if crond is removed, the device  
  should  
   reboot. so i need a way to invoke an ioctl from shellscript.  
  
  I think this doesn't work.  
 
 in our special case it would work, because all daemon-checking
 is done via cron. so if cron fails everything is not working anymore.
   
  What you could try is increasing the likeliness of the watchdog
  process
  to get killed on OOM.
  Setting /proc/WATCHDOGPID/oom_score_adj to 1000 will always kill
  the watchdog
  on any oom condition, as far as I can see.  
 
 Thats seems like an interesting idea.
 As far i can read oom_kill.c this will add 100% to the oom_badness() of
 the watchdog-kicker, but the value is calculated based on memory-consumption. 
 IMHO this is not enough, because even our mini-cron
 consumes more memory then the watchdog-kicker.  

No, this is not true.


/*
* /proc/pid/oom_score_adj ranges from -1000 to +1000 such that it may
* either completely disable oom killing or always prefer a certain
* task.
*/
points += p-signal-oom_score_adj;

if (points = 0)
return 1;
return (points  1000) ? points : 1000;


This is done in a loop for every process and then the process with the highest
score, which is max 1000 and watchdog has 1000, is selected. It is
unlikely that there is another process which also has 1000 due to its memory
consumption only, that is selected first. And it's even unlikelier that cron
consumes 1000 points of badness. So cron will never be selected in favor of 
watchdog.

 beside that:
 would'nt it be senseful to adjust START=01 to /etc/init.d/watchdog
 and place something like this?
 
 pid=$( pidof watchdog )
 echo 1000 /proc/$pid/oom_score_adj  

yeah, could do this.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] /dev/watchdog from shell script

2011-12-28 Thread Michael Büsch 
On Wed, 28 Dec 2011 10:39:33 +
Bastian Bittorf bitt...@bluebottle.com wrote:

 for having a better way not to lost a router i like to
 use /dev/watchdog from a shell script. the reason is this:
 
 Sometimes the oom-killer removes important tasks like
 ssh + httpd + routing + cron but leaves the watchdog-petting on,
 so the device is running, but in fact lost.
 
 A better way would be IMHO to use a cron.minutely which fire's
 an ioctl to /dev/watchdog. if crond is removed, the device should
 reboot. so i need a way to invoke an ioctl from shellscript.

I think this doesn't work.

What you could try is increasing the likeliness of the watchdog process
to get killed on OOM.
Setting /proc/WATCHDOGPID/oom_score_adj to 1000 will always kill the watchdog
on any oom condition, as far as I can see.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt-Commits] r28688 - in trunk/tools/firmware-utils: . src

2011-10-30 Thread Michael Büsch 
On Sun, 30 Oct 2011 23:57:41 +0100
openwrt-comm...@openwrt.org wrote:

 Author: acinonyx
 Date: 2011-10-30 23:57:41 +0100 (Sun, 30 Oct 2011)
 New Revision: 28688

Just a few comments...

 --- trunk/tools/firmware-utils/src/mkedimaximg.c  
 (rev 0)
 +++ trunk/tools/firmware-utils/src/mkedimaximg.c  2011-10-30 22:57:41 UTC 
 (rev 28688)

 +#if (__BYTE_ORDER == __LITTLE_ENDIAN)
 +#  define HOST_TO_LE16(x)(x)
 +#  define HOST_TO_LE32(x)(x)
 +#else
 +#  define HOST_TO_LE16(x)bswap_16(x)
 +#  define HOST_TO_LE32(x)bswap_32(x)
 +#endif
 +
 +struct header
 +{
 +unsigned char sign[4];
 +unsigned int start;
 +unsigned int flash;
 +unsigned char model[4];
 +unsigned int size;
 +} __attribute__ ((packed));

 +static unsigned short fwcsum (struct buf *buf) {
 +int i;
 +unsigned short ret = 0;
 +
 +for (i = 0; i  buf-size / 2; i++)
 + ret -= ((unsigned short *) buf-start)[i];

It seems you need
ret -= LE16_TO_HOST(((unsigned short *) buf-start)[i]);
to be endianness safe.

 +if (header.sign == NULL) {
 + fprintf(stderr, no signature specified\n);
 + usage(EXIT_FAILURE);
 +}
 +
 +if (header.model == NULL) {
 + fprintf(stderr, no model specified\n);
 + usage(EXIT_FAILURE);
 +}

You are actually comparing arrays to NULL here. Seems an odd thing to do.
You probably want
if (!header.sign[0])
and
if (!header.model[0])
That ought to be good enough in this case.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] replace CONFIG_PREEMPT_NONE with CONFIG_PREEMPT

2011-09-05 Thread Michael Büsch 
On Mon, 5 Sep 2011 09:58:58 +0200
Florian Fainelli flor...@openwrt.org wrote:
 Now this looks better, I am not opposed at all in us exposing such a kernel 
 configuration option to users through OpenWrt's menuconfig.

I'm completely fine with this as long as it defaults to no-preempt
and that it is not advertises as a fix to a completely unrelated bug.

short: patch is fine and may be applied, but doesn't fix the bug.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] replace CONFIG_PREEMPT_NONE with CONFIG_PREEMPT

2011-09-05 Thread Michael Büsch 
On Sun, 4 Sep 2011 22:44:08 +0200
Luka Perkov open...@lukaperkov.net wrote:
 Unhandled kernel unaligned access[#1]:
 Cpu 0
 $ 0   :   0006 0011
 $ 4   : d5bf9da3 80dbb548 0006 c010
 $ 8   : c578  6e617332 6e617332
 $12   :    
 $16   : 6fbb5ff7 80d05618 8028fab0 
 $20   : 8028fa28 80cba248 8028fabc 8028fabe
 $24   :  80d85a50
 $28   : 8028e000 8028f9f0 81043d14 80cb8708
 Hi: 0235
 Lo: 02922c00
 epc   : 80cb8968 nf_nat_setup_info+0x2e0/0x6e8 [nf_nat]
 Tainted: P
 ra: 80cb8708 nf_nat_setup_info+0x80/0x6e8 [nf_nat]
 Status: 1100fc03KERNEL EXL IE
 Cause : 00800010
 BadVA : 6fbb600f
 PrId  : 00019641 (MIPS 24Kc)
 Modules linked in: gpio_keys_polled dwc_otg ath_pci ath_hal(P) lantiq_atm 
 drv_dsl_cpe_api lantiq_mei ipt_MASQUERADE iptable_nat nf_nat xt_conntrack 
 xt_NOTRACK iptable_raw xt_state nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack 
 pppoe pppox ipt_REJECT xt_TCPMSS ipt_LOG xt_comment xt_multiport xt_mac 
 xt_limit iptable_mangle iptable_filter ip_tables xt_tcpudp x_tables ppp_async 
 ppp_generic slhc br2684 atm drv_vmmc usbcore drv_tapi crc_ccitt drv_ifxos 
 arc4 aes_generic crypto_algapi
 Process swapper (pid: 0, threadinfo=8028e000, task=80291bc0, tls=)
 Stack : 81722280 8019bfa0 801c686c 80f4f800 c0a801c7   
 
 c5780002 6ea9cbd9    a6a90600 d5bf9da3 
 
 6ea9cbd9    a6a90002 c0a801c7  
 
  c5780601 80cb9fd0 80cb8b0c 0001 d5bf9da3  
 
 c0a801c7 8028fae4 80fd8840 80d05618 8028fae8 d8263338 813ca98c 
 80fd8840
 ...
 Call Trace:
 [80cb8968] nf_nat_setup_info+0x2e0/0x6e8 [nf_nat]
 [80d1e158] masquerade_tg+0xc0/0xe8 [ipt_MASQUERADE]
 [80c646a8] ipt_do_table+0x3e0/0x484 [ip_tables]
 [80dee0c0] nf_nat_rule_find+0x28/0x9c [iptable_nat]
 [80dee290] nf_nat_fn+0x120/0x1a0 [iptable_nat]
 [801baa34] nf_iterate+0x8c/0xfc
 [801bab34] nf_hook_slow+0x90/0x17c
 [801c76c8] ip_output+0xd8/0x104
 [8019a224] __netif_receive_skb+0x4d4/0x578
 [80210128] br_handle_frame+0x280/0x2b8
 [80199f9c] __netif_receive_skb+0x24c/0x578
 [8019a370] process_backlog+0xa8/0x188
 [8019a778] net_rx_action+0x8c/0x1b8
 [800215f0] __do_softirq+0xa8/0x154
 [800217f0] do_softirq+0x48/0x68
 [800031c0] plat_irq_dispatch+0xf4/0x164
 [800059ec] ret_from_irq+0x0/0x4
 [80005be0] r4k_wait+0x20/0x40
 [80007690] cpu_idle+0x28/0x4c
 [802a58d0] start_kernel+0x35c/0x378

thanks.
I am still wondering how enabling preempt could possibly workaround/hide
an alignment bug. sounds strange to me. Does somebody have an idea?

I didn't look too closely at the function yet, though.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] replace CONFIG_PREEMPT_NONE with CONFIG_PREEMPT

2011-09-04 Thread Michael Büsch 
On Sun, 04 Sep 2011 10:11:08 -0700
Philip Prindeville philipp_s...@redfish-solutions.com wrote:
  And finally, I'm not really convinced that any of the routers/APs
  that OpenWRT supports have latency requirements in the milliseconds range.
  I'd rather say throughput matters a _lot_ more than a millisecond of latency
  for these devices.
 
 If you're doing VoIP, then I'd certainly say latency matters.

No it doesn't. At least not in the MILLISECONDS range.
It does not matter at all, if your voip call has 300 or 302 ms latency.
But it _does_ matter that there's enough throughput bandwidth to get most
of the packages through the pipe.

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] replace CONFIG_PREEMPT_NONE with CONFIG_PREEMPT

2011-09-04 Thread Michael Büsch 
On Sun, 4 Sep 2011 01:06:02 +0200
Luka Perkov open...@lukaperkov.net wrote:
  What are you actually trying to fix with enabling preemption? I didn't
  really get it by reading your mail.
 
 Kernel oops that I described.

Yeah. And that is completely unacceptable.

 CONFIG_PREEMPT must be enabled; don't know what more I can do.

No. You must provide a full OOPS message.
An unaligned access is easy to fix (or at least work around properly)
with proper debugging information.

 --- a/net/ipv4/netfilter/nf_nat_core.c
 +++ b/net/ipv4/netfilter/nf_nat_core.c
 @@ -276,9 +276,9 @@ nf_nat_setup_info(struct nf_conn *ct,
  
   /* nat helper or nfctnetlink also setup binding */
   nat = nfct_nat(ct);
 - if (!nat) {
 + if (unlikely(!nat)) {
   nat = nf_ct_ext_add(ct, NF_CT_EXT_NAT, GFP_ATOMIC);
 - if (nat == NULL) {
 + if (unlikely(nat == NULL)) {
   pr_debug(failed to add NAT extension\n);
   return NF_ACCEPT;
   }
 @@ -313,16 +313,17 @@ nf_nat_setup_info(struct nf_conn *ct,
   }
  
   if (maniptype == IP_NAT_MANIP_SRC) {
 - unsigned int srchash;
 + unsigned int h;
  
 - srchash = hash_by_src(net, nf_ct_zone(ct),
 -   ct-tuplehash[IP_CT_DIR_ORIGINAL].tuple);
 - spin_lock_bh(nf_nat_lock);
 - /* nf_conntrack_alter_reply might re-allocate exntension aera */
 + h = hash_by_src(net, nf_ct_zone(ct),
 + ct-tuplehash[IP_CT_DIR_ORIGINAL].tuple);
 +
 + /* nf_conntrack_alter_reply might re-allocate extension area */
   nat = nfct_nat(ct);
   nat-ct = ct;
 - hlist_add_head_rcu(nat-bysource,
 -net-ipv4.nat_bysource[srchash]);
 +
 + spin_lock_bh(nf_nat_lock);
 + hlist_add_head_rcu(nat-bysource, net-ipv4.nat_bysource[h]);
   spin_unlock_bh(nf_nat_lock);
   }

This doesn't seem to fix any alignment issues, does it?

-- 
Greetings, Michael.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt-Commits] r26963 - trunk/include

2011-05-20 Thread Michael Büsch 
On Fri, 20 May 2011 18:21:30 +0200
openwrt-comm...@openwrt.org wrote:

 add LD_LIBRARY to cmake.mk

 + -DDL_LIBRARY=$(STAGING_DIR) \

Is this a typo, or is this intentional (DL vs. LD)?
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt-Commits] r26963 - trunk/include

2011-05-20 Thread Michael Büsch 
On Fri, 2011-05-20 at 18:21 +, Michael Büsch wrote: 
 On Fri, 20 May 2011 18:21:30 +0200
 openwrt-comm...@openwrt.org wrote:
 
  add LD_LIBRARY to cmake.mk
 
  +   -DDL_LIBRARY=$(STAGING_DIR) \
 
 Is this a typo, or is this intentional (DL vs. LD)?

Oh it seems I missed that other mail on the list. So please ignore this.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [OpenWrt-Commits] r24626 - trunk/target/linux/brcm47xx

2010-12-16 Thread Michael Büsch 
On Thu, 2010-12-16 at 20:35 +0100, openwrt-comm...@openwrt.org wrote: 
 Author: hauke
 Date: 2010-12-16 20:35:59 +0100 (Thu, 16 Dec 2010)
 New Revision: 24626
 
 Modified:
trunk/target/linux/brcm47xx/config-2.6.34
trunk/target/linux/brcm47xx/config-2.6.36
trunk/target/linux/brcm47xx/config-2.6.37
 Log:
 brcm47xx: add ssb debug option.
 
 This fixes a problem with wrt350n. 
 It boots only if this config option is set, otherwise it reboots after 
 Switching to clocksource MIPS
 
 Thank you sn9 for fixing this problem.

Erm, wait. What?
This option should not affect semantics of the code. I'm pretty sure
that this commit just hides the real bug.
Could you try disabling the option again and sprinkle some delays into
the ssb bootup code?


 
 Modified: trunk/target/linux/brcm47xx/config-2.6.34
 ===
 --- trunk/target/linux/brcm47xx/config-2.6.34 2010-12-16 19:31:05 UTC (rev 
 24625)
 +++ trunk/target/linux/brcm47xx/config-2.6.34 2010-12-16 19:35:59 UTC (rev 
 24626)
 @@ -157,6 +157,7 @@
  CONFIG_SSB=y
  CONFIG_SSB_B43_PCI_BRIDGE=y
  CONFIG_SSB_BLOCKIO=y
 +CONFIG_SSB_DEBUG=y
  CONFIG_SSB_DRIVER_EXTIF=y
  CONFIG_SSB_DRIVER_GIGE=y
  CONFIG_SSB_DRIVER_MIPS=y
 
 Modified: trunk/target/linux/brcm47xx/config-2.6.36
 ===
 --- trunk/target/linux/brcm47xx/config-2.6.36 2010-12-16 19:31:05 UTC (rev 
 24625)
 +++ trunk/target/linux/brcm47xx/config-2.6.36 2010-12-16 19:35:59 UTC (rev 
 24626)
 @@ -137,6 +137,7 @@
  CONFIG_SSB=y
  CONFIG_SSB_B43_PCI_BRIDGE=y
  CONFIG_SSB_BLOCKIO=y
 +CONFIG_SSB_DEBUG=y
  CONFIG_SSB_DRIVER_EXTIF=y
  CONFIG_SSB_DRIVER_GIGE=y
  CONFIG_SSB_DRIVER_MIPS=y
 
 Modified: trunk/target/linux/brcm47xx/config-2.6.37
 ===
 --- trunk/target/linux/brcm47xx/config-2.6.37 2010-12-16 19:31:05 UTC (rev 
 24625)
 +++ trunk/target/linux/brcm47xx/config-2.6.37 2010-12-16 19:35:59 UTC (rev 
 24626)
 @@ -137,6 +137,7 @@
  CONFIG_SSB=y
  CONFIG_SSB_B43_PCI_BRIDGE=y
  CONFIG_SSB_BLOCKIO=y
 +CONFIG_SSB_DEBUG=y
  CONFIG_SSB_DRIVER_EXTIF=y
  CONFIG_SSB_DRIVER_GIGE=y
  CONFIG_SSB_DRIVER_MIPS=y
 
 ___
 openwrt-commits mailing list
 openwrt-comm...@lists.openwrt.org
 https://lists.openwrt.org/mailman/listinfo/openwrt-commits
 


-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] fix gnuplot compile error

2010-11-01 Thread Michael Büsch 
On Mon, 2010-11-01 at 11:13 +0800, Xiangfu Liu wrote: 
 this patch add intl, iconv patch to TARGET FLAGS,
 add intl and iconv to DEPENDS.
 
 attach is the patch.

Thanks, applied.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] lm-sensors package upgrade

2010-10-31 Thread Michael Büsch 
On Sun, 2010-10-31 at 23:25 +0100, Luka Perkov wrote: 
 +PKG_BUILD_PARALLEL:=1

 define Build/Compile
   $(MAKE) -C $(PKG_BUILD_DIR) \
 + $(TARGET_CONFIGURE_OPTS) \
   KERNELVERSION=$(LINUX_VERSION) \
   LINUX=$(LINUX_DIR) \
   CC=$(TARGET_CC) \
 @@ -63,6 +64,17 @@
   user
  endef


PKG_BUILD_PARALLEL does nothing unless you use the default
build macro, or PKG_JOBS.

So you either want to $(call Build/Compile/Default) and set the
appropriate MAKE_FLAGS, or add PKG_JOBS to your Build/Compile macro.



 +define Build/InstallDev
 +   mkdir -p $(1)/usr/include/sensors

I think you should use $(INSTALL_DIR) instead of mkdir -p.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] add spandsp library package

2010-10-18 Thread Michael Büsch 
Thanks, I committed this to trunk.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] rrs package fails to link

2010-10-15 Thread Michael Büsch 
The rss package fails to link properly on ARM:

farm9crypt.ssl.cc.o: In function `farm9crypt_init':
farm9crypt.cc:(.text+0x288): undefined reference to `operator
new(unsigned int)'
farm9crypt.cc:(.text+0x2c8): undefined reference to `operator
new(unsigned int)'
farm9crypt.cc:(.text+0x2f4): undefined reference to `operator
delete(void*)'
farm9crypt.cc:(.text+0x2fc): undefined reference to `__cxa_end_cleanup'
farm9crypt.ssl.cc.o:(.ARM.extab+0x0): undefined reference to
`__gxx_personality_v0'
collect2: ld returned 1 exit status


Does somebody have an idea?
I already tried various things, but I currently don't see way to resolve
this, except by linking to libstdc++ instead of uClibc++.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] rrs package fails to link

2010-10-15 Thread Michael Büsch 
On Fri, 2010-10-15 at 18:01 +0200, Michael Büsch wrote: 
 The rss package fails to link properly on ARM:
 
 farm9crypt.ssl.cc.o: In function `farm9crypt_init':
 farm9crypt.cc:(.text+0x288): undefined reference to `operator
 new(unsigned int)'
 farm9crypt.cc:(.text+0x2c8): undefined reference to `operator
 new(unsigned int)'
 farm9crypt.cc:(.text+0x2f4): undefined reference to `operator
 delete(void*)'
 farm9crypt.cc:(.text+0x2fc): undefined reference to `__cxa_end_cleanup'
 farm9crypt.ssl.cc.o:(.ARM.extab+0x0): undefined reference to
 `__gxx_personality_v0'
 collect2: ld returned 1 exit status
 
 
 Does somebody have an idea?
 I already tried various things, but I currently don't see way to resolve
 this, except by linking to libstdc++ instead of uClibc++.
 

Oh nevermind. This was a uclibc++ issue. It works now.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] gw6c package compile failure

2010-10-15 Thread Michael Büsch 
On Tue, 2010-10-12 at 20:12 +0200, Michael Büsch wrote: 
 The gw6c package fails to compile for me on my ARM testbed.
 
 It fails to find a truckload of uClibc++ symbols (seems like it does
 not find any). The uClibc++ linker options seem to be present, however.
 I was unable to fix this properly.

Fixed in trunk. This was a uclibc++ issue.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] gw6c package compile failure

2010-10-12 Thread Michael Büsch 
The gw6c package fails to compile for me on my ARM testbed.

It fails to find a truckload of uClibc++ symbols (seems like it does
not find any). The uClibc++ linker options seem to be present, however.
I was unable to fix this properly.

The following patch removes the uClibc++ dependency. It compiles properly
with this applied.

However, does somebody have an idea why it is unable to find uClibc++ symbols?


Index: patches/100-no-uclibcxx.patch
===
--- patches/100-no-uclibcxx.patch   (revision 0)
+++ patches/100-no-uclibcxx.patch   (revision 0)
@@ -0,0 +1,29 @@
+---
+ gw6c/src/gw6c/platform/openwrt/Makefile |6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+--- gw6c-5.0.orig/gw6c/src/gw6c/platform/openwrt/Makefile
 gw6c-5.0/gw6c/src/gw6c/platform/openwrt/Makefile
+@@ -14,11 +14,11 @@ include ../../Mk/mk-$(target).mk
+ OBJDIR=../../objs
+ OBJ=$(OBJDIR)/tsp_local.o $(OBJDIR)/tsp_tun.o
+ OBJLINK=$(OBJDIR)/*.o
+-EXTRALIBS=-nodefaultlibs -luClibc++ -lc -lgcc -lpthread -lgw6cconfig 
-lgw6cmessaging
++EXTRALIBS=-lpthread -lgw6cconfig -lgw6cmessaging
+ BIN=../../bin
+ TSPC=gw6c
+ 
+-CFLAGS=-g -Wall -I../../include -I../../platform/$(target)
++CFLAGS=-Wall -I../../include -I../../platform/$(target)
+ 
+ all: $(OBJ) $(wildcard $(OBJLINK)) $(BIN)/$(TSPC)
+ 
+@@ -28,7 +28,7 @@ $(OBJDIR)/tsp_tun.o:tsp_tun.c
+   $(CC) $(CFLAGS) -c tsp_tun.c -o $(OBJDIR)/tsp_tun.o $(DEFINES)
+ 
+ $(BIN)/$(TSPC): $(OBJ) $(wildcard $(OBJLINK))
+-  $(CC) $(CFLAGS) $(LDFLAGS) -o $(BIN)/$(TSPC) $(OBJLINK) $(EXTRALIBS)
++  $(LINKER) $(CFLAGS) $(LDFLAGS) -o $(BIN)/$(TSPC) $(OBJLINK) $(EXTRALIBS)
+ 
+ clean:
+   rm -f $(OBJDIR)/*.o $(BIN)/$(TSPC)
Index: Makefile
===
--- Makefile(revision 23416)
+++ Makefile(working copy)
@@ -15,7 +15,7 @@
 define Package/gw6c
   SECTION:=ipv6
   CATEGORY:=IPv6
-  DEPENDS:=+libpthread +ip +kmod-tun +kmod-ipv6 +uclibcxx +radvd
+  DEPENDS:=+libpthread +ip +kmod-tun +kmod-ipv6 +radvd
   TITLE:=IPv6 tunnel client software
   URL:=http://www.go6.net
 endef
@@ -30,12 +30,17 @@
$(INSTALL_DIR) $(PKG_BUILD_DIR)
bzcat $(DL_DIR)/$(PKG_NAME)-$(PKG_VERSION).tar.bz2 | $(TAR) -C 
$(PKG_BUILD_DIR) -xvf -
$(CP) $(PKG_BUILD_DIR)/gw6c/src/gw6c-config/gw6cconfig/gw6c_c_wrapper.h 
$(PKG_BUILD_DIR)/gw6c/src/gw6c/include
+   $(call Build/Patch)
 endef
 
+EXTRA_CFLAGS:=\
+   -include $(TOOLCHAIN_DIR)/include/stdlib.h \
+   -include $(TOOLCHAIN_DIR)/include/string.h
+
 GW6C_OPTS:= \
-   C_COMPILER=$(TARGET_CC) -c -DNO_STDLIBCXX \
-   COMPILER=$(TARGET_CROSS)g++ -c -DNO_STDLIBCXX \
-   CPP_FLAGS=$(TARGET_CFLAGS) -fno-builtin -nostdinc++ -I. -Wall -DNDEBUG 
-I$(STAGING_DIR)/usr/include/uClibc++ $(TARGET_CPPFLAGS) \
+   C_COMPILER=$(TARGET_CC) -c \
+   COMPILER=$(TARGET_CROSS)g++ -c \
+   CPP_FLAGS=$(TARGET_CFLAGS) -I. -Wall -DNDEBUG $(TARGET_CPPFLAGS) 
$(EXTRA_CFLAGS) \
RANLIB=$(TARGET_CROSS)ranlib \
ARCHIVER=$(TARGET_CROSS)ar \
C_LINKER=$(TARGET_CC) \
@@ -50,11 +55,14 @@
$(GW6C_OPTS)
$(MAKE) -C $(PKG_BUILD_DIR)/gw6c/src/gw6c \
CC=$(TARGET_CC) \
-   CFLAGS=$(TARGET_CFLAGS) -fno-builtin -Wall 
-I$(PKG_BUILD_DIR)/gw6c/src/gw6c/include \
-   -I$(PKG_BUILD_DIR)/gw6c/src/gw6c/platform/openwrt 
-I$(PKG_BUILD_DIR)/gw6c/src/gw6c \
+   LINKER=$(TARGET_CROSS)g++ \
+   CFLAGS=$(TARGET_CFLAGS) -Wall $(EXTRA_CFLAGS) \
+   -I$(PKG_BUILD_DIR)/gw6c/src/gw6c/include \
+   -I$(PKG_BUILD_DIR)/gw6c/src/gw6c/platform/openwrt \
+   -I$(PKG_BUILD_DIR)/gw6c/src/gw6c \
LDFLAGS=-L$(PKG_BUILD_DIR)/gw6c/src/gw6c/gw6cconfig \
-L$(PKG_BUILD_DIR)/gw6c/src/gw6c/gw6cmessaging \
-   $(TARGET_LDFLAGS) -nodefaultlibs -luClibc++ 
$(LIBGCC_S) \
+   $(TARGET_LDFLAGS) \
target=openwrt \
installdir=$(PKG_INSTALL_DIR)
 endef

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Conditionnal build dependency (was: Re: Your modifications to nginx package in OpenWRT)

2010-10-12 Thread Michael Büsch 
On Tue, 2010-10-12 at 20:19 +0200, Benjamin Cama wrote: 
 Le mardi 12 octobre 2010 à 19:57 +0200, Michael Büsch a écrit :
  On Tue, 2010-10-12 at 19:41 +0200, Benjamin Cama wrote: 
   * Your openssl added dependency is wrong: it is optionnaly selected when
   you enable the SSL module. See Config.in. Is there something wrong with
   that that you found ?
  
  It is incorrect to select a package from a Config.in file, because that
  violates build dependencies. (Build failed for me).
 
 Mmh, okay, but does it do that after a package/nginx/clean ?

Yeah, it was a clean tree. And that is why it did actually fail.
The openssl package was not built, yet.

 I think that, from what I understand, a PKG_CONFIG_DEPENDS is actually
 needed for this package (on CONFIG_PACKAGE_libopenssl). But how do you
 do the PKG_BUILD_DEPENDS bit when the symbol is in a Config.in ? This is
 why I Cc'ed the list: does someone have an advice on this ?

Probably something like this:

PKG_BUILD_DEPENDS:=CONFIG_NGINX_SSL:CONFIG_PACKAGE_libopenssl

You also most likely need a PKG_CONFIG_DEPENDS on all of your
CONFIG_NGINX_...
flags to ensure that the package is rebuilt if somebody changes those
config options.



-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] clock_gettime not found when compiling a package

2010-09-27 Thread Michael Büsch 
On Mon, 2010-09-27 at 15:16 +0200, Roberto Riggio wrote: 
 when compiling a package for openwrt i get the following error:
 
 ../lib/libclicktool_build.a(glue.bo): In function `click_random_srandom()':
 glue.cc:(.text+0xa40): undefined reference to `clock_gettime'
 
 Any idea about where the problem could be?

uclibc does not support the clock_xxx functions. The kernel implements
them, however. You might want to use a wrapper in your application.
Take a look at this:
http://bu3sch.de/gitweb?p=pwrtray.git;a=blob;f=backend/timer.c;hb=HEAD#l30
(see the #defines and the syscall() stubs below)

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] iproute2 make dependencies broken (parallel builds broken)

2010-09-12 Thread Michael Büsch 
On Sat, 2010-09-11 at 18:19 -0600, Joseph Roback wrote: 
 iproute2 tc/Makefile does not define proper dependencies for the Bison/Flex 
 files used. 
 Therefore parallel builds are broken.

I will apply the dependency fix and leave the removal of the generated
flex code out, because...

 It also contains a 3 year old patch for broken flex implementation.
 Is this still broken? Removing this patch worked for me on Ubuntu 10.04 and 
 Darwin 10.6.4.

Well, lex/yacc from the host is used. So you can never be sure whether
there is a broken version or not. 

Thanks a lot for your patch.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Broadcom releases Linux driver sources for new chipsets

2010-09-10 Thread Michael Büsch 
On Fri, 2010-09-10 at 11:44 +0200, Florian Fainelli wrote: 
 Hi Daniel,
 
 On Friday 10 September 2010 11:18:11 Daniel A. Nagy wrote:
  Just in case someone missed the good news:
  http://tinyurl.com/brcm-driver
 
 Just so that nobody has false hopes regarding the *current* state of these 
 drivers, they are not SSB-bus aware, so they cannot be used with Broadcom 
 Wireless SoC right now.
 
 Now that they are released, someone might consider adding SSB support to 
 these.

Or the other way around, port the PHY code to b43.
I'm not sure which way is easier.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] busybox parallel build (Makefile)

2010-09-07 Thread Michael Büsch 
On Tue, 2010-09-07 at 10:13 +0200, Gert Doering wrote: 
 Hi,
 
 On Mon, Sep 06, 2010 at 11:31:22PM +0200, Michael Büsch wrote:
  (I guess you already compiletested them. It's also useful to do one or
  two dircleans or similar and rebuild the whole tree to make sure they
  behave well in parallel build).
 
 What are the requirements to enable parallel building for a package?  Is
 it sufficient if the package itself builds cleanly with make -j4,
 or do I need to take some sort of cross-package things into account?

The package itself has to compile cleanly (preferably tested multiple times)
with multiple jobs. Inter-package dependencies don't matter in this context,
as the whole package build is delayed until those dependencies are met. 

 (I'm fairly sure openvpn-devel will handle parallel building nicely,
 but it might not be well-behaved regarding dependencies or something
 like that...)

Well, it is actually pretty hard to write a makefile that does _not_ handle
parallel build correctly. You have to abuse makefile features to break it.
So over 98% (estimated by me) of all software builds nicely with multiple
jobs. There are makefiles that do not behave very well (do not parallelize
well), but there rarely are makefiles that actually break compile.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] uclibc++ parallel build

2010-09-07 Thread Michael Büsch 
On Tue, 2010-09-07 at 10:38 -0600, Joseph Roback wrote: 
 Subject says it all. Compile tested on Linux and Darwin hosts.
 
 Signed-off-by: Joe Roback j...@roback.cc
 
 ---
 
 Index: feeds/packages/libs/uclibc++/Makefile
 ===
 --- feeds/packages/libs/uclibc++/Makefile (revision 22968)
 +++ feeds/packages/libs/uclibc++/Makefile (working copy)
 @@ -16,6 +16,7 @@
  PKG_MD5SUM:=1ceef3209cca88be8f1bd9de99735954
  
  PKG_BUILD_DIR:=$(BUILD_DIR)/uClibc++-$(PKG_VERSION)
 +PKG_BUILD_PARALLEL:=1
  
  PKG_INSTALL:=1

Thanks a lot. I applied all of your patches to trunk.

-- 
Greetings Michael.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel