Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-30 Thread Luka Perkov
Hi Jay,

On Wed, Nov 28, 2012 at 08:01:55PM -0500, Jay Carlson wrote:
  Sorry it took me a while to test your patch. I applied it to trunk
  r33391 and can confirm, that uboot works fine on my dockstar when
  installed as primary bootloader to flash.
 
 It doesn't work on mine--in fact, it bricks it--but this may be a 
 documentation bug. 

I'm sorry that you have bricked your device...
 
 https://dev.openwrt.org/ticket/12492
 
 Short version: the wiki says 
 http://wiki.openwrt.org/toh/seagate/dockstar
 
 nand write.e 0x80 0x00 0x4
 
 which really does not sound right, since u-boot is 0x594c8 bytes long. What
 is the procedure for flashing the new uboot as primary, and is it intended to
 work as a secondary? 

It won't work as secondary, you must use it as primary.

This is how I flash it on my kirkwood boards:

tftpboot 0x080 u-boot.kwb
nand erase 0x0 0x${filesize}
nand write 0x080 0x0 0x${filesize}
 
 There's also both .img and .kwb files. I'm not sure what the difference is.
 (Since I've got original dockstars, I won't be serial booting the .kwb
 apparently :-)

You only need .kwb file. Do you have JTAG adapter?

Luka
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-28 Thread Jay Carlson
On Nov 4, 2012, at 11:57 AM, Martin Mueller wrote:

 On Thu, Oct 18, 2012 at 10:59:00PM +0200, openwrt at lukaperkov.net wrote:
 All our kirkwood uboot patches have been upstreamed with this release ;)
 
 Board owners please test this patch and give feedback for the boards:
 
 * dockstar
 
 Sorry it took me a while to test your patch. I applied it to trunk
 r33391 and can confirm, that uboot works fine on my dockstar when
 installed as primary bootloader to flash.

It doesn't work on mine--in fact, it bricks it--but this may be a documentation 
bug. 

https://dev.openwrt.org/ticket/12492

Short version: the wiki says 
http://wiki.openwrt.org/toh/seagate/dockstar

nand write.e 0x80 0x00 0x4

which really does not sound right, since u-boot is 0x594c8 bytes long. What is 
the procedure for flashing the new uboot as primary, and is it intended to work 
as a secondary? 

There's also both .img and .kwb files. I'm not sure what the difference is. 
(Since I've got original dockstars, I won't be serial booting the .kwb 
apparently :-)

Jay
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-06 Thread Daniel Golle
Hi!

On 18/10/12 22:59, open...@lukaperkov.net wrote:
 All our kirkwood uboot patches have been upstreamed with this release ;)

 Board owners please test this patch and give feedback for the boards:

  * sheevaplug
  * dockstar
  * iconnect

ACK. Works on the iConnect.

Just lost the environment as it isn't stored in an separate mtd partition and I
did mtd erase u-boot ... :/

Having u-boot and u-boot-env separate would make it easier and also reduce the
risks involved when dealing with either one of them.

Besides that, we should have the resulting .kwb image aligned with the NAND
pages, otherwise flashing it results in:
nand_do_write_ops: attempt to write non page aligned data
Error writing image.

So it would be nice to have the partition layout in-sync with what we got in the
kernel.

U-Boot default env:
mtdparts=mtdparts=orion_nand:0x8@0x0(uboot),0x2@0x8(uboot_env),-@0xa(rootfs)
vs.
arch/arm/mach-kirkwood/iconnect-setup.c:
static struct mtd_partition iconnect_nand_parts[] = {
{
.name = u-boot,
.offset = 0,
.size = SZ_1M
}, {
.name = uImage,
.offset = MTDPART_OFS_NXTBLK,
.size = SZ_1M + SZ_2M
}, {
.name = rootfs,
.offset = MTDPART_OFS_NXTBLK,
.size = SZ_32M,
}, {
.name = data,
.offset = MTDPART_OFS_NXTBLK,
.size = MTDPART_SIZ_FULL
},
};

U-Boot 2012.10 (Oct 23 2012 - 14:48:13) Iomega iConnect

SoC:   Kirkwood 88F6281_A0
DRAM:  256 MiB
WARNING: Caches not enabled
NAND:  512 MiB
*** Warning - bad CRC, using default environment

In:serial
Out:   serial
Err:   serial
Net:   egiga0
Warning: failed to set MAC address

Hit any key to stop autoboot:  0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-06 Thread Imre Kaloz

Hi,

On Tue, 06 Nov 2012 14:13:26 +0100, Daniel Golle dgo...@allnet.de wrote:

snip


U-Boot default env:
mtdparts=mtdparts=orion_nand:0x8@0x0(uboot),0x2@0x8(uboot_env),-@0xa(rootfs)
vs.
arch/arm/mach-kirkwood/iconnect-setup.c:
static struct mtd_partition iconnect_nand_parts[] = {


IMHO u-boot shouldn't do anything with mtdparts...


Imre
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-06 Thread Daniel Golle
On 06/11/12 15:21, Imre Kaloz wrote:
 Hi,
 
 On Tue, 06 Nov 2012 14:13:26 +0100, Daniel Golle dgo...@allnet.de wrote:
 
 snip
 
 U-Boot default env:
 mtdparts=mtdparts=orion_nand:0x8@0x0(uboot),0x2@0x8(uboot_env),-@0xa(rootfs)
 vs.
 arch/arm/mach-kirkwood/iconnect-setup.c:
 static struct mtd_partition iconnect_nand_parts[] = {
 
 IMHO u-boot shouldn't do anything with mtdparts...

Unless you want to use ubi/ubifs to load the kernel, which I do want to use,
especially on large NAND (like the one of the iConnect, which already got 3
bad-blocks when it left the factory -- a well-known common phenomena on big NAND
chips and the reason why we got UBI)

See the whole uboot-environment to illustrate what I mean:
iconnect = printenv
baudrate=115200
bootargs_root=noinitrd ubi.mtd=2 root=ubi0:rootfs rootfstype=ubifs
bootcmd=setenv bootargs ${console} ${mtdparts} ${bootargs_root}; ubi part
rootfs; ubifsmount rootfs; ubifsload 0x80 ${kernel}; bootm 0x80
bootdelay=3
console=console=ttyS0,115200
ethact=egiga0
kernel=/boot/uImage
mtdids=nand0=orion_nand
mtdparts=mtdparts=orion_nand:0x8@0x0(uboot),0x2@0x8(uboot_env),-@0xa(rootfs)
stderr=serial
stdin=serial
stdout=serial

So the kernel uImage is loaded from inside the filesystem, similar to GRUB
loading vmlinuz from an ext3 partition on x86.

Besides that, given that one might want to update u-boot itself or use
fw_printenv from inside OpenWrt, it makes sense to have the uboot/uboot-env
partitions in-sync.

Maybe even the opposite is true:
The kernel shouldn't have mtd-partitions built-in but rather rely on the cmdline
(like the way it works now on ar71xx; you can still have a patched built-in
cmdline, if needed)
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-11-04 Thread Martin Mueller
Hi Luka,

On Thu, Oct 18, 2012 at 10:59:00PM +0200, open...@lukaperkov.net wrote:
 All our kirkwood uboot patches have been upstreamed with this release ;)
 
 Board owners please test this patch and give feedback for the boards:
 
  * dockstar

Sorry it took me a while to test your patch. I applied it to trunk
r33391 and can confirm, that uboot works fine on my dockstar when
installed as primary bootloader to flash.

bye
  MM
--
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH][RFC] uboot-kirkwood: upgrade to 2012.10

2012-10-18 Thread openwrt
All our kirkwood uboot patches have been upstreamed with this release ;)

Board owners please test this patch and give feedback for the boards:

 * sheevaplug
 * dockstar
 * iconnect

Signed-off-by: Luka Perkov open...@lukaperkov.net
---

 package/boot/uboot-kirkwood/Makefile   |   9 +-
 .../files/board/iomega/iconnect/Makefile   |  43 -
 .../files/board/iomega/iconnect/iconnect.c | 141 
 .../files/board/iomega/iconnect/iconnect.h |  39 -
 .../files/board/iomega/iconnect/kwbimage.cfg   | 165 
 .../files/include/configs/iconnect.h   | 124 ---
 .../boot/uboot-kirkwood/patches/0001-ib62x0.patch  | 542 -
 .../boot/uboot-kirkwood/patches/0002-kwboot.patch  | 873 -
 .../boot/uboot-kirkwood/patches/0003-ide_bus.patch |  17 -
 .../boot/uboot-kirkwood/patches/100-iconnect.patch |  10 -
 10 files changed, 2 insertions(+), 1961 deletions(-)

diff --git a/package/boot/uboot-kirkwood/Makefile 
b/package/boot/uboot-kirkwood/Makefile
index 48bcf99..08a9fb6 100644
--- a/package/boot/uboot-kirkwood/Makefile
+++ b/package/boot/uboot-kirkwood/Makefile
@@ -9,13 +9,13 @@ include $(TOPDIR)/rules.mk
 include $(INCLUDE_DIR)/kernel.mk
 
 PKG_NAME:=u-boot
-PKG_VERSION:=2012.04.01
+PKG_VERSION:=2012.10
 PKG_RELEASE:=1
 
 
PKG_BUILD_DIR:=$(KERNEL_BUILD_DIR)/$(PKG_NAME)-$(BUILD_VARIANT)/$(PKG_NAME)-$(PKG_VERSION)
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
 PKG_SOURCE_URL:=ftp://ftp.denx.de/pub/u-boot
-PKG_MD5SUM:=192bb231082d9159fb6e16de3039b6b2
+PKG_MD5SUM:=8655f63b1e5c4647295ac9ce44660be3
 PKG_TARGETS:=bin
 
 include $(INCLUDE_DIR)/package.mk
@@ -67,11 +67,6 @@ UBOOT_CONFIG:=$(if $(CONFIG),$(CONFIG),$(BUILD_VARIANT))
 UBOOT_IMAGE:=$(if 
$(IMAGE),$(IMAGE),openwrt-$(BOARD)-$(BUILD_VARIANT)-u-boot.bin)
 endif
 
-define Build/Prepare
-   $(call Build/Prepare/Default)
-   $(CP) ./files/* $(PKG_BUILD_DIR)
-endef
-
 define Build/Configure
$(MAKE) -C $(PKG_BUILD_DIR) \
$(UBOOT_CONFIG)_config
diff --git a/package/boot/uboot-kirkwood/files/board/iomega/iconnect/Makefile 
b/package/boot/uboot-kirkwood/files/board/iomega/iconnect/Makefile
deleted file mode 100644
index f77fcfb..000
--- a/package/boot/uboot-kirkwood/files/board/iomega/iconnect/Makefile
+++ /dev/null
@@ -1,43 +0,0 @@
-#
-# (C) Copyright 2009
-# Marvell Semiconductor www.marvell.com
-# Written-by: Prafulla Wadaskar prafu...@marvell.com
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see http://www.gnu.org/licenses/.
-#
-
-include $(TOPDIR)/config.mk
-
-LIB= $(obj)lib$(BOARD).o
-
-COBJS  := iconnect.o
-
-SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS   := $(addprefix $(obj),$(COBJS))
-SOBJS  := $(addprefix $(obj),$(SOBJS))
-
-$(LIB):$(obj).depend $(OBJS) $(SOBJS)
-   $(call cmd_link_o_target, $(OBJS) $(SOBJS))
-
-#
-
-# defines $(obj).depend target
-include $(SRCTREE)/rules.mk
-
-sinclude $(obj).depend
-
-#
diff --git a/package/boot/uboot-kirkwood/files/board/iomega/iconnect/iconnect.c 
b/package/boot/uboot-kirkwood/files/board/iomega/iconnect/iconnect.c
deleted file mode 100644
index 34ddadf..000
--- a/package/boot/uboot-kirkwood/files/board/iomega/iconnect/iconnect.c
+++ /dev/null
@@ -1,141 +0,0 @@
-/*
- * Copyright (C) 2009-2012
- * Wojciech Dubowik wojciech.dubo...@neratec.com
- * Luka Perkov ub...@lukaperkov.net
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see http://www.gnu.org/licenses/.
- */
-
-#include common.h
-#include miiphy.h
-#include asm/arch/cpu.h
-#include asm/arch/kirkwood.h
-#include