Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-11 Thread mail
> -Original Message- > From: Birger Koblitz [mailto:m...@birger-koblitz.de] > Sent: Sonntag, 11. August 2019 22:06 > To: m...@adrianschmutzler.de; 'OpenWrt Development List' de...@lists.openwrt.org> > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead

Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-11 Thread Birger Koblitz
de >> Cc: 'OpenWrt Development List' >> Subject: Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio- >> export >> >> Dear Adrian, >> >> I'll resubmit a patch taking your comments into account. I am using a script >> that parses the DTS ...

Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-11 Thread mail
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Birger Koblitz > Sent: Sonntag, 11. August 2019 13:11 > To: m...@adrianschmutzler.de > Cc: 'OpenWrt Development List' > Subject: Re: [OpenWrt-Devel] [PATCH

Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-11 Thread Birger Koblitz
Dear Adrian, I'll resubmit a patch taking your comments into account. I am using a script that parses the DTS and I will use more of the original line-name to name the node, i.e. "tp-link:power:usb" -> power-usb "tp-link:reset:sr" -> reset-sr This should also prevent the double naming of the

Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-10 Thread mail
Hi, > +    usb { > +        gpio-hog; > +        line-name = "tp-link:power:usb"; > +        gpios = <6 GPIO_ACTIVE_HIGH>; > +        output-high; > }; >  }; As stated earlier, I would prefer calling those blocks usb-power, usb1-power, etc.. > diff --git

Re: [OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-07 Thread Adrian Schmutzler
Hi, > +    lna0 { is there a scheme for proper names already? While I do not have an opinion for lnaX, I'd prefer "usb_power"/"usb0_power" over just "usb"/"usb0". > +        gpio-hog; > +        line-name = "tp-link:ext:lna0"; > +        gpios = <18 GPIO_ACTIVE_HIGH>; At least for lnaX, so

[OpenWrt-Devel] [PATCH] ath79: use gpio_hog instead of gpio-export

2019-08-02 Thread Birger Koblitz
ath79: use gpio_hog instead of gpio-export The `gpio-export` functionality is a hack for missing kernel functionality, which was rejected in upstream kernel long time ago, for details see this email http://lists.infradead.org/pipermail/openwrt-devel/2019-February/015772.html, discussion in