Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-14 Thread Felix Fietkau
On 2016-01-13 18:38, Daniel Dickinson wrote: > Sorry, I wasn clear I guess. I mean I'm not clear on how or if other > targets use the 'Default' profile to select building all images for that > target. That is, my question is whether ar71xx is the only target for > which the Default profile sel

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-13 Thread Daniel Dickinson
Sorry, I wasn clear I guess. I mean I'm not clear on how or if other targets use the 'Default' profile to select building all images for that target. That is, my question is whether ar71xx is the only target for which the Default profile selects building all available images. Regards, Danie

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-13 Thread Felix Fietkau
On 2016-01-13 18:04, Daniel Dickinson wrote: > Hi, > > I'm looking at the 'Default' profiles in architectures and as far as I > can tell the only architecture that currently uses Default to mean > 'build all profiles for this arch-subtarget'. Is that correct. > > I've seen other 00-default.mk

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-13 Thread Daniel Dickinson
Hi, I'm looking at the 'Default' profiles in architectures and as far as I can tell the only architecture that currently uses Default to mean 'build all profiles for this arch-subtarget'. Is that correct. I've seen other 00-default.mk profiles by on most archs this seems to be used as a gen

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Daniel Dickinson
On 11/01/16 04:05 PM, Felix Fietkau wrote: On 2016-01-11 20:27, Eric Schultz wrote: Felix, Would it be unreasonable to have overridable defaults like suggested in metadata.pl? Convention over configuration and all that. I don't understand what you're asking. Could you elaborate? To be honest

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Felix Fietkau
On 2016-01-11 20:27, Eric Schultz wrote: > Felix, > > Would it be unreasonable to have overridable defaults like suggested in > metadata.pl? Convention over configuration and all that. I don't understand what you're asking. Could you elaborate? - Felix

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Felix Fietkau
On 2016-01-11 21:23, Daniel Dickinson wrote: > Actually I thought of a solution, but it starts to get ugly. A choice > submemenu with non-duplicate (i.e. TARGET_SINGLE_...) symbols that also > select TARGET_SINGLE, AND have all the normal TARGET_... depend on > !(TARGET_SYMBOL && !TARGET_SINGLE

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Daniel Dickinson
Actually I thought of a solution, but it starts to get ugly. A choice submemenu with non-duplicate (i.e. TARGET_SINGLE_...) symbols that also select TARGET_SINGLE, AND have all the normal TARGET_... depend on !(TARGET_SYMBOL && !TARGET_SINGLE_..profile). That would probably work, but it's rat

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Felix Fietkau
On 2016-01-11 21:11, Daniel Dickinson wrote: > On 11/01/16 08:35 AM, Felix Fietkau wrote: >> I like the idea of allowing the user to select multiple profiles. >> However, there also needs to be a clean and simple way to select a >> single profile without going through the list and deselecting every

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Daniel Dickinson
On 11/01/16 08:35 AM, Felix Fietkau wrote: Signed-off-by: Daniel Dickinson --- scripts/metadata.pl | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/scripts/metadata.pl b/scripts/metadata.pl index 48b1b7a..4487d26 100755 --- a/scripts/metada

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Eric Schultz
Felix, Would it be unreasonable to have overridable defaults like suggested in metadata.pl? Convention over configuration and all that. Eric On Mon, Jan 11, 2016 at 7:35 AM, Felix Fietkau wrote: > On 2016-01-11 06:16, open...@daniel.thecshore.com wrote: > > From: Daniel Dickinson > > > > Cert

Re: [OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-11 Thread Felix Fietkau
On 2016-01-11 06:16, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > Certain platforms have large numbers of possible images, and it can be > desirable to build neither all images nor only a single image, > therefore this patch makes selecting target profiles a menu instead of a

[OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-10 Thread openwrt
From: Daniel Dickinson Certain platforms have large numbers of possible images, and it can be desirable to build neither all images nor only a single image, therefore this patch makes selecting target profiles a menu instead of a single choice, which allows the user to build a specific subset of