Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-27 Thread Florian Fainelli
Hi, Le 02/25/12 17:56, Jo-Philipp Wich a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. I think it should be handled in mtd, rewriting the complete image only because a single block had a transient erase problem is a bit excessive imo. It also means that sysupgrade would loop

[OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Bastian Bittorf
Remembering the old days, where we had floppy-drives? Now we have MTD. sad but true, in case of any error during sysupgrade regarding mtd, there are no further checks and we are f*cked: ### Performing system upgrade... Unlocking linux ... Writing from stdin to linux ... [e]MTD

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Peter Naulls
On 02/25/2012 07:13 AM, Bastian Bittorf wrote: Remembering the old days, where we had floppy-drives? Now we have MTD. sad but true, in case of any error during sysupgrade regarding mtd, there are no further checks and we are f*cked: ### Performing system upgrade... Unlocking linux ... Writing

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. I think it should be handled in mtd, rewriting the complete image only because a single block had a transient erase problem is a bit excessive imo. It also means that sysupgrade would loop forever in case of a really fatal issue, like when the

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Bastian Bittorf
It also means that sysupgrade would loop forever in case of a really fatal issue, like when the image is too large for the given mtd partition. maybe we should limit the loop to X times? I'd say the mtd util should perform 3-5 consecutive tries in case of a block erase problem and then

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 so just the error-handling within the sysupgrade-script. fire telnet + landev? Yes, that'd be a good solution - plus maybe netmsg to send the usual UDP broadcast stating that something is broken. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Peter Naulls
On 02/25/2012 10:15 AM, Bastian Bittorf wrote: cause is, but what I have seen is that the mtd utility needs to retry sometimes, and that [e] condition is a temporary Out of memory error. At least, on ar71xx. out of memory doesnt satisfy me. And? I'm telling you what the error is at this

Re: [OpenWrt-Devel] [PATCH] sysupgrade: try harder during an error

2012-02-25 Thread Bastian Bittorf
My machine too has significant free memory, but I suspect the memory relates to some kernel memory issues, rather than megabytes of free user space memory. Chill. And I recommend use of your shift key ;-) Thanks for your feedback. I'am fine with shift 8-) and just misunderstood you...