Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-12 Thread Stijn Segers
Op wo, 11 jul 2018 om 10:31 , schreef Koen Vandeputte : On 2018-07-11 10:11, Kevin Darbyshire-Bryant wrote: > > Really not convinced I agree with the "patch 335 removes the whole code block where that one line changed in upstream”. Did a refresh myself, several times, and patch 335 is a ri

Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-11 Thread Kevin Darbyshire-Bryant
> On 11 Jul 2018, at 10:44, Hannu Nyman wrote: > > Kevin Darbyshire-Bryant wrote: >> Really not convinced I agree with the "patch 335 removes the whole code >> block where that one line changed in upstream”. > > You are right. > The corresponding addition needs to be done for the lines replac

[OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-11 Thread Hannu Nyman
Kevin Darbyshire-Bryant wrote: Really not convinced I agree with the "patch 335 removes the whole code block where that one line changed in upstream”. You are right. The corresponding addition needs to be done for the lines replacing the removed lines: 932 + if (filter && filter->table[0] &&

Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-11 Thread Koen Vandeputte
On 2018-07-11 10:11, Kevin Darbyshire-Bryant wrote: Really not convinced I agree with the "patch 335 removes the whole code block where that one line changed in upstream”. Did a refresh myself, several times, and patch 335 is a right confusing pain in the backside. I think the block in que

Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-11 Thread Koen Vandeputte
On 2018-07-10 22:08, Stijn Segers wrote: Refreshed patches. The bump from .53 to .54 introduced a minor change in net/netfilter/nf_tables_api.c [1] but I am unable to judge if this is a fluke or not, so I'd like a second pair of eyes on that. It's a single 'table[0]' being replaced by 'table'

Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-11 Thread Kevin Darbyshire-Bryant
> On 11 Jul 2018, at 05:45, Hannu Nyman wrote: > > Stijn Segers kirjoitti 10.7.2018 klo 23:08: >> Refreshed patches. The bump from .53 to .54 introduced a minor change in >> net/netfilter/nf_tables_api.c [1] but I am unable to >> judge if this is a fluke or not, so I'd like a second pair of ey

Re: [OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-10 Thread Hannu Nyman
Stijn Segers kirjoitti 10.7.2018 klo 23:08: Refreshed patches. The bump from .53 to .54 introduced a minor change in net/netfilter/nf_tables_api.c [1] but I am unable to judge if this is a fluke or not, so I'd like a second pair of eyes on that. It's a single 'table[0]' being replaced by 'table

[OpenWrt-Devel] [PATCH 2/2] [RFC] kernel: bump 4.14 to 4.14.54 for 18.06

2018-07-10 Thread Stijn Segers
Refreshed patches. The bump from .53 to .54 introduced a minor change in net/netfilter/nf_tables_api.c [1] but I am unable to judge if this is a fluke or not, so I'd like a second pair of eyes on that. It's a single 'table[0]' being replaced by 'table': - if (filter && filter->table[0] && + if