Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-13 Thread Sergey Ryazanov
Hello Denis, On Thu, May 6, 2021 at 7:31 PM Denis Kalashnikov wrote: > When porting RB91xG ad hoc drivers (gpio-latch and rb91x-nand) from ar71xx > to ath79, I made a decision to rework this to more clear design in my opinion: > MFD driver that requests and controls the gpio lines, and separate

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-12 Thread Koen Vandeputte
On 12.05.21 15:09, Bjørn Mork wrote: Koen Vandeputte writes: Hi Bjørn I can confirm the slot can also handle pcie signaling. Got a rb912 board laying on my desk this very moment running an extra ath9k pcie card :-)  (openwrt 19.07) Thanks. Good to be wrong :-) The slot is also advertised

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-12 Thread Bjørn Mork
Koen Vandeputte writes: > Hi Bjørn > > I can confirm the slot can also handle pcie signaling. > Got a rb912 board laying on my desk this very moment running an extra > ath9k pcie card :-)  (openwrt 19.07) Thanks. Good to be wrong :-) > The slot is also advertised by MikroTik that it can do

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-12 Thread Koen Vandeputte
On 12.05.21 14:47, Bjørn Mork wrote: Koen Vandeputte writes: I've fixed most of the open stuff, with the exception of using a PCIe device in the slot. (checking currently what is wrong there) Are you sure that's supported? This is a slot intended only for LTE modems, isn't it? Looking at

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-12 Thread Bjørn Mork
Koen Vandeputte writes: > I've fixed most of the open stuff, with the exception of using a PCIe > device in the slot. (checking currently what is wrong there) Are you sure that's supported? This is a slot intended only for LTE modems, isn't it? Looking at the picture at

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-12 Thread Koen Vandeputte
Hi Denis, I have high interest in this target device and wanted to provide some assistance if that's ok with you. I've fixed most of the open stuff, with the exception of using a PCIe device in the slot. (checking currently what is wrong there) Changes: - dts cleanup - Enabled USB - Added

Re: [PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-06 Thread John Crispin
interesting. I have a rb92xx on my desk and am wondering if this would also work ? after a brief glance at the code I think this might work. the rb92xx certainly has the same latch setup ...     John On 06.05.21 18:19, Denis Kalashnikov wrote: When porting RB91xG ad hoc drivers (gpio-latch

[PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-06 Thread Denis Kalashnikov
When porting RB91xG ad hoc drivers (gpio-latch and rb91x-nand) from ar71xx to ath79, I made a decision to rework this to more clear design in my opinion: MFD driver that requests and controls the gpio lines, and separate NAND driver and GPIO-latch driver that uses API of the MFD driver (like how

[PATCH 0/4] RFC: ath79: add support for Mikrotik RB91xG

2021-05-06 Thread Denis Kalashnikov
When porting RB91xG ad hoc drivers (gpio-latch and rb91x-nand) from ar71xx to ath79, I made a decision to rework this to more clear design in my opinion: MFD driver that requests and controls the gpio lines, and separate NAND driver and GPIO-latch driver that uses API of the MFD driver (like how