Re: [PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Birger Koblitz
Hi, On 07.06.22 11:10, Sander Vanheule wrote: > On Tue, 2022-06-07 at 10:24 +0200, Birger Koblitz wrote: >> Hi, >> >> at least for the RTL931x, removing the rtl931x_setup() is not a good idea as >> the WDT reset does >> not work for that architecture. >> The only way to get a working reset is

Re: [PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Sander Vanheule
On Tue, 2022-06-07 at 10:24 +0200, Birger Koblitz wrote: > Hi, > > at least for the RTL931x, removing the rtl931x_setup() is not a good idea as > the WDT reset does > not work for that architecture. > The only way to get a working reset is via registering a reset handler: > > static void __init

Re: [PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Birger Koblitz
Hi, at least for the RTL931x, removing the rtl931x_setup() is not a good idea as the WDT reset does not work for that architecture. The only way to get a working reset is via registering a reset handler: static void __init rtl931x_setup(void) { pr_info("Registering _machine_restart\n");

[PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Sander Vanheule
Disabling the sys-led peripheral should be done via a pin controller, for which pinctrl-single nodes are present in the platform DTSI files. Drop the hardcoded per-platform sys-led configurations, and require things to be set up in the devicetree. Co-developed-by: INAGAKI Hiroshi Signed-off-by: