Re: [OpenWrt-Devel] netifd: per-interface MTU settings vs per-route MTU settings?

2020-05-25 Thread Aleksander Morgado
Hey, >> >> There's an ongoing discussion in the ModemManager package in github >> related to how the MTU may be configured in the network interface >> based on what the MM bearer object reports: >> https://github.com/openwrt/packages/issues/11383 >> >> E.g.: >> >> $ ip route show >> default via

[OpenWrt-Devel] [PATCH] layerscape: kernel: cma: increase CMA buffer size from 16 to 32MB

2020-05-25 Thread Linus Lüssing
From: Linus Lüssing 16MB are not enough for ath10k to initialize three 4x4 AC Wave 2 PCIe cards (168c:0046: Qualcomm Atheros QCA9984 802.11ac Wave 2 Wireless Network Adapter). This leads to the following error when trying to initialize the third one: [ 16.742475] ath10k_pci 0002:01:00.0: pci

[OpenWrt-Devel] [PATCH 2/2] netifd: wireless: add support for tracking wifi-station sections

2020-05-25 Thread John Crispin
This new section allows us to assign mac specific key/vid settings to a station. Signed-off-by: John Crispin --- config.c | 29 scripts/netifd-wireless.sh | 24 +++ wireless.c | 134 - wireless.h

Re: [OpenWrt-Devel] [PATCH] layerscape: kernel: cma: increase CMA buffer size from 16 to 32MB

2020-05-25 Thread mail
> -Original Message- > From: Linus Lüssing [mailto:l...@simonwunderlich.de] > Sent: Montag, 25. Mai 2020 12:14 > To: m...@adrianschmutzler.de; 'Linus Lüssing' ; > openwrt-devel@lists.openwrt.org > Cc: 'Sven Eckelmann' > Subject: Re: [OpenWrt-Devel] [PATCH] layerscape: kernel: cma:

[OpenWrt-Devel] Targets without 5.4 support yet

2020-05-25 Thread mail
Hi all, while there has been a lot of progress during the last months, there are still a few target that have not been updated to 5.4 (at least as testing kernel) yet: 4.19: cns3xxx 4.14: ar71xx (to be removed) arc770 (RFT patch:

Re: [OpenWrt-Devel] [PATCH RFC libubox] blobmsg: another attrs iteration fix for blobmsg_check_array_len()

2020-05-25 Thread Felix Fietkau
On 2020-05-25 10:31, Rafał Miłecki wrote: > From: Rafał Miłecki > > After more reviews is seems that blobmsg_for_each_attr() should not be > used when dealing with untrusted data as it reads length from blob data > itself. It means it can't be used in the blobmsg_check_array_len(). > > Switch

Re: [OpenWrt-Devel] [PATCH] layerscape: kernel: cma: increase CMA buffer size from 16 to 32MB

2020-05-25 Thread Linus Lüssing
On 25/05/2020 11:25, m...@adrianschmutzler.de wrote: [...] Despite, armv7 uses 64 MB ? Hm, you're right. Not sure, I wouldn't increase the CMA buffer more as needed though, as any unused CMA space is basically wasted, it can't be used for caches etc right now. But I can increase it to 64

[OpenWrt-Devel] [PATCH 1/2] netifd: wireless: add support for tracking wifi-vlann sections

2020-05-25 Thread John Crispin
This new section allows us to create apvlan settings for hostapd. Signed-off-by: John Crispin --- config.c | 42 ++- scripts/netifd-wireless.sh | 42 ++- wireless.c | 247 +++-- wireless.h | 23 +++- 4

Re: [OpenWrt-Devel] [PATCH RFC libubox] blobmsg: another attrs iteration fix for blobmsg_check_array_len()

2020-05-25 Thread Petr Štetiar
Felix Fietkau [2020-05-25 10:51:36]: Hi, > I think your previous fix is completely fine as-is. just FYI Rafał's fix triggered fuzzer CI failure[1], regression, I'm able to reproduce it localy so it's not false positive. So perhaps there's some additional check missing somewhere? $ echo

[OpenWrt-Devel] [PATCH 1/2] bcm47xx: remove support for kernel 4.14

2020-05-25 Thread Adrian Schmutzler
We currently support three kernel versions on this target, let's just get rid of the oldest one. Cc: Rafał Miłecki Signed-off-by: Adrian Schmutzler --- target/linux/bcm47xx/config-4.14 | 215 ...-Add-Luxul-XAP1500-XWR1750-WiFi-LEDs.patch | 86 ---

Re: [OpenWrt-Devel] [PATCH] layerscape: kernel: cma: increase CMA buffer size from 16 to 32MB

2020-05-25 Thread mail
Hi Linus, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Linus Lüssing > Sent: Montag, 25. Mai 2020 09:40 > To: openwrt-devel@lists.openwrt.org > Cc: Linus Lüssing ; Sven Eckelmann > > Subject: [OpenWrt-Devel] [PATCH]

Re: [OpenWrt-Devel] [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2020-05-25 Thread Sven Eckelmann
On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote: [...] > could somone clarify the state here and why it was dropped? > the original patch i wrote does exclude the soc chipsets, but the patch > was later reorganized and some part have been rewritten > so i'm not sure if it

Re: [OpenWrt-Devel] [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2020-05-25 Thread Sebastian Gottschall
Am 25.05.2020 um 11:22 schrieb Sven Eckelmann: On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote: [...] could somone clarify the state here and why it was dropped? the original patch i wrote does exclude the soc chipsets, but the patch was later reorganized and some part have

[OpenWrt-Devel] [PATCH RFC libubox] blobmsg: another attrs iteration fix for blobmsg_check_array_len()

2020-05-25 Thread Rafał Miłecki
From: Rafał Miłecki After more reviews is seems that blobmsg_for_each_attr() should not be used when dealing with untrusted data as it reads length from blob data itself. It means it can't be used in the blobmsg_check_array_len(). Switch back to using __blobmsg_for_each_attr() BUT pass correct

Re: [OpenWrt-Devel] Targets without 5.4 support yet

2020-05-25 Thread Koen Vandeputte
On 25.05.20 13:11, Zoltan HERPAI wrote: Hi, On 5/25/2020 12:42, m...@adrianschmutzler.de wrote: Hi all, while there has been a lot of progress during the last months, there are still a few target that have not been updated to 5.4 (at least as testing kernel) yet: 4.19: cns3xxx 4.14:

Re: [OpenWrt-Devel] [PATCH] build: always use -minterlink-mips16 if USE_MIPS16

2020-05-25 Thread Felix Fietkau
On 2020-05-25 02:19, Eneas U de Queiroz wrote: > Individual packages may turn off MIPS16 ISA individually with > PKG_USE_MIPS16. However, they may link to a library compiled with > MIPS16. In such cases, the -minterlink-mips16 is needed to ensure there > are no direct jumps to code compiled with

Re: [OpenWrt-Devel] [PATCH RFC libubox] blobmsg: another attrs iteration fix for blobmsg_check_array_len()

2020-05-25 Thread Petr Štetiar
Rafał Miłecki [2020-05-25 10:31:06]: Hi, > From: Rafał Miłecki > > After more reviews is seems that blobmsg_for_each_attr() should not be > used when dealing with untrusted data as it reads length from blob data > itself. It means it can't be used in the blobmsg_check_array_len(). > > Switch

Re: [OpenWrt-Devel] Targets without 5.4 support yet

2020-05-25 Thread Zoltan HERPAI
Hi, On 5/25/2020 12:42, m...@adrianschmutzler.de wrote: Hi all, while there has been a lot of progress during the last months, there are still a few target that have not been updated to 5.4 (at least as testing kernel) yet: 4.19: cns3xxx 4.14: ar71xx (to be removed) arc770 (RFT patch:

Re: [OpenWrt-Devel] [PATCH] build: always use -minterlink-mips16 if USE_MIPS16

2020-05-25 Thread Eneas Queiroz
On Mon, May 25, 2020 at 5:06 AM Felix Fietkau wrote: > > On 2020-05-25 02:19, Eneas U de Queiroz wrote: > > Individual packages may turn off MIPS16 ISA individually with > > PKG_USE_MIPS16. However, they may link to a library compiled with > > MIPS16. In such cases, the -minterlink-mips16 is

Re: [OpenWrt-Devel] Fix for missing kernel stack-protector in x86_64 glibc builds

2020-05-25 Thread Ian Cooper
Yes, it appears we can handle uclibc the same way Uclibc-ng supports SSP in the library itself, so use of GCC_LIBSSP can eliminated. I'll do some testing ... config UCLIBC_HAS_SSP bool "Support for GCC stack smashing protector" depends on !HAVE_NO_SSP help Add

Re: [OpenWrt-Devel] [RFT PATCH] arc770: bump kernel to 5.4

2020-05-25 Thread Hauke Mehrtens
On 4/13/20 12:33 PM, Adrian Schmutzler wrote: > Update config with make kernel_oldconfig and copy patch. > > Directly switch to kernel 5.4. > > Signed-off-by: Adrian Schmutzler > > --- > > I just stupidly copied/refreshed the patch and the config. > > Build-tested, run-test required as I

[OpenWrt-Devel] [PATCH] hostapd: add support for wifi-station and wifi-vlan sections

2020-05-25 Thread John Crispin
This patch adds support for 2 new uci sections. config wifi-vlan # iface is optional. if it is not defined the vlan will apply # to all interfaces option ifacedefault_radio0 option name guest option vid 100 option network guest config

[OpenWrt-Devel] [PATCH libubox 3/3] blobmsg: fix missing length checks

2020-05-25 Thread Felix Fietkau
blobmsg_check_attr_len was calling blobmsg_check_data for some, but not all attribute types. These checks was missing for arrays and tables. Additionally, the length check in blobmsg_check_data was a bit off, since it was comparing the blobmsg data length against the raw blob attr length. Fix

[OpenWrt-Devel] [PATCH libubox 1/3] blobmsg: fix length in blobmsg_check_array

2020-05-25 Thread Felix Fietkau
blobmsg_check_array_len expects the length of the full attribute buffer, not just the data length. Due to other missing length checks (fixed in the next commit), this did not show up as a test failure Signed-off-by: Felix Fietkau --- blobmsg.c | 2 +- 1 file changed, 1 insertion(+), 1

[OpenWrt-Devel] [PATCH libubox 2/3] blobmsg: simplify and fix name length checks in blobmsg_check_name

2020-05-25 Thread Felix Fietkau
blobmsg_hdr_valid_namelen was omitted when name==false The blob_len vs blobmsg_namelen changes were not taking into account potential padding between name and data Signed-off-by: Felix Fietkau --- blobmsg.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

Re: [OpenWrt-Devel] [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2020-05-25 Thread Sven Eckelmann
On Monday, 25 May 2020 11:22:13 CEST Sven Eckelmann wrote: [...] > And it still can with this OpenWrt version. But it doesn't seem to happen > with > the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000 > commits inbetween. So no idea what changed (just a timing thing or

Re: [OpenWrt-Devel] netifd: per-interface MTU settings vs per-route MTU settings?

2020-05-25 Thread Aleksander Morgado
Hey, > >> There's an ongoing discussion in the ModemManager package in github > >> related to how the MTU may be configured in the network interface > >> based on what the MM bearer object reports: > >> https://github.com/openwrt/packages/issues/11383 > >> > >> E.g.: > >> > >> $ ip route show >

Re: [OpenWrt-Devel] netifd: per-interface MTU settings vs per-route MTU settings?

2020-05-25 Thread Michael Jones
On Mon, May 25, 2020 at 8:00 AM Aleksander Morgado wrote: > Other protocol handlers, like uqmi, are also able to setup the MTU, > and instead of doing it via proto_send_update, they just do it like > this: > > [ -n "$mtu" ] && { > echo "Setting MTU to $mtu" >

Re: [OpenWrt-Devel] [PATCH libubox 2/3] blobmsg: simplify and fix name length checks in blobmsg_check_name

2020-05-25 Thread Rafał Miłecki
On 25.05.2020 17:19, Felix Fietkau wrote: blobmsg_hdr_valid_namelen was omitted when name==false The blob_len vs blobmsg_namelen changes were not taking into account potential padding between name and data Signed-off-by: Felix Fietkau Tested-by: Rafał Miłecki

Re: [OpenWrt-Devel] [PATCH libubox 3/3] blobmsg: fix missing length checks

2020-05-25 Thread Rafał Miłecki
On 25.05.2020 17:19, Felix Fietkau wrote: blobmsg_check_attr_len was calling blobmsg_check_data for some, but not all attribute types. These checks was missing for arrays and tables. Additionally, the length check in blobmsg_check_data was a bit off, since it was comparing the blobmsg data

Re: [OpenWrt-Devel] [PATCH libubox 1/3] blobmsg: fix length in blobmsg_check_array

2020-05-25 Thread Rafał Miłecki
On 25.05.2020 17:19, Felix Fietkau wrote: blobmsg_check_array_len expects the length of the full attribute buffer, not just the data length. Due to other missing length checks (fixed in the next commit), this did not show up as a test failure Signed-off-by: Felix Fietkau Tested-by: Rafał

[OpenWrt-Devel] [PATCH v5] ramips: add support for Trendnet TEW-810DR

2020-05-25 Thread Heppler, J. Scott
* MediaTek MT7620A (580 Mhz) * 8 MB of FLASH * 64 MB of RAM * 2.4Ghz and 5.0Ghz radios both now functional * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN) * UART header on PCB (57600 8n1) * Green/Orange Power LEDs illuminating a Power-Button Lens Green/Orange Internet LEDs GPIO controlled

[OpenWrt-Devel] [PATCH v6] ramips: add support for Trendnet TEW-810DR

2020-05-25 Thread Heppler, J. Scott
* MediaTek MT7620A (580 Mhz) * 8 MB of FLASH * 64 MB of RAM * 2.4Ghz and 5.0Ghz radios both now functional * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN) * UART header on PCB (57600 8n1) * Green/Orange Power LEDs illuminating a Power-Button Lens Green/Orange Internet LEDs GPIO controlled

[OpenWrt-Devel] [PATCH v7] ramips: add support for TRENDnet TEW-810DR

2020-05-25 Thread Heppler, J. Scott
* MediaTek MT7620A (580 Mhz) * 8 MB of FLASH * 64 MB of RAM * 2.4Ghz and 5.0Ghz radios both now functional * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN) * UART header on PCB (57600 8n1) * Green/Orange Power LEDs illuminating a Power-Button Lens Green/Orange Internet LEDs GPIO controlled

Re: [OpenWrt-Devel] [PATCH v5] ramips: add support for Trendnet TEW-810DR

2020-05-25 Thread Daniel Golle
On Mon, May 25, 2020 at 04:57:36PM -0700, Heppler, J. Scott wrote: > > * MediaTek MT7620A (580 Mhz) > * 8 MB of FLASH > * 64 MB of RAM > * 2.4Ghz and 5.0Ghz radios both now functional > * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN) > * UART header on PCB (57600 8n1) > * Green/Orange Power LEDs

Re: [OpenWrt-Devel] [PATCH v6] ramips: add support for Trendnet TEW-810DR

2020-05-25 Thread Daniel Golle
On Mon, May 25, 2020 at 05:05:16PM -0700, Heppler, J. Scott wrote: > > * MediaTek MT7620A (580 Mhz) > * 8 MB of FLASH > * 64 MB of RAM > * 2.4Ghz and 5.0Ghz radios both now functional > * 5x 10/100 Mbps Ethernet (1 WAN and 4 LAN) > * UART header on PCB (57600 8n1) > * Green/Orange Power LEDs

[OpenWrt-Devel] [PATCH 0/1] toolchain: remove gcc libssp and use libc variant

2020-05-25 Thread Ian Cooper
Gcc's libssp is a standalone userspace implementation of SSP that makes gcc incompatible with kernel stack protection. Builds using libssp cannot enable kernel stack protection due to the insertion of an incompatible stack canary by libssp-enabled gcc. All three C libraries supported by OpenWrt

[OpenWrt-Devel] [PATCH 1/1] toolchain: remove gcc libssp and use libc variant

2020-05-25 Thread Ian Cooper
Removes the standalone implementation of stack smashing protection in gcc's libssp in favour of the native implementation in musl, glibc and uClibc and introduces a uniform configuration interface. This also makes kernel-level stack smashing protection available for builds using non-musl libc