[PATCH 2/3] rtl838x: d-link_dgs-1210: refactor common family bits

So it can be easily shared with other boards in the family and while at it add missing SPDX license identifiers into the DTS files. Signed-off-by: Petr Štetiar --- .../dts/rtl8382_d-link_dgs-1210-16.dts| 81 +- .../rtl838x/dts/rtl8382_d-link_dgs-1210.dtsi | 84

[PATCH 1/3] rtl838x: clean whitespace issues in rtl8382_d-link_dgs-1210-16.dts

So it's tidy. Signed-off-by: Petr Štetiar --- target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-16.dts | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-16.dts b/target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-1

[PATCH 3/3] rtl838x: add support for D-Link DGS-1210-28

nning from initramfs image. It has been developed and tested on device with F1 revision. Signed-off-by: Petr Štetiar --- .../dts/rtl8382_d-link_dgs-1210-28.dts| 339 ++ target/linux/rtl838x/image/Makefile | 6 + 2 files changed, 345 insertions(+) create mode 1

[PATCH v2 5/6] rtl838x: rtl838x.dtsi: fix missing interrupt-parent for uart0

Fixes following dtc warning: Warning (interrupts_property): /uart@b8002000: Missing interrupt-parent Signed-off-by: Petr Štetiar --- target/linux/rtl838x/dts/rtl838x.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/linux/rtl838x/dts/rtl838x.dtsi b/target/linux/rtl838x/dts

[PATCH v2 1/6] rtl838x: clean whitespace issues in rtl8382_d-link_dgs-1210-16.dts

So it's tidy. Signed-off-by: Petr Štetiar --- target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-16.dts | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-16.dts b/target/linux/rtl838x/dts/rtl8382_d-link_dgs-1210-1

[PATCH v2 4/6] rtl838x: rtl838x.dtsi: remove reg property from root node

Fixes following dtc warning: ../dts/rtl838x.dtsi:38.3-145.3: Warning (reg_format): /: Root node has a "reg" property Signed-off-by: Petr Štetiar --- target/linux/rtl838x/dts/rtl838x.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/rtl838x/dts/rtl838x.dtsi b/ta

[PATCH v2 0/6] rtl838x: add support for D-Link DGS-1210-28

added macros for phy and switch definitions Cheers, Petr Petr Štetiar (6): rtl838x: clean whitespace issues in rtl8382_d-link_dgs-1210-16.dts rtl838x: d-link_dgs-1210: refactor common family bits rtl838x: add support for D-Link DGS-1210-28 rtl838x: rtl838x.dtsi: remove reg property from

[PATCH v2 2/6] rtl838x: d-link_dgs-1210: refactor common family bits

So the common bits can be easily shared with other boards in the family and while at it add missing SPDX license identifiers into the DTS files and fixed alphabetic sorting of the devices in the images. Signed-off-by: Petr Štetiar --- .../dts/rtl8382_d-link_dgs-1210-10p.dts | 2

[PATCH v2 6/6] rtl838x: dts: use macros for phy and switch definitions

It's quite more readable, saves some tedious copy&pasting, more error prone etc. Signed-off-by: Petr Štetiar --- .../dts/rtl8382_allnet_all-sg8208m.dts| 111 +- .../dts/rtl8382_d-link_dgs-1210-10p.dts | 125 +- .../dts/rtl8382_d-link_dgs-1210-16.dts

[PATCH v2 3/6] rtl838x: add support for D-Link DGS-1210-28

nning from initramfs image. It has been developed and tested on device with F1 revision. Signed-off-by: Petr Štetiar --- .../dts/rtl8382_d-link_dgs-1210-28.dts| 339 ++ target/linux/rtl838x/image/Makefile | 5 + 2 files changed, 344 insertions(+) create mode 1

x86/64 SDK segfaults on some hosts [Was: Re: [PATCH 1/2] fakeroot: make fakeroot script relocatable]

Jo-Philipp Wich [2020-09-10 14:57:30]: Hi, > Patch the fakeroot script template to discover faked and libfakeroot.so > relative to the STAGING_DIR_HOST environment variable, similar to how it > is done for automake, libtool, quilt and autoconf already. > > This avoids the need for passing the p

[PATCH] rtl838x: fine tune default package set

Althought most of the switches aren't routers, they can be used as such, so let's add some of the packages from the router's DEVICE_TYPE. While at it, remove swconfig package which is not needed on DSA targets. Signed-off-by: Petr Štetiar --- target/linux/rtl838x/Makefile

QEMU x86/64 ubus issues [Was: Re: [PATCH 0/2] enable procd security features by default]

Daniel Golle [2020-11-07 14:17:12]: Hi, > A while ago we have added some useful kernel features to !SMALL_FLASH > devices[1]. To make more use of that by default in a way which will > make exploiting potential vulnerabilities in OpenWrt's services much > harder, it'd be great to also have procd-

Re: x86/64 SDK segfaults on some hosts [Was: Re: [PATCH 1/2] fakeroot: make fakeroot script relocatable]

Paul Spooren [2020-11-09 08:58:16]: > On Mon Nov 9, 2020 at 7:33 AM HST, Jo-Philipp Wich wrote: > > I probably missed the point of your mail - do you meant to imply that my > > patch introduced this regression? > > Since the CI builds start failing the same day as the patches were > commited the

Re: Upcoming 19.07.4 and 18.07.9 stable releases

Hauke Mehrtens [2020-11-11 00:58:52]: Hi, > Currently 18.06 looks good for me and I would really like to do the final > release and call it then officially end of life. I've just noticed following "librpc: fix CE in mac os" https://github.com/openwrt/openwrt/pull/3263 -- ynezz __

Re: [PATCH] busybox: enable whois by default

Josef Schlehofer [2020-11-17 02:07:09]: Hi, > Whois can identify who owns a domain and how to get reach owner. Providing > this tool in OpenWrt someone does not need to use websites for everything. I don't think, that this tool is essential enough to be shipped by default. One can use whois on

[PATCH] download: handle possibly invalid local tarballs

ball source make package/libubox/{clean,compile} Signed-off-by: Petr Štetiar --- include/download.mk | 2 +- scripts/download.pl | 18 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/include/download.mk b/include/download.mk index d393bf390716..7c2de929d347

Re: 20.xx: postponse LuCI HTTPS per default

Paul Spooren [2020-11-19 13:09:02]: Hi, > while 20.xx seems close, I don't share your view on this one, 21.xx is close, yes :-) Just being realistic here. So I would say, that if this issue should be tackled, there is still some time left to do so. > I'd like to suggest to postponse HTTPS LuC

[PATCH v2] download: handle possibly invalid local tarballs

ball source make package/libubox/{clean,compile} Signed-off-by: Petr Štetiar --- Changes since v1: * fixed infinite re-downloading of the source tarball when using KERNEL_GIT_LOCAL_REPOSITORY include/host-build.mk | 2 ++ include/package.mk| 2 ++ scripts/download.pl | 18 +++

[PATCH 1/2] toolchain: kernel-headers: fix check target for kernel Git tree

'toolchain/kernel-headers' toolchain/Makefile:100: recipe for target 'toolchain/kernel-headers/check' failed Signed-off-by: Petr Štetiar --- toolchain/kernel-headers/Makefile | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/toolchain/kernel-header

[PATCH 2/2] toolchain: kernel-headers: kernel Git tree mirror hash

Allow setting of mirror hash for Git kernel tree. Signed-off-by: Petr Štetiar --- config/Config-devel.in| 5 + toolchain/kernel-headers/Makefile | 1 + 2 files changed, 6 insertions(+) diff --git a/config/Config-devel.in b/config/Config-devel.in index 6447a79db2ca..21e15f16dcb4

Re: QEMU x86/64 ubus issues [Was: Re: [PATCH 0/2] enable procd security features by default]

Petr Štetiar [2020-11-10 07:43:24]: Hi, > I've started QEMU x86/64 (4 cores, 512MB RAM) with LAN/WAN interfaces > yesterday in the afternoon and found it in unusable state this morning, > without network and constantly OOMing. I did tested it few more times and it looks like it

Re: [PATCH] Revert "build: switch VERSION_REPO to HTTPS"

Paul Spooren [2020-11-24 22:29:00]: Hi, > Using HTTPS for opkg dramatically slows down download of packages and reload > of indexes. do you've such dramatic numbers handy? > This was mostly introduced to secure the ImageBuilder. However with the > usign signature checking ability added to Imag

Re: [PATCH] config: clean double whitespace in Config-build.in

> + config KERNEL_STACKPROTECTOR_STRONG > bool > default KERNEL_CC_STACKPROTECTOR_STRONG Reviewed-by: Petr Štetiar ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] Revert "build: switch VERSION_REPO to HTTPS"

Baptiste Jonglez [2020-11-25 12:41:18]: Hi, > For the imagebuilder, it increases the *total* build time (not just > download time!) by +50%: > > http://lists.openwrt.org/pipermail/openwrt-devel/2020-September/031406.html I don't consider 10 seconds dramatic increase of time, but it of course d

Re: [PATCH 0/8] kernel: mtdsplit_uimage: use device tree properties for non-standard uimage parsing

Bjørn Mork [2020-11-25 12:45:03]: Hi, > Still not sure that was a good idea. 140 insertions(+), 377 deletions(-) nice numbers, I like it, thanks. Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.or

Re: [PATCH] libroxml: switch to CMake

Rosen Penev [2020-07-11 11:20:15]: Hi, > Added patch to fix compilation with gcc10. > > Fixed license information. > > Fix ABI_VERSION. possibly another candidate for move into packages feed? Thanks! Cheers, Petr ___ openwrt-devel mailing list op

Re: [PATCH] openssl: fix compilation

Rosen Penev [2020-11-24 02:04:24]: Hi, > It seems the Makefile wrongly picks up dist CC and matches on a clang > path. > > Fixes: > > mips-openwrt-linux-musl-gcc: error: unrecognized command-line option > '-Qunused-arguments' then the fix seems wrong. You should make sure, that proper CC is u

odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Hi Hans, I've tried to ping you on IRC few days ago as I've found some strange issue with odhcp6c which leads to OOM/OOPS[1] (log with just the important parts). It simply happens every time after about 10 hours for me when I boot the system in QEMU and have LAN/WAN networks connected there. It l

Recovering mailing list archives

Hi, so far I've noticed 2 years of missing emails in openwrt-adm archives from 6/2018 to 5/2020 and would like to fix this situation. So here is my current vision: 1. Collect[A] email archives in maildir or mbox format for openwrt-devel and openwrt-adm lists * please send me the links t

Re: [PATCH 0/2] enable procd security features by default

Daniel Golle [2020-11-07 14:17:12]: Hi, > Please report back testing now the latest master on rtl8382 booted from initramfs and seeing following: Thu Nov 26 14:45:35 2020 user.notice dnsmasq: DNS rebinding protection is active, will discard upstream RFC1918 responses! Thu Nov 26 14:45:36 2

Re: [PATCH 0/2] enable procd security features by default

Daniel Golle [2020-11-27 03:21:39]: Hi, > On Thu, Nov 26, 2020 at 05:43:53PM +0100, Petr Štetiar wrote: > > Daniel Golle [2020-11-07 14:17:12]: > > > > > Please report back > > > > testing now the latest master on rtl8382 booted from initramfs and seeing

[PATCH] cmake.mk,rules.mk: fix host builds using CMake and ccache

as well. Fixes: f98878e4c17d ("cmake.mk: set C/CXX compiler for host builds as well") Reported-by: Ansuel Smith Signed-off-by: Petr Štetiar --- include/cmake.mk | 18 -- rules.mk | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/include/cm

Re: [PATCH] cmake.mk, rules.mk: fix host builds using CMake and ccache

Ansuel Smith [2020-11-28 15:13:32]: Hi, > Can confirm that this fix the bug. sorry for the breakage and thank you for testing. Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/op

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Hans Dedecker [2020-11-26 21:19:30]: Hi, > Is it possible to have a pcap trace of the DHCPv6 messages on the wan ? > I hope to find some time next weekend to investigate the issue further http://ynezz.true.cz/openwrt/odhcp6c/capture.pcap.gz Cheers, Petr __

[PATCH 19.07 5/6] toolchain: kernel-headers: fix check target for kernel Git tree

'toolchain/kernel-headers' toolchain/Makefile:100: recipe for target 'toolchain/kernel-headers/check' failed Signed-off-by: Petr Štetiar (cherry picked from commit bb7ba6b6a81d1fb7ac6075edfd8e8b713dd61db2) --- toolchain/kernel-headers/Makefile | 11 +-- 1 file changed

[PATCH 19.07 0/6] backport fixes

Hi, seems like dust has settled so I would like to backport fixes related to reproducibility of builds and one CMake fix for new macOS/XCode woes. Cheers, Petr Petr Štetiar (5): cmake.mk,rules.mk: fix host builds using CMake and ccache download: handle possibly invalid local tarballs

[PATCH 19.07 1/6] cmake.mk: set C/CXX compiler for host builds as well

From: Rosen Penev Without this, cmake will use whatever CC/CXX is set to, which could be clang. In that case, at least libjson-c/host will fail to compile. Signed-off-by: Rosen Penev (cherry picked from commit f98878e4c17d5f11e78994b4fc456e6b60b2660f) Signed-off-by: Petr Štetiar --- include

[PATCH 19.07 3/6] download: handle possibly invalid local tarballs

ball source make package/libubox/{clean,compile} Signed-off-by: Petr Štetiar (cherry picked from commit 4e19cbc553350b8146985367ba46514cf50e3393) --- include/host-build.mk | 2 ++ include/package.mk| 2 ++ scripts/download.pl | 18 ++ 3 files changed, 22 insertions(+) diff

[PATCH 19.07 6/6] toolchain: kernel-headers: kernel Git tree mirror hash

Allow setting of mirror hash for Git kernel tree. Signed-off-by: Petr Štetiar (cherry picked from commit 796d51834c5be85771d26e433fd509cd3bef72e3) --- config/Config-devel.in| 5 + toolchain/kernel-headers/Makefile | 1 + 2 files changed, 6 insertions(+) diff --git a/config

[PATCH 19.07 4/6] download.pl: properly cleanup intermediate .hash file

-by: Hannu Nyman Signed-off-by: Petr Štetiar (cherry picked from commit 52a5d0d27f2557db99fc5435fbd7783b649cb9b2) --- scripts/download.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/download.pl b/scripts/download.pl index c1623bf91fe0..2876ae5807cd 100755 ---

[PATCH 19.07 2/6] cmake.mk, rules.mk: fix host builds using CMake and ccache

as well. Fixes: f98878e4c17d ("cmake.mk: set C/CXX compiler for host builds as well") Reported-by: Ansuel Smith Tested-by: Ansuel Smith Signed-off-by: Petr Štetiar (cherry picked from commit 524fb5646eec6147aadfdd508219f39bcf8ba8fc) --- include/cmake.mk | 18 -- rules.m

Re: [PATCH] kernel: enable SRv6 support

vinc...@systemli.org [2020-12-02 12:25:58]: Hi, > diff --git a/target/linux/generic/config-5.4 b/target/linux/generic/config-5.4 > index 10d14f6be5..942777b41e 100644 > --- a/target/linux/generic/config-5.4 > +++ b/target/linux/generic/config-5.4 > @@ -2387,7 +2387,7 @@ CONFIG_IO_STRICT_DEVMEM=y

Re: [PATCH 19.07 6/6] toolchain: kernel-headers: kernel Git tree mirror hash

Adrian Schmutzler [2020-12-02 15:55:18]: Hi, > > Allow setting of mirror hash for Git kernel tree. > > Not sure whether backporting this very patch is absolutely necessary, but it > shouldn't hurt either. it's not obvious, but it's needed with patch 5/6, otherwise you can't set mirror hash a

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Hans Dedecker [2020-12-01 21:12:30]: Hi, > Can you check if commit > https://git.openwrt.org/?p=project/odhcp6c.git;a=commit;h=a7b2221f687264c020b7a18a4e690d79f312a667 > fixes the issue in your setup ? yes, it seems so as it's currently almost 24h up without any issues. > While doing the test

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Hans Dedecker [2020-12-03 21:18:11]: Hi, > Looking into the new pcap capture I must admit I've never seen such a DHCPv6 > server with such weird behavior. it's OpenWrt so odhcpd. -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.or

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Hans Dedecker [2020-12-04 13:55:27]: > Could you run odhcpd with loglevel 7 as I would like to understand > what triggers the numerous transmission of the Reconfigure messages http://ynezz.true.cz/openwrt/odhcp6c/syslog-2020-12-05.log.gz ___ openwrt-d

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

Petr Štetiar [2020-12-02 21:25:12]: Hi, > > Can you check if commit > > https://git.openwrt.org/?p=project/odhcp6c.git;a=commit;h=a7b2221f687264c020b7a18a4e690d79f312a667 > > fixes the issue in your setup ? > > yes, it seems so as it's currently almost 24h up witho

Re: [PATCH] ustream-ssl: openssl: fix bio memory leak

Rosen Penev [2020-12-08 17:02:03]: Hi, > Is this needed? AFAIK, OpenSSL 1.1 frees everything automatically. LeakSanitizer: $ uclient-fetch-san -q -O /dev/null 'https://expired.badssl.com/' = ==1990==ERROR: LeakSanitizer:

Re: [PATCH ustream] ustream-openssl: fix bio memory leak

Eneas U de Queiroz [2020-12-09 13:06:45]: Hi, > Using the patch by Pan Chen as inspiration, this avoids a memory leak by > using a global BIO_METHOD pointer that doesn't ordinarily need to be > freed. this sounds weird, how is global pointer avoiding memory leaks? :-) > CC: Pan Chen > > Sign

Re: [PATCH ustream] ustream-openssl: fix bio memory leak

Eneas U de Queiroz [2020-12-09 14:39:06]: Hi, > So the answer to your question is because you only allocate the table if > methods_ustream is NULL, and it will point to the created table then. I was referencing the missing freeing of allocated resources. > We could free it in s_ustream_free,

Security Advisory 2020-11-XX-2 - libuci import heap use after free (CVE-2020-XXXX)

Galindo, fixed by Petr Štetiar and Hauke Mehrtens. REFERENCES 1. https://nvd.nist.gov/vuln/detail/CVE-2020-28951 2. https://openwrt.org/advisory/2020-12-09-2 signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel

[PATCH] wolfssl: fix broken wolfSSL_X509_check_host

Backport upstream post 4.5.0 fix for broken wolfSSL_X509_check_host(). References: https://github.com/wolfSSL/wolfssl/issues/3329 Signed-off-by: Petr Štetiar --- package/libs/wolfssl/Makefile | 2 +- .../200-fix-checkhostname-matching.patch | 123 ++ 2

[PATCH ustream-ssl 02/12] cmake: fix linking when wolfSSL not in default paths

Fixes following issue when wolfSSL libs are installed in different paths: /usr/bin/ld: cannot find -lwolfssl Signed-off-by: Petr Štetiar --- CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 315aeb87c80b..42c7f1fb00de

[PATCH ustream-ssl 01/12] cmake: fix building out of the tree

When building out of the tree, linker is unable to find the ubox library so fix it by using find_library CMake command. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 86e1b0788613

[PATCH ustream-ssl 07/12] cmake: enable extra compiler checks

Let's enforce additional automatic checks enforced by the compiler in order to catch possible errors during compilation. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bb2abe5

[PATCH ustream-ssl 03/12] cmake: fix linking when mbed TLS not in default paths

Fixes following issue when mbed TLS libs are installed in different paths: /usr/bin/ld: cannot find -lmbedtls /usr/bin/ld: cannot find -lmbedcrypto /usr/bin/ld: cannot find -lmbedx509 Signed-off-by: Petr Štetiar --- CMakeLists.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH ustream-ssl 04/12] ustream-openssl: fix wolfSSL includes

SL_SetIOWriteCtx' is invalid in C99 [-Werror,-Wimplicit-function-declaration] Signed-off-by: Petr Štetiar --- ustream-openssl.c | 3 +++ ustream-openssl.h | 6 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ustream-openssl.c b/ustream-openssl.c index f8e848d69fb3..dec

[PATCH ustream-ssl 00/12] fixes, improvements and CI

Petr Štetiar (12): cmake: fix building out of the tree cmake: fix linking when wolfSSL not in default paths cmake: fix linking when mbed TLS not in default paths ustream-openssl: fix wolfSSL includes ustream-openssl: fix BIO_method memory leak ustream-mbedtls: fix comparison of integers

[PATCH ustream-ssl 09/12] ustream-mbedtls: implement set_require_validation

In commit "ustream-openssl: wolfSSL: fix certificate validation" we've added new set_require_validation() function so implement it for mbed TLS as well. Signed-off-by: Petr Štetiar --- ustream-mbedtls.c | 12 1 file changed, 12 insertions(+) diff --git a/ustr

[PATCH ustream-ssl 06/12] ustream-mbedtls: fix comparison of integers of different signs

Fixes following compiler extra warning: ustream-mbedtls.c:40:11: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] if (slen > len) ^ ~~~ Signed-off-by: Petr Štetiar ---

[PATCH ustream-ssl 10/12] ustream-mbedtls: fix certificate verification

ing either). References: https://lists.infradead.org/pipermail/openwrt-devel/2018-August/019183.html Suggested-by: Paul Wassi Signed-off-by: Petr Štetiar --- ustream-mbedtls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ustream-mbedtls.c b/ustream-mbedtls.c index 1b

[PATCH ustream-ssl 12/12] Add initial GitLab CI support

/openwrt-ci/ Signed-off-by: Petr Štetiar --- .gitlab-ci.yml | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index ..aae5e9297edf --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,6

[PATCH ustream-ssl 05/12] ustream-openssl: fix BIO_method memory leak

966==by 0x401FD9: init_request (uclient-fetch.c:333) ==1966==by 0x401E08: main (uclient-fetch.c:745) Suggested-by: Pan Chen Signed-off-by: Petr Štetiar --- ustream-io-openssl.c | 47 ++-- ustream-openssl.c| 7 +++ ustream-openssl.h| 5 +

[PATCH ustream-ssl 11/12] wolfssl: remove now deprecated compatibility code

f spending time on fixing it, I've simply decided to remove it as we're now on wolfSSL 4.5.0 and those symbols should be avaialable so no symbol detection and handling should be needed anymore. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 13 - ustream-io-wolfssl.c |

[PATCH ustream-ssl 08/12] ustream-openssl: wolfSSL: fix certificate validation

sages via `notify_verify_error()` callback we as well need to handle certificate errors manually. Fixes: FS#3465 Signed-off-by: Petr Štetiar --- ustream-internal.h | 1 + ustream-openssl.c | 73 ++ ustream-ssl.c | 1 + ustream-ssl.h | 19 +++

[PATCH uclient 04/12] uclient-http: fix freeing of stack allocated memory

Fixes following issue reported by clang-12 static analyzer: uclient-http.c:568:2: warning: Memory allocated by alloca() should not be deallocated [unix.Malloc] free(buf_orig); ^~ Signed-off-by: Petr Štetiar --- uclient-http.c | 12 +--- 1 file changed, 5

[PATCH uclient 01/12] cmake: fix building out of the tree

When building out of the tree, linker is unable to find the ubox library so fix it by using find_library CMake command. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 072afef92479

[PATCH uclient 00/12] fixes, improvements and CI

Petr Petr Štetiar (12): cmake: fix building out of the tree Add basic cram based unit tests Fix extra compiler warnings uclient-http: fix freeing of stack allocated memory uclient-fetch: fix statement may fallt hrough uclient: fix initialized but never read variable uclient-fetch

[PATCH uclient 07/12] uclient-fetch: fix potential memory leaks

#x27;, strlen(optarg)); ^~ uclient-fetch.c:618:25: warning: Potential leak of memory pointed to by 'password' [unix.Malloc] memset(optarg, '*', strlen(optarg)); ^~~~~~ Signed-off-by: Petr Š

[PATCH uclient 06/12] uclient: fix initialized but never read variable

Fixes following issue reported by clang-12 static analyzer: uclient.c:290:22: warning: Value stored to 'url' during its initialization is never read [deadcode.DeadStores] struct uclient_url *url = cl->url; ^~~ ~~~ Signed-off-by:

[PATCH uclient 05/12] uclient-fetch: fix statement may fallt hrough

Fixes following issue reported by clang-12 static analyzer: uclient-fetch.c:228:6: error: this statement may fall through [-Werror=implicit-fallthrough=] if (sscanf(blobmsg_get_string(tb[H_RANGE]), ^ uclient-fetch.c:236:2: note: here case 204: ^~~~ Signed-off-by: Petr Štetiar

[PATCH uclient 08/12] uclient-http: fix extra compiler warnings on mips_24kc and cortex-a9+neon

0:11: error: comparison of integer expressions of different signedness: 'unsigned int' and 'long int' [-Werror=sign-compare] if (len > uh->content_length) ^ References: https://gitlab.com/ynezz/openwrt-uclient/-/pipelines/226912126 Signed-off-by: Petr Šte

[PATCH uclient 03/12] Fix extra compiler warnings

(i = 0; i < ARRAY_SIZE(request_types); i++) { ~ ^ ~ uclient-fetch.c:551:67: error: missing field 'flag' initializer [-Werror,-Wmissing-field-initializers] [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument }, Signed-off-by: Petr

[PATCH uclient 09/12] cmake: enable extra compiler checks

Let's enforce additional automatic checks enforced by the compiler in order to catch possible errors during compilation. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c2f1fdb

[PATCH uclient 10/12] uclient-fetch: init_ca_cert: fix memory leak

) by 0x4C33D84: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x553C7DF: glob_in_dir (glob.c:1410) by 0x553D5E8: glob@@GLIBC_2.27 (glob.c:1097) by 0x401D62: init_ca_cert (uclient-fetch.c:503) by 0x401D62: main (uclient-fetch.c:741) Signed-off-by: Petr Štetiar

[PATCH uclient 02/12] Add basic cram based unit tests

For the start just basic uclient-fetch functionality coverage. Signed-off-by: Petr Štetiar --- CMakeLists.txt | 24 - tests/CMakeLists.txt| 1 + tests/cram/CMakeLists.txt | 38 ++ tests/cram/server/lorem | 64

[PATCH uclient 12/12] Add initial GitLab CI support

/openwrt-ci/ Signed-off-by: Petr Štetiar --- .gitlab-ci.yml | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index ..94befcee491e --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,7

[PATCH uclient 11/12] uclient-fetch: wolfSSL: fix certificate validation

urrent OpenSSL based post connection verification logic thus doesn't work. So in order to get the validation working we need to use SSL_VERIFY_PEER for wolfSSL by default and allow disabling it explicitly by new `context_set_require_validation()` call. Fixes: FS#3465 Signed-off-by: Petr Štetiar

Re: [PATCH ustream] ustream-openssl: fix bio memory leak

Eneas U de Queiroz [2020-12-10 11:29:36]: Hi, > access that memory after we free it. This would be after we call > BIO_free. The thing is, we aren't making that call. so we are leaking > that resource as well. IIRC this is solved by OpenSSL internal reference counting and executed in SSL_fre

Re: [PATCH] Revert "build: switch VERSION_REPO to HTTPS"

Paul Spooren [2020-11-25 08:52:30]: Hi, > Until somebody jumps on ustream-ssl and fixes the WolfSSL > implementation, we should consider to disable it. FYI I've just posted hopefully fixes for those issue(s): uclient https://patchwork.ozlabs.org/project/openwrt/list/?series=219813 ustream-ss

Re: [PATCH] build/json: add filesystem information

Paul Spooren [2020-12-13 14:40:55]: > Some images are created using different filesystems, most popular > squashfs and ext4. To allow downstream projects to distinguesh between > those, add the `filesystem` information to created json files. > > Signed-off-by: Paul Spooren Re

Re: [PATCH] build/prereq: requie make 4.1 or later

Paul Spooren [2020-12-12 21:17:02]: Hi, > FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of > stdout piping to a file. The issue describes how e.g. terminal color > codes and up in log files if running make like `make > log.txt`. > > The proposed solution uses the make vari

[PATCH] uhttpd: don't redirect to HTTPS by default

nt: $ uci set uhttpd.main.redirect_https=1 $ uci commit uhttpd $ service uhttpd reload Signed-off-by: Petr Štetiar --- package/network/services/uhttpd/files/uhttpd.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/uhttpd/files/uhttpd.config b/package/network/

Re: [PATCH v2] procd: add info json output

Florian Eckert [2020-12-14 13:56:03]: Hi, > By adding the extra command `info` it is now possible to retrieve all > relevant data from a procd started service directly via the init script. whats the use case, how is this useful? > Until now, you have to query the ubus with the command: > ubus

Re: [PATCH] uhttpd: don't redirect to HTTPS by default

Jo-Philipp Wich [2020-12-14 23:24:23]: Hi, > > So we can ship px5g-wolfssl by default in the release image, but still > > make the HTTPS for LuCI optional. This small change with addition of > > `CONFIG_PACKAGE_px5g-wolfssl=y` into the buildbot's seed config for the > > next release should provi

Make HTTPS in LuCI optional but dead simple in 20.12 [Was: Re: 20.xx: postponse LuCI HTTPS per default]

Petr Štetiar [2020-11-20 11:44:14]: > > I'd like to suggest to postponse HTTPS LuCI (`luci-ssl` vs `luci`) per > > default. > > Do we need to make this hard decission? Can't we leave it to the end users? > We need most of the SSL stuff for other parts, so why n

Re: [RFC] raise gcc/make versions for 20.x

Paul Spooren [2020-12-15 16:26:14]: Hi, > I've seen two patches for version raises of build requirements and would > like to know if we should merge them before or after 20.x. > > make: 3.81.x -> 4.1.x > gcc: 4.8 -> 6.x > > I'm in favor to merge both *before* the branch. it would probably hel

Re: [RFC] raise gcc/make versions for 20.x

Rosen Penev [2020-12-15 19:03:55]: Hi, > The issue is with EL7. That would break the ability to compile. this is moot argument[1]: [root@9bb9a267fbb6 build]# cat /etc/redhat-release CentOS Linux release 7.7.1908 (Core) [root@9bb9a267fbb6 build]# gcc --version gcc (GCC) 8.3.1 20190311 (Re

Re: [PATCH v3] procd: add procd json output to init

Florian Eckert [2020-12-17 09:40:08]: Hi, > By adding the extra command `procd` it is now possible to retrieve all > relevant data from a procd started service directly via the init script. > > Until now, you have to query the ubus to get the information with the > following command. > > `ubus

Re: [PATCH v3] procd: add procd json output to init

Florian Eckert [2020-12-17 10:34:25]: > So that I do not always have to type the whole string. Well, you don't need to. root@OpenWrt:/# cat ~/.shinit procd_service_list() { ubus call service list "{'name':\"$1\",'verbose':true}" } root@OpenWrt:/# procd_service_list urngd { "urn

Re: Upcoming 19.07.6 release plan

Hi, I'm really sorry for the previous email hiccup :-) Anyway, I just wanted to make you aware, that there is a plan to do a next 19.07.6 release somewhere in January 2021 around Tuesday 19th. So feel free to suggest backport/fixes which should be included in this release by replying to this em

Meeting notes - 10th December 2020 virtual meeting

Hi, I would like to let you know, that there was virtual meeting week ago and you can find the meeting minutes on the wiki[1]. 1. https://openwrt.org/meetings/20201210 Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:

[PATCH] build: replace which with Bash command built-in

: command not found /bin/sh: line 1: which: command not found ... Checking 'python3'... failed. ... Fix this by switching to Bash builtin `command` which should provide same functionality. Fixes: FS#3525 Signed-off-by: Petr Štetiar --- Other option is to check for `which` util presence

Re: [PATCH] ca-certificated: use relative symlink for cert.pem

Rosen Penev [2020-12-19 19:11:48]: Hi, > Fixes dead symlink under InstallDev. where is that dead symlink? root@OpenWrt:/# ls -al /etc/ssl/cert.pem lrwxrwxrwx1 root root34 Dec 21 16:53 /etc/ssl/cert.pem -> /etc/ssl/certs/ca-certificates.crt root@OpenWrt:/# ls -al /etc/ssl/

Re: [PATCH] ca-certificated: use relative symlink for cert.pem

Rosen Penev [2020-12-22 02:21:15]: > It's not on the installed device. It's under InstallDev. > > find staging_dir/target-mips_*/root-*/ -xtype l > > for more. $ find staging_dir/target-x86*/root-*/ -xtype l staging_dir/target-x86_64_musl/root-x86/etc/localtime staging_dir/target-x86_64_mus

Re: firewall3: add udp/icmp flood protection

Maksym Kovalchuck [2020-11-04 15:40:04]: Please add proper commit description, see openwrt.org/submitting-patches for details > Signed-off-by: Maksym Kovalchuck > --- > defaults.c | 54 ++ > options.h | 14 +++--- > 2 files changed,

Re: [PATCH] ath79: switch to kernel loader for ar9344 CPE/WBS

Sander Vanheule [2020-09-27 15:59:33]: Hi, > Now that firmware partitions starting with an ELF kernel loader can be > split automatically, move the TP-Link ar9344-based CPE and WBS devices > from an OKLI loader to a plain kernel loader. > > This reduces the size of the device images a bit (2kB

Re: [PATCH] dnsmasq: Ignore carrier status for bridge interfaces

Reuben Dowle [2020-07-16 00:10:43]: Hi, > This occurs because netifd can incorrectly indicate carrier down on an > interface through devstatus after issuing a carrier up hotplug event. then it seems like this should be fixed in netifd. > This patch ignores carrier status for bridge interfaces,

Re: Turris Omnia boot failure after "mvebu: fix initramfs/kernel image for CZNIC Turris Omnia"

Magnus Kroken [2020-12-18 00:30:42]: Hi Magnus, thank you for the bug report and sorry for the breakage. > Commit e401a2a42e6d7c892e1cf7d765fa5ec9b2db3fb3 causes my Turris Omnia > CZ11NIC13 to no longer boot. Compiling with EARLY_PRINTK does not show > anything of interest: > > ## Executing sc

  1   2   3   4   5   6   7   8   9   10   >