Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
Hello, On Monday 29 August 2011 22:09:35 eugene...@gmail.com wrote: From: Eugene San (eugenesan) eugene...@gmail.com Signed-off-by: Eugene San (eugenesan) eugene...@gmail.com --- net/rsync/Makefile | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/rsync/Makefile b/net/rsync/Makefile index 46670e5..f6d8eb1 100644 --- a/net/rsync/Makefile +++ b/net/rsync/Makefile @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 include $(INCLUDE_DIR)/package.mk define Package/rsync - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Fast remote file copy program (like rcp) - DEPENDS:=+libpopt - URL:=http://rsync.samba.org/ + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Fast remote file copy program (like rcp) + DEPENDS:=+libpopt + URL:=http://rsync.samba.org/ endef define Package/rsyncd - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Rsync daemon - DEPENDS:=+rsync + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Rsync daemon + DEPENDS:=+rsync endef define Package/rsync/description @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ --disable-debug \ --disable-locale \ --disable-xattr-support \ - --disable-acl-support \ + --disable-acl-support define Package/rsync/install $(INSTALL_DIR) $(1)/usr/bin @@ -68,7 +68,7 @@ define Package/rsyncd/description endef define Package/rsyncd/conffiles -/etc/rsyncd.conf + /etc/rsyncd.conf endef define Package/rsyncd/install The prefered way of writing a Makefile is how it is right now. Inserting tabs instead of 2 spaces is not what we generally have. -- Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
Ok. I just tried to unify style of this file, and wasn't planning tabs-spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject. Note, there is at least one change not related to styling: - --disable-acl-support \ + --disable-acl-support On Fri, Sep 30, 2011 at 14:48, Florian Fainelli flor...@openwrt.org wrote: Hello, On Monday 29 August 2011 22:09:35 eugene...@gmail.com wrote: From: Eugene San (eugenesan) eugene...@gmail.com Signed-off-by: Eugene San (eugenesan) eugene...@gmail.com --- net/rsync/Makefile | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/rsync/Makefile b/net/rsync/Makefile index 46670e5..f6d8eb1 100644 --- a/net/rsync/Makefile +++ b/net/rsync/Makefile @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 include $(INCLUDE_DIR)/package.mk define Package/rsync - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Fast remote file copy program (like rcp) - DEPENDS:=+libpopt - URL:=http://rsync.samba.org/ + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Fast remote file copy program (like rcp) + DEPENDS:=+libpopt + URL:=http://rsync.samba.org/ endef define Package/rsyncd - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Rsync daemon - DEPENDS:=+rsync + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Rsync daemon + DEPENDS:=+rsync endef define Package/rsync/description @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ --disable-debug \ --disable-locale \ --disable-xattr-support \ - --disable-acl-support \ + --disable-acl-support define Package/rsync/install $(INSTALL_DIR) $(1)/usr/bin @@ -68,7 +68,7 @@ define Package/rsyncd/description endef define Package/rsyncd/conffiles -/etc/rsyncd.conf + /etc/rsyncd.conf endef define Package/rsyncd/install The prefered way of writing a Makefile is how it is right now. Inserting tabs instead of 2 spaces is not what we generally have. -- Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
On Friday 30 September 2011 14:37:05 Eugene San wrote: Ok. I just tried to unify style of this file, and wasn't planning tabs-spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject. Agreed, in general I try to keep this style of 2 spaces for declarations inside define/endef blocks, but having tabs is also valid. Note sure about other editors, but vim for instance does a better highlighting job when using 2 spaces (it's Friday after all). Note, there is at least one change not related to styling: - --disable-acl-support \ + --disable-acl-support On Fri, Sep 30, 2011 at 14:48, Florian Fainelli flor...@openwrt.org wrote: Hello, On Monday 29 August 2011 22:09:35 eugene...@gmail.com wrote: From: Eugene San (eugenesan) eugene...@gmail.com Signed-off-by: Eugene San (eugenesan) eugene...@gmail.com --- net/rsync/Makefile | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/rsync/Makefile b/net/rsync/Makefile index 46670e5..f6d8eb1 100644 --- a/net/rsync/Makefile +++ b/net/rsync/Makefile @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 include $(INCLUDE_DIR)/package.mk define Package/rsync - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Fast remote file copy program (like rcp) - DEPENDS:=+libpopt - URL:=http://rsync.samba.org/ + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Fast remote file copy program (like rcp) + DEPENDS:=+libpopt + URL:=http://rsync.samba.org/ endef define Package/rsyncd - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Rsync daemon - DEPENDS:=+rsync + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Rsync daemon + DEPENDS:=+rsync endef define Package/rsync/description @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ --disable-debug \ --disable-locale \ --disable-xattr-support \ - --disable-acl-support \ + --disable-acl-support define Package/rsync/install $(INSTALL_DIR) $(1)/usr/bin @@ -68,7 +68,7 @@ define Package/rsyncd/description endef define Package/rsyncd/conffiles -/etc/rsyncd.conf + /etc/rsyncd.conf endef define Package/rsyncd/install The prefered way of writing a Makefile is how it is right now. Inserting tabs instead of 2 spaces is not what we generally have. -- Florian -- Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
I understand. BTW, thank you for reviewing and applying my patches. On Fri, Sep 30, 2011 at 15:59, Florian Fainelli flor...@openwrt.org wrote: On Friday 30 September 2011 14:37:05 Eugene San wrote: Ok. I just tried to unify style of this file, and wasn't planning tabs-spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject. Agreed, in general I try to keep this style of 2 spaces for declarations inside define/endef blocks, but having tabs is also valid. Note sure about other editors, but vim for instance does a better highlighting job when using 2 spaces (it's Friday after all). Note, there is at least one change not related to styling: - --disable-acl-support \ + --disable-acl-support On Fri, Sep 30, 2011 at 14:48, Florian Fainelli flor...@openwrt.org wrote: Hello, On Monday 29 August 2011 22:09:35 eugene...@gmail.com wrote: From: Eugene San (eugenesan) eugene...@gmail.com Signed-off-by: Eugene San (eugenesan) eugene...@gmail.com --- net/rsync/Makefile | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/rsync/Makefile b/net/rsync/Makefile index 46670e5..f6d8eb1 100644 --- a/net/rsync/Makefile +++ b/net/rsync/Makefile @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 include $(INCLUDE_DIR)/package.mk define Package/rsync - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Fast remote file copy program (like rcp) - DEPENDS:=+libpopt - URL:=http://rsync.samba.org/ + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Fast remote file copy program (like rcp) + DEPENDS:=+libpopt + URL:=http://rsync.samba.org/ endef define Package/rsyncd - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Rsync daemon - DEPENDS:=+rsync + SECTION:=net + CATEGORY:=Network + SUBMENU:=File Transfer + TITLE:=Rsync daemon + DEPENDS:=+rsync endef define Package/rsync/description @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ --disable-debug \ --disable-locale \ --disable-xattr-support \ - --disable-acl-support \ + --disable-acl-support define Package/rsync/install $(INSTALL_DIR) $(1)/usr/bin @@ -68,7 +68,7 @@ define Package/rsyncd/description endef define Package/rsyncd/conffiles -/etc/rsyncd.conf + /etc/rsyncd.conf endef define Package/rsyncd/install The prefered way of writing a Makefile is how it is right now. Inserting tabs instead of 2 spaces is not what we generally have. -- Florian -- Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
On Fri, September 30, 2011 13:48, Florian Fainelli wrote: Hello, On Monday 29 August 2011 22:09:35 eugene...@gmail.com wrote: From: Eugene San (eugenesan) eugene...@gmail.com Signed-off-by: Eugene San (eugenesan) eugene...@gmail.com --- net/rsync/Makefile | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/rsync/Makefile b/net/rsync/Makefile index 46670e5..f6d8eb1 100644 --- a/net/rsync/Makefile +++ b/net/rsync/Makefile @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 include $(INCLUDE_DIR)/package.mk define Package/rsync - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Fast remote file copy program (like rcp) - DEPENDS:=+libpopt - URL:=http://rsync.samba.org/ +SECTION:=net +CATEGORY:=Network +SUBMENU:=File Transfer +TITLE:=Fast remote file copy program (like rcp) +DEPENDS:=+libpopt +URL:=http://rsync.samba.org/ endef define Package/rsyncd - SECTION:=net - CATEGORY:=Network - SUBMENU:=File Transfer - TITLE:=Rsync daemon - DEPENDS:=+rsync +SECTION:=net +CATEGORY:=Network +SUBMENU:=File Transfer +TITLE:=Rsync daemon +DEPENDS:=+rsync endef define Package/rsync/description @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ --disable-debug \ --disable-locale \ --disable-xattr-support \ ---disable-acl-support \ +--disable-acl-support define Package/rsync/install $(INSTALL_DIR) $(1)/usr/bin @@ -68,7 +68,7 @@ define Package/rsyncd/description endef define Package/rsyncd/conffiles -/etc/rsyncd.conf +/etc/rsyncd.conf endef define Package/rsyncd/install The prefered way of writing a Makefile is how it is right now. Inserting tabs instead of 2 spaces is not what we generally have. Florian Actually it is totally wrong as a leading TAB means this is a shell command. And it doesn't break here as the calling code has leading spaces. Always remember: In Makefiles leading tabs and spaces have special meaning. Maddes ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
Le 30/09/2011 14:59, Florian Fainelli a écrit : On Friday 30 September 2011 14:37:05 Eugene San wrote: Ok. I just tried to unify style of this file, and wasn't planning tabs-spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject. Agreed, in general I try to keep this style of 2 spaces for declarations inside define/endef blocks, but having tabs is also valid. Note sure about other editors, but vim for instance does a better highlighting job when using 2 spaces (it's Friday after all). Same for geany and gedit, as far as I can tell. With tabs, variable definitions are not highlighted correctly (they are when 2 spaces are used). -- Emmanuel Deloget ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/5] [packages] rsync: cosmetic changes after package split
On Fri, September 30, 2011 16:10, Emmanuel Deloget wrote: Le 30/09/2011 14:59, Florian Fainelli a �crit : On Friday 30 September 2011 14:37:05 Eugene San wrote: Ok. I just tried to unify style of this file, and wasn't planning tabs-spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject. Agreed, in general I try to keep this style of 2 spaces for declarations inside define/endef blocks, but having tabs is also valid. Note sure about other editors, but vim for instance does a better highlighting job when using 2 spaces (it's Friday after all). Same for geany and gedit, as far as I can tell. With tabs, variable definitions are not highlighted correctly (they are when 2 spaces are used). -- Emmanuel Deloget This is correct highlighting behaviour, as in Makefiles leading tabs and spaces have special and different meaning. Writing a Makefile is totally different to writing code. Maddes ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
