Re: Release of pax jdbc 1.0.0 is staged now

2017-01-24 Thread Christian Schneider 

Yes .. will recut. If any of you find more issues please let me know.

Christian

On 24.01.2017 18:09, 'Achim Nierbeck' via OPS4J wrote:

Hi Christian,

in case of such uncertainties and with the possibilities to fix, yes 
just do it :)


regards, Achim


2017-01-24 17:28 GMT+01:00 Jean-Baptiste Onofré 
>:


Hi Christian

I would re-cut the release yes.

Up to you.

Regards
JB
On Jan 24, 2017, at 17:05, Christian Schneider
> wrote:

I found another issue.

If you configure a DataSource with pooling but no XA like this:
osgi.jdbc.driver.name =H2
url=jdbc:h2:mem:test
dataSourceName=person
pool=dbcp2

and then add the pooling support as well as transaction support:
feature:repo-add pax-jdbc 1.0.0
feature:install transaction pax-jdbc-config pax-jdbc-pool-dbcp2 
pax-jdbc-h2

Then you get two DataSources. The reason is that the dbcp2 pooling
creates two PoolingDataSourceFactory services. One with xa=true and one
without the
xa attribute. For just pooling we search for (pool=dbcp2) so we get two
services and install two DataSources.

What do you think? Should I redo the release? The artifacts are not yet
pushed.

Christian

On 24.01.2017 11:38, Christian Schneider wrote:

I have staged a release of pax jdbc 1.0.0 on the sonatype
nexus:
https://oss.sonatype.org/content/repositories/orgops4j-1249

It would be great if you could test it and give feedback.
I will take care of the update in Apache karaf.
https://issues.apache.org/jira/browse/KARAF-4956
 As JB
wants to do a karaf release 4.1.0 soon with pax jdbc 1.0.0
I will push the pax jdbc bundles to central later today if
there is no biggger problem reported. Christian



-- 
-- -- OPS4J - http://www.ops4j.org -

ops4j@googlegroups.com  --- You
received this message because you are subscribed to the Google
Groups "OPS4J" group. To unsubscribe from this group and stop
receiving emails from it, send an email to
ops4j+unsubscr...@googlegroups.com
. For more options,
visit https://groups.google.com/d/optout
. 


--
Apache Member
Apache Karaf  Committer & PMC OPS4J Pax Web 
 Committer & Project 
Lead blog 

Co-Author of Apache Karaf Cookbook 
Software Architect / Project Manager / Scrum Master
-- -- -- OPS4J - http://www.ops4j.org - 
ops4j@googlegroups.com --- You received this message because you are 
subscribed to the Google Groups "OPS4J" group. To unsubscribe from 
this group and stop receiving emails from it, send an email to 
ops4j+unsubscr...@googlegroups.com 
. For more options, visit 
https://groups.google.com/d/optout. 


--
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

--
--
--
OPS4J - http://www.ops4j.org - ops4j@googlegroups.com

--- 
You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to ops4j+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Release of pax jdbc 1.0.0 is staged now

2017-01-24 Thread Christian Schneider 

I found another issue.

If you configure a DataSource with pooling but no XA like this:
osgi.jdbc.driver.name=H2
url=jdbc:h2:mem:test
dataSourceName=person
pool=dbcp2

and then add the pooling support as well as transaction support:
feature:repo-add pax-jdbc 1.0.0
feature:install transaction pax-jdbc-config pax-jdbc-pool-dbcp2 pax-jdbc-h2

Then you get two DataSources. The reason is that the dbcp2 pooling 
creates two PoolingDataSourceFactory services. One with xa=true and one 
without the
xa attribute. For just pooling we search for (pool=dbcp2) so we get two 
services and install two DataSources.


What do you think? Should I redo the release? The artifacts are not yet 
pushed.


Christian

On 24.01.2017 11:38, Christian Schneider wrote:

I have staged a release of pax jdbc 1.0.0 on the sonatype nexus:

https://oss.sonatype.org/content/repositories/orgops4j-1249

It would be great if you could test it and give feedback. I will take 
care of the update in Apache karaf.

https://issues.apache.org/jira/browse/KARAF-4956

As JB wants to do a karaf release 4.1.0 soon with pax jdbc 1.0.0 I 
will push the pax jdbc bundles to central later today if there is no 
biggger problem reported.


Christian




--
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

--
--
--
OPS4J - http://www.ops4j.org - ops4j@googlegroups.com

--- 
You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to ops4j+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Release of pax jdbc 1.0.0 is staged now

2017-01-24 Thread Christian Schneider 
I have done some tests on karaf 4.1.0-SNAPSHOT creating a H2 DataSource 
from config with dbcp2 pooling and optionally xa support.


It works fine but I spotted some small issues:

1. If the TransactionManager or pax-jdbc-pool-dbcp2 is missing then the 
log shows:
Tracking pooling support with filter 
(&(objectClass=org.ops4j.pax.jdbc.pool.common.PooledDataSourceFactory)(pool=dbcp2)(xa=true))
It is a little bit hard to interpret that this means either the 
pax-jdbc-pool-dbcp2 feature or the transaction feature is missing. I 
have added this to the Documentation.

It would be great if we can improve the logging.

2. If the DataSource is created correctly then there are 3 identical 
lines in the log:

Found DataSourceFactory. Creating DataSource my

It seems that we hit the logging 3 times for some reason. There is only 
one DSF service and only one PooledDataSourceFactory service. So I have 
no idea why this happens.
In any case there is only one DataSource registered. So it does not seem 
to be a severe error.


Christian


On 24.01.2017 11:38, Christian Schneider wrote:

I have staged a release of pax jdbc 1.0.0 on the sonatype nexus:

https://oss.sonatype.org/content/repositories/orgops4j-1249

It would be great if you could test it and give feedback. I will take 
care of the update in Apache karaf.

https://issues.apache.org/jira/browse/KARAF-4956

As JB wants to do a karaf release 4.1.0 soon with pax jdbc 1.0.0 I 
will push the pax jdbc bundles to central later today if there is no 
biggger problem reported.


Christian




--
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

--
--
--
OPS4J - http://www.ops4j.org - ops4j@googlegroups.com

--- 
You received this message because you are subscribed to the Google Groups "OPS4J" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to ops4j+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.