Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-13 Thread Robert Osfield
Thanks Santosh, changes look like a good improvement w.r.t robustness and getting rid of warning, changes now merged and submitted to svn/trunk, thanks :-) On Sun, Apr 12, 2009 at 4:41 PM, Santosh sant...@darshan3d.com wrote: Hi Robert I have added the exception handling in ply loader. All

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-10 Thread Robert Osfield
On Thu, Apr 9, 2009 at 10:18 PM, Santosh sant...@darshan3d.com wrote: Hi Robert Attached is the updated ply.h and plyfile.cpp in which I resolved the warnings of vertexData.cpp.() Thanks changes now merged and submitted to snv/trunk. On my system I didn't got the warnings of fread()

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-09 Thread Robert Osfield
Hi Santosh, I'm just reviewing the code and mostly everything looks fine but need to clarify the license on vertexData.h and vertexData.cpp and typedefs.h. The notice is: /* vertexData.h Copyright (c) 2007, Tobias Wolf tw...@access.unizh.ch All rights reserved. Header file of

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-09 Thread Martin Beckett
The ply file format is by Greg Turk at Stanford and is BSD licenced. The original VertexData class is by Tobias Wolf and is LGPL But most of the original functionality in VertexData (calcualting normals, kd-tree etc) is in OSG anyway so this plugin only uses a minimal set of file reading

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-02 Thread Santosh
Martin Beckett wrote: Thanks - I had just started working on this! A couple of points - I can't get this to work with binary models, is it limited to certain features in the binary ply? The normals seem to be the wrong way round (at least for the Stanford bunny model) I have tested this

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-01 Thread Martin Beckett
Thanks - I had just started working on this! A couple of points - I can't get this to work with binary models, is it limited to certain features in the binary ply? The normals seem to be the wrong way round (at least for the Stanford bunny model) I think you need the attached CMakeLists.txt to

Re: [osg-submissions] Would like to contribute osg-plugin for ply file (Stanford Triangle Format)

2009-04-01 Thread Ulrich Hertlein
Hi Santosh, On 2/4/09 4:44 AM, Santosh wrote: Attached is the osg-plugin for reading ply ( Stanford Triangle Format ) file. I have written the plugin according to OSG standard and have also added cmake build system. The plugin is working fine on both Linux and Windows and should behave