Re: [osg-submissions] OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined
Hi Robert, The fist method I am used to do the push of my branch up to Github is requesting a password, so I guess I am not doing something correctly. Next I forked off a copy of the master branch, made my changes and then created the push request, this seems to have worked OK. If something is not quite correct let me know and I will do some more research on this subject as its not something I do much. I think I have only done this once before a few years back.. ... Thank you! Cheers, Curtis -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=69574#69574 ___ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Re: [osg-submissions] OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined
Hi Curtis, It would be worth just trying out a pull request from your commit, I can see if the use of local branch will have any effect, hopefully github will sort it out. I can of course simply use the file you posted. I haven't had time to review it, there isn't much difference in time for me to use a straight file or pull request. For trivial changes a PR is probably the quickest. Cheers, Robert. On 1 December 2016 at 19:22, Curtis Rubel wrote: > Hi Robert, > > Just curious if you would like this converted to a pull request? > > I have created a new local branch called PThreadPullRequest > and committed the one file with the fixes. > > Just want to be sure its OK to commit this new branch up to the master > branch and then generate the pull request? At least that is > how I think its supposed to be done as I have not done > one yet.. > > Thank you! > > Cheers, > Curtis > > -- > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=69572#69572 > > > > > > ___ > osg-submissions mailing list > osg-submissions@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org ___ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
Re: [osg-submissions] OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined
Hi Robert, Just curious if you would like this converted to a pull request? I have created a new local branch called PThreadPullRequest and committed the one file with the fixes. Just want to be sure its OK to commit this new branch up to the master branch and then generate the pull request? At least that is how I think its supposed to be done as I have not done one yet.. Thank you! Cheers, Curtis -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=69572#69572 ___ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
