Re: [osg-users] Bug in Cull Visitor

On 13 May 2018 at 18:48, Robert Osfield wrote: > On 13 May 2018 at 17:01, Gedalia Pasternak wrote: >> Does that mean it’s used incorrectly in >> OcclusionQueryNode::getPassed()? That was what I was basing my understanding >> on. > > I'm not the

Re: [osg-users] Bug in Cull Visitor

Hi Gedalia, On 13 May 2018 at 17:01, Gedalia Pasternak wrote: > Does that mean it’s used incorrectly in > OcclusionQueryNode::getPassed()? That was what I was basing my understanding > on. I'm not the author of OcclisionQueyNode so I have to look it up, jikes, yep it

Re: [osg-users] Bug in Cull Visitor

Does that mean it’s used incorrectly in OcclusionQueryNode::getPassed()? That was what I was basing my understanding on. Gedalia On Sun, May 13, 2018 at 10:57 AM Robert Osfield wrote: > Hi Gedalia, > > On 13 May 2018 at 15:27, Gedalia Pasternak

Re: [osg-users] Bug in Cull Visitor

Hi Gedalia, On 13 May 2018 at 15:27, Gedalia Pasternak wrote: >But won’t just simply removing it mean that adding a render leaf will be > changing what the current frame is? TraversalNumber is local value to a visitor it isn't a the frame number, this is retrieved with

Re: [osg-users] Bug in Cull Visitor

Thanks Robert, But won’t just simply removing it mean that adding a render leaf will be changing what the current frame is? For occlusion nodes I’ve realized that it’s not currently possible to use them within instanced hierarchy without tracking which traversal generated a given query, the

Re: [osg-users] Bug in Cull Visitor

Hi Gedalia, Well spotted, this issue has been in the code for almost two decades without anyone noticing. I've removed the duplicate from CullVisitor and checked this into OSG master and the 3.6 branch. Robert. On 12 May 2018 at 21:34, Gedalia Pasternak wrote: > Both

[osg-users] Bug in Cull Visitor

Both CullVisitor and it's base class NodeVisitor have members named _traversalNumber. Yielding duplicate member variables with the same name, and inconsistent behavior depending on how you access the class. Cull visitor's should be renamed, maybe to _cullTraversalNumber or something that wouldn't