Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-09-03 Thread Robert Osfield
Hi Guy, I have looked into the revision that Konstantin made back in January and it looks to me like the intent was to prevent the viewer from starting threads before you've called realize:

Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Robert Osfield
On Thu, 12 Jul 2018 at 17:52, Guy Volckaert wrote: > I also looked at the osg-submissions archives and could not find any trace of > this change. I went back as far as June 2017. Most submissions now come it via pull requests on github. Robert. ___

Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Guy Volckaert
Actually, if we want to adjust the threading affinity when cycling through the threading model, then would`t be better to if we replaced: Code: if (isRealized() && _threadingModel!=SingleThreaded) startThreading(); by Code: if (isRealized() && _threadingModel!=SingleThreaded)

Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Guy Volckaert
Hi, I also looked at the osg-submissions archives and could not find any trace of this change. I went back as far as June 2017. -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=74329#74329 ___

Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Guy Volckaert
Hi, I looked at the commit but the description does not clearly provide a reason for the change. I looked at the forum but could not find anything. I'll try the mailing list next. Thank you! Cheers, Guy -- Read this topic online here:

Re: [osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Robert Osfield
Hi Guy, The commit that changes this was: ommit bb84f1ea3c23625a645b9c2848202bca7c566efb Author: Konstantin S. Matveyev Date: Sat Jan 13 15:46:53 2018 +0300 osgViewer::ViewerBase setThreadingModel func fix: should not start threading, must only restart Off the top of my head I only

[osg-users] [build] ViewerBase::setThreadingModel() not working

2018-07-12 Thread Guy Volckaert
Hi, When I try to cycle through the threading models by pressing the 'm' key (when the ThreadingHandler is registered) the stats would indicates the correct threading model, but the engine would remain in SingleThreaded. So I started investigating the issue and I noticed that, with OSG v3.6.2,