Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged
On 5 April 2018 at 16:33, Daniel Emminizer, Code 5773 wrote: > Minor build error on Windows. Missing "extern OSGDB_EXPORT" on the function > change in ReadFile. Once I fixed that -- > https://github.com/openscenegraph/OpenSceneGraph/pull/525 -- everything in > your change works great. Thank you, Thanks for the quick turnaround on testing and providing a fix, now merged. Guess this means I'll need to do yet another rc!... Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged
Hi Robert, Minor build error on Windows. Missing "extern OSGDB_EXPORT" on the function change in ReadFile. Once I fixed that -- https://github.com/openscenegraph/OpenSceneGraph/pull/525 -- everything in your change works great. Thank you, - Dan -Original Message- From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On Behalf Of Robert Osfield Sent: Thursday, April 05, 2018 9:23 AM To: OpenSceneGraph Users Subject: Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged Hi Dan, On 5 April 2018 at 13:18, Daniel Emminizer, Code 5773 wrote: > Looking good so far here with testing on GL Core 3.3. Main concerns is that > it's noisy on the console. You just pushed a commit that helps with this in > DisplaySettings::setShaderHint(). But I still see: Thanks for the testing. > 1) osgText prints errors about "Error reading file shaders/text.frag: file > not found", but correctly falls back to built-in shader. Same with > text.vert. One fix for this is to use a custom version of > readRefShaderFileWithFallback() in osgText/Text.cpp but obviously that's > messy. > > Other options include requiring end user apps to always package those files, > or to always intercept the search with osgDB tricks. > > > 2) Drawable::createVertexArrayStateImplementation() still has an OSG_NOTICE > that spams the console in some of our apps. Would recommend OSG_INFO or > commenting out. I have checked in a fix for this noisy debug output: https://github.com/openscenegraph/OpenSceneGraph/commit/914e60a8723b0306daef7dd7d8b3839f4b84d84b > No other concerns at this point. Thank you for the excellent software. Cheers :-) Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged
Hi Dan, On 5 April 2018 at 13:18, Daniel Emminizer, Code 5773 wrote: > Looking good so far here with testing on GL Core 3.3. Main concerns is that > it's noisy on the console. You just pushed a commit that helps with this in > DisplaySettings::setShaderHint(). But I still see: Thanks for the testing. > 1) osgText prints errors about "Error reading file shaders/text.frag: file > not found", but correctly falls back to built-in shader. Same with > text.vert. One fix for this is to use a custom version of > readRefShaderFileWithFallback() in osgText/Text.cpp but obviously that's > messy. > > Other options include requiring end user apps to always package those files, > or to always intercept the search with osgDB tricks. > > > 2) Drawable::createVertexArrayStateImplementation() still has an OSG_NOTICE > that spams the console in some of our apps. Would recommend OSG_INFO or > commenting out. I have checked in a fix for this noisy debug output: https://github.com/openscenegraph/OpenSceneGraph/commit/914e60a8723b0306daef7dd7d8b3839f4b84d84b > No other concerns at this point. Thank you for the excellent software. Cheers :-) Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged
Hi Robert, Looking good so far here with testing on GL Core 3.3. Main concerns is that it's noisy on the console. You just pushed a commit that helps with this in DisplaySettings::setShaderHint(). But I still see: 1) osgText prints errors about "Error reading file shaders/text.frag: file not found", but correctly falls back to built-in shader. Same with text.vert. One fix for this is to use a custom version of readRefShaderFileWithFallback() in osgText/Text.cpp but obviously that's messy. Other options include requiring end user apps to always package those files, or to always intercept the search with osgDB tricks. 2) Drawable::createVertexArrayStateImplementation() still has an OSG_NOTICE that spams the console in some of our apps. Would recommend OSG_INFO or commenting out. No other concerns at this point. Thank you for the excellent software. - Dan -Original Message- From: osg-users [mailto:osg-users-boun...@lists.openscenegraph.org] On Behalf Of Robert Osfield Sent: Wednesday, April 04, 2018 10:46 AM To: OpenSceneGraph Users Subject: [osg-users] OpenScenGraph 3.6 release candidate 5 tagged Hi All, I have just tagged 3.6.0-rc5: https://github.com/openscenegraph/OpenSceneGraph I'm pretty well ready to release now. But is the code? I need feedback from the community now on build and runtime performance. All going well I'll tag 3.6.0. Thanks in advance for all the final testing you can do. As before let me know of success as well as failure. Cheers, Robert. -- ChangeLog since rc4: Wed, 4 Apr 2018 15:09:43 +0100 Author : Robert Osfield Fixed threading crash in osgFX that occurred when an osgFX node is added to the scene being rendered in multiple threaded windows. Wed, 4 Apr 2018 13:40:51 +0100 Author : Robert Osfield Added focus classifiction of handling of keyboard events Wed, 4 Apr 2018 13:40:06 +0100 Author : Robert Osfield Added EventHandler to report key and mouse events for debugging purposes Wed, 4 Apr 2018 12:26:53 +0100 Author : Robert Osfield Added -4 command line entry that creates two seperate windows within CompositeViewer Wed, 4 Apr 2018 08:50:39 +0100 Author : Frank Bausch When testing XYZ/ECEF coordinate values that convert to LLA points with latitude = 90.0 or latitude = -90.0, the heights calculated by EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the provided change, points at the pole are handled more correctly. This has been tested against US NGA GoldData. Tue, 3 Apr 2018 17:21:47 +0100 Author : Robert Osfield Updated rc to 5 Tue, 3 Apr 2018 17:17:59 +0100 Author : OpenSceneGraph git repository Merge pull request #518 from emminizer/fix-scroll-eventCompositeViewer: SCROLL event now only goes to view with focus. Incl… robert@katrine:~/temp/OpenSceneGraph-3.6$ more ChangeLog Wed, 4 Apr 2018 15:09:43 +0100 Author : Robert Osfield Fixed threading crash in osgFX that occurred when an osgFX node is added to the scene being rendered in multiple threaded windows. Wed, 4 Apr 2018 13:40:51 +0100 Author : Robert Osfield Added focus classifiction of handling of keyboard events Wed, 4 Apr 2018 13:40:06 +0100 Author : Robert Osfield Added EventHandler to report key and mouse events for debugging purposes Wed, 4 Apr 2018 12:26:53 +0100 Author : Robert Osfield Added -4 command line entry that creates two seperate windows within CompositeViewer Wed, 4 Apr 2018 08:50:39 +0100 Author : Frank Bausch When testing XYZ/ECEF coordinate values that convert to LLA points with latitude = 90.0 or latitude = -90.0, the heights calculated by EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the provided change, points at the pole are handled more correctly. This has been tested against US NGA GoldData. Tue, 3 Apr 2018 17:21:47 +0100 Author : Robert Osfield Updated rc to 5 Tue, 3 Apr 2018 17:17:59 +0100 Author : OpenSceneGraph git repository Merge pull request #518 from emminizer/fix-scroll-eventCompositeViewer: SCROLL event now only goes to view with focus. Incl… ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] OpenScenGraph 3.6 release candidate 5 tagged
Hi All, I have just tagged 3.6.0-rc5: https://github.com/openscenegraph/OpenSceneGraph I'm pretty well ready to release now. But is the code? I need feedback from the community now on build and runtime performance. All going well I'll tag 3.6.0. Thanks in advance for all the final testing you can do. As before let me know of success as well as failure. Cheers, Robert. -- ChangeLog since rc4: Wed, 4 Apr 2018 15:09:43 +0100 Author : Robert Osfield Fixed threading crash in osgFX that occurred when an osgFX node is added to the scene being rendered in multiple threaded windows. Wed, 4 Apr 2018 13:40:51 +0100 Author : Robert Osfield Added focus classifiction of handling of keyboard events Wed, 4 Apr 2018 13:40:06 +0100 Author : Robert Osfield Added EventHandler to report key and mouse events for debugging purposes Wed, 4 Apr 2018 12:26:53 +0100 Author : Robert Osfield Added -4 command line entry that creates two seperate windows within CompositeViewer Wed, 4 Apr 2018 08:50:39 +0100 Author : Frank Bausch When testing XYZ/ECEF coordinate values that convert to LLA points with latitude = 90.0 or latitude = -90.0, the heights calculated by EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the provided change, points at the pole are handled more correctly. This has been tested against US NGA GoldData. Tue, 3 Apr 2018 17:21:47 +0100 Author : Robert Osfield Updated rc to 5 Tue, 3 Apr 2018 17:17:59 +0100 Author : OpenSceneGraph git repository Merge pull request #518 from emminizer/fix-scroll-eventCompositeViewer: SCROLL event now only goes to view with focus. Incl… robert@katrine:~/temp/OpenSceneGraph-3.6$ more ChangeLog Wed, 4 Apr 2018 15:09:43 +0100 Author : Robert Osfield Fixed threading crash in osgFX that occurred when an osgFX node is added to the scene being rendered in multiple threaded windows. Wed, 4 Apr 2018 13:40:51 +0100 Author : Robert Osfield Added focus classifiction of handling of keyboard events Wed, 4 Apr 2018 13:40:06 +0100 Author : Robert Osfield Added EventHandler to report key and mouse events for debugging purposes Wed, 4 Apr 2018 12:26:53 +0100 Author : Robert Osfield Added -4 command line entry that creates two seperate windows within CompositeViewer Wed, 4 Apr 2018 08:50:39 +0100 Author : Frank Bausch When testing XYZ/ECEF coordinate values that convert to LLA points with latitude = 90.0 or latitude = -90.0, the heights calculated by EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the provided change, points at the pole are handled more correctly. This has been tested against US NGA GoldData. Tue, 3 Apr 2018 17:21:47 +0100 Author : Robert Osfield Updated rc to 5 Tue, 3 Apr 2018 17:17:59 +0100 Author : OpenSceneGraph git repository Merge pull request #518 from emminizer/fix-scroll-eventCompositeViewer: SCROLL event now only goes to view with focus. Incl… ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
