With v2 applied, I got:
scripts/build mode=debug image=cli,nginx -j8 fs=ramfs
...
LINK build/debug.x64/tools/uush/uush.so
LINK cpiod.so
MKBOOTFS build/debug.x64/bootfs.bin
Traceback (most recent call last):
File
"/home/justin_cinkelj/devel/mikelangelo/osv-fc25/osv/scripts/mkbootfs.py",
Signed-off-by: geraldo netto
---
scripts/mkbootfs.py | 73 -
1 file changed, 5 insertions(+), 68 deletions(-)
diff --git a/scripts/mkbootfs.py b/scripts/mkbootfs.py
index 94835e9..134fb7b 100755
---
The first patch fixes one small issue and the pair of paths are 'glued' with ':'
Otherwise, it will fail in some cases (I don't recall now which app had this
issue)
The implementation from mkbootfs already had this small adjustment
The second patch is the reuse itself, basically deleting all
From: Justin Cinkelj
Committer: Nadav Har'El
Branch: master
Makefile: replace realpath with pwd
The realpath is not installed by default on Ubuntu.
Use pwd instead.
Fixes #946
Signed-off-by: Justin Cinkelj
Message-Id:
Hello Nadav/Justin/All,
I have made the tuning Nadav suggested at it is working like a charm for me
:)
In any case, I'll test some options/combinations
2 interesting things I just found:
- make is not receiving the the -j parameter properly
- for this combination mode=debug image=cli,nginx
The realpath is not installed by default on Ubuntu.
Use pwd instead.
Fixes #946
Signed-off-by: Justin Cinkelj
---
modules/cli/rpmbuild/Makefile | 2 +-
modules/httpserver-api/Makefile | 2 +-
modules/lua/Makefile| 2 +-
3 files changed, 3 insertions(+), 3
Hi, please see comments inline below (also explains the bug which Justin
found).
--
Nadav Har'El
n...@scylladb.com
On Fri, Feb 9, 2018 at 6:56 PM, geraldo netto
wrote:
> Signed-off-by: geraldo netto
> ---
> scripts/mkbootfs.py | 80
Hello Justin,
Thanks for your feedback, let me reproduce it here :)
Kind Regards,
Geraldo Netto
Sapere Aude => Non dvcor, dvco
http://exdev.sf.net/
On 15 February 2018 at 07:23, Justin Cinkelj
wrote:
> With v2 applied, I got:
> scripts/build mode=debug
On Thu, Feb 15, 2018 at 3:09 PM, Geraldo Netto
wrote:
> Hello Nadav/Justin/All,
>
> I have made the tuning Nadav suggested at it is working like a charm for
> me :)
> In any case, I'll test some options/combinations
>
> 2 interesting things I just found:
> - make is not
My 2 cents. I am not sure if that is related but I have also found out that
if one changes lzkernel_base in Makefile and does not not clean or
specifically does not delete $OUT/arch/$arch/boot (arch/x64/boot16.S
depends on OSV_LZKERNEL_BASE) the the build process does not detect this
change
10 matches
Mail list logo