Re: OSv time drifting when running under KVM

2018-10-22 Thread Nadav Har'El
On Sat, Oct 20, 2018 at 4:27 AM Rick Payne wrote: > > OSv sets the MSR once, and then uses the result repeatedly - in fact it > barrier()s it which is odd as we know it shouldn't change unless we > write the MSR - which makes me think there was some misunderstanding > here (which could easily be

Re: [PATCH] Handle wall clock MSR correctly

2018-10-22 Thread Rick Payne
On Mon, 2018-10-22 at 16:13 +0300, Nadav Har'El wrote: > > After this patch, the host NTP keeps the time accurate on the guest > as well? Not verified yet - should be able to do that soon though. I suspect it totally sorts the issue though. > Another thing we could do is to reread the wall

Re: [PATCH] Handle wall clock MSR correctly

2018-10-22 Thread Rick Payne
Something like this? diff --git a/drivers/kvmclock.cc b/drivers/kvmclock.cc index 68389dfb..4af229d5 100644 --- a/drivers/kvmclock.cc +++ b/drivers/kvmclock.cc @@ -31,6 +31,8 @@ protected: private: static bool _new_kvmclock_msrs; pvclock_wall_clock* _wall; +u64 _wall_phys; +