Re: [PATCH] fix no output boot_time event "TLS initialization"

在 18/4/12 上午10:50, Waldek Kozaczuk 写道: Including the author of the patch. Sent from my iPhone On Apr 10, 2018, at 23:44, Waldek Kozaczuk > wrote: Nice catch. Even though the patch addresses the bug it also makes _event member variable

Re: [PATCH] fix no output boot_time event "TLS initialization"

Including the author of the patch. Sent from my iPhone > On Apr 10, 2018, at 23:44, Waldek Kozaczuk wrote: > > Nice catch. > > Even though the patch addresses the bug it also makes _event member variable > public and therefore weakens encapsulation. I wonder if we can

Re: [PATCH] fix no output boot_time event "TLS initialization"

在 18/4/12 上午10:22, Waldek Kozaczuk 写道: Hi. I reviewed this and other patch and replied on the the mailing list. Have my replies not reached you ？. I haven't recieved it, maybe i am not in the mail list, and you re send reviewed mail to me? -- You received this message because you are

Re: [PATCH] fix no output boot_time event "TLS initialization"

Hi. I reviewed this and other patch and replied on the the mailing list. Have my replies not reached you ? Waldek Sent from my iPhone > On Apr 11, 2018, at 22:15, Wang Yu wrote: > > no one review? > > >> 在 18/4/9 下午8:37, Wang Yu 写道: >> before patch boot with

Re: [PATCH] fix no output boot_time event "TLS initialization"

no one review? 在 18/4/9 下午8:37, Wang Yu 写道: before patch boot with --bootchart, "TLS initialization" is not output ... disk read (real mode): 50.71ms, (+50.71ms) .init functions: 89.20ms, (+5.48ms) SMP launched: 90.56ms, (+1.36ms) VFS initialized:

Re: [PATCH] fix no output boot_time event "TLS initialization"

Nice catch. Even though the patch addresses the bug it also makes _event member variable public and therefore weakens encapsulation. I wonder if we can address this bug along these lines: diff --git a/arch/x64/arch-setup.cc b/arch/x64/arch-setup.cc index 325c26a..e4c1ab0 100644 ---